Cover Comment List
List cover comments
GET /api/covers/52842/comments/?format=api
[ { "id": 95368, "web_url": "http://patches.dpdk.org/comment/95368/", "msgid": "<2742111.xWhxeopsW5@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2742111.xWhxeopsW5@xps", "date": "2019-04-21T16:40:54", "subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "17/04/2019 06:13, Honnappa Nagarahalli:\n> Dharmik Thakkar (1):\n> test/rcu_qsbr: add API and functional tests\n> \n> Honnappa Nagarahalli (2):\n> rcu: add RCU library supporting QSBR mechanism\n> doc/rcu: add lib_rcu documentation\n\nSorry I cannot merge this library in DPDK 19.05-rc2\nbecause of several issues:\n- 32-bit compilation is broken because of %lx/%lu instead of PRI?64\n- shared link is broken because of rcu_log_type not exported\n- some public symbols (variable, macros, functions) are not prefixed with rte\n\nI am not sure about getting it later in 19.05,\nit may be too late to merge a new library.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 680941B467;\n\tSun, 21 Apr 2019 18:41:02 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D15D21B205\n\tfor <dev@dpdk.org>; Sun, 21 Apr 2019 18:41:01 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 1D08F20A3C;\n\tSun, 21 Apr 2019 12:41:00 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Sun, 21 Apr 2019 12:41:00 -0400", "from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr\n\t[90.29.158.159])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id AC4A2103CB;\n\tSun, 21 Apr 2019 12:40:57 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=+DNtgM6qnKIxL6lC2RaDYI0/0fr0NMI4s4VMVLF9TPg=; b=Ubl2swCW3QbJ\n\tv4kkcT+TrT+hu6JZQpMZIEYR+6CO3FxrpoYBnKq6bjvjORpdRNZVce3drF8iuTjV\n\tvlcug24L2F6xg0r451i+2ZjpcG+QkoyngF+yATEUqmTHoxKCCqmpkvgzHJf8663Y\n\tRx5k1KYGelWE3uQwN/V67PN9b/NmBjA=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=+DNtgM6qnKIxL6lC2RaDYI0/0fr0NMI4s4VMVLF9T\n\tPg=; b=L4C4CGT9K/eCfrDzA8/0oc6JI44Zg5AXAea4XWgqAQD/UqBFi2MceMKZl\n\tDdijhe+RrRS+a8e+5Mv2fiZ1/IMP2lG3DNe0xYR66Yp3wVUtxh+GvVvIoqNqlUrD\n\tOK8dFzMomglgRkcjgHuXIXsiG2hIcM2bu2xG6jvX/JrOrrFbRpJBj6xjeilv46pi\n\tED6FMDC518KXULePcii9vO5RFqkr727mLt48BWftXBFChISSRN+5dCR536bElep/\n\tPBvl5cHNB/AP/5rw2I/3BZZrJ7qoiXdIIR20acGFMwFSYX1f6gE5v+W3f7ntX6pX\n\tFfYW3XRT3dMqL1v70OG7/0/N4cmiQ==" ], "X-ME-Sender": "<xms:G528XK5UOQoBG5FfFuclqSaIV7C4kNlZaPOBhNTeYTcTyKn-fP4HcQ>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrgeeggdektdcutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n\tfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs\n\tucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n\tepledtrddvledrudehkedrudehleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm\n\trghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:G528XPartAWad_9JGKCBdVe-FFc_ku8sFAGdpWIQtHnhS215QOerlA>\n\t<xmx:G528XAd_COtm5JffsLX85xPRZzH5qPtDD595iVlgrYxyYDKoBvh2_g>\n\t<xmx:G528XAFmB1qvWOiWay9Ztwbzf2RwfxPQ6bUTFHdyQgKQdasrCRnDRw>\n\t<xmx:HJ28XLah27Iq-X3reagQNyzKlwA2tKbB5Y5O_TsBBdpeabGwAfCzdw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Cc": "dev@dpdk.org, konstantin.ananyev@intel.com, stephen@networkplumber.org, \n\tpaulmck@linux.ibm.com, marko.kovacevic@intel.com, gavin.hu@arm.com,\n\tdharmik.thakkar@arm.com, malvika.gupta@arm.com", "Date": "Sun, 21 Apr 2019 18:40:54 +0200", "Message-ID": "<2742111.xWhxeopsW5@xps>", "In-Reply-To": "<20190417041359.45335-1-honnappa.nagarahalli@arm.com>", "References": "<20181122033055.3431-1-honnappa.nagarahalli@arm.com>\n\t<20190417041359.45335-1-honnappa.nagarahalli@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95546, "web_url": "http://patches.dpdk.org/comment/95546/", "msgid": "<AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com", "date": "2019-04-25T14:18:52", "subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "content": "> \n> 17/04/2019 06:13, Honnappa Nagarahalli:\n> > Dharmik Thakkar (1):\n> > test/rcu_qsbr: add API and functional tests\n> >\n> > Honnappa Nagarahalli (2):\n> > rcu: add RCU library supporting QSBR mechanism\n> > doc/rcu: add lib_rcu documentation\n> \n> Sorry I cannot merge this library in DPDK 19.05-rc2 because of several issues:\nApologies, we will improve our internal CI to add some of these compilations.\n\n> - 32-bit compilation is broken because of %lx/%lu instead of PRI?64\nI am able to reproduce this issue. However, I am not able to run the application. Following is the log on x86, does anyone know what is happening?\n\nEAL: Detected 28 lcore(s)\nEAL: Detected 2 NUMA nodes\nEAL: Multi-process socket /var/run/dpdk/rte/mp_socket\nEAL: Some devices want iova as va but pa will be used because.. EAL: vfio-noiommu mode configured\nEAL: few device bound to UIO\nEAL: Probing VFIO support...\nEAL: VFIO support initialized\nEAL: Cannot get a virtual area: Cannot allocate memory\nEAL: Cannot reserve memory\nEAL: Cannot allocate VA space for memseg list, retrying with different page size\nEAL: Cannot allocate VA space on socket 0\nEAL: FATAL: Cannot init memory\nEAL: Cannot init memory\n\n> - shared link is broken because of rcu_log_type not exported\nI am not sure what this is. Is this shared library compilation? Can you please let me know how to reproduce this?\n\n> - some public symbols (variable, macros, functions) are not prefixed with rte\nFor my understanding, are you referring to the following symbols?\nrcu_log_type\nRCU_DP_LOG - This is internal to the library, will change it to __RTE_RCU_DP_LOG\nRCU_IS_LOCK_CNT_ZERO - Same as above\n__rcu_qsbr_check_selective\n__rcu_qsbr_check_all\n\n> \n> I am not sure about getting it later in 19.05, it may be too late to merge a\n> new library.\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 467FB1B5AC;\n\tThu, 25 Apr 2019 16:18:55 +0200 (CEST)", "from EUR03-DB5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr40049.outbound.protection.outlook.com [40.107.4.49])\n\tby dpdk.org (Postfix) with ESMTP id 4501B1B5AA\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 16:18:54 +0200 (CEST)", "from AM0PR08MB5138.eurprd08.prod.outlook.com (10.255.30.207) by\n\tAM0PR08MB4003.eurprd08.prod.outlook.com (20.178.119.138) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1835.13; Thu, 25 Apr 2019 14:18:53 +0000", "from AM0PR08MB5138.eurprd08.prod.outlook.com\n\t([fe80::7134:261b:1f22:f379]) by\n\tAM0PR08MB5138.eurprd08.prod.outlook.com\n\t([fe80::7134:261b:1f22:f379%5]) with mapi id 15.20.1835.010;\n\tThu, 25 Apr 2019 14:18:53 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n\ts=selector1-arm-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ArVez2BhKTHGghqVGbQj3uydD3r+xUEWmV2KccsL+JA=;\n\tb=Yu2I2gVs9h84b0F2yTFbDrwlz4GxR+Dh9wl5CjHkPBXO0bhvOeYg9NKQuFvz00kYy25Ao7NRWS4EIYx8cLpx4xVCaBYOCkbdS9/G+A2lP0aFKKAf9ftes8FFjw76l3cvlxa4rCkla8/3xzbn5tGfab1FaEPrEYR2wogJTrlC1CU=", "From": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "To": "\"thomas@monjalon.net\" <thomas@monjalon.net>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"konstantin.ananyev@intel.com\"\n\t<konstantin.ananyev@intel.com>, \"stephen@networkplumber.org\"\n\t<stephen@networkplumber.org>, \"paulmck@linux.ibm.com\"\n\t<paulmck@linux.ibm.com>, \"marko.kovacevic@intel.com\"\n\t<marko.kovacevic@intel.com>, \"Gavin Hu (Arm Technology China)\"\n\t<Gavin.Hu@arm.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,\n\tMalvika Gupta <Malvika.Gupta@arm.com>,\n\tHonnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, \n\tnd <nd@arm.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "Thread-Index": "AQHU+GEDGjZxocb4x0ia29BvM8Tdd6ZKTVeg", "Date": "Thu, 25 Apr 2019 14:18:52 +0000", "Message-ID": "<AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "References": "<20181122033055.3431-1-honnappa.nagarahalli@arm.com>\n\t<20190417041359.45335-1-honnappa.nagarahalli@arm.com>\n\t<2742111.xWhxeopsW5@xps>", "In-Reply-To": "<2742111.xWhxeopsW5@xps>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Honnappa.Nagarahalli@arm.com; ", "x-originating-ip": "[217.140.111.135]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "8bb8134d-be9c-44d8-bb9e-08d6c988f1df", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:AM0PR08MB4003; ", "x-ms-traffictypediagnostic": "AM0PR08MB4003:", "x-ld-processed": "f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr", "nodisclaimer": "True", "x-microsoft-antispam-prvs": "<AM0PR08MB4003FC6B461B3244FE6B7D73983D0@AM0PR08MB4003.eurprd08.prod.outlook.com>", "x-forefront-prvs": "0018A2705B", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(366004)(396003)(136003)(376002)(39860400002)(199004)(189003)(5640700003)(72206003)(66556008)(4326008)(6916009)(99286004)(508600001)(8936002)(81166006)(8676002)(7696005)(1730700003)(81156014)(14454004)(68736007)(316002)(2501003)(71200400001)(54906003)(25786009)(71190400001)(2906002)(2351001)(446003)(11346002)(486006)(305945005)(74316002)(7736002)(33656002)(476003)(3846002)(6116002)(66066001)(229853002)(55016002)(26005)(97736004)(76176011)(6506007)(5660300002)(53936002)(9686003)(186003)(6246003)(52536014)(6436002)(66946007)(73956011)(76116006)(14444005)(256004)(102836004)(64756008)(66476007)(66446008)(86362001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4003;\n\tH:AM0PR08MB5138.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "heBU9PIW/IWedF0VBAY5LMxvm3Mu0wrnVEDsNNjGy2GQqjM37PnF0u4Ce2Cycfe86+de9TGmUBet159fNPYo707yjLkkvQPO3Ls037f7N6rRLDddR5zxnfq2QNUVhHJs7W1wIJDmjOGK1NurC5wMUO6z+/gTUgn5aMi1crGE12Nf/GTSKe/Rk0MXYpWbZbw5k9arH/oFTwcfLGLhgqetWiiiSYEbNSRvh6NNnmDc013W2xr0Wln2FVAcWXtSSLYCqchqkMbFx4K7j3WtVwwE2lc4yvoPyJGkawk5U7lpsaO6wR2FrsR96lIWLU6W5m2bE5+Y6ZvIiu8/IrHKAysClDYxRGashQxouaOV0jurUreYemhZSDOyh57VbAkXjE/J9CV1rwKzdkMu55HmR4lF41hZj8dqtBUY300s6lNmYJU=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "8bb8134d-be9c-44d8-bb9e-08d6c988f1df", "X-MS-Exchange-CrossTenant-originalarrivaltime": "25 Apr 2019 14:18:52.9099\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR08MB4003", "Subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95547, "web_url": "http://patches.dpdk.org/comment/95547/", "msgid": "<AM0PR08MB513848CA861A19FA3E9EBECF983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR08MB513848CA861A19FA3E9EBECF983D0@AM0PR08MB5138.eurprd08.prod.outlook.com", "date": "2019-04-25T14:27:36", "subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "content": "> >\n> > 17/04/2019 06:13, Honnappa Nagarahalli:\n> > > Dharmik Thakkar (1):\n> > > test/rcu_qsbr: add API and functional tests\n> > >\n> > > Honnappa Nagarahalli (2):\n> > > rcu: add RCU library supporting QSBR mechanism\n> > > doc/rcu: add lib_rcu documentation\n> >\n> > Sorry I cannot merge this library in DPDK 19.05-rc2 because of several\n> issues:\n> Apologies, we will improve our internal CI to add some of these compilations.\n> \n> > - 32-bit compilation is broken because of %lx/%lu instead of PRI?64\n> I am able to reproduce this issue. However, I am not able to run the\n> application. Following is the log on x86, does anyone know what is happening?\n> \n> EAL: Detected 28 lcore(s)\n> EAL: Detected 2 NUMA nodes\n> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket\n> EAL: Some devices want iova as va but pa will be used because.. EAL: vfio-\n> noiommu mode configured\n> EAL: few device bound to UIO\n> EAL: Probing VFIO support...\n> EAL: VFIO support initialized\n> EAL: Cannot get a virtual area: Cannot allocate memory\n> EAL: Cannot reserve memory\n> EAL: Cannot allocate VA space for memseg list, retrying with different page\n> size\n> EAL: Cannot allocate VA space on socket 0\n> EAL: FATAL: Cannot init memory\n> EAL: Cannot init memory\n> \nThis is resolved. It needed '--legacy-mem' option (thanks Maxime).\n\n> > - shared link is broken because of rcu_log_type not exported\n> I am not sure what this is. Is this shared library compilation? Can you please\n> let me know how to reproduce this?\n> \n> > - some public symbols (variable, macros, functions) are not prefixed\n> > with rte\n> For my understanding, are you referring to the following symbols?\n> rcu_log_type\n> RCU_DP_LOG - This is internal to the library, will change it to\n> __RTE_RCU_DP_LOG RCU_IS_LOCK_CNT_ZERO - Same as above\n> __rcu_qsbr_check_selective __rcu_qsbr_check_all\n> \n> >\n> > I am not sure about getting it later in 19.05, it may be too late to\n> > merge a new library.\n> >", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 961571B5AC;\n\tThu, 25 Apr 2019 16:27:39 +0200 (CEST)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr130070.outbound.protection.outlook.com [40.107.13.70])\n\tby dpdk.org (Postfix) with ESMTP id AB03D1B59E\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 16:27:38 +0200 (CEST)", "from AM0PR08MB5138.eurprd08.prod.outlook.com (10.255.30.207) by\n\tAM0PR08MB3411.eurprd08.prod.outlook.com (20.177.109.141) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1835.13; Thu, 25 Apr 2019 14:27:37 +0000", "from AM0PR08MB5138.eurprd08.prod.outlook.com\n\t([fe80::7134:261b:1f22:f379]) by\n\tAM0PR08MB5138.eurprd08.prod.outlook.com\n\t([fe80::7134:261b:1f22:f379%5]) with mapi id 15.20.1835.010;\n\tThu, 25 Apr 2019 14:27:37 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n\ts=selector1-arm-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=N8a5nC+bZUjURNawvdfW+99DuEpNVMIf3nz6mj8s0dU=;\n\tb=LORpKELom5MdxyyM3YU1gPJ1iAAigw/k6uPCrRCFb/P0aQrZLFyKSFW28OG6h7lCrI2he+AMzeyG0pUYAOV7rr6HSpmbQVcfcJmDbio1ZKNNbZpJvEO97b1gUl//qrBve/wg653Nn+g78mAfVTtgn+tRlolOIBS3jW/enTzrTBo=", "From": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "To": "\"thomas@monjalon.net\" <thomas@monjalon.net>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"konstantin.ananyev@intel.com\"\n\t<konstantin.ananyev@intel.com>, \"stephen@networkplumber.org\"\n\t<stephen@networkplumber.org>, \"paulmck@linux.ibm.com\"\n\t<paulmck@linux.ibm.com>, \"marko.kovacevic@intel.com\"\n\t<marko.kovacevic@intel.com>, \"Gavin Hu (Arm Technology China)\"\n\t<Gavin.Hu@arm.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,\n\tMalvika Gupta <Malvika.Gupta@arm.com>,\n\tHonnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, \n\tnd <nd@arm.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "Thread-Index": "AQHU+GEDGjZxocb4x0ia29BvM8Tdd6ZKTVeggAKmzcA=", "Date": "Thu, 25 Apr 2019 14:27:36 +0000", "Message-ID": "<AM0PR08MB513848CA861A19FA3E9EBECF983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "References": "<20181122033055.3431-1-honnappa.nagarahalli@arm.com>\n\t<20190417041359.45335-1-honnappa.nagarahalli@arm.com>\n\t<2742111.xWhxeopsW5@xps>\n\t<AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "In-Reply-To": "<AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Honnappa.Nagarahalli@arm.com; ", "x-originating-ip": "[217.140.111.135]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "266f9be6-1da4-44bf-930a-08d6c98a2a3d", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:AM0PR08MB3411; ", "x-ms-traffictypediagnostic": "AM0PR08MB3411:", "x-ld-processed": "f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr", "nodisclaimer": "True", "x-microsoft-antispam-prvs": "<AM0PR08MB341177697C19F396E9B211E6983D0@AM0PR08MB3411.eurprd08.prod.outlook.com>", "x-forefront-prvs": "0018A2705B", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(366004)(136003)(396003)(39860400002)(376002)(189003)(199004)(86362001)(5640700003)(55016002)(97736004)(9686003)(6436002)(229853002)(256004)(93156006)(6916009)(4326008)(25786009)(2351001)(8676002)(81156014)(81166006)(53936002)(14444005)(6246003)(316002)(7736002)(305945005)(26005)(186003)(74316002)(11346002)(476003)(486006)(14454004)(72206003)(2501003)(3846002)(2906002)(6116002)(508600001)(1730700003)(8936002)(33656002)(68736007)(99286004)(54906003)(7696005)(52536014)(76176011)(6506007)(5660300002)(102836004)(71190400001)(93886005)(71200400001)(2940100002)(66066001)(66476007)(76116006)(73956011)(66556008)(64756008)(66446008)(66946007)(446003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3411;\n\tH:AM0PR08MB5138.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "L5KE+78kCU5K1SzWW88D4TE5prjfxl7sMQWckdF29ujoFbO0tiEl0VrwHDHim4SX5/3kIXz1ifPf6tAvtRTHv/4wXOm04qdF04+DksPcWxMnB5z+w62AdKGvMbQcNmvsuL7P3DpGQzbJkx3mZ6GFQ4mMkfoTbxfOW3/UuxCOUhkwUYiTsL/C5zBEVlF8tQTUFw6iMj9BVAolz3DOagDnvyDlgpkRFt9YY7Bp0fnsf+8NYXMb/0aO206oZwzcjCPooSYk90672UaOgTsqdloXTsXqLpeeCAqzqJlAn/mC7DmE5kQXOEfo/a64UyuJOShvYDrJKIAu3x96R4kHFOVkIDIozsJ5JSDkh+Bk2fVjdTlYj7p5y0MS2SxByRpMNVBw7C2lzmshZ749NZD15wSORfqtKQpT+qD8EAdNFAM8hSs=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "266f9be6-1da4-44bf-930a-08d6c98a2a3d", "X-MS-Exchange-CrossTenant-originalarrivaltime": "25 Apr 2019 14:27:36.9881\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR08MB3411", "Subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95548, "web_url": "http://patches.dpdk.org/comment/95548/", "msgid": "<CAJFAV8zuzJTz=UkcdDmZxJCAg9f=XiVN5S8AfZY4UHJjpLDj-w@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8zuzJTz=UkcdDmZxJCAg9f=XiVN5S8AfZY4UHJjpLDj-w@mail.gmail.com", "date": "2019-04-25T14:38:17", "subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Thu, Apr 25, 2019 at 4:19 PM Honnappa Nagarahalli <\nHonnappa.Nagarahalli@arm.com> wrote:\n\n> > - shared link is broken because of rcu_log_type not exported\n> I am not sure what this is. Is this shared library compilation? Can you\n> please let me know how to reproduce this?\n>\n> > - some public symbols (variable, macros, functions) are not prefixed\n> with rte\n> For my understanding, are you referring to the following symbols?\n> rcu_log_type\n> RCU_DP_LOG - This is internal to the library, will change it to\n> __RTE_RCU_DP_LOG\n> RCU_IS_LOCK_CNT_ZERO - Same as above\n> __rcu_qsbr_check_selective\n> __rcu_qsbr_check_all\n>\n\nAfaiu, those are exposed via exported symbols, so they are part of the api.\nYou need to prefix them.\n\nHad a quick look at the code, I suppose enabling rcu debug and shared\nlibrary will trigger the link issue Thomas reported.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B9361B598;\n\tThu, 25 Apr 2019 16:38:31 +0200 (CEST)", "from mail-vs1-f68.google.com (mail-vs1-f68.google.com\n\t[209.85.217.68]) by dpdk.org (Postfix) with ESMTP id E4B871B579\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 16:38:28 +0200 (CEST)", "by mail-vs1-f68.google.com with SMTP id t23so12618267vso.10\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 07:38:28 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=xiXuWWmY+Vmj3iC+r6nI/mehs3AjUsUhSZ66+WESdWE=;\n\tb=Ge8fuyABVTU5OPg4hTIfreY2D5vFqO+rRO1dDm8m1Y0hUhiLbdsexFN7vpPZOxQqjL\n\tAxrMtaTIGC9PA00TP6W44VAsMYqgC/iOSEUnvsLVNnIekTl762wzzP0UzR9ub1Q6UAfm\n\ta8zxPxHIhwCJH2yw18kHj7pTlJlEq/T4cwSyZwtn/lCN73/pVT+Uizdf2BW9GBswSOC1\n\tr4DzMRQGeMXmvHDf0m6lTkzwEUIj6B/ntsDeeiMIIVBROgZUefaRH31aV+APmzEtYAeb\n\tt5xRQuxXjLEKJQSKZaDbwmt3Gn0UsqRjVqSrnGrEpKLx+jRZQdBelCO2By/NzxvIFq7U\n\tQSVA==", "X-Gm-Message-State": "APjAAAUI8/oBYlLUBLcV4VrKDRiLV/e08zDSBSmQA4x0FaF4Sjf3hvlY\n\t+e8iFU9qnhESK+MH9KpOcmXcTdeTP9nyOvny9EkIfA==", "X-Google-Smtp-Source": "APXvYqyh9pAoiQ8+IW+sbR17+5+3xviVoXNtM/9fGKSWrv9eAJksk+MCIsW2GIEt8BKwmDnktcABg84VThleE7mlgNM=", "X-Received": "by 2002:a67:edcb:: with SMTP id\n\te11mr21148410vsp.105.1556203108273; \n\tThu, 25 Apr 2019 07:38:28 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20181122033055.3431-1-honnappa.nagarahalli@arm.com>\n\t<20190417041359.45335-1-honnappa.nagarahalli@arm.com>\n\t<2742111.xWhxeopsW5@xps>\n\t<AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "In-Reply-To": "<AM0PR08MB5138D983CAB5983AF521A99B983D0@AM0PR08MB5138.eurprd08.prod.outlook.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Thu, 25 Apr 2019 16:38:17 +0200", "Message-ID": "<CAJFAV8zuzJTz=UkcdDmZxJCAg9f=XiVN5S8AfZY4UHJjpLDj-w@mail.gmail.com>", "To": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "Cc": "\"thomas@monjalon.net\" <thomas@monjalon.net>,\n\t\"dev@dpdk.org\" <dev@dpdk.org>, \n\t\"konstantin.ananyev@intel.com\" <konstantin.ananyev@intel.com>, \n\t\"stephen@networkplumber.org\" <stephen@networkplumber.org>, \n\t\"paulmck@linux.ibm.com\" <paulmck@linux.ibm.com>, \n\t\"marko.kovacevic@intel.com\" <marko.kovacevic@intel.com>, \n\t\"Gavin Hu (Arm Technology China)\" <Gavin.Hu@arm.com>,\n\tDharmik Thakkar <Dharmik.Thakkar@arm.com>, \n\tMalvika Gupta <Malvika.Gupta@arm.com>, nd <nd@arm.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting\n\tQSBR mechanism", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]