Cover Comment List
List cover comments
GET /api/covers/52436/comments/?format=api
[ { "id": 94680, "web_url": "http://patches.dpdk.org/comment/94680/", "msgid": "<f7tk1g4fcxb.fsf@dhcp-25.97.bos.redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f7tk1g4fcxb.fsf@dhcp-25.97.bos.redhat.com", "date": "2019-04-08T20:40:48", "subject": "Re: [dpdk-dev] [PATCH 0/3] librte_acl: fixes related to testing\n\twith the meson build", "submitter": { "id": 332, "url": "http://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "content": "Aaron Conole <aconole@redhat.com> writes:\n\n> This series fixes the following conditions in the RTE_ACL library:\n>\n> 1. Fix outstanding compilation issues on ARM with the NEON optimized code\n> These consisted mostly of compiler type-cast warnings. Additionally, some\n> of the vector code didn't initialize memory properly.\n>\n> 2. Properly include ARM, and PPC objects when building on those platforms\n> During the meson port, only the scalar code, and some of the x86_64 code was\n> ported.\n>\n> 3. Allow the unit tests to pass\n> In order to support this, the unsupported symbols were moved to a separate\n> file, which was needed to prevent the compiler from inlining references to the\n> functions (resulting in non-scalar code always falling into the -ENOTSUP case).\n>\n> The tests were modified to primarily test the scalar version - a better system\n> for exercising the non-scalar code needs to be developed.\n>\n> Aaron Conole (3):\n> acl: fix arm argument types\n> acl: update the build for multi-arch\n> acl: adjust the tests\n>\n> app/test/test_acl.c | 62 +++++++++++++--------------------\n> lib/librte_acl/Makefile | 1 +\n> lib/librte_acl/acl_run_neon.h | 46 ++++++++++++++----------\n> lib/librte_acl/acl_run_notsup.c | 46 ++++++++++++++++++++++++\n> lib/librte_acl/meson.build | 9 +++--\n> 5 files changed, 104 insertions(+), 60 deletions(-)\n> create mode 100644 lib/librte_acl/acl_run_notsup.c\n\nMight have sent prematurely - please ignore for the time being.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B8C3C4CA6;\n\tMon, 8 Apr 2019 22:40:52 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 1756F3572\n\tfor <dev@dpdk.org>; Mon, 8 Apr 2019 22:40:51 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 53F7830842AC;\n\tMon, 8 Apr 2019 20:40:50 +0000 (UTC)", "from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 71F261A7CD;\n\tMon, 8 Apr 2019 20:40:48 +0000 (UTC)" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "dev@dpdk.org", "Cc": "Konstantin Ananyev <konstantin.ananyev@intel.com>,\n\tJerin Jacob <jerinj@marvell.com>, Gavin Hu <gavin.hu@arm.com>,\n\tDavid Marchand <dmarchan@redhat.com>", "References": "<20190408182420.4398-1-aconole@redhat.com>", "Date": "Mon, 08 Apr 2019 16:40:48 -0400", "In-Reply-To": "<20190408182420.4398-1-aconole@redhat.com> (Aaron Conole's\n\tmessage of \"Mon, 8 Apr 2019 14:24:17 -0400\")", "Message-ID": "<f7tk1g4fcxb.fsf@dhcp-25.97.bos.redhat.com>", "User-Agent": "Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.40]); Mon, 08 Apr 2019 20:40:50 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH 0/3] librte_acl: fixes related to testing\n\twith the meson build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]