Cover Comment List
List cover comments
GET /api/covers/52226/comments/?format=api
[ { "id": 94434, "web_url": "http://patches.dpdk.org/comment/94434/", "msgid": "<4770051.yqIPWfFot0@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/4770051.yqIPWfFot0@xps", "date": "2019-04-03T20:39:51", "subject": "Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool\n\thandler", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "03/04/2019 22:09, Gage Eads:\n> v7:\n> - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely()\n> - Add rte_compat.h include to rte_stack.h for __rte_experimental\n\nThere is another error when compiling for Arm:\n\nlib/librte_stack/rte_stack.h:76:2: error:\n\timplicit declaration of function 'RTE_ASSERT'", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F3BC77CB0;\n\tWed, 3 Apr 2019 22:39:56 +0200 (CEST)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n\t[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E11415F72\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 22:39:55 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 371B02323D;\n\tWed, 3 Apr 2019 16:39:55 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Wed, 03 Apr 2019 16:39:55 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id DBAF9E4176;\n\tWed, 3 Apr 2019 16:39:52 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=ppLoJ1pS2n1mFH6SvLmAqTKF/+cUNo76ow+9/OLRJeA=; b=X93HFABf0HB5\n\ttpR7cI5cuabw63IFBT16qvwBU3QkWZnXzBhoqLs+xqPKsVS37ja3KDNUKletTx1n\n\tfuq81P4f4ebRx+03mWu7Eh2TdxBleOuCTssfNUAR01thT1NYUaOKdEAW1u/gJ4Vt\n\td0TpzwXLIkwC+M40XB3MFj50C4cG0zI=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm2; bh=ppLoJ1pS2n1mFH6SvLmAqTKF/+cUNo76ow+9/OLRJ\n\teA=; b=m8MGuExXVYddGpz3hPnA48g+pBGlsUNU89RkTQtmcozhUC10ybdqCMb4l\n\tD+1cM4JXXXB6mUpnLXrmhSKbeWp2xZYjPkIqR9sL1DH6RN9i+fljBboKucw/YLrV\n\tRL+MyKjZcKxFbS0HsnyNeP/nyxF4IPd4VcFexU2kznMkMsdxSYtYxmZc4sDXmDdJ\n\tfMZxcsp27FIzAh0uCBuBioGDUFPRFhWVlA20BrYMX7JIajhSLMNCZgM/9kgTPHye\n\tX3fsFh38kvNYEpSJAYyujT2Hz/ezmrDAUQlbexgF3GL3lqd64QU32Z1S31FPbbvk\n\tWuw4m22JK+ug8M5Tss7bvdZF2he6A==" ], "X-ME-Sender": "<xms:GhqlXEU7Brqoj62SLe9AHuO8AK3r7xjUWGnCrL2iJU3R2A9UHo3JuQ>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeduuddrtdefgdduvdehucdltddurdeguddtrddttd\n\tdmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv\n\tpdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih\n\tgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv\n\tnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh\n\tgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm\n\tpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush\n\thtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:GhqlXESIhtw2EibofHF2oYDArqxsTWn18V6i6wMdmlst6Ic0J2e3lA>\n\t<xmx:GhqlXMC6oBSTCpbb-xNItDxU6_TCuMluwokxO-syfCSR2i_MYeIb4w>\n\t<xmx:GhqlXDnSOcaM04YEqs4DwgSc790HrpDj5zHEl6HEVJCXpbqS9PNZHg>\n\t<xmx:GxqlXOdfmQDfI-cURcjVDZ4yGUhod7_DgvxdJDXeoS_46L6SedZN0g>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Gage Eads <gage.eads@intel.com>", "Cc": "dev@dpdk.org, olivier.matz@6wind.com, arybchenko@solarflare.com,\n\tbruce.richardson@intel.com, konstantin.ananyev@intel.com,\n\tgavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com", "Date": "Wed, 03 Apr 2019 22:39:51 +0200", "Message-ID": "<4770051.yqIPWfFot0@xps>", "In-Reply-To": "<20190403200916.16349-1-gage.eads@intel.com>", "References": "<20190401211429.20282-1-gage.eads@intel.com>\n\t<20190403200916.16349-1-gage.eads@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool\n\thandler", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 94435, "web_url": "http://patches.dpdk.org/comment/94435/", "msgid": "<9184057F7FC11744A2107296B6B8EB1E542107EF@FMSMSX108.amr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9184057F7FC11744A2107296B6B8EB1E542107EF@FMSMSX108.amr.corp.intel.com", "date": "2019-04-03T20:49:08", "subject": "Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool\n\thandler", "submitter": { "id": 586, "url": "http://patches.dpdk.org/api/people/586/?format=api", "name": "Eads, Gage", "email": "gage.eads@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas@monjalon.net]\n> Sent: Wednesday, April 3, 2019 3:40 PM\n> To: Eads, Gage <gage.eads@intel.com>\n> Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com;\n> Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin\n> <konstantin.ananyev@intel.com>; gavin.hu@arm.com;\n> Honnappa.Nagarahalli@arm.com; nd@arm.com\n> Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool\n> handler\n> \n> 03/04/2019 22:09, Gage Eads:\n> > v7:\n> > - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely()\n> > - Add rte_compat.h include to rte_stack.h for __rte_experimental\n> \n> There is another error when compiling for Arm:\n> \n> lib/librte_stack/rte_stack.h:76:2: error:\n> \timplicit declaration of function 'RTE_ASSERT'\n\nFix incoming. Looking through the rest of that header, I don't see any other externally defined macros/data structures/functions/etc. that would need another include.\n\nAlso note that v7's ci/Performance-Testing build fail (http://mails.dpdk.org/archives/test-report/2019-April/079261.html) is because dpdklab applied the patch on commit 3c45889189924067, which is older than the 128-bit CAS patch.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 30D7B5F36;\n\tWed, 3 Apr 2019 22:49:14 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 5F2845920\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 22:49:12 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 13:49:11 -0700", "from fmsmsx105.amr.corp.intel.com ([10.18.124.203])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Apr 2019 13:49:11 -0700", "from fmsmsx112.amr.corp.intel.com (10.18.116.6) by\n\tFMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP\n\tServer (TLS) id 14.3.408.0; Wed, 3 Apr 2019 13:49:09 -0700", "from fmsmsx108.amr.corp.intel.com ([169.254.9.216]) by\n\tFMSMSX112.amr.corp.intel.com ([169.254.5.23]) with mapi id\n\t14.03.0415.000; Wed, 3 Apr 2019 13:49:09 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,306,1549958400\"; d=\"scan'208\";a=\"139759390\"", "From": "\"Eads, Gage\" <gage.eads@intel.com>", "To": "Thomas Monjalon <thomas@monjalon.net>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"olivier.matz@6wind.com\"\n\t<olivier.matz@6wind.com>, \"arybchenko@solarflare.com\"\n\t<arybchenko@solarflare.com>, \"Richardson, Bruce\"\n\t<bruce.richardson@intel.com>, \"Ananyev, Konstantin\"\n\t<konstantin.ananyev@intel.com>, \"gavin.hu@arm.com\" <gavin.hu@arm.com>,\n\t\"Honnappa.Nagarahalli@arm.com\" <Honnappa.Nagarahalli@arm.com>,\n\t\"nd@arm.com\" <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool\n\thandler", "Thread-Index": "AQHU6l106HJcq+HQzkaheTjzG/xNHaYq58Yg", "Date": "Wed, 3 Apr 2019 20:49:08 +0000", "Message-ID": "<9184057F7FC11744A2107296B6B8EB1E542107EF@FMSMSX108.amr.corp.intel.com>", "References": "<20190401211429.20282-1-gage.eads@intel.com>\n\t<20190403200916.16349-1-gage.eads@intel.com> <4770051.yqIPWfFot0@xps>", "In-Reply-To": "<4770051.yqIPWfFot0@xps>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTA1NWZkNjQtNTE5My00Yjc5LWI5MDAtODg0MjA0ODhiMTlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUQ5b2dLTG1qNEx2WlRLMmF5azR1U082RWR0YjE1dHdxSnJBTG4yUVVjQzJ5cGwyNXlGZDdEeUYrek92aVRRbyJ9", "x-ctpclassification": "CTP_NT", "dlp-product": "dlpe-windows", "dlp-version": "11.0.400.15", "dlp-reaction": "no-action", "x-originating-ip": "[10.1.200.107]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool\n\thandler", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]