Cover Detail
Show a cover letter.
GET /api/covers/51234/?format=api
{ "id": 51234, "url": "http://patches.dpdk.org/api/covers/51234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20190315182022.39976-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190315182022.39976-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190315182022.39976-1-bruce.richardson@intel.com", "date": "2019-03-15T18:20:18", "name": "[v3,0/4] One versionfile to rule them all...", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20190315182022.39976-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 3763, "url": "http://patches.dpdk.org/api/series/3763/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3763", "date": "2019-03-15T18:20:18", "name": "One versionfile to rule them all...", "version": 3, "mbox": "http://patches.dpdk.org/series/3763/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/51234/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 38EAE4C96;\n\tFri, 15 Mar 2019 19:20:41 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 4289F2C17\n\tfor <dev@dpdk.org>; Fri, 15 Mar 2019 19:20:39 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Mar 2019 11:20:38 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby fmsmga007.fm.intel.com with ESMTP; 15 Mar 2019 11:20:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,483,1544515200\"; d=\"scan'208\";a=\"134701229\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>,\n\tThomas Monjalon <thomas@monjalon.net>, Luca Boccassi <bluca@debian.org>, \n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 15 Mar 2019 18:20:18 +0000", "Message-Id": "<20190315182022.39976-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190307115448.54041-1-bruce.richardson@intel.com>", "References": "<20190307115448.54041-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all...", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Right now with DPDK we have two sources of version information - the\nrte_version.h header file containing macros for C use, and the project\nversion number in the project definition in meson.build. This is not\noptimal, so this patchset aims to provide a single source for the DPDK\nversion. The options considered are:\n\n* Keep version info in rte_version.h only. The two reasons this was not\n chosen were:\n 1) parsing the version number from the header is awkward, as seen in the\n rte.sdkconfig.mk file, and a script to do so would be needed to\n integrate that into the meson build project definition.\n 2) rte_version.h is not in an obvious location inside the project when\n a user clones from git. It's hidden away in the\n \"lib/librte_eal/common/include\" folder. Ideally the version number\n should be evident at the top level of the DPDK tree.\n\n* Keep version info in meson.build file only. This seemed a better option\n than keeping the info in rte_version.h, but it still had disadvantages:\n 1) For make, using grep on meson.build to extract the version seemed a\n bit awkward, though doable. Splitting the version was tricky too, but\n manageable with a small amount of scripting.\n 2) There was no easy way to have users access the version number when\n \"make showversion\" was deprecated with the make build system.\n\n* Store the version number in a new version file at the root level of the\n repo.\n * This did have the advantage of being easily discoverable on clone\n * Still had the disadvantage of needing some parsing to generate the\n defines from rte_version.h\n\nSince the last option seemed best, that is what is implemented in this set.\nThe file DPDK_VERSION is added to store the version number, and make and\nmeson both use that as their source of version info. For C code, the\nrte_version.h header remains, except that the basic definitions of the\nrelease YEAR, MONTH, MINOR etc. are moved to be automatically generated as\npart of rte_config.h. For make builds, this is done via using the\npreprocessor to insert the values when it generates the config. For meson\nbuilds, this is done by just adding the values to the dpdk_conf\nconfiguration object.\n\n---\nV3: Reworked following review from Thomas Monjalon. Main change is to how\n the RTE_VER_RELEASE value is computed for non-release candidates.\n Also added int() conversion to each version value to remove leading\n zeros\nV2: Updated following review from David Marchand.\n\nBruce Richardson (4):\n build: add single source of DPDK version number\n build: move meson version handling to config directory\n build: use version number from config file\n eal: remove unneeded version logic\n\n VERSION | 1 +\n config/common_base | 14 ++++++++\n config/meson.build | 26 +++++++++++++++\n config/rte_config.h | 3 ++\n lib/librte_eal/common/include/rte_version.h | 36 +--------------------\n meson.build | 21 +++++-------\n mk/rte.sdkconfig.mk | 23 ++++++-------\n 7 files changed, 62 insertions(+), 62 deletions(-)\n create mode 100644 VERSION" }