Cover Detail
Show a cover letter.
GET /api/covers/50057/?format=api
{ "id": 50057, "url": "http://patches.dpdk.org/api/covers/50057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20190125202642.66559-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190125202642.66559-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190125202642.66559-1-bruce.richardson@intel.com", "date": "2019-01-25T20:26:38", "name": "[0/4] RFC: consolidate testing apps to app dir", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20190125202642.66559-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 3330, "url": "http://patches.dpdk.org/api/series/3330/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3330", "date": "2019-01-25T20:26:38", "name": "RFC: consolidate testing apps to app dir", "version": 1, "mbox": "http://patches.dpdk.org/series/3330/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/50057/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F0141F1C;\n\tFri, 25 Jan 2019 21:26:53 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 6ECABF72\n\tfor <dev@dpdk.org>; Fri, 25 Jan 2019 21:26:51 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jan 2019 12:26:50 -0800", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby fmsmga004.fm.intel.com with ESMTP; 25 Jan 2019 12:26:49 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,522,1539673200\"; d=\"scan'208\";a=\"138843377\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 25 Jan 2019 20:26:38 +0000", "Message-Id": "<20190125202642.66559-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The apps for testing are split between the \"test\" and \"app\" directories,\nwith a not-very-clear distinction between the two (at least to my mind).\n\nGiven how the apps are being built, the easiest path to having\ncmdline_test, test-acl and test-pipeline build using meson is to\nconsolidate all these apps back into the app folder and use the logic\nthere. The bpf folder doesn't contain an actual application, but\nrather example bpf code which can be loaded into testpmd. That is\npossibly best moved to the examples folder, but I'm open to feedback\non the best place for it.\n\nWith these changes, the \"test\" folder then becomes the location for\nunit tests only.\n\n\nBruce Richardson (4):\n test/cmdline_test: move to app directory\n test/test-acl: move to app directory\n test/test-pipeline: move to app directory\n test/bpf: move to examples folder\n\n app/Makefile | 3 +++\n {test => app}/cmdline_test/Makefile | 0\n {test => app}/cmdline_test/cmdline_test.c | 0\n {test => app}/cmdline_test/cmdline_test.h | 0\n {test => app}/cmdline_test/cmdline_test.py | 0\n {test => app}/cmdline_test/cmdline_test_data.py | 0\n {test => app}/cmdline_test/commands.c | 0\n app/cmdline_test/meson.build | 5 +++++\n app/meson.build | 5 ++++-\n {test => app}/test-acl/Makefile | 0\n {test => app}/test-acl/main.c | 0\n app/test-acl/meson.build | 5 +++++\n {test => app}/test-pipeline/Makefile | 0\n {test => app}/test-pipeline/config.c | 0\n {test => app}/test-pipeline/init.c | 0\n {test => app}/test-pipeline/main.c | 0\n {test => app}/test-pipeline/main.h | 0\n app/test-pipeline/meson.build | 14 ++++++++++++++\n {test => app}/test-pipeline/pipeline_acl.c | 0\n {test => app}/test-pipeline/pipeline_hash.c | 0\n {test => app}/test-pipeline/pipeline_lpm.c | 0\n {test => app}/test-pipeline/pipeline_lpm_ipv6.c | 0\n {test => app}/test-pipeline/pipeline_stub.c | 0\n {test => app}/test-pipeline/runtime.c | 0\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++----\n examples/bpf/README | 8 ++++++++\n {test => examples}/bpf/dummy.c | 0\n {test => examples}/bpf/mbuf.h | 0\n examples/bpf/meson.build | 6 ++++++\n {test => examples}/bpf/t1.c | 0\n {test => examples}/bpf/t2.c | 0\n {test => examples}/bpf/t3.c | 0\n test/Makefile | 3 ---\n 33 files changed, 49 insertions(+), 8 deletions(-)\n rename {test => app}/cmdline_test/Makefile (100%)\n rename {test => app}/cmdline_test/cmdline_test.c (100%)\n rename {test => app}/cmdline_test/cmdline_test.h (100%)\n rename {test => app}/cmdline_test/cmdline_test.py (100%)\n rename {test => app}/cmdline_test/cmdline_test_data.py (100%)\n rename {test => app}/cmdline_test/commands.c (100%)\n create mode 100644 app/cmdline_test/meson.build\n rename {test => app}/test-acl/Makefile (100%)\n rename {test => app}/test-acl/main.c (100%)\n create mode 100644 app/test-acl/meson.build\n rename {test => app}/test-pipeline/Makefile (100%)\n rename {test => app}/test-pipeline/config.c (100%)\n rename {test => app}/test-pipeline/init.c (100%)\n rename {test => app}/test-pipeline/main.c (100%)\n rename {test => app}/test-pipeline/main.h (100%)\n create mode 100644 app/test-pipeline/meson.build\n rename {test => app}/test-pipeline/pipeline_acl.c (100%)\n rename {test => app}/test-pipeline/pipeline_hash.c (100%)\n rename {test => app}/test-pipeline/pipeline_lpm.c (100%)\n rename {test => app}/test-pipeline/pipeline_lpm_ipv6.c (100%)\n rename {test => app}/test-pipeline/pipeline_stub.c (100%)\n rename {test => app}/test-pipeline/runtime.c (100%)\n create mode 100644 examples/bpf/README\n rename {test => examples}/bpf/dummy.c (100%)\n rename {test => examples}/bpf/mbuf.h (100%)\n create mode 100644 examples/bpf/meson.build\n rename {test => examples}/bpf/t1.c (100%)\n rename {test => examples}/bpf/t2.c (100%)\n rename {test => examples}/bpf/t3.c (100%)" }