Cover Comment List
List cover comments
GET /api/covers/44172/comments/?format=api
[ { "id": 86898, "web_url": "http://patches.dpdk.org/comment/86898/", "msgid": "<F93C4FAB-2053-4C7E-83CE-E3D1834593A2@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F93C4FAB-2053-4C7E-83CE-E3D1834593A2@intel.com", "date": "2018-10-05T14:09:10", "subject": "Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "submitter": { "id": 166, "url": "http://patches.dpdk.org/api/people/166/?format=api", "name": "Wiles, Keith", "email": "keith.wiles@intel.com" }, "content": "> On Sep 3, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote:\n> \n> For meson build without deprecation warnings following\n> patch should be applied first:\n> http://patches.dpdk.org/patch/44129/\n\nNot to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is delay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which is a form of delay, but delay in DPDK assume busy wait.\n> \n> Ilya Maximets (2):\n> eal: add nanosleep based delay function\n> drivers/net: use sleep delay by default for intel NICs\n> \n> drivers/net/avf/Makefile | 1 +\n> drivers/net/avf/base/avf_osdep.h | 4 +-\n> drivers/net/e1000/Makefile | 1 +\n> drivers/net/e1000/base/e1000_osdep.h | 2 +-\n> drivers/net/e1000/meson.build | 2 +\n> drivers/net/i40e/base/i40e_osdep.h | 6 +--\n> drivers/net/ifc/base/ifcvf_osdep.h | 2 +-\n> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +-\n> drivers/net/ixgbe/meson.build | 3 +-\n> lib/librte_eal/common/eal_common_timer.c | 19 +++++++\n> .../common/include/generic/rte_cycles.h | 11 ++++\n> lib/librte_eal/rte_eal_version.map | 1 +\n> test/test/autotest_data.py | 6 +++\n> test/test/meson.build | 1 +\n> test/test/test_cycles.c | 51 ++++++++++++++-----\n> 15 files changed, 89 insertions(+), 23 deletions(-)\n> \n> -- \n> 2.17.1\n> \n\nRegards,\nKeith", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D771E1B136;\n\tFri, 5 Oct 2018 16:09:52 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 1D5481B134\n\tfor <dev@dpdk.org>; Fri, 5 Oct 2018 16:09:50 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Oct 2018 07:09:50 -0700", "from fmsmsx104.amr.corp.intel.com ([10.18.124.202])\n\tby fmsmga008.fm.intel.com with ESMTP; 05 Oct 2018 07:09:12 -0700", "from fmsmsx111.amr.corp.intel.com (10.18.116.5) by\n\tfmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 5 Oct 2018 07:09:11 -0700", "from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by\n\tfmsmsx111.amr.corp.intel.com ([169.254.12.10]) with mapi id\n\t14.03.0319.002; Fri, 5 Oct 2018 07:09:11 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,344,1534834800\"; d=\"scan'208\";a=\"76466420\"", "From": "\"Wiles, Keith\" <keith.wiles@intel.com>", "To": "Ilya Maximets <i.maximets@samsung.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Wu, Jingjing\" <jingjing.wu@intel.com>,\n\t\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>, \"Lu, Wenzhuo\"\n\t<wenzhuo.lu@intel.com>, \"Xing, Beilei\" <beilei.xing@intel.com>, \"Zhang,\n\tQi Z\" <qi.z.zhang@intel.com>, \"Wang, Xiao W\" <xiao.w.wang@intel.com>,\n\t\"Richardson, Bruce\" <bruce.richardson@intel.com>", "Thread-Topic": "[dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "Thread-Index": "AQHUQ5SjvH4y+epZ7EKWcma5u068v6URWCgA", "Date": "Fri, 5 Oct 2018 14:09:10 +0000", "Message-ID": "<F93C4FAB-2053-4C7E-83CE-E3D1834593A2@intel.com>", "References": "<20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com>\n\t<CGME20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6@eucas1p2.samsung.com>\n\t<20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com>", "In-Reply-To": "<20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.254.18.77]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-ID": "<699DF7E166764E41B748942D370F8204@intel.com>", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 86902, "web_url": "http://patches.dpdk.org/comment/86902/", "msgid": "<20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com", "date": "2018-10-05T14:44:16", "subject": "Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "content": "On 05.10.2018 17:09, Wiles, Keith wrote:\n> \n> \n>> On Sep 3, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote:\n>>\n>> For meson build without deprecation warnings following\n>> patch should be applied first:\n>> http://patches.dpdk.org/patch/44129/\n> \n> Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is delay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which is a form of delay, but delay in DPDK assume busy wait.\n\nI'm not sure about this, because this function intended to be used\nas 'rte_delay_us_callback', i.e. as implementation of 'rte_delay_us()'.\nIMO, it should state that it is the part of this API and that it\nsleeps internally at the same time. So I tried to combine both \"delay\"\nand \"sleep\" in one function name.\n\nIf we'll change the name to 'rte_sleep_us' it will look like alternative\nto 'rte_delay_us', but it's one of its implementations.\n'rte_delay_us_sleep' should be alternative to 'rte_delay_us_block()'.\n\nI'd like to call it 'rte_delay_us_nonblock()', but it may be way more\nconfusing.\n\nWhat do you think?\n\n>>\n>> Ilya Maximets (2):\n>> eal: add nanosleep based delay function\n>> drivers/net: use sleep delay by default for intel NICs\n>>\n>> drivers/net/avf/Makefile | 1 +\n>> drivers/net/avf/base/avf_osdep.h | 4 +-\n>> drivers/net/e1000/Makefile | 1 +\n>> drivers/net/e1000/base/e1000_osdep.h | 2 +-\n>> drivers/net/e1000/meson.build | 2 +\n>> drivers/net/i40e/base/i40e_osdep.h | 6 +--\n>> drivers/net/ifc/base/ifcvf_osdep.h | 2 +-\n>> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +-\n>> drivers/net/ixgbe/meson.build | 3 +-\n>> lib/librte_eal/common/eal_common_timer.c | 19 +++++++\n>> .../common/include/generic/rte_cycles.h | 11 ++++\n>> lib/librte_eal/rte_eal_version.map | 1 +\n>> test/test/autotest_data.py | 6 +++\n>> test/test/meson.build | 1 +\n>> test/test/test_cycles.c | 51 ++++++++++++++-----\n>> 15 files changed, 89 insertions(+), 23 deletions(-)\n>>\n>> -- \n>> 2.17.1\n>>\n> \n> Regards,\n> Keith\n> \n> \n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DFCD41B20C;\n\tFri, 5 Oct 2018 16:41:59 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n\t[210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 572B81B203\n\tfor <dev@dpdk.org>; Fri, 5 Oct 2018 16:41:58 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n\tby mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20181005144157euoutp01ed10248911fd98f9956bbf2fe7e4d34f~avXFXkWMH0195401954euoutp01p\n\tfor <dev@dpdk.org>; Fri, 5 Oct 2018 14:41:57 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20181005144156eucas1p2550a14190d15d8967a39b0daa0a53892~avXE5sV9I2637926379eucas1p2k;\n\tFri, 5 Oct 2018 14:41:56 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n\teusmges3new.samsung.com (EUCPMTA) with SMTP id 96.72.04806.43877BB5;\n\tFri, 5 Oct 2018 15:41:56 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n\t20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L;\n\tFri, 5 Oct 2018 14:41:55 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n\teusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n\t20181005144155eusmtrp19787076de3a4f5a07dded310ad259e2d~avXD1n0f81790617906eusmtrp1H;\n\tFri, 5 Oct 2018 14:41:55 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms1.samsung.com (EUCPMTA) with SMTP id C7.ED.04284.33877BB5;\n\tFri, 5 Oct 2018 15:41:55 +0100 (BST)", "from [106.109.129.180] (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20181005144154eusmtip25b1babf729d73806965e94332e430598~avXDQxPxl0624606246eusmtip2L;\n\tFri, 5 Oct 2018 14:41:54 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n\t20181005144157euoutp01ed10248911fd98f9956bbf2fe7e4d34f~avXFXkWMH0195401954euoutp01p", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1538750517;\n\tbh=peE204DvhnhFzaykwDe9dfATXgqhkWJe3qUUYiP4l5k=;\n\th=Subject:To:Cc:From:Date:In-Reply-To:References:From;\n\tb=M0ksPKy09G5XVdEN2KUQ2FJw8TXLGjM08tq7gsDenpiRvjyHOsYCIOJ/JLZQoh4Fp\n\tj2XcBHLf1UVa93b1rcf0gZB2N8z7RlukwZ66DBFghXMWiAooDF484wFg2j5LH03e4S\n\tzT7znjGARDik6F9XFwkHw1ZQZjhQu5lD2aVAjNgg=", "X-AuditID": "cbfec7f5-34dff700000012c6-19-5bb77834dadc", "To": "\"Wiles, Keith\" <keith.wiles@intel.com>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Wu, Jingjing\" <jingjing.wu@intel.com>,\n\t\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>, \"Lu, Wenzhuo\"\n\t<wenzhuo.lu@intel.com>, \"Xing, Beilei\" <beilei.xing@intel.com>, \"Zhang,\n\tQi Z\" <qi.z.zhang@intel.com>, \"Wang, Xiao W\" <xiao.w.wang@intel.com>,\n\t\"Richardson, Bruce\" <bruce.richardson@intel.com>", "From": "Ilya Maximets <i.maximets@samsung.com>", "Date": "Fri, 5 Oct 2018 17:44:16 +0300", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<F93C4FAB-2053-4C7E-83CE-E3D1834593A2@intel.com>", "Content-Language": "en-GB", "Content-Transfer-Encoding": "7bit", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsWy7djP87omFdujDVpuSlh0f2hhsrixyt7i\n\t3aftTBZX2n+yW8xc8JnR4urx78wW7/8sYrGYvqGfzWLrmb+MFvufH2Z34PL4tWApq8fiPS+Z\n\tPPq2rGIMYI7isklJzcksSy3St0vgymibvIatYJZQxfneR+wNjPt5uxg5OSQETCQ2tv1n7mLk\n\t4hASWMEo8XbJVCjnC6PEnYPdLBDOZ0aJ/+33mGBa/q36zAiRWM4o8XTlcSjnI6PEjL/fWUCq\n\thAVsJe5cewJmiwhoSSz894YdpIhZ4CqTRMvBz+wgCTYBHYlTq48wgtgsAioSLU0f2EBsUYEI\n\tiSMPFoLFeQUEJU7OhBjECTS0ffMyMJtZQFyi6ctKVghbXmL72zlgh0sIbGOXaO9tBrqVA6i5\n\tTOL//yyIs10kOs/OY4GwhSVeHd/CDmHLSJye3AMVr5e43/KSEWJOB6PE9EP/oH62l9jy+hw7\n\tyExmAU2J9bv0IcKOEmentbCBhCUE+CRuvBWEOIdPYtK26cwQYV6JjjYhiGoVid8HlzND2FIS\n\tN999Zp/AqDQLyZOzkDw2C8ljsxD2LmBkWcUonlpanJueWmycl1quV5yYW1yal66XnJ+7iRGY\n\tjk7/O/51B+O+P0mHGAU4GJV4eF8ob4sWYk0sK67MPcQowcGsJMK7J357tBBvSmJlVWpRfnxR\n\taU5q8SFGaQ4WJXHeZfM2RgsJpCeWpGanphakFsFkmTg4pRoYTx3pnRI+715+VnHP1FNrn7xt\n\tVDR5bTvXetPK1PUcvo2c/tE1KQEHZLqKZvzf+qDpr7RA0WHG214/lYxKTJNXXdjVOj99atza\n\tS2eML85p5l73q2nr32aWZ0zrn4t/L3IKfKXt/X/dkR+q2/ravLbcvvci7v7T7o23a3fNUZM/\n\tuXb14Svmmz/ndyuxFGckGmoxFxUnAgBL59yiQwMAAA==", "H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t/xe7rGFdujDX5fV7Do/tDCZHFjlb3F\n\tu0/bmSyutP9kt5i54DOjxdXj35kt3v9ZxGIxfUM/m8XWM38ZLfY/P8zuwOXxa8FSVo/Fe14y\n\tefRtWcUYwBylZ1OUX1qSqpCRX1xiqxRtaGGkZ2hpoWdkYqlnaGwea2VkqqRvZ5OSmpNZllqk\n\tb5egl9E2eQ1bwSyhivO9j9gbGPfzdjFyckgImEj8W/WZEcQWEljKKHHjfBREXErix68LrBC2\n\tsMSfa11sEDXvGSV2H60FsYUFbCXuXHvCAmKLCGhJLPz3hh3EZha4ziSx9H9EFyMXUP0rJokV\n\tu5YwgyTYBHQkTq0+AraMV8BOYvqyiWALWARUJFqaPoAtEBWIkFi9/AUrRI2gxMmZEAs4gZa1\n\tb17GArFAXeLPvEvMELa4RNOXlawQtrzE9rdzmCcwCs1C0j4LScssJC2zkLQsYGRZxSiSWlqc\n\tm55bbKhXnJhbXJqXrpecn7uJERh924793LyD8dLG4EOMAhyMSjy8L5S3RQuxJpYVV+YeYpTg\n\tYFYS4d0Tvz1aiDclsbIqtSg/vqg0J7X4EKMp0HMTmaVEk/OBiSGvJN7Q1NDcwtLQ3Njc2MxC\n\tSZz3vEFllJBAemJJanZqakFqEUwfEwenVAPjJLe6m4HNC7R4fNalKRfaGS+uPb1068oYrmz2\n\tKzlSdqV3tEJSXs35v0n3KTfPzCeLLftXzp6ZPP3BhsIdplye11rdQy3uSE7fm2bcvPDNir/G\n\tftXPG6Yt1dxqVnX5Ekvpn4MCt0s+bjcrPB3U9Urzeunu10feMrccK/hVXStTsM108fR7uvKc\n\tSizFGYmGWsxFxYkAkNQUytQCAAA=" ], "Message-Id": "<20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com>", "X-CMS-MailID": "20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6", "References": "<20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com>\n\t<CGME20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6@eucas1p2.samsung.com>\n\t<20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com>\n\t<F93C4FAB-2053-4C7E-83CE-E3D1834593A2@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 86905, "web_url": "http://patches.dpdk.org/comment/86905/", "msgid": "<FAF13BAD-3722-4816-81C9-4C49694A580F@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/FAF13BAD-3722-4816-81C9-4C49694A580F@intel.com", "date": "2018-10-05T15:04:57", "subject": "Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "submitter": { "id": 166, "url": "http://patches.dpdk.org/api/people/166/?format=api", "name": "Wiles, Keith", "email": "keith.wiles@intel.com" }, "content": "> On Oct 5, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote:\n> \n> On 05.10.2018 17:09, Wiles, Keith wrote:\n>> \n>> \n>>> On Sep 3, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote:\n>>> \n>>> For meson build without deprecation warnings following\n>>> patch should be applied first:\n>>> http://patches.dpdk.org/patch/44129/\n>> \n>> Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is delay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which is a form of delay, but delay in DPDK assume busy wait.\n> \n> I'm not sure about this, because this function intended to be used\n> as 'rte_delay_us_callback', i.e. as implementation of 'rte_delay_us()'.\n> IMO, it should state that it is the part of this API and that it\n> sleeps internally at the same time. So I tried to combine both \"delay\"\n> and \"sleep\" in one function name.\n> \n> If we'll change the name to 'rte_sleep_us' it will look like alternative\n> to 'rte_delay_us', but it's one of its implementations.\n> 'rte_delay_us_sleep' should be alternative to 'rte_delay_us_block()'.\n> \n> I'd like to call it 'rte_delay_us_nonblock()', but it may be way more\n> confusing.\n> \n> What do you think?\n\nI personally do not see the big tie to delay and callback as the rte_delay_us() is not rte_delay_us_with_callback() :-) Yes the code maybe doing a callback, but that has nothing to do with the API name IMO.\n\nAnyone else care about the name?\n\n> \n>>> \n>>> Ilya Maximets (2):\n>>> eal: add nanosleep based delay function\n>>> drivers/net: use sleep delay by default for intel NICs\n>>> \n>>> drivers/net/avf/Makefile | 1 +\n>>> drivers/net/avf/base/avf_osdep.h | 4 +-\n>>> drivers/net/e1000/Makefile | 1 +\n>>> drivers/net/e1000/base/e1000_osdep.h | 2 +-\n>>> drivers/net/e1000/meson.build | 2 +\n>>> drivers/net/i40e/base/i40e_osdep.h | 6 +--\n>>> drivers/net/ifc/base/ifcvf_osdep.h | 2 +-\n>>> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +-\n>>> drivers/net/ixgbe/meson.build | 3 +-\n>>> lib/librte_eal/common/eal_common_timer.c | 19 +++++++\n>>> .../common/include/generic/rte_cycles.h | 11 ++++\n>>> lib/librte_eal/rte_eal_version.map | 1 +\n>>> test/test/autotest_data.py | 6 +++\n>>> test/test/meson.build | 1 +\n>>> test/test/test_cycles.c | 51 ++++++++++++++-----\n>>> 15 files changed, 89 insertions(+), 23 deletions(-)\n>>> \n>>> -- \n>>> 2.17.1\n>>> \n>> \n>> Regards,\n>> Keith\n>> \n>> \n>> \n\nRegards,\nKeith", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 532081B3A1;\n\tFri, 5 Oct 2018 17:05:04 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id DF8A41B1CD\n\tfor <dev@dpdk.org>; Fri, 5 Oct 2018 17:05:02 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Oct 2018 08:05:02 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby fmsmga001.fm.intel.com with ESMTP; 05 Oct 2018 08:04:58 -0700", "from fmsmsx116.amr.corp.intel.com (10.18.116.20) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 5 Oct 2018 08:04:58 -0700", "from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by\n\tfmsmsx116.amr.corp.intel.com ([169.254.2.92]) with mapi id\n\t14.03.0319.002; Fri, 5 Oct 2018 08:04:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,344,1534834800\"; d=\"scan'208\";a=\"96395354\"", "From": "\"Wiles, Keith\" <keith.wiles@intel.com>", "To": "Ilya Maximets <i.maximets@samsung.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Wu, Jingjing\" <jingjing.wu@intel.com>,\n\t\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>, \"Lu, Wenzhuo\"\n\t<wenzhuo.lu@intel.com>, \"Xing, Beilei\" <beilei.xing@intel.com>, \"Zhang,\n\tQi Z\" <qi.z.zhang@intel.com>, \"Wang, Xiao W\" <xiao.w.wang@intel.com>,\n\t\"Richardson, Bruce\" <bruce.richardson@intel.com>", "Thread-Topic": "[dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "Thread-Index": "AQHUQ5SjvH4y+epZ7EKWcma5u068v6URWCgAgAAJzgCAAAXIgA==", "Date": "Fri, 5 Oct 2018 15:04:57 +0000", "Message-ID": "<FAF13BAD-3722-4816-81C9-4C49694A580F@intel.com>", "References": "<20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com>\n\t<CGME20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6@eucas1p2.samsung.com>\n\t<20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com>\n\t<F93C4FAB-2053-4C7E-83CE-E3D1834593A2@intel.com>\n\t<20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com>", "In-Reply-To": "<20181005144155eucas1p17ea3717e6772e390d02bc9ce44e50a8d~avXEH-nZ31850018500eucas1p1L@eucas1p1.samsung.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.254.18.77]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-ID": "<EA23713506CEBA4CA287387061434899@intel.com>", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]