Cover Comment List
List cover comments
GET /api/covers/44067/comments/?format=api
[ { "id": 85151, "web_url": "http://patches.dpdk.org/comment/85151/", "msgid": "<20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com", "date": "2018-08-31T11:32:59", "subject": "Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "content": "On Fri, Aug 31, 2018 at 11:00:57AM +0200, Adrien Mazarguil wrote:\n> This is a follow up to the \"Flow API helpers enhancements\" series submitted\n> almost a year ago [1]. The new title is due to the reduced scope of this\n> version.\n> \n> rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n> temporary solution pending something better [2]. It replaces a lot of\n> duplicated code found in testpmd and removes some of the maintenance burden\n> that developers tend to forget (me included) when modifying pattern\n> items or actions (updating app/test-pmd/config.c to be clear).\n> \n> This series was unearthed in order to complete the implementation of\n> RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n> duplicate existing code once again.\n> \n> See individual patches for specific changes in this version.\n> \n> v3 changes:\n> \n> - Marked rte_flow_conv() as experimental, modified net/bonding accordingly.\n> - Fixed compilation issue on ARM.\n> - Removed deprecation notice.\n> \n> v2 changes:\n> \n> - rte_flow_copy() is kept, albeit deprecated, no API/ABI impact.\n> - Updated bonding PMD.\n> - No more automatic generation of rte_flow_conv.h.\n> \n> [1] https://mails.dpdk.org/archives/dev/2017-October/077551.html\n> [2] https://mails.dpdk.org/archives/dev/2017-July/070492.html\n> [3] Currently the command-line parser (cmdline_flow.c) is aware of these\n> actions, however config.c isn't. Flow rules with such actions cannot\n> be created and cannot be validated with PMDs that implement them.\n> \n> Adrien Mazarguil (7):\n> ethdev: add flow API object converter\n> ethdev: add flow API item/action name conversion\n> app/testpmd: rely on flow API conversion function\n> net/failsafe: switch to flow API object conversion function\n> net/bonding: switch to flow API object conversion function\n> ethdev: add missing items/actions to flow object converter\n> ethdev: deprecate rte_flow_copy function\n> \n> app/test-pmd/config.c | 407 +++------------\n> app/test-pmd/testpmd.h | 7 +-\n> doc/guides/prog_guide/rte_flow.rst | 20 +\n> doc/guides/rel_notes/deprecation.rst | 7 -\n> drivers/net/bonding/Makefile | 1 +\n> drivers/net/bonding/meson.build | 1 +\n> drivers/net/bonding/rte_eth_bond_api.c | 6 +-\n> drivers/net/bonding/rte_eth_bond_flow.c | 31 +-\n> drivers/net/bonding/rte_eth_bond_private.h | 5 +-\n> drivers/net/failsafe/failsafe_ether.c | 6 +-\n> drivers/net/failsafe/failsafe_flow.c | 31 +-\n> drivers/net/failsafe/failsafe_private.h | 5 +-\n> lib/librte_ethdev/rte_ethdev_version.map | 1 +\n> lib/librte_ethdev/rte_flow.c | 666 ++++++++++++++++++------\n> lib/librte_ethdev/rte_flow.h | 231 +++++++-\n> 15 files changed, 886 insertions(+), 539 deletions(-)\n> \n> -- \n> 2.11.0\n\nAcked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D077C4CAF;\n\tFri, 31 Aug 2018 13:33:08 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 469FF4CA5\n\tfor <dev@dpdk.org>; Fri, 31 Aug 2018 13:33:07 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id k5-v6so10897854wre.10\n\tfor <dev@dpdk.org>; Fri, 31 Aug 2018 04:33:07 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\th206-v6sm1276323wmf.25.2018.08.31.04.33.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 31 Aug 2018 04:33:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to:openpgp\n\t:user-agent; bh=HP491GnYDV6IJR1b0BSjx6yB0wQWWs0rJ+hQK2RUqR0=;\n\tb=Ii7IhN3NLloqkI5mOb9w0VV6Xl5wXH2DQftxcrcqXJIMBpiFg0wva/atshDHxIUXaA\n\t4BsUcu0OwQ9KYm9KXiOMiZvj040B+geCljzGw0XgFgSBnH+jYwtFAdf431BWwhGAEW82\n\tR0sCqGrbU7KskbDckKz9eaN7CuL9C/P1qNfb4kZHEE+duR8lqAWSHTeCmOoLyV7Nn1KW\n\tXcwcPbx+zuXzIaITTS2CodiM+J+cTajoyrDZ1wcLMleEs10tp9W2tt8ybA+i0AFVvi6w\n\t3mk7l84KTWjeNKuabz512ctJGqTOPXTtJX9EVA/GasnFa/5r4X+ojDS1At7hZK0l1glh\n\tZ+Yg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:openpgp:user-agent;\n\tbh=HP491GnYDV6IJR1b0BSjx6yB0wQWWs0rJ+hQK2RUqR0=;\n\tb=rdcinE7F5SoPir8wbp6GAPX5xRO65+nDZ6C7GAtOKLJOafNHFtyy70FA9eOGGiPivz\n\tfcwmFvujsWh1QeA2nBk83ee3nxkpzeclaLRLCt4urya2k3Yf9Wpg1FTdZwAHPNOAsA1h\n\tzY8DKbAEul5tN9VDpHX0DiGWoYwxvVYXtV9mUvF4UvqXlYcDXQGy/1ubScWO7XHvXPk2\n\tO5g7ZYRgnVKfARfC2Ww4igalId/Y5BT3dHkeZtDx7TVz8JIwTL/RmkGIn4YJpZ2S6BnL\n\tf9b07o5za9nY0Ab45lc0pZ+jaIwL+9eowkPazyk4W1L1OJQJ6Rjlq5TYVzbwwGX0/57m\n\t+vzg==", "X-Gm-Message-State": "APzg51BM05i28M74pRTgayQBhDwj5g6prgayF9yfhiLPNtjDAgOcjPGq\n\twwyXWtg7PwE2Vdz40KHTt9Dh", "X-Google-Smtp-Source": "ANB0Vdb7SnxJBP7/Wt2U+hZsaWUDd8naep9JLqFQxrA49cdRDpWQjFH0Vq4FCxstXu04VJJvkTLXzQ==", "X-Received": "by 2002:a5d:6a0e:: with SMTP id\n\tm14-v6mr10540106wru.192.1535715187072; \n\tFri, 31 Aug 2018 04:33:07 -0700 (PDT)", "Date": "Fri, 31 Aug 2018 13:32:59 +0200", "From": "=?iso-8859-1?q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org", "Message-ID": "<20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com>", "References": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>\n\t<20180831085337.21419-1-adrien.mazarguil@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=iso-8859-1", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<20180831085337.21419-1-adrien.mazarguil@6wind.com>", "OpenPGP": "id=A0075DA8F66A5949 preference=signencrypt", "User-Agent": "NeoMutt/20170113 (1.7.2)", "Subject": "Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 86717, "web_url": "http://patches.dpdk.org/comment/86717/", "msgid": "<2339995.YGgu5CYcxV@xps>", "list_archive_url": "https://inbox.dpdk.org/dev/2339995.YGgu5CYcxV@xps", "date": "2018-10-03T20:31:33", "subject": "Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "31/08/2018 13:32, Nélio Laranjeiro:\n> On Fri, Aug 31, 2018 at 11:00:57AM +0200, Adrien Mazarguil wrote:\n> > This is a follow up to the \"Flow API helpers enhancements\" series submitted\n> > almost a year ago [1]. The new title is due to the reduced scope of this\n> > version.\n> > \n> > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n> > temporary solution pending something better [2]. It replaces a lot of\n> > duplicated code found in testpmd and removes some of the maintenance burden\n> > that developers tend to forget (me included) when modifying pattern\n> > items or actions (updating app/test-pmd/config.c to be clear).\n> > \n> > This series was unearthed in order to complete the implementation of\n> > RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n> > duplicate existing code once again.\n> \n> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n\nNo more comment after one month.\nFerruh, I think it should go into next-net.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 43F9B1B187;\n\tWed, 3 Oct 2018 22:31:36 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C4EC41B137\n\tfor <dev@dpdk.org>; Wed, 3 Oct 2018 22:31:35 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 4A76A21FAC;\n\tWed, 3 Oct 2018 16:31:35 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Wed, 03 Oct 2018 16:31:35 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 11DBD102D2;\n\tWed, 3 Oct 2018 16:31:33 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=mesmtp;\n\tbh=zYRJ9UBK5qEYBf3Sfl4afa350f5WTvKaN3gattMZamM=; b=fC8Tdk9m+/+g\n\tcw4bTNKeRurUSKsVKIki5dmwfsDawcgK4VvbBMXHC9v0L+Hy+e7MSSWac4MwgZHA\n\tN7xKxkXMOuTtlnD4+URqKEd+ORGNlSc2ycdGSYeHH8NoeEIcQAbHLcM147qLYFUK\n\tQYqGWkbM8BRBZM9i4m52TfLqCT7X62A=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=fm3; bh=zYRJ9UBK5qEYBf3Sfl4afa350f5WTvKaN3gattMZa\n\tmM=; b=jHUuLm4p/yg+VlrrzJNv/V5aPSRFsPMB6yqi5XYCPks8sG3iJCEX2MGQ4\n\t+GT7aAd36xgLOwHz/CtLxrrlPoYpql1eh1ee1A1l4lLzk4RvBIeiNqW2Eqz7dBrm\n\tXIQdADkIj7yXNj5Kk+yauZViRPl2dRWRKtxYWX7ToM22TlEBXqSzbhEJNDMN8E8s\n\tEK5M6T0rLoYaR9jligS82kPTFqulKfL7zZOB9LrJNxTis3c2YeYKlvk0DARgWFPB\n\tGkE7KBuIBjqJxVIi1+zpCHczbjNtOAqenF2qLIFb/rHrFCXWhNmYCl8XxmPSxnkH\n\t5+F5QNGAJXPisPR0ndxGVEXv1zoyQ==" ], "X-ME-Sender": "<xms:Jie1W7sef-4pPSykwi1TB1MP59K7NDkiDyw16TLuxEFhD6eH0kPhTA>", "X-ME-Proxy": "<xmx:Jie1W2q92Q3QbIP-ByM12E1tlb5Wz5AgJX_yTz-laRMxVkPaQlKHFg>\n\t<xmx:Jie1W6F3M-DxKu36stu_Zt__lf-lXEHM-CxoTNZWvHGgexTtuyEJ8w>\n\t<xmx:Jie1W_-012wTk83yiz8ucYR7xqH-apAdtDKxbTP1Ti4YKVw1u5zCuw>\n\t<xmx:Jie1W22T_GV2lRbjY9e_a4KlvGK0OkVNqJ02QPpjGWh3KCWdi5okXg>\n\t<xmx:Jie1WzZaKFp-g1ZK9Q57iZtfkOT8qXXC4icBHJSeC9T5dOh7hWb2tA>\n\t<xmx:Jye1W5soA8bmjDY0XGsU5mQL6URHlzVXB1thPCMPnlnXPshk6bIQPg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, =?iso-8859-1?q?N=E9lio?=\n\tLaranjeiro <nelio.laranjeiro@6wind.com>, Adrien Mazarguil\n\t<adrien.mazarguil@6wind.com>", "Date": "Wed, 03 Oct 2018 22:31:33 +0200", "Message-ID": "<2339995.YGgu5CYcxV@xps>", "In-Reply-To": "<20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com>", "References": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>\n\t<20180831085337.21419-1-adrien.mazarguil@6wind.com>\n\t<20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Subject": "Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 86787, "web_url": "http://patches.dpdk.org/comment/86787/", "msgid": "<cc7a58af-9b9f-9953-ba9b-116ebe2f8a50@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cc7a58af-9b9f-9953-ba9b-116ebe2f8a50@intel.com", "date": "2018-10-04T14:25:58", "subject": "Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 10/3/2018 9:31 PM, Thomas Monjalon wrote:\n> 31/08/2018 13:32, Nélio Laranjeiro:\n>> On Fri, Aug 31, 2018 at 11:00:57AM +0200, Adrien Mazarguil wrote:\n>>> This is a follow up to the \"Flow API helpers enhancements\" series submitted\n>>> almost a year ago [1]. The new title is due to the reduced scope of this\n>>> version.\n>>>\n>>> rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a\n>>> temporary solution pending something better [2]. It replaces a lot of\n>>> duplicated code found in testpmd and removes some of the maintenance burden\n>>> that developers tend to forget (me included) when modifying pattern\n>>> items or actions (updating app/test-pmd/config.c to be clear).\n>>>\n>>> This series was unearthed in order to complete the implementation of\n>>> RTE_FLOW_ACTION_TYPE_ENCAP_(VXLAN|NVGRE) in testpmd [3] without having to\n>>> duplicate existing code once again.\n>>\n>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n> \n> No more comment after one month.\n> Ferruh, I think it should go into next-net.\n\nSeries applied to dpdk-next-net/master, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 513E81B497;\n\tThu, 4 Oct 2018 16:26:02 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 16E551B496\n\tfor <dev@dpdk.org>; Thu, 4 Oct 2018 16:26:00 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Oct 2018 07:26:00 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49])\n\t([10.237.221.49])\n\tby orsmga005.jf.intel.com with ESMTP; 04 Oct 2018 07:25:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,340,1534834800\"; d=\"scan'208\";a=\"262841095\"", "To": "Thomas Monjalon <thomas@monjalon.net>", "Cc": "dev@dpdk.org, =?utf-8?q?N=C3=A9lio_Laranjeiro?=\n\t<nelio.laranjeiro@6wind.com>, Adrien Mazarguil\n\t<adrien.mazarguil@6wind.com>", "References": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>\n\t<20180831085337.21419-1-adrien.mazarguil@6wind.com>\n\t<20180831113259.u5rceja7zpx5i27w@laranjeiro-vm.dev.6wind.com>\n\t<2339995.YGgu5CYcxV@xps>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Message-ID": "<cc7a58af-9b9f-9953-ba9b-116ebe2f8a50@intel.com>", "Date": "Thu, 4 Oct 2018 15:25:58 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<2339995.YGgu5CYcxV@xps>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]