Cover Comment List
List cover comments
GET /api/covers/42891/comments/?format=api
[ { "id": 83725, "web_url": "http://patches.dpdk.org/comment/83725/", "msgid": "<9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com", "date": "2018-07-12T20:39:16", "subject": "Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device", "submitter": { "id": 166, "url": "http://patches.dpdk.org/api/people/166/?format=api", "name": "Wiles, Keith", "email": "keith.wiles@intel.com" }, "content": "> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:\n> \n> This is the Distributed Software (DSW) event device, which distributes\n> the task of scheduling events among all the eventdev ports and their\n> lcore threads.\n> \n> DSW is primarily designed for atomic-only queues, but also supports\n> single-link and parallel queues.\n> \n> (DSW would be more accurately described as 'parallel', but since that\n> term is used to describe an eventdev queue type, it's referred to as\n> 'distributed', to avoid suggesting it's somehow biased toward parallel\n> queues.)\n> \n> \n\nJust a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.\n\nAs for the RFC I like the idea of this RFC, but need to dig into the code.\n\nThanks\n\n> Short-term TODO\n> ===============\n> \n> o Figure out which DSW parameters needs to be runtime configurable.\n> o Consider adding support for event priority.\n> o Add relevant test cases to eventdev unit tests.\n> o Convert this massive cover letter into proper DPDK documentation.\n> \n> [1] http://www.lysator.liu.se/~hofors/dsw/migration-sequence.svg\n> \n> Mattias Rönnblom (1):\n> eventdev: add distributed software (DSW) event device\n> \n> config/common_base | 5 +\n> drivers/event/Makefile | 1 +\n> drivers/event/dsw/Makefile | 28 +\n> drivers/event/dsw/dsw_evdev.c | 361 +++++\n> drivers/event/dsw/dsw_evdev.h | 296 ++++\n> drivers/event/dsw/dsw_event.c | 1285 +++++++++++++++++\n> drivers/event/dsw/dsw_sort.h | 47 +\n> drivers/event/dsw/dsw_xstats.c | 284 ++++\n> .../event/dsw/rte_pmd_evdev_dsw_version.map | 3 +\n> mk/rte.app.mk | 1 +\n> 10 files changed, 2311 insertions(+)\n> create mode 100644 drivers/event/dsw/Makefile\n> create mode 100644 drivers/event/dsw/dsw_evdev.c\n> create mode 100644 drivers/event/dsw/dsw_evdev.h\n> create mode 100644 drivers/event/dsw/dsw_event.c\n> create mode 100644 drivers/event/dsw/dsw_sort.h\n> create mode 100644 drivers/event/dsw/dsw_xstats.c\n> create mode 100644 drivers/event/dsw/rte_pmd_evdev_dsw_version.map\n> \n> -- \n> 2.17.1\n> \n\nRegards,\nKeith", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9906D1B3A3;\n\tThu, 12 Jul 2018 22:39:22 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 501D91B3A1\n\tfor <dev@dpdk.org>; Thu, 12 Jul 2018 22:39:20 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2018 13:39:19 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n\tby orsmga007.jf.intel.com with ESMTP; 12 Jul 2018 13:39:17 -0700", "from fmsmsx115.amr.corp.intel.com (10.18.116.19) by\n\tFMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 12 Jul 2018 13:39:17 -0700", "from fmsmsx117.amr.corp.intel.com ([169.254.3.3]) by\n\tfmsmsx115.amr.corp.intel.com ([169.254.4.136]) with mapi id\n\t14.03.0319.002; Thu, 12 Jul 2018 13:39:17 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,344,1526367600\"; d=\"scan'208\";a=\"56095797\"", "From": "\"Wiles, Keith\" <keith.wiles@intel.com>", "To": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"jerin.jacob@caviumnetworks.com\"\n\t<jerin.jacob@caviumnetworks.com>, \"Richardson, Bruce\"\n\t<bruce.richardson@intel.com>", "Thread-Topic": "[dpdk-dev] [RFC 0/1] A Distributed Software Event Device", "Thread-Index": "AQHUGV1JGM07VvjH7UG2xefgLi865KSMg2gA", "Date": "Thu, 12 Jul 2018 20:39:16 +0000", "Message-ID": "<9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>", "References": "<20180711212154.5807-1-mattias.ronnblom@ericsson.com>", "In-Reply-To": "<20180711212154.5807-1-mattias.ronnblom@ericsson.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.252.133.123]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-ID": "<3342A350296D7845ACEBC4576AB77624@intel.com>", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 83805, "web_url": "http://patches.dpdk.org/comment/83805/", "msgid": "<17ce95f7-ac9b-3bd3-fb5a-4e1abbd18bc9@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/17ce95f7-ac9b-3bd3-fb5a-4e1abbd18bc9@ericsson.com", "date": "2018-07-13T17:21:56", "subject": "Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "content": "On 2018-07-12 22:39, Wiles, Keith wrote:\n> \n> \n>> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:\n>>\n>> This is the Distributed Software (DSW) event device, which distributes\n>> the task of scheduling events among all the eventdev ports and their\n>> lcore threads.\n>>\n>> DSW is primarily designed for atomic-only queues, but also supports\n>> single-link and parallel queues.\n>>\n>> (DSW would be more accurately described as 'parallel', but since that\n>> term is used to describe an eventdev queue type, it's referred to as\n>> 'distributed', to avoid suggesting it's somehow biased toward parallel\n>> queues.)\n>>\n>>\n> \n> Just a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.\n> \n> As for the RFC I like the idea of this RFC, but need to dig into the code.\n> \n\nI did run checkpatch (w/ a checkpatch.pl from a newly cloned Linux \nkernel tree), but it didn't catch this.\n\nI'll fix it. Thanks.\n\nRegards,\n\tMattias", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 987BD1C0B;\n\tFri, 13 Jul 2018 19:22:02 +0200 (CEST)", "from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])\n\tby dpdk.org (Postfix) with ESMTP id DB0E41AFF\n\tfor <dev@dpdk.org>; Fri, 13 Jul 2018 19:22:01 +0200 (CEST)", "from mail.lysator.liu.se (localhost [127.0.0.1])\n\tby mail.lysator.liu.se (Postfix) with ESMTP id 4DD9B40004\n\tfor <dev@dpdk.org>; Fri, 13 Jul 2018 19:22:01 +0200 (CEST)", "by mail.lysator.liu.se (Postfix, from userid 1004)\n\tid 3845D4002B; Fri, 13 Jul 2018 19:22:01 +0200 (CEST)", "from [192.168.1.59] (host-90-232-4-114.mobileonline.telia.com\n\t[90.232.4.114])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.lysator.liu.se (Postfix) with ESMTPSA id 8DC2240004;\n\tFri, 13 Jul 2018 19:21:57 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on\n\tbernadotte.lysator.liu.se", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.2 required=5.0 tests=ALL_TRUSTED,AWL\n\tautolearn=disabled version=3.4.1", "X-Spam-Score": "-0.2", "To": "\"Wiles, Keith\" <keith.wiles@intel.com>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>,\n\t\"jerin.jacob@caviumnetworks.com\" <jerin.jacob@caviumnetworks.com>,\n\t\"Richardson, Bruce\" <bruce.richardson@intel.com>", "References": "<20180711212154.5807-1-mattias.ronnblom@ericsson.com>\n\t<9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Message-ID": "<17ce95f7-ac9b-3bd3-fb5a-4e1abbd18bc9@ericsson.com>", "Date": "Fri, 13 Jul 2018 19:21:56 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]
