Cover Comment List
List cover comments
GET /api/covers/42456/comments/?format=api
[ { "id": 83366, "web_url": "http://patches.dpdk.org/comment/83366/", "msgid": "<20180709013928.GA7795@debian>", "list_archive_url": "https://inbox.dpdk.org/dev/20180709013928.GA7795@debian", "date": "2018-07-09T01:39:29", "subject": "Re: [dpdk-dev] [PATCH v4 0/5] vhost: generalize buffer vectors", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "content": "On Fri, Jul 06, 2018 at 09:04:44AM +0200, Maxime Coquelin wrote:\n> This series is again preliminray work to ease packed ring\n> layout integration.\n> \n> Main changes are using vector buffres also in the dequeue\n> path, and perform IOVA to HVA translation at vectors fill\n> time.\n> \n> I still have to run more benchmarks, but PVP benchmarks does\n> not show performance changes.\n> \n> Good thing is that it saves ~140 further lines.\n> \n> Changes since v3:\n> =================\n> - Fix dequeue_zero_copy last_used_idx update (Tiwei)\n> - Remove \"vhost: make gpa to hpa failure an error\" patch (Tiwei)\n> \n> Changes since v2:\n> =================\n> - check vec_id doesn't overflow (Tiwei)\n> - Fix perm parameters passed to fill_vec_buf (Tiwei)\n> - Remove extra space in variable assignation (Tiwei)\n> \n> \n> Maxime Coquelin (5):\n> vhost: use shadow used ring in dequeue path\n> vhost: use buffer vectors in dequeue path\n> vhost: improve prefetching in dequeue path\n> vhost: prefetch first descriptor in dequeue path\n> vhost: improve prefetching in enqueue path\n> \n> lib/librte_vhost/vhost.h | 1 +\n> lib/librte_vhost/virtio_net.c | 517 ++++++++++++++++--------------------------\n> 2 files changed, 193 insertions(+), 325 deletions(-)\n> \n> -- \n> 2.14.4\n> \n\nFor the series:\nAcked-by: Tiwei Bie <tiwei.bie@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 351F35B14;\n\tMon, 9 Jul 2018 03:39:51 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 8AD2D58FE\n\tfor <dev@dpdk.org>; Mon, 9 Jul 2018 03:39:48 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jul 2018 18:39:46 -0700", "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby fmsmga005.fm.intel.com with ESMTP; 08 Jul 2018 18:39:41 -0700" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,327,1526367600\"; d=\"scan'208\";a=\"243613829\"", "Date": "Mon, 9 Jul 2018 09:39:29 +0800", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "zhihong.wang@intel.com, dev@dpdk.org", "Message-ID": "<20180709013928.GA7795@debian>", "References": "<20180706070449.1946-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "In-Reply-To": "<20180706070449.1946-1-maxime.coquelin@redhat.com>", "User-Agent": "Mutt/1.10.0 (2018-05-17)", "Subject": "Re: [dpdk-dev] [PATCH v4 0/5] vhost: generalize buffer vectors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 83377, "web_url": "http://patches.dpdk.org/comment/83377/", "msgid": "<20180709070133.GA5852@debian>", "list_archive_url": "https://inbox.dpdk.org/dev/20180709070133.GA5852@debian", "date": "2018-07-09T07:01:34", "subject": "Re: [dpdk-dev] [PATCH v4 0/5] vhost: generalize buffer vectors", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "content": "On Fri, Jul 06, 2018 at 09:04:44AM +0200, Maxime Coquelin wrote:\n> This series is again preliminray work to ease packed ring\n> layout integration.\n> \n> Main changes are using vector buffres also in the dequeue\n> path, and perform IOVA to HVA translation at vectors fill\n> time.\n> \n> I still have to run more benchmarks, but PVP benchmarks does\n> not show performance changes.\n> \n> Good thing is that it saves ~140 further lines.\n> \n> Changes since v3:\n> =================\n> - Fix dequeue_zero_copy last_used_idx update (Tiwei)\n> - Remove \"vhost: make gpa to hpa failure an error\" patch (Tiwei)\n> \n> Changes since v2:\n> =================\n> - check vec_id doesn't overflow (Tiwei)\n> - Fix perm parameters passed to fill_vec_buf (Tiwei)\n> - Remove extra space in variable assignation (Tiwei)\n> \n> \n> Maxime Coquelin (5):\n> vhost: use shadow used ring in dequeue path\n> vhost: use buffer vectors in dequeue path\n> vhost: improve prefetching in dequeue path\n> vhost: prefetch first descriptor in dequeue path\n> vhost: improve prefetching in enqueue path\n> \n> lib/librte_vhost/vhost.h | 1 +\n> lib/librte_vhost/virtio_net.c | 517 ++++++++++++++++--------------------------\n> 2 files changed, 193 insertions(+), 325 deletions(-)\n> \n> -- \n> 2.14.4\n> \n\nApplied to dpdk-next-virtio/master, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 949347EC7;\n\tMon, 9 Jul 2018 09:01:50 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id F13902BF5\n\tfor <dev@dpdk.org>; Mon, 9 Jul 2018 09:01:48 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jul 2018 00:01:47 -0700", "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby orsmga007.jf.intel.com with ESMTP; 09 Jul 2018 00:01:47 -0700" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,329,1526367600\"; d=\"scan'208\";a=\"55016217\"", "Date": "Mon, 9 Jul 2018 15:01:34 +0800", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "zhihong.wang@intel.com, dev@dpdk.org", "Message-ID": "<20180709070133.GA5852@debian>", "References": "<20180706070449.1946-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "In-Reply-To": "<20180706070449.1946-1-maxime.coquelin@redhat.com>", "User-Agent": "Mutt/1.10.0 (2018-05-17)", "Subject": "Re: [dpdk-dev] [PATCH v4 0/5] vhost: generalize buffer vectors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]