Cover Comment List
List cover comments
GET /api/covers/42099/comments/?format=api
[ { "id": 83047, "web_url": "http://patches.dpdk.org/comment/83047/", "msgid": "<20180703024902.GA26043@debian>", "list_archive_url": "https://inbox.dpdk.org/dev/20180703024902.GA26043@debian", "date": "2018-07-03T02:49:03", "subject": "Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal\n\tand offload improvements", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "content": "On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote:\n> In this v3, the main change is the removal of the Tx simple path.\n> Indeed, this path is not compliant with the Virtio specification,\n> so could cause problems with some host implementations.\n> \n> Since Marvin has introduced the in-order path, we have a good\n> replacement for simple Tx and so we think it is better to\n> remove it than disabling it by defaul\n> \n> Maxime Coquelin (4):\n> net/virtio: remove simple Tx path\n> net/virtio: improve Tx offload features negotiation\n> net/virtio: don't use simple Rx if TCP LRO or VLAN strip\n> net/virtio: improve offload check performance\n> \n> drivers/net/virtio/virtio_ethdev.c | 49 ++++++++++++++++------\n> drivers/net/virtio/virtio_ethdev.h | 3 --\n> drivers/net/virtio/virtio_pci.h | 4 +-\n> drivers/net/virtio/virtio_rxtx.c | 74 ++++++---------------------------\n> drivers/net/virtio/virtio_rxtx_simple.c | 67 -----------------------------\n> drivers/net/virtio/virtio_rxtx_simple.h | 49 ----------------------\n> drivers/net/virtio/virtio_user_ethdev.c | 1 -\n> 7 files changed, 51 insertions(+), 196 deletions(-)\n> \n> -- \n> 2.14.4\n> \n\nFor the series:\nReviewed-by: Tiwei Bie <tiwei.bie@intel.com>\n\nThanks!", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 74B951BE6B;\n\tTue, 3 Jul 2018 04:49:06 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 27A4C1BE6A\n\tfor <dev@dpdk.org>; Tue, 3 Jul 2018 04:49:04 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2018 19:49:02 -0700", "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby orsmga007.jf.intel.com with ESMTP; 02 Jul 2018 19:49:01 -0700" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,301,1526367600\"; d=\"scan'208\";a=\"53629860\"", "Date": "Tue, 3 Jul 2018 10:49:03 +0800", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "zhihong.wang@intel.com, dev@dpdk.org, yong.liu@intel.com", "Message-ID": "<20180703024902.GA26043@debian>", "References": "<20180702152547.31423-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "In-Reply-To": "<20180702152547.31423-1-maxime.coquelin@redhat.com>", "User-Agent": "Mutt/1.9.5 (2018-04-13)", "Subject": "Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal\n\tand offload improvements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 83131, "web_url": "http://patches.dpdk.org/comment/83131/", "msgid": "<20180704051754.GA27518@debian>", "list_archive_url": "https://inbox.dpdk.org/dev/20180704051754.GA27518@debian", "date": "2018-07-04T05:17:54", "subject": "Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal\n\tand offload improvements", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "content": "On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote:\n> In this v3, the main change is the removal of the Tx simple path.\n> Indeed, this path is not compliant with the Virtio specification,\n> so could cause problems with some host implementations.\n> \n> Since Marvin has introduced the in-order path, we have a good\n> replacement for simple Tx and so we think it is better to\n> remove it than disabling it by defaul\n> \n> Maxime Coquelin (4):\n> net/virtio: remove simple Tx path\n> net/virtio: improve Tx offload features negotiation\n> net/virtio: don't use simple Rx if TCP LRO or VLAN strip\n> net/virtio: improve offload check performance\n> \n> drivers/net/virtio/virtio_ethdev.c | 49 ++++++++++++++++------\n> drivers/net/virtio/virtio_ethdev.h | 3 --\n> drivers/net/virtio/virtio_pci.h | 4 +-\n> drivers/net/virtio/virtio_rxtx.c | 74 ++++++---------------------------\n> drivers/net/virtio/virtio_rxtx_simple.c | 67 -----------------------------\n> drivers/net/virtio/virtio_rxtx_simple.h | 49 ----------------------\n> drivers/net/virtio/virtio_user_ethdev.c | 1 -\n> 7 files changed, 51 insertions(+), 196 deletions(-)\n> \n\nApplied to dpdk-next-virtio/master, thanks.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EC2661BE3C;\n\tWed, 4 Jul 2018 07:17:57 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 8C3A31BE20\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 07:17:56 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jul 2018 22:17:54 -0700", "from debian.sh.intel.com (HELO debian) ([10.67.104.228])\n\tby orsmga004.jf.intel.com with ESMTP; 03 Jul 2018 22:17:53 -0700" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,306,1526367600\"; d=\"scan'208\";a=\"213268017\"", "Date": "Wed, 4 Jul 2018 13:17:54 +0800", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "zhihong.wang@intel.com, dev@dpdk.org, yong.liu@intel.com", "Message-ID": "<20180704051754.GA27518@debian>", "References": "<20180702152547.31423-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "In-Reply-To": "<20180702152547.31423-1-maxime.coquelin@redhat.com>", "User-Agent": "Mutt/1.9.5 (2018-04-13)", "Subject": "Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal\n\tand offload improvements", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]