Cover Detail
Show a cover letter.
GET /api/covers/123520/?format=api
{ "id": 123520, "url": "http://patches.dpdk.org/api/covers/123520/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20230209091710.485512-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230209091710.485512-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230209091710.485512-1-maxime.coquelin@redhat.com", "date": "2023-02-09T09:16:49", "name": "[00/21] Add control queue & MQ support to Virtio-user vDPA", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20230209091710.485512-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 26913, "url": "http://patches.dpdk.org/api/series/26913/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26913", "date": "2023-02-09T09:16:49", "name": "Add control queue & MQ support to Virtio-user vDPA", "version": 1, "mbox": "http://patches.dpdk.org/series/26913/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/123520/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 485CC41C4D;\n\tThu, 9 Feb 2023 10:17:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 31AA040DF8;\n\tThu, 9 Feb 2023 10:17:19 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 1A5FC4067B\n for <dev@dpdk.org>; Thu, 9 Feb 2023 10:17:18 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-651-XlwoXiQcOOyriEFQk-gQnQ-1; Thu, 09 Feb 2023 04:17:14 -0500", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 328CD8028B0;\n Thu, 9 Feb 2023 09:17:14 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.26])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CBA72492C3F;\n Thu, 9 Feb 2023 09:17:12 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1675934237;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=UgxUrzaLCUr9tQA0/encekZmUuZ5dKkWYsnz5hXn5RA=;\n b=BpahCC5AoLSPxP+jX07nUFW4PZ4P4Uya9wCc2HQHR0k0+diY1MOSxLoIe8db6w165lE9vq\n p1Vm5oRn/TOGlpYEZoWOJRmE4zzrehcwuynu+iOf6ZviOF2gV+w0cTxHAXDqtEgqEtWyIC\n kFQ/BMXfhpnrMwWIUYAqUTE6Qr2OPlY=", "X-MC-Unique": "XlwoXiQcOOyriEFQk-gQnQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n eperezma@redhat.com, stephen@networkplumber.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH 00/21] Add control queue & MQ support to Virtio-user vDPA", "Date": "Thu, 9 Feb 2023 10:16:49 +0100", "Message-Id": "<20230209091710.485512-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This series introduces control queue support for Vhost-vDPA\nbackend. This is a requirement to support multiqueue, but\nbe usefull for other features like RSS for example.\n\nSince the Virtio-user layer of the Virtio PMD must handle\nsome control messages, like the number of queue pairs to\nbe used by the device, a shadow control queue is created\nat Virtio-user layer.\n\nControl messages from the regular Virtio control queue\nare still dequeues and handled if needed by the Virtio-user\nlayer, and are then forwarded to the shadow control queue\nso that the physical vDPA device can handle them.\n\nThis model is similar to the one adopted by the QEMU\nproject.\n\nIn order to avoid code duplication, virtqueue allocation\nand control queue message sending has been factored out\nof the Virtio layer to be reusable by the Virtio-user\nlayer.\n\nFinally, in order to support vDPA hardware which may\nsupport large number of queues, last patch removes the\n8 queue pairs limitation by dynamically allocating\nvring metadata.\n\nThe series has been tested with Nvidia Cx-6 DX NIC\nwith up to 16 queue pairs:\n\n# echo 0 > /sys/bus/pci/devices/0000\\:3b\\:00.0/sriov_numvfs\n# echo 0 > /sys/bus/pci/devices/0000\\:3b\\:00.1/sriov_numvfs\n# modprobe vhost_vdpa\n# modprobe mlx5_vdpa\n# echo 1 > /sys/bus/pci/devices/0000\\:3b\\:00.0/sriov_numvfs\n# echo 0000:3b:00.2 >/sys/bus/pci/drivers/mlx5_core/unbind\n# devlink dev eswitch set pci/0000:3b:00.0 mode switchdev\n# echo 0000:3b:00.2 >/sys/bus/pci/drivers/mlx5_core/bind\n# vdpa dev add name vdpa0 mgmtdev pci/0000:3b:00.2 mac 00:11:22:33:44:03 max_vqp 16\n# ulimit -l unlimited\n# dpdk-testpmd -l 0,2,4,6 --socket-mem 1024,0 --vdev 'virtio_user0,path=/dev/vhost-vdpa-0' --no-pci -n 3 -- --nb-cores=3 -i --rxq=16 --txq=16\n\nChanges in v3:\n==============\n- Trivial code simplifications (Eugenio)\n\nChanges in v2:\n==============\n- Fix double spaces (Chenbo)\n- Get rid of uneeded gotos (Stephen)\n- Only allocate packed ring metadata if supported (Chenbo)\n- Rebased on top of main\n\nMaxime Coquelin (21):\n net/virtio: move CVQ code into a dedicated file\n net/virtio: introduce notify callback for control queue\n net/virtio: virtqueue headers alloc refactoring\n net/virtio: remove port ID info from Rx queue\n net/virtio: remove unused fields in Tx queue struct\n net/virtio: remove unused queue ID field in Rx queue\n net/virtio: remove unused Port ID in control queue\n net/virtio: move vring memzone to virtqueue struct\n net/virtio: refactor indirect desc headers init\n net/virtio: alloc Rx SW ring only if vectorized path\n net/virtio: extract virtqueue init from virtio queue init\n net/virtio-user: fix device starting failure handling\n net/virtio-user: simplify queues setup\n net/virtio-user: use proper type for number of queue pairs\n net/virtio-user: get max number of queue pairs from device\n net/virtio-user: allocate shadow control queue\n net/virtio-user: send shadow virtqueue info to the backend\n net/virtio-user: add new callback to enable control queue\n net/virtio-user: forward control messages to shadow queue\n net/virtio-user: advertize control VQ support with vDPA\n net/virtio-user: remove max queues limitation\n\n drivers/net/virtio/meson.build | 1 +\n drivers/net/virtio/virtio.h | 6 -\n drivers/net/virtio/virtio_cvq.c | 229 +++++++++\n drivers/net/virtio/virtio_cvq.h | 127 +++++\n drivers/net/virtio/virtio_ethdev.c | 472 +-----------------\n drivers/net/virtio/virtio_rxtx.c | 47 +-\n drivers/net/virtio/virtio_rxtx.h | 31 +-\n drivers/net/virtio/virtio_rxtx_packed.c | 3 +-\n drivers/net/virtio/virtio_rxtx_simple.c | 3 +-\n drivers/net/virtio/virtio_rxtx_simple.h | 7 +-\n .../net/virtio/virtio_rxtx_simple_altivec.c | 4 +-\n drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 +-\n drivers/net/virtio/virtio_rxtx_simple_sse.c | 4 +-\n drivers/net/virtio/virtio_user/vhost.h | 1 +\n drivers/net/virtio/virtio_user/vhost_vdpa.c | 16 +-\n .../net/virtio/virtio_user/virtio_user_dev.c | 305 +++++++++--\n .../net/virtio/virtio_user/virtio_user_dev.h | 30 +-\n drivers/net/virtio/virtio_user_ethdev.c | 49 +-\n drivers/net/virtio/virtqueue.c | 346 ++++++++++++-\n drivers/net/virtio/virtqueue.h | 127 +----\n 20 files changed, 1066 insertions(+), 746 deletions(-)\n create mode 100644 drivers/net/virtio/virtio_cvq.c\n create mode 100644 drivers/net/virtio/virtio_cvq.h" }