Cover Detail
Show a cover letter.
GET /api/covers/103054/?format=api
{ "id": 103054, "url": "http://patches.dpdk.org/api/covers/103054/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20211027142213.556166-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211027142213.556166-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211027142213.556166-1-maxime.coquelin@redhat.com", "date": "2021-10-27T14:22:08", "name": "[v6,0/5] Virtio PMD RSS support & RSS fixes", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20211027142213.556166-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 20057, "url": "http://patches.dpdk.org/api/series/20057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20057", "date": "2021-10-27T14:22:08", "name": "Virtio PMD RSS support & RSS fixes", "version": 6, "mbox": "http://patches.dpdk.org/series/20057/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/103054/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 65515A0C47;\n\tWed, 27 Oct 2021 16:23:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4F8AA40E0F;\n\tWed, 27 Oct 2021 16:23:07 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 8C45E40DDA\n for <dev@dpdk.org>; Wed, 27 Oct 2021 16:23:05 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-515-ar1SfsfwMcyo0Ijfuteipg-1; Wed, 27 Oct 2021 10:23:04 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85E0F10247A6;\n Wed, 27 Oct 2021 14:23:02 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.21])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3BDD21002D6A;\n Wed, 27 Oct 2021 14:22:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1635344585;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=HQGbfr9aIdvr99uw3wrrONrHO1bfLPuOdEyqHfmF5p4=;\n b=i44nQ3S/qG3zwKMnQFXWUIXsIsdhGRg7LUA3ESLLzSuNat7yHIUYSDU2dXAQepwYak6r/j\n VjE42h9wZOXKCyyC0NwBu5PdDpycuyrTYhNPZCINsxPrmCr2bOpORM5K2DeDF6C5RndCbo\n Ad9lU9ENYvIx2P7HoBq5vJ1fuz8iUH0=", "X-MC-Unique": "ar1SfsfwMcyo0Ijfuteipg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,\n david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru,\n ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com,\n xiaoyun.li@intel.com", "Cc": "nelio.laranjeiro@6wind.com, yvugenfi@redhat.com, ybendito@redhat.com,\n Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 27 Oct 2021 16:22:08 +0200", "Message-Id": "<20211027142213.556166-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v6 0/5] Virtio PMD RSS support & RSS fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This series is mainly adding support for RSS to Virtio PMD\ndriver. The two last patches are fixing an issue in testpmd\nthat could cause out of bounds access, and fix\nan issue spotted in the mlx5 driver while looking for\ninspiration.\n\nThe first motivation for this series is to eventually\nsupport RSS down to the Vhost-user library, so that OVS can\nbenefit from it. But it will be also useful with vDPA\ndevices in the future.\n\nRegarding the testing, I have tested it with qemu v5.2 from\nFedora 34. Since libvirt does not support yet enabling RSS\nfeature in the Qemu virtio-net device, and this feature is\ndisabled by default, the tester can either rebuild the qemu\npackage to enable it by default or use the qemu cmdline to\ndo the same.\n\nThe tester can use testpmd in icmpecho mode in the guest\nand scapy on the host to inject random traffic on the tap\ninterface, e.g.:\nsendp(Ether(src=RandMAC()) / IP(src=RandIP(), dst='192.168.123.9') / UDP(sport=RandShort(), dport=RandShort()), loop=True, iface='vnet7')\n\nThen it can play with RSS config in testpmd to change the\nRETA, or hash type and see traffic being steered\naccordingly by checking the Rx xstats.\n\nChanges in v6:\n==============\n- Rebased on top of main, including convertion to new naming of some defines\n- Convert hash types definition to RTE_BIT32() (Andrew)\n- Add build check for RETA size being a pow2 (Andrew)\n- Restore RSS config if device update fails (Andrew)\n- Prevent RSS config if RXq number == 0 (Andrew)\n- Reconfigure the RETA if the number of RXq changed (Andrew)\n- Apply rss_conf even if the RSS key had previously been configured (Andrew)\n\nChanges in v5:\n==============\n- Remove unneeded index init (Chenbo)\n- Improve error print (Chenbo)\n- Add missed comment on RSS ctrl message\n\nChanges in v4:\n==============\n- s/GPTU/GTPU/ (Xiaoyun)\n\nChanges in v3:\n==============\n- Add applying user-specified RSS conf a device config time (Andrew)\n- Remove useless checks (Chenbo)\n- Clean control message payload dlen variable (Chenbo)\n- Add GTPU offload type (Xiaoyun)\n- Add missing types to str2flowtype() (Xiaoyun)\n\nChanges in v2:\n==============\n- Rework patch 2 to keep old behaviour, but fix possible out of bounds due to key length (Andrew/Nelio/Xiaoyun)\n- s/reta/RETA/ (Andrew)\n- Applied A-by on patch 3 (Slava)\n- Fix display of configured hash types\n- Add missing flow types definition to testpmd's port info command\n\nMaxime Coquelin (5):\n net/virtio: add initial RSS support\n app/testpmd: fix RSS key length\n app/testpmd: fix RSS type display\n net/mlx5: fix RSS RETA update\n app/testpmd: add missing flow types in port info\n\n app/test-pmd/cmdline.c | 4 +\n app/test-pmd/config.c | 11 +-\n doc/guides/nics/features/virtio.ini | 3 +\n doc/guides/nics/virtio.rst | 3 +\n doc/guides/rel_notes/release_21_11.rst | 6 +\n drivers/net/mlx5/mlx5_rss.c | 2 +-\n drivers/net/virtio/virtio.h | 32 +-\n drivers/net/virtio/virtio_ethdev.c | 436 ++++++++++++++++++++++++-\n drivers/net/virtio/virtio_ethdev.h | 3 +-\n drivers/net/virtio/virtqueue.h | 25 ++\n 10 files changed, 513 insertions(+), 12 deletions(-)" }