Cover Detail
Show a cover letter.
GET /api/covers/100823/?format=api
{ "id": 100823, "url": "http://patches.dpdk.org/api/covers/100823/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20211008171852.736387-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211008171852.736387-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211008171852.736387-1-bruce.richardson@intel.com", "date": "2021-10-08T17:18:47", "name": "[v7,0/5] improve telemetry support with in-memory mode", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20211008171852.736387-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 19464, "url": "http://patches.dpdk.org/api/series/19464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19464", "date": "2021-10-08T17:18:47", "name": "improve telemetry support with in-memory mode", "version": 7, "mbox": "http://patches.dpdk.org/series/19464/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/100823/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4759A0C43;\n\tFri, 8 Oct 2021 19:19:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7296D40685;\n\tFri, 8 Oct 2021 19:19:13 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id EF64F40140\n for <dev@dpdk.org>; Fri, 8 Oct 2021 19:19:11 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Oct 2021 10:19:03 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.151])\n by orsmga001.jf.intel.com with ESMTP; 08 Oct 2021 10:18:59 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10131\"; a=\"207362108\"", "E=Sophos;i=\"5.85,358,1624345200\"; d=\"scan'208\";a=\"207362108\"", "E=Sophos;i=\"5.85,358,1624345200\"; d=\"scan'208\";a=\"523050381\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Ciara Power <ciara.power@intel.com>,\n David Marchand <david.marchand@redhat.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Kevin Traynor <ktraynor@redhat.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 8 Oct 2021 18:18:47 +0100", "Message-Id": "<20211008171852.736387-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210915141030.23514-1-bruce.richardson@intel.com>", "References": "<20210915141030.23514-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 0/5] improve telemetry support with in-memory\n mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patchset cleans up telemetry support for \"in-memory\" mode, so that\nmultiple independent processes can be run using that mode and still have\ntelemetry support. It also removes problems of one process removing the\nsocket of another - which was the original issue reported. The main changes\nin this set are to:\n\n* disable telemetry for secondary processes, which prevents any socket\n conflicts in multi-process cases.\n* when multiple processes are run using the same runtime directory (i.e.\n \"in-memory\" mode or similar), add a counter suffix to the socket names to\n avoid conflicts over the socket. Each process will use the lowest available\n suffix, with the first process using the directory, not adding any suffix.\n* update the telemetry script and documentation to allow it to connect to\n in-memory DPDK processes.\n\n---\nV7: Change from adding a pid suffix generally in \"in-memory\" mode, to adding an\nincreasing counter as a suffix in case of name conflicts generally. This\nachieves the same result in terms of connectivity, but keeps compatibility of\nbehaviour for the case of a single in-memory process, while also providing\npredictable more socket names for each process i.e. 4 running in-memory\ninstances they will always use suffixes 1-3 for the extra 3 sockets, even across\nrestarts.\n\nV6: fixed issue whereby the failing of the legacy telemetry init would roll-back\ninit of the v2 telemetry, causing the socket to be deleted, even though it was\nstill necessary.\n\nV5: Rebase on latest main after other script cleanups were merged\n\nV4: Move from simple-fix patch to proper fix patchset\n\nV3: Drop CC stable, as will have separate backport patch which does not\nerror out, so avoiding causing problems with currently running application\n\nV2: fix build error on FreeBSD\n\nBruce Richardson (5):\n eal: limit telemetry to primary processes\n telemetry: fix deletion of active sockets\n telemetry: use unique socket paths for in-memory mode\n usertools/dpdk-telemetry: connect to separate instances\n usertools/dpdk-telemetry: provide info on available sockets\n\n doc/guides/howto/telemetry.rst | 41 +++++++++++++++++++++\n lib/eal/freebsd/eal.c | 2 +-\n lib/eal/linux/eal.c | 2 +-\n lib/telemetry/telemetry.c | 65 +++++++++++++++++++++++++---------\n usertools/dpdk-telemetry.py | 45 ++++++++++++++++++++---\n 5 files changed, 133 insertions(+), 22 deletions(-)\n\n--\n2.30.2" }