Cover Detail
Show a cover letter.
GET /api/covers/100302/?format=api
{ "id": 100302, "url": "http://patches.dpdk.org/api/covers/100302/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20211001162705.442298-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211001162705.442298-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20211001162705.442298-1-stephen@networkplumber.org", "date": "2021-10-01T16:26:53", "name": "[v12,00/12] Packet capture framework update", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20211001162705.442298-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 19329, "url": "http://patches.dpdk.org/api/series/19329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19329", "date": "2021-10-01T16:26:53", "name": "Packet capture framework update", "version": 12, "mbox": "http://patches.dpdk.org/series/19329/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/100302/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C774EA0032;\n\tFri, 1 Oct 2021 18:30:41 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 745044067E;\n\tFri, 1 Oct 2021 18:30:41 +0200 (CEST)", "from mail-pf1-f182.google.com (mail-pf1-f182.google.com\n [209.85.210.182])\n by mails.dpdk.org (Postfix) with ESMTP id 026D74067A\n for <dev@dpdk.org>; Fri, 1 Oct 2021 18:30:39 +0200 (CEST)", "by mail-pf1-f182.google.com with SMTP id w14so8439555pfu.2\n for <dev@dpdk.org>; Fri, 01 Oct 2021 09:30:39 -0700 (PDT)", "from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123])\n by smtp.gmail.com with ESMTPSA id u2sm1450432pfi.120.2021.10.01.09.30.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Oct 2021 09:30:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OComxdiRpxO95Lwy9dK9TkkqlnKqEkB94pa4Kot61iU=;\n b=0G+jhp0uDP7V/N95vja9fTSBlv4t0g+RsGmGV4bYR4/rL4oY0Dr+ahW4+pIwsEnQXQ\n JemtUw2S8JQWSfRFw94AkLKc6+s5PerZw5+DAYrDn0HY080ejWZ0o+4nEMEjdm/Qz+tO\n sJO8laUOxjE88IcFC4jMJT2qUbzbZXuL+6yZ0aDYUmT41Ln/Hk31RcQUnTPLuJs5Hcvo\n eKXWWSECW8qlXJmoFI3GnbG0S8g0AnqI7iqm1Lmj3xlWG7XXdNkEbLayFIkpvbbvRxUr\n hxgXw2YCjTy7c0A3oOdi9rx+joaP7etGvnMgaBOV7sySlBneqffYh3iR6H5j3Nx7qhbi\n Qb8g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OComxdiRpxO95Lwy9dK9TkkqlnKqEkB94pa4Kot61iU=;\n b=fskHuBmHGGxzvJF0dlaXYINIf7OJDWx+HUvLJLDuo7C4pvL8lwxjFptNP7ODuw4Hcz\n Y/I80weUCQBlyLNRP2bQ/Dlw7VbpkvdBVwjzG5RoKMIaMjuliKh0XEj4yhTWc9aPF3Kf\n f7eBZJVXtOZWu9aMUOcXcRgaUpdRi8IIh6XBhzOMNW4aovoA5RpcVL4YHi53P8QeA69r\n fTb6NQRv5U7F696pyBoXwO+Jh1mzbAsDsjs90SwW+2cE1wtGkjp1HORkplNQ7vjQi8Lp\n h4xiEfeFgsUg0fQZRxDrUONhK4/gdlrD9DgHXUW9k5Ws/n944PCD89ALv9lfDPzuZq8B\n DZMw==", "X-Gm-Message-State": "AOAM533I5T1PWGLezXe+/MkKeFyjc9JliDn/BR/Mxik5CEy25hCEWuyR\n ckS05AsH3JkTchQDasOT0a7w1450vj4dag==", "X-Google-Smtp-Source": "\n ABdhPJyoge4jGmYBU87TZo/RHjEdlADsJ5xjDUqodqjZKkTw6xaSwn3Ps9n058hcnn9Ld/2JRoPNCQ==", "X-Received": "by 2002:a63:d34f:: with SMTP id\n u15mr10424419pgi.200.1633105838051;\n Fri, 01 Oct 2021 09:30:38 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 1 Oct 2021 09:26:53 -0700", "Message-Id": "<20211001162705.442298-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210903004732.109023-1-stephen@networkplumber.org>", "References": "<20210903004732.109023-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v12 00/12] Packet capture framework update", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch set is a more complete version of the the enhanced\npacket capture support described last year.\n\nThe new capture library and utility are:\n - faster avoids lots of extra I/O, does bursting, etc.\n - gives more information (multiple ports, queues, etc)\n - has a better user interface (same as Wireshark dumpcap)\n - fixes structural problems with VLAN's and timestamps\n\nThere are no blocker items.\nThe following are worth noting:\n * bogus checkpatch warnings\n\t- the correct flag to open is O_CREAT\n - intentionally keeping macro with goto since that\n was in original code and is clearer\n - the tempfile name can not be const since it is\n overwritten by tmpfile() call\n\n * enabling BPF tests causes CI to see a pre-existing bug\n https://bugs.dpdk.org/show_bug.cgi?id=811\n\n * future filtering for stripped VLAN tags needs collabration\n with libpcap project to fix pcap_compile_filter().\n\nv12\n - fixes for capture offloaded VLAN tags.\n look at direction flag and handle QinQ offload.\n\nv11\n - address review comments for pdump (patch 6)\n\nv10:\n - fix to rte_bpf_dump to handle more instructions\n make sure all bpf_test cases are decoded\n\nv9:\n - incorporate suggested change to BPF XOR\n - make autotest for pcapng more complete by reading the\n resulting file with libpcap\n\nv8:\n - enable BPF tests in autotest\n - add more BPF test strings\n - use rte_strscpy to satisfy checkpatch\n - merge MAINTAINERS (put this in with existing pdump)\n\nv7:\n - add functional tests for pcapng lib\n - bug fix for error returns in pcapng lib\n - handle long osname on FreeBSD\n - resolve almost all checkpatch issues\n\nv5:\n - minor build and checkpatch fixes for RHEL/FreeBSD\n - disable lib/pdump on Windows. It was not useful before\n and now pdump depends on bpf.\n\nv4:\n - minor checkpatch fixes.\n Note: some of the checkpatch warnings are bogus and won't be fixed.\n - fix build of dumpcap on FreeBSD\n\nv3:\n - introduce packet filters using classic BPF to eBPF converter\n required small fix to DPDK BPF interpreter\n - introduce function to decode eBPF instructions\n - add option to dumpcap to show both classic BPF and eBPF result\n - drop some un-useful stubs\n - minor checkpatch warning cleanup\n\nv2:\n fix formatting of packet blocks\n fix the new packet capture statistics\n fix crash when primary process exits\n record start/end time\n various whitespace/checkpatch warnings\n\n\n\nStephen Hemminger (12):\n lib: pdump is not supported on Windows\n librte_pcapng: add new library for writing pcapng files\n bpf: allow self-xor operation\n bpf: add function to convert classic BPF to DPDK BPF\n bpf: add function to dump eBPF instructions\n pdump: support pcapng and filtering\n app/dumpcap: add new packet capture application\n test: add test for bpf_convert\n test: add a test for pcapng library\n test: enable bpf autotest\n doc: changes for new pcapng and dumpcap\n MAINTAINERS: add entry for new packet capture features\n\n MAINTAINERS | 11 +-\n app/dumpcap/main.c | 844 ++++++++++++++++++\n app/dumpcap/meson.build | 16 +\n app/meson.build | 1 +\n app/test/meson.build | 6 +\n app/test/test_bpf.c | 200 +++++\n app/test/test_pcapng.c | 272 ++++++\n doc/api/doxy-api-index.md | 1 +\n doc/api/doxy-api.conf.in | 1 +\n .../howto/img/packet_capture_framework.svg | 96 +-\n doc/guides/howto/packet_capture_framework.rst | 67 +-\n doc/guides/prog_guide/index.rst | 1 +\n doc/guides/prog_guide/pcapng_lib.rst | 24 +\n doc/guides/prog_guide/pdump_lib.rst | 28 +-\n doc/guides/rel_notes/release_21_11.rst | 10 +\n doc/guides/tools/dumpcap.rst | 86 ++\n doc/guides/tools/index.rst | 1 +\n lib/bpf/bpf_convert.c | 575 ++++++++++++\n lib/bpf/bpf_dump.c | 139 +++\n lib/bpf/bpf_validate.c | 9 +-\n lib/bpf/meson.build | 6 +\n lib/bpf/rte_bpf.h | 39 +\n lib/bpf/version.map | 7 +\n lib/meson.build | 6 +-\n lib/pcapng/meson.build | 8 +\n lib/pcapng/pcapng_proto.h | 129 +++\n lib/pcapng/rte_pcapng.c | 613 +++++++++++++\n lib/pcapng/rte_pcapng.h | 194 ++++\n lib/pcapng/version.map | 12 +\n lib/pdump/meson.build | 2 +-\n lib/pdump/rte_pdump.c | 427 ++++++---\n lib/pdump/rte_pdump.h | 113 ++-\n lib/pdump/version.map | 8 +\n 33 files changed, 3733 insertions(+), 219 deletions(-)\n create mode 100644 app/dumpcap/main.c\n create mode 100644 app/dumpcap/meson.build\n create mode 100644 app/test/test_pcapng.c\n create mode 100644 doc/guides/prog_guide/pcapng_lib.rst\n create mode 100644 doc/guides/tools/dumpcap.rst\n create mode 100644 lib/bpf/bpf_convert.c\n create mode 100644 lib/bpf/bpf_dump.c\n create mode 100644 lib/pcapng/meson.build\n create mode 100644 lib/pcapng/pcapng_proto.h\n create mode 100644 lib/pcapng/rte_pcapng.c\n create mode 100644 lib/pcapng/rte_pcapng.h\n create mode 100644 lib/pcapng/version.map" }