From patchwork Tue Mar 31 04:41:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67446 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0997A0562; Tue, 31 Mar 2020 06:42:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D38B1C031; Tue, 31 Mar 2020 06:42:13 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id E4CA22C6D for ; Tue, 31 Mar 2020 06:42:08 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id g2so7658228plo.3 for ; Mon, 30 Mar 2020 21:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Jr3fjP0rIx5UsynO3o27dxl+xUKTyA0kBPWq6+Ex1M=; b=KNYx450f1raRtnps7RbpvTgSL12g2w7GIWdw+a/HoT3qDcOMSbJOtiSFY0kq0spuRK C69+PwrD4WofxGm9FKJmFxAM2werSrzTYHe+7ePJBEqKJIiFYD3C6tVPp41QsG1e4T+y ho9SfK1bDr11ePPFKLURGDBeCVx7PHqLyxeS6LLjRVbHXZyaTb4E4xbJW/x1UoLu7huM i/24iWfFwRRLfMsxK6dYUkR4OseJTBjYAQmRhp4WmHYsTISl9EvPyFvD+YxEam4l/lDu pZM5nArBOkCV3b4P3DuHU+yWqhanDHiP/HgaKo5E4Xf16f6dlxHORWQChPH9N7vHK7Az Ctow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Jr3fjP0rIx5UsynO3o27dxl+xUKTyA0kBPWq6+Ex1M=; b=sz4nZyGy1WEbHpPDUoo7XXKDyAib6NwZn5l77Z5p3kxbtGndzb+XMSw29j/kM8z/rF ZX+jnZfxiX/gPR8gC3SDgghNVctvPBsaxX/CfgltlHpSjbAQ0J1gr2neKyrKKOzynPkp R9iXn0pSUxSQWEvDg7W7jy9o06gsibJEWNOJx1h8JVpq9YMNQcELNtKZMkPJC7yctePn 1yE/e/8N0log1EvdEHTH6kALEwqNREo3FwI9EPHhJuwFCOmO1OMJVFKrV1JQI+J6z3Ij //UjWY2NqOtIceBEWVXgtgKmcA26vsklQkDT93AhYHcH9/IJNU3Px68YEFSTeEFc+weT 9o5Q== X-Gm-Message-State: ANhLgQ3zvuvXMcQvSlENVuPHaNNgs9ViWtcA4fo3RvA06LrPJsJSfqer satURkGNiVC3DcqVJkCKLJy2Az4F/3vdDQ== X-Google-Smtp-Source: ADFU+vsw6/UYdhEyipkKu8wKqaBIN6YcpyL7izG04M0wWc0n3bQj76TnTA8cJ1TLJilN9+Sw+d4JAQ== X-Received: by 2002:a17:902:bf07:: with SMTP id bi7mr14970499plb.164.1585629727590; Mon, 30 Mar 2020 21:42:07 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:06 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , nsamsono@marvell.com Date: Mon, 30 Mar 2020 21:41:50 -0700 Message-Id: <20200331044156.31935-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/7] net/mvneta: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is legacy and should not be used. Fixes: 3378383dceab ("net/mvneta: support statistics reset") Cc: nsamsono@marvell.com Signed-off-by: Stephen Hemminger --- drivers/net/mvneta/mvneta_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c index 865ad61aed1c..4aea87648814 100644 --- a/drivers/net/mvneta/mvneta_ethdev.c +++ b/drivers/net/mvneta/mvneta_ethdev.c @@ -751,7 +751,7 @@ mvneta_stats_reset(struct rte_eth_dev *dev) ret = mvneta_stats_get(dev, &priv->prev_stats); if (unlikely(ret)) - RTE_LOG(ERR, PMD, "Failed to reset port statistics"); + MVNETA_LOG(ERR, "Failed to reset port statistics"); return ret; } From patchwork Tue Mar 31 04:41:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67447 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D923A0562; Tue, 31 Mar 2020 06:42:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55B781C0B1; Tue, 31 Mar 2020 06:42:14 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 4FE881C025 for ; Tue, 31 Mar 2020 06:42:10 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id x7so9784623pgh.5 for ; Mon, 30 Mar 2020 21:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qs9zlBE4fyG5LqFpaPm/c6MNr1pbJrv1ZOQDh6idtJM=; b=BZ2QQZ732fj2dn5geDc+7xPeLWLMRsCQ701s8K6PXNTSGjKlFMMsGBzT4vly8lpcZf Knm0cIUSYhWZjkehvGuyDiLH48cmk/WKWVsuybaWaSg8aqNMnkK1kPciFu/F0z8dafgl Ls8PEcmmU4fyURs7aGGTqAauNg99k7UXaTmH3/N9/YJXIs3TX2IMfwRGSC20OIa4TFgC pa3gonJUiR0eYYKTjNVPcqbUmFKyt2Tm+zmS50RPSwbwmqs0FPbJ9vKIanNW93n4uOyi UMvDFTQwEijZEJv7D5hDye4QTvwXPhewifWivsdPdIMciysQRZe4RzU0Cm+2I/PQJ4h6 s/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qs9zlBE4fyG5LqFpaPm/c6MNr1pbJrv1ZOQDh6idtJM=; b=W7rg8SgXiR2WAV6kWYntZaGDBwIFj8NCNhlnlhDSKhE46ek+gnSEhQHEjcUXFAr7FQ bRXFy13yWD95mA9sNUEa852021h3JIR0XiO3bxPLOQuw5PA4dUUvopvIZJUSV38NpnRd N/cE/Kgu2Mh0USdQX2o7/GOyn0182SCpCMDgGB1/lTqIp2CUsIJMMJgdehRDDwlMYYD4 7sZiRa/4qbXlLPLCI4KOkBqK6N+BbJD5+ufQN7MlFWmYxoY+VdXgi3VM3tYI2XJRSWDC u0PhL7aRIv91Xy8NkeuKHXRdpleO9VijKAT430UoqBNFt5OFZTOmjEZDVu2GE+JlcgBI pxfA== X-Gm-Message-State: ANhLgQ0i4/+X1FhQptw2QWUvsL/pq+16YHvPimKynXYr1pasc1RuQyEp yw3MsbPZCz89wO6GZgKtVS4/4n7JzLFa8w== X-Google-Smtp-Source: ADFU+vvCAB9w+EzuupDEqXsBKMAUkC5HWs6p8tXiH3eGYwx/n6orLtqTmCD8E0RzQUaHLGxFxfW/JA== X-Received: by 2002:a62:6244:: with SMTP id w65mr16560496pfb.89.1585629728936; Mon, 30 Mar 2020 21:42:08 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:08 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 30 Mar 2020 21:41:51 -0700 Message-Id: <20200331044156.31935-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/7] net/virtio: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Virtio driver has its own logtype adn should not use legacy PMD logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 6 +++--- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 752faa0f6e7e..060410577af4 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1085,7 +1085,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, RTE_MIN(vq->vq_nentries / 4, DEFAULT_TX_FREE_THRESH); if (tx_free_thresh >= (vq->vq_nentries - 3)) { - RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the " + PMD_DRV_LOG(ERR, "tx_free_thresh must be less than the " "number of TX entries minus 3 (%u)." " (tx_free_thresh=%u port=%u queue=%u)\n", vq->vq_nentries - 3, @@ -1133,7 +1133,7 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_recv_refill(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } @@ -1145,7 +1145,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_refill_inorder(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index e61af4068322..4f565f913bf2 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -561,7 +561,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev) const char *name = rte_vdev_device_name(dev); eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { - RTE_LOG(ERR, PMD, "Failed to probe %s\n", name); + PMD_INIT_LOG(ERR,"Failed to probe %s", name); return -1; } From patchwork Tue Mar 31 04:41:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67448 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF0FBA0562; Tue, 31 Mar 2020 06:42:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFAB31C0B7; Tue, 31 Mar 2020 06:42:15 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 523662BCE for ; Tue, 31 Mar 2020 06:42:11 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id g32so3739009pgb.6 for ; Mon, 30 Mar 2020 21:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4STHvn45VW3tSwuQaAkxb8w0CsvHEqi7ZK830XrKDMg=; b=Wkxk4u/q8jZqrg6Xkf69r+nx4L/zJ/lfvMo7VJiyUGj4AoKgmbgTQDCCufQ9LpOAQR DS+yEpZOMgTXyWViA1EL6PMsDGWiJcMAq0/8QezxzbroV8CMbx80IL0Ry7L8sWhxpOOV 2cPA3fQ87MzmE+YwjaPpsUs8ikaziqAVq9coCUk51PYEXiFSTurrghKM4OyWv2PRqWpy va5IRPPmfPrVnAdxGuEgYe058IPsqTeaPNyuZxABhhIf9aGozygqDX8Zw0kNaUKgkS32 Cf0C1Hs3OlP99aoIKBNj9Tz5EZAT47YicSk1vbroNN16wMrO1f9RR3jaATGF1HZLCuzs 9RIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4STHvn45VW3tSwuQaAkxb8w0CsvHEqi7ZK830XrKDMg=; b=gBJhHkUjG+QkNE+8j7qU8THHx0pzYvh7qwVTsx8fNJTzTjmd+W8K4QKm26Zv16NQv3 1+nH5id9WhZKNZpQYZR0uOWTMrkaWyEgHj8imn1cI63Dwse3zV/QsO+ow6zNQ84vxVDR Wk8StGfXWwnTrlDBSGLQssaSe8HqV6TOGCaO/fQkqQh0IDYGCkcaqUOCrT5O202vT1hB 47W0HKxPyzrylfmKhFAgvIBS/WtbQJ931SonV0ygkA3k87QlkTjlsivLAZGeNlUNYdXw NMBPo7OmYT/FM01I/3h1yCpemZ5BWPakhsGTZ5alV6zHVNR4mhg4Zb9ERvqLCxiFfphe tywQ== X-Gm-Message-State: ANhLgQ2Cufrs14vL5s/rNyvjdAOgSRCh7nYqGFln0Gvwtec7bPMd+2iF KC6KdsM3M2Zy+KeWaEZE8renwJ/kmBQxOw== X-Google-Smtp-Source: ADFU+vvvhRcMjPepB/mX6ex2Um1Hqg4FCWaGF9oo6HzL3UqknIOaYwPmkqovW8y6Af5bTIZGkDhwVQ== X-Received: by 2002:a63:5847:: with SMTP id i7mr15845828pgm.127.1585629730285; Mon, 30 Mar 2020 21:42:10 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:09 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ophirmu@mellanox.com Date: Mon, 30 Mar 2020 21:41:52 -0700 Message-Id: <20200331044156.31935-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/7] net/tap: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is legacy and drivers should use their own logtype. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") Cc: ophirmu@mellanox.com Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 05470a211588..2c9fb76b63de 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -778,7 +778,7 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request, case SIOCSIFMTU: break; default: - RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + TAP_LOG(WARNING, "%s: ioctl() called with wrong arg", pmd->name); return -EINVAL; } @@ -1301,7 +1301,9 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!mp) { struct pmd_internals *pmd = dev->data->dev_private; - RTE_LOG(DEBUG, PMD, "%s: failed to create mbuf pool for device %s\n", + + TAP_LOG(ERR, + "%s: failed to create mbuf pool for device %s\n", pmd->name, dev->device->name); return -1; } From patchwork Tue Mar 31 04:41:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67449 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8CC8A0562; Tue, 31 Mar 2020 06:42:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 114821C0BD; Tue, 31 Mar 2020 06:42:18 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id CE6831C02A for ; Tue, 31 Mar 2020 06:42:12 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id c138so98053pfc.0 for ; Mon, 30 Mar 2020 21:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZyZfhZ5DpSzXyTh/4YlHeDyF8WAHch7RaLsHQIFNklw=; b=ED71UlEqrAmkE/jzqbAFBV9NeUvrIXCjAKrdJyKQ5FKzue0tqEhL1wUmZwZO571+Wk QZ0Iodbiq1IbLtkcEJoXeRdVm6+9tSVpMLs2/D2xAP/zvRMUMahusAa1WaFInXfX7GIJ l3WnC+ph2asN9TesGPI67I7jgz56wmIvrs100kGqfkojpnpjQAg6qDt724qQTpzMyQVi qNNzXImiEM4yy0svIRfl/3r4UmLNU7n+1BQ7jDnHJhejYDpnfLR3YC59sV1xnkEbx7Td rJc3e9CmG6PHqkbFfIcsXAigfgy3t3Ch1ol+BomUwFIaRFilsyNkF22j9MSNAFoc7WPr RltA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZyZfhZ5DpSzXyTh/4YlHeDyF8WAHch7RaLsHQIFNklw=; b=ck92B/ddpEw9daZWDiuwhu1RgHdoZsaWPn5nD4S6H6PN524/XE6qC8Urx63bv1a+8D RuxWWoT6lchM7WXJWYzRSX/LZRTFZuVPRRBDq7PYVaP8AfKqvJ0xxHMRerb1tgT9hIwp qljOWkRF07yZofrPhwAs5PrDUSkw2L5xax35LaLXXaHbR0atYJogsfxmBLR/LoN6dYTz jq4wuRsB6Of9GDe2YIYNFUBPqa1epI+ySWFG+eBxHRyHMB7mCszM3UKvg/wgjBwfWm1Y FcR4/F+9JVGIEDX3EcXSiicH9pK5CK2TlvlcLGWSOF076+V0a2dYhHS+1l8wTCSmSadt h7tw== X-Gm-Message-State: AGi0PuY8DkZWCcJHGEkBz7/9051c0A0j3U5HHbGtV0PS0b2qiXxBG8b3 nuaihSjFuup437I9zd5ivrTYfx4u4DYgRw== X-Google-Smtp-Source: APiQypJm9rfeCyccA7D1WHORvS6GDzmxxzw6uiKs8n6LBtZFSDvEFaalJSvk/jsrbwlEbs0NR+qGTA== X-Received: by 2002:a62:2b06:: with SMTP id r6mr4979235pfr.249.1585629731580; Mon, 30 Mar 2020 21:42:11 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:10 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , g.singh@nxp.com Date: Mon, 30 Mar 2020 21:41:53 -0700 Message-Id: <20200331044156.31935-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/7] net/pfe: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is a legacy from original DPDK logging. All drivers must use their own dynamic log type. Fixes: b1bc1afa4a0e ("net/pfe: support dynamic logging") Cc: g.singh@nxp.com Signed-off-by: Stephen Hemminger --- drivers/net/pfe/pfe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c index 940347819875..59b5b8387b9d 100644 --- a/drivers/net/pfe/pfe_ethdev.c +++ b/drivers/net/pfe/pfe_ethdev.c @@ -990,7 +990,7 @@ pmd_pfe_probe(struct rte_vdev_device *vdev) if (rc < 0) return -EINVAL; - RTE_LOG(INFO, PMD, "Initializing pmd_pfe for %s Given gem-id %d\n", + PFE_PMD_LOG(INFO, "Initializing pmd_pfe for %s Given gem-id %d", name, init_params.gem_id); if (g_pfe) { @@ -1118,7 +1118,7 @@ pmd_pfe_probe(struct rte_vdev_device *vdev) else gem_id = init_params.gem_id; - RTE_LOG(INFO, PMD, "Init pmd_pfe for %s gem-id %d(given =%d)\n", + PFE_PMD_LOG(INFO, "Init pmd_pfe for %s gem-id %d(given =%d)", name, gem_id, init_params.gem_id); rc = pfe_eth_init(vdev, g_pfe, gem_id); From patchwork Tue Mar 31 04:41:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67450 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DF46A0562; Tue, 31 Mar 2020 06:42:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E7DB1C0C0; Tue, 31 Mar 2020 06:42:19 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by dpdk.org (Postfix) with ESMTP id 1B06B1C043 for ; Tue, 31 Mar 2020 06:42:14 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id b1so9772805pgm.8 for ; Mon, 30 Mar 2020 21:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wO6IY/wlv7lUEjktkkD7Fjq4/897tIP5+E0ot3LFeCE=; b=GBY0xnzvfBx38YfdTezhnNNfs+1dYtqCZNfpX50yEpQ7sxns50vvyn3ZtSxZBeMzhU 4GrNij0uTSGS3XYwYhjwXEHzJjF2sRwHg0OAmvm/HHFvWcb4YaAo1J+ZEv65+k7NR4wH C1fAzV0fi0u/pmHZFSXOM/Kkzkh5By9wlBxaNiXwply9O2fp+5uKmQ5Oo2fhoQRc/xZD xxc/jo7pJNL0ZtODkLUaf6cT38Qmhm+M8c62jx9azfI38X8UvN983DEQBoy9/9GCo5/v 3xGRx0XsbvJ5O1r5F71h+M8VS6Ia3rp1gbhLSdhuk03xr3YZqQ7Pp82Wb9xGgXjqP+Cc ol6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wO6IY/wlv7lUEjktkkD7Fjq4/897tIP5+E0ot3LFeCE=; b=bHJknR/KSW1aOML+bwEDkxU57AB8wVaC/cSrv3UP37piPsePU96EXTW/wooNLeUe5U SAIraIoCe3TBv3Ay6N1DAUqXOYwzLHY/BVebMQDdbxa2CTVNgUlfjQbMjLFg3LXQlUS1 pzPd4tEeuHxLE+m/GQo2JmDXwoV8lXUH6f1do1RjcUhWXwUcLfshRwhRJLWXoNc/nkLV gI+Zg9Wddq9GPB8i79xHWyaMqU88TdYxqnfn9UaHA0i6X29aern7TB+/Cv/DPiVN2lvK nCQvjqhKmN6hhIZmrBAcUNo7XEmz+2GW8hjyYsdOrp3SHregQgVdlYC6zt6Rrezvv3B6 KahA== X-Gm-Message-State: ANhLgQ1Os1EXB5qa8/KqzyRepmDSp+0KCrN+rj+syYUe+NN7sSUnBPOH rcgcZ73veKaZxvS8p1em8P9Kspd9FRw3/Q== X-Google-Smtp-Source: ADFU+vvCWS0kSOaX10OrfjxGDgcDGeH9LcGwIVIp0C/uBFz7MmwnrvCmYGNp6WXnIZhap7kioitXlA== X-Received: by 2002:aa7:9097:: with SMTP id i23mr15971574pfa.170.1585629732880; Mon, 30 Mar 2020 21:42:12 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:12 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ajit.khaparde@broadcom.com Date: Mon, 30 Mar 2020 21:41:54 -0700 Message-Id: <20200331044156.31935-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 5/7] net/bnxt: don't use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Accidental use of PMD logtype rather than per-driver logtype. Fixes: 14255b351537 ("net/bnxt: fix queue start/stop operations") Cc: ajit.khaparde@broadcom.com Signed-off-by: Stephen Hemminger Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index d6e4e8a28138..1999cd7861b8 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/drivers/net/bnxt/bnxt_ring.c @@ -598,7 +598,7 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index) if (rxq->rx_started) { if (bnxt_init_one_rx_ring(rxq)) { - RTE_LOG(ERR, PMD, + PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring failed!\n"); bnxt_rx_queue_release_op(rxq); rc = -ENOMEM; From patchwork Tue Mar 31 04:41:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67451 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE9BCA0562; Tue, 31 Mar 2020 06:43:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C1BAD1C0C7; Tue, 31 Mar 2020 06:42:20 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 89B711C0B5 for ; Tue, 31 Mar 2020 06:42:15 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id e1so7644336plt.9 for ; Mon, 30 Mar 2020 21:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tG+/U7x5Z+gugjcCBLn14Jm9KyXgv4aLbb6fHw6Ev4c=; b=eqL7MLtR5mnazzQut78L4uKntEKANdT8bQl24Ix1tGlM7Ke02tb08SmHe0DzTNFx8H /ph2tgYQCzEMbyvlveJnVQVCPC5bh0CSXo0ifjSGiPYcWUCNmruonh/YN0lYx1E/n/lq +MKRmR/SoeUJMydF/QykPd1Qqj2DOY7SH/zz06cdRsW+ROsOjbkbMTPy8A8B0v1O7uBO u3LYbbxodgLqjSa42bzlRcXissfSBTcoLPttPgpIra/jrLYYG+OKOyr4egJ1L6R4Dzqp Bd6h0jpzcNhYe9gUPJKHUfwq33ni9yIIz/nfwYwYDePcrUxDEK/u5qhutaZnNV9qU2Nm 7kXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tG+/U7x5Z+gugjcCBLn14Jm9KyXgv4aLbb6fHw6Ev4c=; b=fZFe9qoSyq1cc+FOQkMRVZvK9nJ0aXBN81If9fMeC3SxqHxm/Ujncs08nAtFKwiHqg tFw35cdRAM3fIUxyicVSycSiS9ex3Zy6RaHkjkCJ/P52TmXivaBUEo1xXr6zrnu/i1To +ocPRmg6e7hTLB46Tqneeyotx17XfgXPQlwpn+ucfL+dsb5qHS/6ljxDLMTwEwwsPLNQ +j+bJN4A1ZoL6KcgBR/A7gK8yBk0FvAPTd8ngMJW34HbAPvC76U411jolrHplfLWuAvP /nHthOfELYuiGt6CeomFb50gTnHTYy4hDAkg9cI/fu8Dj5BTG0ohZof8yzbyrbnGW01a yeQA== X-Gm-Message-State: AGi0Pubpe21S+a191iiifoZ7wAl3p0Tv6L4amYgFGxYevK5HFlq2Dfue Zc1mppkFBt/wCJrBKikHG0b/C3OETO427Q== X-Google-Smtp-Source: APiQypIMFESMrzUO3TU1qTVTftOdsIbvjgpm8Hr5AUVTLTGRBMlIdErfYSbZwuYxLMq/my51CtixOw== X-Received: by 2002:a17:90b:24c:: with SMTP id fz12mr1634905pjb.85.1585629734212; Mon, 30 Mar 2020 21:42:14 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , shreyansh.jain@nxp.com Date: Mon, 30 Mar 2020 21:41:55 -0700 Message-Id: <20200331044156.31935-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 6/7] net/dpaa: use dynamic logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The static PMD logtype should not be used by drivers. Instead, use existing log macros in this driver. Also use standard rte_ether routine to format ether address. Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") Cc: shreyansh.jain@nxp.com Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index fce9ce2feb9d..f59c2631a56c 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -881,8 +881,8 @@ dpaa_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id) PMD_INIT_FUNC_TRACE(); if (qman_query_fq_frm_cnt(rxq, &frm_cnt) == 0) { - RTE_LOG(DEBUG, PMD, "RX frame count for q(%d) is %u\n", - rx_queue_id, frm_cnt); + DPAA_PMD_DEBUG("RX frame count for q(%d) is %u", + rx_queue_id, frm_cnt); } return frm_cnt; } @@ -996,8 +996,7 @@ dpaa_dev_add_mac_addr(struct rte_eth_dev *dev, ret = fman_if_add_mac_addr(dpaa_intf->fif, addr->addr_bytes, index); if (ret) - RTE_LOG(ERR, PMD, "error: Adding the MAC ADDR failed:" - " err = %d", ret); + DPAA_PMD_ERR("Adding the MAC ADDR failed: err = %d", ret); return 0; } @@ -1023,7 +1022,7 @@ dpaa_dev_set_mac_addr(struct rte_eth_dev *dev, ret = fman_if_add_mac_addr(dpaa_intf->fif, addr->addr_bytes, 0); if (ret) - RTE_LOG(ERR, PMD, "error: Setting the MAC ADDR failed %d", ret); + DPAA_PMD_ERR("Setting the MAC ADDR failed %d", ret); return ret; } @@ -1306,6 +1305,7 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) struct fman_if *fman_intf; struct fman_if_bpool *bp, *tmp_bp; uint32_t cgrid[DPAA_MAX_NUM_PCD_QUEUES]; + char eth_buf[RTE_ETHER_ADDR_FMT_SIZE]; PMD_INIT_FUNC_TRACE(); @@ -1457,15 +1457,9 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) /* copy the primary mac address */ rte_ether_addr_copy(&fman_intf->mac_addr, ð_dev->data->mac_addrs[0]); + rte_ether_format_addr(eth_buf, sizeof(eth_buf), &fman_intf->mac_addr); - RTE_LOG(INFO, PMD, "net: dpaa: %s: %02x:%02x:%02x:%02x:%02x:%02x\n", - dpaa_device->name, - fman_intf->mac_addr.addr_bytes[0], - fman_intf->mac_addr.addr_bytes[1], - fman_intf->mac_addr.addr_bytes[2], - fman_intf->mac_addr.addr_bytes[3], - fman_intf->mac_addr.addr_bytes[4], - fman_intf->mac_addr.addr_bytes[5]); + DPAA_PMD_INFO("net: dpaa: %s: %s", dpaa_device->name, eth_buf); /* Disable RX mode */ fman_if_discard_rx_errors(fman_intf); @@ -1578,8 +1572,8 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, if (!is_global_init && (rte_eal_process_type() == RTE_PROC_PRIMARY)) { if (access("/tmp/fmc.bin", F_OK) == -1) { - RTE_LOG(INFO, PMD, - "* FMC not configured.Enabling default mode\n"); + DPAA_PMD_INFO( + "* FMC not configured.Enabling default mode"); default_q = 1; } From patchwork Tue Mar 31 04:41:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 67452 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7CBCA0562; Tue, 31 Mar 2020 06:43:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B3721C0CF; Tue, 31 Mar 2020 06:42:22 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 183BD1C0BD for ; Tue, 31 Mar 2020 06:42:17 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id np9so554696pjb.4 for ; Mon, 30 Mar 2020 21:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kfWY8BpKtVfj3exsjUIbHGRPW5ZZLZ0U7/DrQto+CZ8=; b=kSAlGkJHpI5MytJAcf38iSF+NmDEa302khMt52sy4VRxFPjeuwlw2Ak9WMTZ6FGrF9 Cnl7h8K+e7Z+rOLRPE9AfjWGfPSptVE3KYF+cD3gThTr7faBNs/3C5sFuEXIxyy0q3cA Ag6yMTVeoRBdLi0XAi7NcXrFVYCeDHpw1zU1dPYsKYxvVz9p2c0GG4pQbYt2wNAV8bzv /heId8pjYm44+bdt7eewkqfaIos+JL+kZsyl0xVoPiBqNWSv3UgwiZu9iAhIxpXJ6fQ7 uGnBFjf3sF1bJJd6tUTxlqS6b9MW2xX70J3c0hsHACMlS3XpPdHxXqzRaCjdXKK2cUAQ z4Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kfWY8BpKtVfj3exsjUIbHGRPW5ZZLZ0U7/DrQto+CZ8=; b=Tm90Sa5Iu41xfI5fMR6qKkvFnUfhcn5/FcdN18WjHHi7PYWEl55fg6bLXepxMi4f0N uDUi4O+9tyw4Eu8vf8ay2SBaF/0d6aPl1DhWIGDeWZB2qYtSrEdci67e3prTkPXNDmyv Qj1UTOfIEWWDtmHY75q0Xk8wBYlNyJxoPktfzFQpCHFrZQvvKB/9MOFzG+YQorn7eBtd insMS5VsQGuo1yClW4RK17V/GV8wMI3iM6kHDhROTWV6cWaNCveTHHoqGWSxfdA9sRYd dhtUdIwVUt5J2DI8AvwveCiuq0uDLDtuBKniMufWPzN56+mWVL3/J0PKy558FXsz35oa NuNQ== X-Gm-Message-State: AGi0PuZizjzhNJkvt5nIiETjdQjNr3PK2u94KRckkRJuLPER5euJ5FM+ PHDGaz319REnnKCeaBFHzI/52pxd1EaEhw== X-Google-Smtp-Source: APiQypIXUwOYzufrJuxwnTbXOssuN3rPcAPuK1OY010aFeVcI7m+nBESd/mcKk910IXOXAy8iX1Xxg== X-Received: by 2002:a17:90a:2489:: with SMTP id i9mr1585023pje.183.1585629735675; Mon, 30 Mar 2020 21:42:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:14 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , jerin.jacob@caviumnetworks.com Date: Mon, 30 Mar 2020 21:41:56 -0700 Message-Id: <20200331044156.31935-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 7/7] net/thunderx: use dynamic logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD static logtype is original DPDK legacy and should not be used. Fixes: 43362c6a7647 ("net/thunderx: support RSS and RETA query and update") Cc: jerin.jacob@caviumnetworks.com Signed-off-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_ethdev.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index 6f43541a5d42..00e8287fac38 100644 --- a/drivers/net/thunderx/nicvf_ethdev.c +++ b/drivers/net/thunderx/nicvf_ethdev.c @@ -496,9 +496,10 @@ nicvf_dev_reta_query(struct rte_eth_dev *dev, int ret, i, j; if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) { - RTE_LOG(ERR, PMD, "The size of hash lookup table configured " - "(%d) doesn't match the number hardware can supported " - "(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); + PMD_DRV_LOG(ERR, + "The size of hash lookup table configured " + "(%u) doesn't match the number hardware can supported " + "(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); return -EINVAL; } @@ -526,9 +527,9 @@ nicvf_dev_reta_update(struct rte_eth_dev *dev, int ret, i, j; if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) { - RTE_LOG(ERR, PMD, "The size of hash lookup table configured " - "(%d) doesn't match the number hardware can supported " - "(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); + PMD_DRV_LOG(ERR,"The size of hash lookup table configured " + "(%u) doesn't match the number hardware can supported " + "(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE); return -EINVAL; } @@ -569,8 +570,8 @@ nicvf_dev_rss_hash_update(struct rte_eth_dev *dev, if (rss_conf->rss_key && rss_conf->rss_key_len != RSS_HASH_KEY_BYTE_SIZE) { - RTE_LOG(ERR, PMD, "Hash key size mismatch %d", - rss_conf->rss_key_len); + PMD_DRV_LOG(ERR, "Hash key size mismatch %u", + rss_conf->rss_key_len); return -EINVAL; }