From patchwork Wed Aug 1 05:22:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Hu X-Patchwork-Id: 43497 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F9CA56A3; Wed, 1 Aug 2018 07:23:30 +0200 (CEST) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 504394CC3; Wed, 1 Aug 2018 07:23:28 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44A0CED1; Tue, 31 Jul 2018 22:23:27 -0700 (PDT) Received: from net-debian.shanghai.arm.com (net-debian.shanghai.arm.com [10.169.36.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 710FD3F2EA; Tue, 31 Jul 2018 22:23:26 -0700 (PDT) From: Gavin Hu To: dev@dpdk.org Cc: honnappa.nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org Date: Wed, 1 Aug 2018 13:22:57 +0800 Message-Id: <20180801052257.14869-1-gavin.hu@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When running checkpatch.sh, it generates the following error on some linux distributions(like Debian) with Dash as the default shell interpreter. trap: SIGINT: bad trap The fix is to replace SIGINT with INT signal, it works for both bash and dash. Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition") Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Acked-by: John McNamara Acked-by: Vipin Varghese --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 2509269df..ba795ad1d 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -29,7 +29,7 @@ clean_tmp_files() { fi } -trap "clean_tmp_files" SIGINT +trap "clean_tmp_files" INT print_usage () { cat <<- END_OF_HELP