From patchwork Mon Feb 10 04:15:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinan Sun X-Patchwork-Id: 65681 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C954A0531; Mon, 10 Feb 2020 05:36:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 484081BE9C; Mon, 10 Feb 2020 05:36:22 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 99AEC2B94 for ; Mon, 10 Feb 2020 05:36:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 20:36:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,423,1574150400"; d="scan'208";a="346967329" Received: from dpdk.sh.intel.com ([10.239.255.129]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2020 20:36:17 -0800 From: Guinan Sun To: dev@dpdk.org Cc: Wenzhuo Lu , Qiming Yang , Guinan Sun Date: Mon, 10 Feb 2020 04:15:25 +0000 Message-Id: <20200210041525.50893-1-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes (Logically dead code) coverity issue. Coverity issue: 353613 Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove") Signed-off-by: Guinan Sun Acked-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_pf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index 493f0f2b9..afae21f81 100644 --- a/drivers/net/ixgbe/ixgbe_pf.c +++ b/drivers/net/ixgbe/ixgbe_pf.c @@ -772,9 +772,6 @@ ixgbe_set_vf_macvlan_msg(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) IXGBE_VT_MSGINFO_SHIFT; if (index) { - if (new_mac == NULL) - return -1; - if (!rte_is_valid_assigned_ether_addr( (struct rte_ether_addr *)new_mac)) { PMD_DRV_LOG(ERR, "set invalid mac vf:%d\n", vf);