From patchwork Sun Jan 26 22:54:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasesh Mody X-Patchwork-Id: 65135 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB535A052F; Sun, 26 Jan 2020 23:54:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16ECA4C74; Sun, 26 Jan 2020 23:54:44 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D3743493D; Sun, 26 Jan 2020 23:54:42 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00QMoXMF018270; Sun, 26 Jan 2020 14:54:42 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=BZcD9keZuNU7gt3K7S7OoI+lsRZbWHVu2+G/cidrW48=; b=CooZqIIgdAZ+PbbjSjIvmqavRA5BDO9oaGxS2BaRz0duxTU6PghRGSHhlVWC7hFi7vQv 3fqAbAyp2hd/5m1qDeK/SlTumJhpwPpotaT7rftyp6Tp1ZpF12BPclXbFwcPZhjGaVOA gJ/ifVx0xl/dlwjs8hFOHU6w/zrHSw1/4f5e9iuxeBsJFE+z5w9uaGi28Ol6rOoyfjLz CBXfqOfSfP+Y/Mj0dj9vLcBL+ESqUlvDXw/QdtLyD2ggTk6jyXhnmNleMeRconsVH/3Y oE9Mi0BELvd6qUepVVZYWEG77dUS40oO+xeP00iiINabssstnHxdZ7ossM3zMXxylNn9 Mw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2xrp2svpbt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 26 Jan 2020 14:54:41 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 26 Jan 2020 14:54:39 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 26 Jan 2020 14:54:39 -0800 Received: from irv1user08.caveonetworks.com (unknown [10.104.116.105]) by maili.marvell.com (Postfix) with ESMTP id 5D0133F703F; Sun, 26 Jan 2020 14:54:39 -0800 (PST) Received: (from rmody@localhost) by irv1user08.caveonetworks.com (8.14.4/8.14.4/Submit) id 00QMsbpG024455; Sun, 26 Jan 2020 14:54:37 -0800 X-Authentication-Warning: irv1user08.caveonetworks.com: rmody set sender to rmody@marvell.com using -f From: Rasesh Mody To: , , CC: Rasesh Mody , , Date: Sun, 26 Jan 2020 14:54:18 -0800 Message-ID: <20200126225419.23919-1-rmody@marvell.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200114003920.17705-1-rmody@marvell.com> References: <20200114003920.17705-1-rmody@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-26_06:2020-01-24, 2020-01-26 signatures=0 Subject: [dpdk-dev] [PATCH v2 1/2] net/bnx2x: fix reset of scan FP flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index ed31335ac..50e289b28 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -4577,10 +4577,10 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp) bnx2x_handle_fp_tq(fp); return; } + /* We have completed slow path completion, clear the flag */ + rte_atomic32_set(&sc->scan_fp, 0); } - /* Assuming we have completed slow path completion, clear the flag */ - rte_atomic32_set(&sc->scan_fp, 0); bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID, le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1); }