From patchwork Tue Jan 14 17:52:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 64678 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA8A4A0512; Tue, 14 Jan 2020 18:52:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 230371C12B; Tue, 14 Jan 2020 18:52:55 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D9C191C126 for ; Tue, 14 Jan 2020 18:52:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 09:52:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,319,1574150400"; d="scan'208";a="213412267" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga007.jf.intel.com with ESMTP; 14 Jan 2020 09:52:49 -0800 From: Ferruh Yigit To: Wenzhuo Lu , Konstantin Ananyev , Phil Yang , Gavin Hu , Dharmik Thakkar Cc: dev@dpdk.org, Maxime Coquelin Date: Tue, 14 Jan 2020 17:52:47 +0000 Message-Id: <20200114175247.2930261-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Build error: In function ‘ixgbe_recv_pkts_lro_bulk_alloc’: ../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24: error: ‘next_sc_entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized] next_sc_entry->fbuf = first_seg; ^ http://mails.dpdk.org/archives/test-report/2020-January/113891.html This is a compiler false positive and error not seen by newer compilers, or clang but to fix the warning initializing the complained variable. According git bisect, no idea how: Fixes: 8a2e7ce976fd ("net/ixgbe: avoid multiple definitions of bool") Reported-by: Maxime Coquelin Signed-off-by: Ferruh Yigit Tested-by: Maxime Coquelin Acked-by: Xiaolong Ye --- Cc: dharmik.thakkar@arm.com --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 13b06eb9c..30f890572 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2028,7 +2028,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, bool eop; struct ixgbe_rx_entry *rxe; struct ixgbe_scattered_rx_entry *sc_entry; - struct ixgbe_scattered_rx_entry *next_sc_entry; + struct ixgbe_scattered_rx_entry *next_sc_entry = NULL; struct ixgbe_rx_entry *next_rxe = NULL; struct rte_mbuf *first_seg; struct rte_mbuf *rxm;