From patchwork Fri Jul 27 17:26:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 43439 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20D155942; Fri, 27 Jul 2018 19:26:16 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 9408C56A3; Fri, 27 Jul 2018 19:26:15 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id c13-v6so5781813wrt.1; Fri, 27 Jul 2018 10:26:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8ru1ojlR06hFhSrJSAZGJzOioNF3GZm8mVV8gCPMDVY=; b=sOmJTpkxxmOyTS7/emf1+ifeESjTu0k3z461lt5yPzOpGcFgCse8djC8vOil7sprnE CgmZTxn3+/ZV8OxdEKCELqq/4s6YdoT/1fU+fYhbYKcuo5rRV3es78TC9myc3QVy+9z+ WqHPAS/3ZgNiLwVmLXkVsYAO87roO43jJx2PjN2dIHhuflfwM2/8p/8GgK3/EHMAMEq+ eJh4NIXWalvk+SN7hbq42rQeRs9Z+BkRzjoK40uFD+krX7zUYjkDw6bHfEqDLypW5K+p cmiryesERtcyBUFFvJOzUUNWVBu/+SJcwjZuFG7twbBGnusxuLxKYbx6Zpx4Kz3z39OC s7Ng== X-Gm-Message-State: AOUpUlEEJSsyev8SCSUYabiOeAhoEB8UCNS+cvfuffSAt2izqkq8YHxo z7sd7RVmwXcQqNfAqPFvy5c+tXpuHzY= X-Google-Smtp-Source: AAOMgpc38txdpB12cBOoCfNYhF3ZhLu1inr4LYZFFkORIxCb1og0lM4s7bboU0FvzgSadQ78AdqgXQ== X-Received: by 2002:a5d:66c4:: with SMTP id k4-v6mr5598120wrw.154.1532712375085; Fri, 27 Jul 2018 10:26:15 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id s2-v6sm7809689wrn.83.2018.07.27.10.26.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 10:26:13 -0700 (PDT) From: Luca Boccassi To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, Luca Boccassi , stable@dpdk.org Date: Fri, 27 Jul 2018 18:26:07 +0100 Message-Id: <20180727172607.16890-1-bluca@debian.org> X-Mailer: git-send-email 2.18.0 Subject: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rx_drop_en is an optimization that does nothing on single-queue devices like e1000. Do not force applications that do not care to select per-devices optimizations flags by returning an error, just log it and carry on. Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") Cc: stable@dpdk.org Signed-off-by: Luca Boccassi Acked-by: Wei Zhao --- drivers/net/e1000/em_rxtx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index a6b3e92a6..81dc41efb 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -1416,12 +1416,13 @@ eth_em_rx_queue_setup(struct rte_eth_dev *dev, } /* - * EM devices don't support drop_en functionality + * EM devices don't support drop_en functionality. + * It's an optimization that does nothing on single-queue devices, + * so just log the issue and carry on. */ if (rx_conf->rx_drop_en) { - PMD_INIT_LOG(ERR, "drop_en functionality not supported by " + PMD_INIT_LOG(NOTICE, "drop_en functionality not supported by " "device"); - return -EINVAL; } /* Free memory prior to re-allocation if needed. */