From patchwork Thu Jan 9 12:59:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 64367 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09FFCA046B; Thu, 9 Jan 2020 13:59:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 576261DD54; Thu, 9 Jan 2020 13:59:37 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id E269B1DD51 for ; Thu, 9 Jan 2020 13:59:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578574775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ulVWVi+k9KOJdQIUTUoTyFdH2u6TsISViIFaqkZvTb4=; b=VOOQUtW+RjEjBBJaH5XA26t4xqnOg/cwXfF5lpTibipQIHm/Gl1fhD0rlcDLHoZwQhDh3e 3xHpMVullM/rTfnBi+egtoNlMgTUmLzxe0yWQcUDDB2BFnFn/a52BxByIvjS6U8ihwZtps hhwlTBkaSqdHzU9d4Q+OKNyDTmIUakk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-G23fbalYNFCc5U-QSegzqw-1; Thu, 09 Jan 2020 07:59:31 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B28F08BD477; Thu, 9 Jan 2020 12:59:29 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-19.brq.redhat.com [10.40.204.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5078A5E7B0; Thu, 9 Jan 2020 12:59:26 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: bruce.richardson@intel.com, bluca@debian.org, aconole@redhat.com, stable@dpdk.org, Thomas Monjalon , Ranjit Menon , Jeff Shaw , Pallavi Kadam , Harini Ramakrishnan , Anand Rawat Date: Thu, 9 Jan 2020 13:59:15 +0100 Message-Id: <20200109125916.32073-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: G23fbalYNFCc5U-QSegzqw-1 X-Mimecast-Spam-Score: 0 Subject: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using version 0.47.1, meson is unable to find the math library in Travis for the 32bits job. Quite surprisingly, this problem is not seen with the 64bits jobs. Switching to 0.48.0, the problem disappears. But we should pass 'm' to find_library instead of 'libm' anyway. Fixes: 98edcbb5ab2f ("eal/windows: introduce Windows support") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Aaron Conole --- config/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 01911ecf9..28a57f56f 100644 --- a/config/meson.build +++ b/config/meson.build @@ -115,7 +115,7 @@ add_project_link_arguments('-pthread', language: 'c') dpdk_extra_ldflags += '-pthread' # on some OS, maths functions are in a separate library -if cc.find_library('libm', required : false).found() +if cc.find_library('m', required : false).found() # some libs depend on maths lib add_project_link_arguments('-lm', language: 'c') dpdk_extra_ldflags += '-lm' From patchwork Thu Jan 9 12:59:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 64368 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B33B1A046B; Thu, 9 Jan 2020 13:59:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E10B1DD5E; Thu, 9 Jan 2020 13:59:40 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 3C4FD1DD58 for ; Thu, 9 Jan 2020 13:59:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578574777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ISfLHjX23D8parBfG0gGCH9Cbzen2d4IxQNWM7qttOk=; b=CZ/A/mPN/P61K2QXa8LaZuk+guDOXE04vq5lkHDD4qzbR4VB1Fd1iC3wodiVJkChm7uy7p hoCEYJnE0uIETujj9t5oDhddm0uLecqQK1TC2tGfs3X62NQRa6h93RTEkYhx2Xi7ANykOY aNTaFP5V4M7rgChY5Diq2XAZC0b0UKA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-O83ySoqeNIG3cZMsDtt5Jg-1; Thu, 09 Jan 2020 07:59:34 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AFAE818C35A0; Thu, 9 Jan 2020 12:59:32 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-19.brq.redhat.com [10.40.204.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 501A55DA66; Thu, 9 Jan 2020 12:59:29 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: bruce.richardson@intel.com, bluca@debian.org, aconole@redhat.com, stable@dpdk.org, Michael Santana Date: Thu, 9 Jan 2020 13:59:16 +0100 Message-Id: <20200109125916.32073-2-david.marchand@redhat.com> In-Reply-To: <20200109125916.32073-1-david.marchand@redhat.com> References: <20200109125916.32073-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: O83ySoqeNIG3cZMsDtt5Jg-1 X-Mimecast-Spam-Score: 0 Subject: [dpdk-dev] [PATCH 2/2] ci: use meson 0.47.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes in Ubuntu 16.04. On the other hand, the minimal version supported in dpdk is 0.47.1. Stick to this version to avoid getting hit by regressions in meson latest shiny release. 1: https://github.com/mesonbuild/meson/issues/6427 Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Aaron Conole --- .ci/linux-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh index dfb9d4a20..38bb88e15 100755 --- a/.ci/linux-setup.sh +++ b/.ci/linux-setup.sh @@ -1,7 +1,7 @@ #!/bin/sh -xe # need to install as 'root' since some of the unit tests won't run without it -sudo python3 -m pip install --upgrade meson +sudo python3 -m pip install --upgrade 'meson==0.47.1' # setup hugepages cat /proc/meminfo