From patchwork Thu Dec 12 17:58:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 63830 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 510BAA04F5; Thu, 12 Dec 2019 18:59:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD4741BF7C; Thu, 12 Dec 2019 18:59:02 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 123DB1BF7A; Thu, 12 Dec 2019 18:59:00 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBCHp9lb003632; Thu, 12 Dec 2019 09:58:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=3khHGbmKp0qxdlJCSPH7QJMy8NpSovqK/edHhS1x2z8=; b=Ega9SEs9yp3t7/5pOmlqpg6+0YrC2ICdygsVUSHfzCbIRNOT7WJKE6BscGD3zf8gBhW8 3BTztS5cjel5eErRcNJXkxGIsKTvEa9V73E04EPag3E400+ZFDu8fwHX4EQIvnewOGnZ SKOl8EJapTGjX/f95w5SZsozaq0iDEqpXVczbh7ivpA0PEkSq9uK9D0UtcbiyfPD4CKV YxTo15GtVI/8lN/jvYLC3ZDZ4l2hRn0wAZxEq2GVRgKrcii/t3k2fMWxk9KaMYatrPIR tI1i4QaY0lZOg3lnfdZk3WoI5g5A0B7b9I7pchFWL51Jq68Whwqbmv0EcT60IFP7zKmt UQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2wue9mtpwg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2019 09:58:59 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Dec 2019 09:58:57 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 12 Dec 2019 09:58:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nn8aVA6TIcjXfGeDmzCZYcU4s8m1iZt+4WDU1K+6wqm7m2S3BFeBQkT3n/ffWO6LgfhN+a5P0pl0whrV4hDbmcwWneHGA71RQXAFSp1lu94tdS3/PIEjowX3CcpaYK6BUbv3tflbYpoBIwXoxnyOdAqTR7HMqhpuSi+craQgyzKtXdKJY4J8xnfhAOcHDBXsQoNkb9LDANl96j/IOOIhw6Ku/FnzJlcx7CxkcUqqCSZVOCqt8ifjOlZGiM+AJE6i/Wz1D8c6ggaBSfm245dDCS/0SEc+pWToV7an2KbU3c4LyT0bM7V595TolVegdEDU2OFb/zdM0P469XRlEMEOAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3khHGbmKp0qxdlJCSPH7QJMy8NpSovqK/edHhS1x2z8=; b=MC3mXanUhXsb7rx9Q5AhEhTEtb2BV7gK/qmeEQCy9twT3aI0J861NJgkmYu4vaz6sD31x+V0zLl/u22N6oWVgi6HYzlutec1cy898Z6E8L0qJKmoaZmLTuYklOm/T3tJy0rkNY4NXYdnx3/qv6W+2UCuPlBF7zPNEY+MGbFEwHBY/NsiyDyCwjy4DnXdkETq+IngYWoHLwam/KhhjfO3V+uZDQLtzKKF6QPqDe29HUAnWZ0nB/eQACJPBlezR+jOdjdx2Ml2Nq+6SLd9Gb8kg/wg4B+FGv5rraiXrdtCs8TB893B6bin2hBVITBc63VvvexGOpiM4cVIPY8aMeaKtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3khHGbmKp0qxdlJCSPH7QJMy8NpSovqK/edHhS1x2z8=; b=FKJHEjqocG6e8z9e8QAN2Wy2t82X3Tm4/2l7w6CrHfdKZlXK6vs4y0jZ5TAibcW/JSu88AEOHSJbTKu4MfLXoUVa5iddpuEE60jqJmDeQLLOQ5F3iRUq+2cVf2+YeZPRRBw8dT1rZl/SoJcNXHoFcK5GlZRN6XaLDXtvoJYw86s= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB2477.namprd18.prod.outlook.com (20.179.81.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Thu, 12 Dec 2019 17:58:56 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::81e4:87d1:7636:2ed7]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::81e4:87d1:7636:2ed7%7]) with mapi id 15.20.2516.018; Thu, 12 Dec 2019 17:58:56 +0000 From: Harman Kalra To: Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda CC: "dev@dpdk.org" , Harman Kalra , "stable@dpdk.org" Thread-Topic: [PATCH] net/octeontx2: fix get supported ptype callback Thread-Index: AQHVsRXS67iIh+8Jv0a2ywV+Wlkirg== Date: Thu, 12 Dec 2019 17:58:56 +0000 Message-ID: <1576173504-29467-1-git-send-email-hkalra@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0035.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::21) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0ca91d0-e31d-41b3-e3c2-08d77f2cf4a6 x-ms-traffictypediagnostic: MN2PR18MB2477: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-forefront-prvs: 0249EFCB0B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(189003)(199004)(2616005)(186003)(2906002)(6486002)(86362001)(71200400001)(55236004)(6512007)(478600001)(26005)(52116002)(8936002)(6636002)(110136005)(66556008)(64756008)(5660300002)(81166006)(316002)(36756003)(6506007)(66476007)(4326008)(450100002)(66946007)(54906003)(8676002)(81156014)(66446008); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2477; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: upWvi3q79cJ83x0hbQt6gyqxrH5bDrH78kNWwWxKUvE73JDJqDvGXFHHkq3v+h5nqgPYrBQ/UMoC7Z3XYbV1fSofXdV5sKiyculdg5jcME+hZEW+eRF0WeIbibn6yZbtHI4ZbTBTmTa8uxs/IV+gUg5zA6zve04LsQHNZRii6F2npJ5a/9CczXRL1uUuKkdTamsjN2iFMCgEAIMb9PE1w5UbW3sjkoh+h+rwiaIinebklhZzIfiadsRdHW2d2UpqezcFKlgxVCjOQ5Bq+pMTEyFfvpt5esGJxBoM6NRnn53xEG3KJ5lKJzLb1xt7/nqGt9xn6GWfGqGVmeTrPFCBIuIlLZ+E+3chGu/RzJZ93XIa6gM+3nFI7RdhW3cbB55OaMlwR2ek8/iyjWgdhMxkiZyMAFtMM7jBx/km94mfsULSCqO6ZtDdpJEf085Zd2mJ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f0ca91d0-e31d-41b3-e3c2-08d77f2cf4a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 17:58:56.0268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HfaReQvUWcsGobWU1qTKUg/Q2A85DeS+dNDauS6RBSnQY3pkWss0ln1+S2uXzYQdqV9/sqZndzuh2rWb0SN7eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2477 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-12_05:2019-12-12,2019-12-12 signatures=0 Subject: [dpdk-dev] [PATCH] net/octeontx2: fix get supported ptype callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Setting up supported ptypes using testpmd command is failing because supported_ptypes_get callback will never return ptypes supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags is zero by default in testpmd. Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") Cc: stable@dpdk.org Signed-off-by: Harman Kalra Acked-by: Jerin Jacob --- drivers/net/octeontx2/otx2_lookup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c index bcf2ff4e8..568557116 100644 --- a/drivers/net/octeontx2/otx2_lookup.c +++ b/drivers/net/octeontx2/otx2_lookup.c @@ -17,7 +17,7 @@ const uint32_t * otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) { - struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); + RTE_SET_USED(eth_dev); static const uint32_t ptypes[] = { RTE_PTYPE_L2_ETHER_QINQ, /* LB */ @@ -56,10 +56,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) RTE_PTYPE_UNKNOWN, }; - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F) - return ptypes; - else - return NULL; + return ptypes; } int