From patchwork Wed Jul 25 18:20:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 43380 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8FBC326C; Wed, 25 Jul 2018 20:20:26 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 73A93F72 for ; Wed, 25 Jul 2018 20:20:23 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id i26-v6so1982252pfo.12 for ; Wed, 25 Jul 2018 11:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eBXkaGCtVZlnkliQrKufSaZgxGdukwqRzcTN4Y7K91A=; b=R7xCjbXjbT8WNMaEp4ABkemZEc0LsKGR/ROL0PQeQG+jDF/UnjSkYDSo6qIm0TLdKo OpLA59hQr/L0bJzS4mIcybPO0Tzwbk4PFvfHk9QPmQPZIiKdjjopkerEVe1dULbSsqOL q17R1/ZH+07Wl4khuVu4RVf2HwYM6oWNty8EISqcfaXCZYrpj7CJ6h78zG6MSYupv9Jd V/Ffo4+GQOwv+Dnvc9f6Y63iVq22cae/RVV1DH/Gy4dsy/BnoUg3ukm3T4/MH/mdhS1l qMmmvp0E+fHepc38qoUl0BUce7gWDO4Ahgj5thVc6NNJsXeOnaxslZ4hWB9a/DJ88mPc i9xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eBXkaGCtVZlnkliQrKufSaZgxGdukwqRzcTN4Y7K91A=; b=t4IgPW/I56325yiLkza5XY5xyYTrIKUZ/vV6Q2ouxxI0TiXcm/QUaQig2jOlZ4yMhA rdn63KcioDzljC2233W3jMIh21XZIISLobTdO2VuokRF1HxLBgAa9Xr9IpKr3/X1S3Hg aN2Ei06G8HpEs3HkefYMH5saDmP7ASoA+uvm1pKg+Iox5WoH7gWHh1zYS9IeVre0S7ED gH8v9pC2q0+ffDYo84z6Ia2UjfitRVCavHqP9UcXXP/WGNrYJKguoJ/4/bT0pmL+JJ7H WMnUnrCEUAX5VGrFtOtknDIp/70MjRXVK1qM63mpWyriNxAXfbG/38sEzf3q4Vrn1ldC 5WCQ== X-Gm-Message-State: AOUpUlGEOBoxDryADWEPScT9/Xdjb5oDgdla9kYuKz5EmU/YC28fFs/g Z5dRXd22ZCclXcBJgnyWq2rxz21ktyQ= X-Google-Smtp-Source: AAOMgpe/5nyxsOq1gk4hLtpnrTIcPWwOavJs4h0I5oset6xCvkkUu7DBA2K9NEQwTtfHhLYKHG7cEg== X-Received: by 2002:a63:2246:: with SMTP id t6-v6mr21639785pgm.258.1532542822340; Wed, 25 Jul 2018 11:20:22 -0700 (PDT) Received: from localhost.localdomain ([167.220.62.92]) by smtp.gmail.com with ESMTPSA id l85-v6sm25973854pfk.34.2018.07.25.11.20.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 11:20:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 25 Jul 2018 11:20:16 -0700 Message-Id: <20180725182019.31518-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180725182019.31518-1-stephen@networkplumber.org> References: <20180725182019.31518-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/4] arm: remove profanity in comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Update comment to describe the problem better without risk of being offensive. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/arch/arm/rte_cycles_32.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h b/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h index c4f974feb3da..859b09748c56 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h +++ b/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h @@ -29,8 +29,8 @@ extern "C" { #ifndef RTE_ARM_EAL_RDTSC_USE_PMU /** - * This call is easily portable to any ARM architecture, however, - * it may be damn slow and inprecise for some tasks. + * This call is easily portable to any architecture, however, + * it may require a system call and inprecise for some tasks. */ static inline uint64_t __rte_rdtsc_syscall(void) From patchwork Wed Jul 25 18:20:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 43381 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8B7E3572; Wed, 25 Jul 2018 20:20:28 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id A72713257 for ; Wed, 25 Jul 2018 20:20:24 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id r5-v6so5843490pgv.0 for ; Wed, 25 Jul 2018 11:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gg7TjbJpVhnhVmFIkbOVUTsZvw+0p3xJnpBjjbTD7vM=; b=KHdLq7GQ5/ylSoEuMKC+E/qXptdJN3UTW/njDoYJPnwtVLiRjvvKbrehvgKr0gta1+ jes+du8uFD5rgr1xUEMHGtKx/IwWW7Wr1iyxzYmk3jWBgHuH6vVjqwZGoJGSVTdjeYXV SC0YUSZxbMHRaxikHC2W7Z3YQ2mTtP2OvXWCjpeGnWlsNiyDbD1wKdFkkMViz2PRQNpf EbTn0uM9h8D7LaB0YbjgzMseX2AuVLdurcubz1JKJAMb62QkLCapgU7+BYkuqpp3IZpf by+54pJVO++idAmOYK0lWB7rNjVeVVEsBpBuJorB3+Tvno9QGxmjDHPWAHmaDSI5k1xn qshw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Gg7TjbJpVhnhVmFIkbOVUTsZvw+0p3xJnpBjjbTD7vM=; b=miirD64Kn4KR/Yx7saFzM6rntPmqDezvqyIKDG1EnMuKTOpGLFLSCsNPdtmAR+DvZD laTEWCxpyfa7ljbgT+AmgqojgsBmY9lFeWuZN/85CtEYipy5gOp3Ad6EgGgbwAoBCxBb FCCkXqzoW3hEMTYAohilQ/sM82R4J7HkoK6Swj3xjQ3G0GBObO1u1NROK/WPCsJoe9lX A3eX0Dm/jhYgUxrIgFZDoY3ILDxENaFipMu/o6ggfIRs1bcQiQ9SsUnVcBJ4MDR6lmB0 kdYI2r7MkfmkrgFN18yVtxeUEVLgKPd3RmlKywkwddGdYtqnwyr1+Drt282bA1IyOfrd 7jRQ== X-Gm-Message-State: AOUpUlGbQPmThamZtMGPvrlcLOhRM/6IkkIFABBpvh3nMgMnb3/FJUue 2JIMkVZbrMtrsNpODuN0PWCJLajHeVM= X-Google-Smtp-Source: AAOMgpfq4qrGDlZqshvbGxT3pFPeJ2qxkSBighmteLBZqt5wuroNwR7F7jjmvI81FwLKj3fqxFuW4g== X-Received: by 2002:a63:a042:: with SMTP id u2-v6mr21141260pgn.80.1532542823606; Wed, 25 Jul 2018 11:20:23 -0700 (PDT) Received: from localhost.localdomain ([167.220.62.92]) by smtp.gmail.com with ESMTPSA id l85-v6sm25973854pfk.34.2018.07.25.11.20.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 11:20:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 25 Jul 2018 11:20:17 -0700 Message-Id: <20180725182019.31518-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180725182019.31518-1-stephen@networkplumber.org> References: <20180725182019.31518-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" No need for profanity in comments. Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/bnx2x/elink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 34a29373af3b..08fe817720a1 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drivers/net/bnx2x/elink.c @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc, PORT_HW_CFG_E3_MOD_ABS_MASK) >> PORT_HW_CFG_E3_MOD_ABS_SHIFT; - /* Should not happen. This function called upon interrupt + /* + * Should not happen. This function called upon interrupt * triggered by GPIO ( since EPIO can only generate interrupts * to MCP). * So if this function was called and none of the GPIOs was set, - * it means the shit hit the fan. */ if ((cfg_pin < PIN_CFG_GPIO0_P0) || (cfg_pin > PIN_CFG_GPIO3_P1)) { From patchwork Wed Jul 25 18:20:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 43382 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CA883798; Wed, 25 Jul 2018 20:20:31 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 085A63257 for ; Wed, 25 Jul 2018 20:20:26 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id r1-v6so5832633pgp.11 for ; Wed, 25 Jul 2018 11:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vXByrRyb+hZHrXapovd4DDhWc40AdT9uNuOBrXKQ48w=; b=jkysMPwUoaD0Rgg2qezADtSJKtWNT8u3Fq1guq7EBZMzQgZGhIMYQ0RHeGmvw9hGlo sLO4Ju1ZL6/QygrT0lV8C5eLdcHAlQHORfgu2lQWjer6BXRVnNS6aiov/wNGrYE2+kdZ ip9rj01yyFRV5R5+1PE+RuLlTJ0z2RsJu6dDcJX68LGNIAiUH3Mz2UlBhlii2DPW8NzL Jb3RJwQShrJbZMS6Hcpfj4z8m0yERPt3WHfd75Pu5XyGhtVE5xl/eIexvXNpyPBGz/yP J+Jt8U3joy0uXTNwPbw7a3c8kTyUmYtEUShc6hHGj6VzWPZdAYk2F3C2A63wMf4o2zkq UjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vXByrRyb+hZHrXapovd4DDhWc40AdT9uNuOBrXKQ48w=; b=Jocucqvk0PeVAyQ7MHqJvSzvlUhnINvYmB/MT7wa7x8Khr97w15m1FCgcU7E+fiDAU J3GJNOrSwSeY0nKIrz5HhwHwKHH9VGwVjVnarVIxOFXr/cnFnIvrJz/xJpd/FSinjkzs /plLKzl+XhgDpPPMu54iEdLwWgAyY8EQmh/kuLkR2TRvLu0W18NDcBjsaXBb4LiT2QWz dJ58qV6GjzckoT4Y03479//bKE5R3jjyly9AiESlXhF5UCw572fN/iHb0SRVmS6vNXrw sa5B5fkRNXOKjdpnKOtyYWfxwXdZO/dROe7jwz2rUwqinKsKFdu3gOyr5YtstQ7VhG7Q B0kQ== X-Gm-Message-State: AOUpUlGJgqATwHq0YyKLwNMZKWsRPzR5xXyWWla5w6tdAhxOrH6dXMcL 1JGiiG4HptjqqBpzfPZeGjGtCziUr2g= X-Google-Smtp-Source: AAOMgpdP+r67Ga4+JdAdAkDMu4VO13L6q4KNQW1VG1a1a49rQoi3DdfdcrEnUTNW4fUHxojxlFlS7A== X-Received: by 2002:a63:4306:: with SMTP id q6-v6mr20769846pga.181.1532542824921; Wed, 25 Jul 2018 11:20:24 -0700 (PDT) Received: from localhost.localdomain ([167.220.62.92]) by smtp.gmail.com with ESMTPSA id l85-v6sm25973854pfk.34.2018.07.25.11.20.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 11:20:23 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 25 Jul 2018 11:20:18 -0700 Message-Id: <20180725182019.31518-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180725182019.31518-1-stephen@networkplumber.org> References: <20180725182019.31518-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no need to call rte_exit and crash the application here; better to let the application handle the error itself. Remove the gratuitous profanity which would be visible if the rte_exit was still there. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_proc.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index 9fcb9121908d..07b7579c565a 100644 --- a/lib/librte_eal/common/eal_common_proc.c +++ b/lib/librte_eal/common/eal_common_proc.c @@ -841,14 +841,12 @@ mp_request_async(const char *dst, struct rte_mp_msg *req, param->user_reply.nb_sent++; - if (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000, - async_reply_handle, pending_req) < 0) { + ret = rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000, + async_reply_handle, pending_req); + if (ret < 0) RTE_LOG(ERR, EAL, "Fail to set alarm for request %s:%s\n", dst, req->name); - rte_panic("Fix the above shit to properly free all memory\n"); - } - - return 0; + return ret; fail: free(pending_req); free(reply_msg); From patchwork Wed Jul 25 18:20:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 43383 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F969493D; Wed, 25 Jul 2018 20:20:33 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 6133E3421 for ; Wed, 25 Jul 2018 20:20:27 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id y5-v6so5842149pgv.1 for ; Wed, 25 Jul 2018 11:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kA4vn52xvGe1C/hiygBETAhPJXkGrnQHf4zwd2Q2tZM=; b=HbgF+WnpWbhRFqwnIexuvPKSSn97s832Q0SukdcmFJpAGo3MhaJ/najeSHRD3n9MtL mJBgfUHe3golM+K1ZtoLttivnTRphUtlw4ZAXMsuZDZiLjzF9qBhSkHnkIiIeArv5ub7 6eHfyxG77gquRCSpO01IxJCKntKI9qMvRlpg6Mo51iI39Hk+FWthA6ABh2wFT4ndeqtc 8wfxOZQiLh5T4axmlmS3dyb7dr/uhOLlHfBJyPtfkJ91BM8Dni+kS16EMRh/OaGwqO1T MjPAbKfd/b8JcUGOA0VcwMloi94KIPu/N1iP8fzNaQDAox+DFX4LYH99Bt8at6M/WpRS N1Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kA4vn52xvGe1C/hiygBETAhPJXkGrnQHf4zwd2Q2tZM=; b=M4fHdi7jk3mu2brMSwB+vAhfjecfsml0t/PWQfLvuVEGD2FDp/6Jt75ltb4Kxt8/vS 84KQlEMdxlJr0J9Mfr5Cgmmt5jCCU3TMODRoEBAIwvuplZ+4BwYlEn+UfQ/hZwYSEQjK 1zm/IW15LvJOQR5mHYZCv9O+uBvySpe6FhWWH0Bi1RpwTT/4hhscjCbI6xRkXMrAS2fU cfOnNsANisdjUf3Z+obcR/JFjcQ7Vo6408LTWBMWV3dKsz0lCKGRjJh+fAid4dRmnG0p El5rPiTD5bYwLY1MWnTNjJGV+3nyOT9cGXtkWw9KM04tAmOlbd9U2g2iovVwzoQfionz p/ag== X-Gm-Message-State: AOUpUlFVwcqF+oDZM20fgWnZ6Gd4z/OADzCQFIWpudLvWP+iVAl9ZCdL 7m+1GKkruxcR2RuEga93Ik3o4BmPlKM= X-Google-Smtp-Source: AAOMgpf0QRyu7k+zidCtUqaf46CkaNN8ooQ6a98Xss/Es81FzJSf81S8tN8hUKMkSQDtDUAgpHuGtg== X-Received: by 2002:a63:5d58:: with SMTP id o24-v6mr21829402pgm.349.1532542826215; Wed, 25 Jul 2018 11:20:26 -0700 (PDT) Received: from localhost.localdomain ([167.220.62.92]) by smtp.gmail.com with ESMTPSA id l85-v6sm25973854pfk.34.2018.07.25.11.20.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 11:20:25 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 25 Jul 2018 11:20:19 -0700 Message-Id: <20180725182019.31518-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180725182019.31518-1-stephen@networkplumber.org> References: <20180725182019.31518-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 4/4] ixgbe: remove mild profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" At the tail end of comment about barriers (I feel your pain); remove mild profanity. Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 354181664202..9e10e15cd34f 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2057,8 +2057,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, * of the ixgbe PMD. * * TODO: - * - Get rid of "volatile" crap and let the compiler do its - * job. + * - Get rid of "volatile" and let the compiler do its job. * - Use the proper memory barrier (rte_rmb()) to ensure the * memory ordering below. */