From patchwork Thu Nov 21 23:34:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 63214 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3BBDA04C1; Fri, 22 Nov 2019 00:34:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34212235; Fri, 22 Nov 2019 00:34:47 +0100 (CET) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 326672BA3 for ; Fri, 22 Nov 2019 00:34:45 +0100 (CET) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B8BD330C085; Thu, 21 Nov 2019 15:31:04 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com B8BD330C085 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1574379064; bh=J3nd94Fu4deSWsY/nvxxk0/ui7JGW4+SdNLsfZ68M5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncw3tqFu+mC9h+hVzqGheNWaHV+b4aJPMM87jBdQ5SVkEx1i4x7bYgp2mpqAAGxM2 hpv8TJS2iSBm8AfAkoPH0SAR9BVQVO+LZ6JJKe0g+4zLWlpGvYLZFXOJV6+GzllBS4 BBohnMjv4/uP1kBVYwWX1+7/oBvI1OggvKfnU0SA= Received: from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net [10.69.74.102]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 42917140069; Thu, 21 Nov 2019 15:34:39 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 21 Nov 2019 15:34:32 -0800 Message-Id: <20191121233435.4263-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) In-Reply-To: References: MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/3] doc: update bnxt feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Updating bnxt.ini file. These features were added earlier under the following commits. 1) 94d4afd2d167 ("net/bnxt: advertise scatter Rx offload capability") 2) 57d5e5bc86e4 ("net/bnxt: add statistics") 3) 88920136688c ("net/bnxt: support xstats get by id") Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini index 9721dd61d..37a99e336 100644 --- a/doc/guides/nics/features/bnxt.ini +++ b/doc/guides/nics/features/bnxt.ini @@ -11,6 +11,7 @@ Rx interrupt = Y Queue start/stop = Y MTU update = Y Jumbo frame = Y +Scattered Rx = Y LRO = Y TSO = Y Promiscuous mode = Y @@ -37,9 +38,11 @@ Rx descriptor status = Y Tx descriptor status = Y Basic stats = Y Extended stats = Y +Stats per queue = Y FW version = Y EEPROM dump = Y LED = Y +Multiprocess aware = Y Linux UIO = Y Linux VFIO = Y ARMv8 = Y From patchwork Thu Nov 21 23:34:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 63215 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81E01A04C1; Fri, 22 Nov 2019 00:34:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14A8C2BBB; Fri, 22 Nov 2019 00:34:49 +0100 (CET) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 2FF47235 for ; Fri, 22 Nov 2019 00:34:45 +0100 (CET) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id D1EE930C086; Thu, 21 Nov 2019 15:31:04 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com D1EE930C086 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1574379064; bh=l/7uDYXExHe3fLuuYTYwspGA2pbB7LrlM914LRnvKfk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rAkMmUUIqA9f2beUgToVadpO6cuENvIwqEjZfiNJaPt6uG8iq/6kGTCzwmsRN8PfJ 5A3mxj5tq5J/3GqK6nb0p/+0zKZF4YvyKHd66eNVTimwg5IlcB17KTsZGAYSqixz/o 5SZEtYH8PigxR5VeggUwNmNJmRbrPQrAFXmTjSUM= Received: from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net [10.69.74.102]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 5FC1414008D; Thu, 21 Nov 2019 15:34:39 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 21 Nov 2019 15:34:33 -0800 Message-Id: <20191121233435.4263-2-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) In-Reply-To: <20191121233435.4263-1-ajit.khaparde@broadcom.com> References: <20191121233435.4263-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/3] doc: update release notes for Broadcom PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Update release doc briefly describing updates to bnxt PMD for 19.11 release. The support for these was added in the following commits: 1) b150a7e7ee66 ("net/bnxt: support LRO on Thor adapters") 2) be14720def9c ("net/bnxt: support FW reset") 3) df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") 4) 698aa7e95325 ("net/bnxt: add code to determine the Tx COS queue") 5) 04102f2ffc8c ("net/bnxt: update HWRM API to version 1.10.1.6") Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_19_11.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst index 48c80e5da..53856399d 100644 --- a/doc/guides/rel_notes/release_19_11.rst +++ b/doc/guides/rel_notes/release_19_11.rst @@ -201,6 +201,16 @@ New Features * Enabled zero copy between application mempools and UMEM by enabling the XDP_UMEM_UNALIGNED_CHUNKS UMEM flag. +* **Updated Broadcom bnxt driver.** + + Updated Broadcom bnxt driver with new features and improvements, including: + + * Added support for hot firmware upgrade. + * Added support for error recovery. + * Added support for querying and using COS classification in hardware. + * Added LRO support Thor devices. + * Update HWRM API to version 1.10.1.6 + * **Added Marvell NITROX symmetric crypto PMD.** Added a symmetric crypto PMD for Marvell NITROX V security processor. From patchwork Thu Nov 21 23:34:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 63216 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55328A04C1; Fri, 22 Nov 2019 00:35:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD3D22BF1; Fri, 22 Nov 2019 00:34:50 +0100 (CET) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 2B2D0A3 for ; Fri, 22 Nov 2019 00:34:45 +0100 (CET) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 92B1230C06F; Thu, 21 Nov 2019 15:31:04 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 92B1230C06F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1574379064; bh=guMgvinaTRJbrHBvBVKkBnv4d/UCoibWZyToOEDTjBo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uzUEfglBsoEsyI0IsFO+gYd6XqHaMbQzhDrz0/WEu7BmU11kHLNhgUMVLE4l+XyoL T4D5XI+piUEWwyOnwU/J7X/SQAS/YJySaOoeNLX6vpY4hKGth1zwIHrVvsBCYpG/Tv 58wyz5wpadLJi661uciG9oW3TL/5oUH+q+K03N5U= Received: from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net [10.69.74.102]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 7385F140090; Thu, 21 Nov 2019 15:34:39 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Somnath Kotur Date: Thu, 21 Nov 2019 15:34:34 -0800 Message-Id: <20191121233435.4263-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) In-Reply-To: <20191121233435.4263-1-ajit.khaparde@broadcom.com> References: <20191121233435.4263-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 3/3] net/bnxt: fix to free all the vnics during port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Somnath Kotur Now that vnics are created only as part of the flow creation cmds and not during init, we cannot rely on iterating only through 'nr_vnics'. We need to sweep all the vnics by using 'max_vnics' otherwise a vnic with a stale 'rx_queue_cnt' might be left lingering post a port stop/start operation. This could lead to a segfault. This change is required because of the recent fix made by commit to "fix flow creation with non-consecutive group ids". Fixes: bab0a1f2ed4b ("net/bnxt: fix flow creation with non-consecutive group ids") Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c index 52a4badfc..104342e13 100644 --- a/drivers/net/bnxt/bnxt_vnic.c +++ b/drivers/net/bnxt/bnxt_vnic.c @@ -75,12 +75,13 @@ struct bnxt_vnic_info *bnxt_alloc_vnic(struct bnxt *bp) void bnxt_free_all_vnics(struct bnxt *bp) { - struct bnxt_vnic_info *temp; + struct bnxt_vnic_info *vnic; unsigned int i; - for (i = 0; i < bp->nr_vnics; i++) { - temp = &bp->vnic_info[i]; - STAILQ_INSERT_TAIL(&bp->free_vnic_list, temp, next); + for (i = 0; i < bp->max_vnics; i++) { + vnic = &bp->vnic_info[i]; + STAILQ_INSERT_TAIL(&bp->free_vnic_list, vnic, next); + vnic->rx_queue_cnt = 0; } }