From patchwork Thu Nov 14 13:59:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dekel Peled X-Patchwork-Id: 63020 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CB66A04C6; Thu, 14 Nov 2019 15:00:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DF602C27; Thu, 14 Nov 2019 15:00:09 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 92F1F2C08 for ; Thu, 14 Nov 2019 15:00:07 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with ESMTPS (AES256-SHA encrypted); 14 Nov 2019 16:00:05 +0200 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.128.130.87]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xAEE05Iv000890; Thu, 14 Nov 2019 16:00:05 +0200 From: Dekel Peled To: john.mcnamara@intel.com, marko.kovacevic@intel.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com Cc: dev@dpdk.org, viacheslavo@mellanox.com Date: Thu, 14 Nov 2019 15:59:13 +0200 Message-Id: X-Mailer: git-send-email 1.7.1 Subject: [dpdk-dev] [PATCH] app/testpmd: fix cleanup of Tx metadata offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previous patch [1] removed the match_metadata Tx offload. This patch removes the option to select this offload from testpmd menu, help text and documentation. It also modifies the cmd_show_tx_metadata_parsed() function, to display the value correctly, and the dump_pkt_burst() function to display the relevant (Tx/Rx) metadata only. [1] http://patches.dpdk.org/patch/62457/ Fixes: 9bf26e1318e3 ("ethdev: move egress metadata to dynamic field") Cc: viacheslavo@mellanox.com Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko Acked-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 10 ++++------ app/test-pmd/util.c | 4 ++-- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +-- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 809c94a..9f3e0b2 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -874,7 +874,7 @@ static void cmd_help_long_parsed(void *parsed_result, "udp_tso|outer_ipv4_cksum|qinq_insert|vxlan_tnl_tso|" "gre_tnl_tso|ipip_tnl_tso|geneve_tnl_tso|" "macsec_insert|mt_lockfree|multi_segs|mbuf_fast_free|" - "security|match_metadata on|off\n" + "security on|off\n" " Enable or disable a per port Tx offloading" " on all Tx queues of a port\n\n" @@ -18571,8 +18571,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#mbuf_fast_free#security#" - "match_metadata"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off = TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_tx_offload_result, @@ -18657,8 +18656,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|mbuf_fast_free|security|" - "match_metadata on|off", + "mt_lockfree|multi_segs|mbuf_fast_free|security on|off", .tokens = { (void *)&cmd_config_per_port_tx_offload_result_port, (void *)&cmd_config_per_port_tx_offload_result_config, @@ -18857,7 +18855,7 @@ struct cmd_show_tx_metadata_result { } if (!strcmp(res->cmd_keyword, "tx_metadata")) { printf("Port %u tx_metadata: %u\n", res->cmd_pid, - rte_be_to_cpu_32(ports[res->cmd_pid].tx_metadata)); + ports[res->cmd_pid].tx_metadata); } } diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index cf41864..b514be5 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -82,10 +82,10 @@ mb->vlan_tci, mb->vlan_tci_outer); else if (ol_flags & PKT_RX_VLAN) printf(" - VLAN tci=0x%x", mb->vlan_tci); - if (ol_flags & PKT_TX_DYNF_METADATA) + if (!is_rx && (ol_flags & PKT_TX_DYNF_METADATA)) printf(" - Tx metadata: 0x%x", *RTE_FLOW_DYNF_METADATA(mb)); - if (ol_flags & PKT_RX_DYNF_METADATA) + if (is_rx && (ol_flags & PKT_RX_DYNF_METADATA)) printf(" - Rx metadata: 0x%x", *RTE_FLOW_DYNF_METADATA(mb)); if (mb->packet_type) { diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 48473d8..a3ba5d2 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1718,8 +1718,7 @@ Enable or disable a per port Tx offloading on all Tx queues of a port:: sctp_cksum, tcp_tso, udp_tso, outer_ipv4_cksum, qinq_insert, vxlan_tnl_tso, gre_tnl_tso, ipip_tnl_tso, geneve_tnl_tso, macsec_insert, - mt_lockfree, multi_segs, mbuf_fast_free, security, - match_metadata + mt_lockfree, multi_segs, mbuf_fast_free, security This command should be run when the port is stopped, or else it will fail.