From patchwork Tue Aug 13 02:07:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57636 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19A4C1BE8A; Tue, 13 Aug 2019 04:09:53 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 43A441B952; Tue, 13 Aug 2019 04:09:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540045" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:48 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 13 Aug 2019 10:07:25 +0800 Message-Id: <20190813020730.10038-2-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 1/6] net/virtio: remove remaining simple Tx related stuff X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The simple Tx path in virtio has been removed in below commit. This patch removes an undefined function declaration of simple Tx and all related descriptions in the doc. Fixes: 57f818963d80 ("net/virtio: remove simple Tx path") Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 15 ++------------- drivers/net/virtio/virtio_ethdev.h | 3 --- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 2ae875cb4..da9cd6ba6 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -201,7 +201,7 @@ The packet transmission flow is: Virtio PMD Rx/Tx Callbacks -------------------------- -Virtio driver has 4 Rx callbacks and 3 Tx callbacks. +Virtio driver has 4 Rx callbacks and 2 Tx callbacks. Rx callbacks: @@ -223,9 +223,6 @@ Tx callbacks: #. ``virtio_xmit_pkts``: Regular version. -#. ``virtio_xmit_pkts_simple``: - Vector version fixes the available ring indexes to optimize performance. - #. ``virtio_xmit_pkts_inorder``: In-order version. @@ -239,25 +236,17 @@ By default, the non-vector callbacks are used: Vector callbacks will be used when: -* ``txmode.offloads`` is set to ``0x0``, which implies: - - * Single segment is specified. - - * No offload support is needed. - * Mergeable Rx buffers is disabled. The corresponding callbacks are: * For Rx: ``virtio_recv_pkts_vec``. -* For Tx: ``virtio_xmit_pkts_simple``. - Example of using the vector version of the virtio poll mode driver in ``testpmd``:: - testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1 + testpmd -l 0-2 -n 4 -- -i --rxq=1 --txq=1 --nb-cores=1 In-order callbacks only work on simulated virtio user vdev. diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 20d331795..a10111758 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -103,9 +103,6 @@ uint16_t virtio_xmit_pkts_inorder(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts); -uint16_t virtio_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts, - uint16_t nb_pkts); - int eth_virtio_dev_init(struct rte_eth_dev *eth_dev); void virtio_interrupt_handler(void *param); From patchwork Tue Aug 13 02:07:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57637 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17A2D1BE94; Tue, 13 Aug 2019 04:09:56 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7AB631BE83; Tue, 13 Aug 2019 04:09:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540061" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:50 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 13 Aug 2019 10:07:26 +0800 Message-Id: <20190813020730.10038-3-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 2/6] doc: fix typo in virtio in-order Rx function name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Rx function that will be used when in-order is enabled should be virtio_recv_mergeable_pkts_inorder() instead of virtio_xmit_pkts_inorder(). Fixes: 8f3bd7e8702d ("net/virtio: add in-order Rx/Tx into selection") Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index da9cd6ba6..08438d064 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -251,7 +251,7 @@ Example of using the vector version of the virtio poll mode driver in In-order callbacks only work on simulated virtio user vdev. * For Rx: If mergeable Rx buffers is enabled and in-order is enabled then - ``virtio_xmit_pkts_inorder`` is used. + ``virtio_recv_mergeable_pkts_inorder`` is used. * For Tx: If in-order is enabled then ``virtio_xmit_pkts_inorder`` is used. From patchwork Tue Aug 13 02:07:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57638 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71AED1BE96; Tue, 13 Aug 2019 04:09:58 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 689F51BE8D; Tue, 13 Aug 2019 04:09:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540064" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:51 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 13 Aug 2019 10:07:27 +0800 Message-Id: <20190813020730.10038-4-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 3/6] doc: update the description for in-order Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The virtio_recv_mergeable_pkts_inorder() has been renamed to virtio_recv_pkts_inorder() and added the non-mergeable support in below commit. Fixes: efcda13648d2 ("net/virtio: add non-mergeable support to in-order path") Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 08438d064..b3c356856 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -215,8 +215,8 @@ Rx callbacks: Vector version without mergeable Rx buffer support, also fixes the available ring indexes and uses vector instructions to optimize performance. -#. ``virtio_recv_mergeable_pkts_inorder``: - In-order version with mergeable Rx buffer support. +#. ``virtio_recv_pkts_inorder``: + In-order version with mergeable and non-mergeable Rx buffer support. Tx callbacks: @@ -250,8 +250,7 @@ Example of using the vector version of the virtio poll mode driver in In-order callbacks only work on simulated virtio user vdev. -* For Rx: If mergeable Rx buffers is enabled and in-order is enabled then - ``virtio_recv_mergeable_pkts_inorder`` is used. +* For Rx: If in-order is enabled then ``virtio_recv_pkts_inorder`` is used. * For Tx: If in-order is enabled then ``virtio_xmit_pkts_inorder`` is used. From patchwork Tue Aug 13 02:07:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57639 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F2041BEA1; Tue, 13 Aug 2019 04:10:00 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 00FFD1BE8D for ; Tue, 13 Aug 2019 04:09:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540073" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:53 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Date: Tue, 13 Aug 2019 10:07:28 +0800 Message-Id: <20190813020730.10038-5-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 4/6] doc: document the devargs for virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Document the devargs for virtio-user and also make it clear that these devargs are only available in virtio-user, i.e. not supported by the PCI virtio driver. Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 38 +++++++++++++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index b3c356856..993e691f5 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -322,7 +322,7 @@ Here we use l3fwd-power as an example to show how to get started. Virtio PMD arguments -------------------- -The user can specify below argument in devargs. +Below devargs are supported by the PCI virtio driver: #. ``vdpa``: @@ -331,12 +331,44 @@ The user can specify below argument in devargs. a virtio device needs to work in vDPA mode. (Default: 0 (disabled)) -#. ``mrg_rxbuf``: +Below devargs are supported by the virtio-user vdev: + +#. ``path``: + + It is used to specify a path to connect to vhost backend. + +#. ``mac``: + + It is used to specify the MAC address. + +#. ``cq``: + + It is used to enable the control queue. (Default: 0 (disabled)) + +#. ``queue_size``: + + It is used to specify the queue size. (Default: 256) + +#. ``queues``: + + It is used to specify the queue number. (Default: 1) + +#. ``iface``: + + It is used to specify the host interface name for vhost-kernel + backend. + +#. ``server``: + + It is used to enable the server mode when using vhost-user backend. + (Default: 0 (disabled)) + +#. ``mrg_rxbuf``: It is used to enable virtio device mergeable Rx buffer feature. (Default: 1 (enabled)) -#. ``in_order``: +#. ``in_order``: It is used to enable virtio device in-order feature. (Default: 1 (enabled)) From patchwork Tue Aug 13 02:07:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57640 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B657E1BEA9; Tue, 13 Aug 2019 04:10:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D6FDD1BE91 for ; Tue, 13 Aug 2019 04:09:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540077" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:54 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Date: Tue, 13 Aug 2019 10:07:29 +0800 Message-Id: <20190813020730.10038-6-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 5/6] doc: document packed virtqueue for virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Document the packed virtqueue layout support in virtio net PMD. Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 63 ++++++++++++++++++++++++++++---------- 1 file changed, 47 insertions(+), 16 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 993e691f5..011954ff6 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -24,15 +24,19 @@ standard qemu vhost back end and vhost kni back end. Virtio Implementation in DPDK ----------------------------- -For details about the virtio spec, refer to Virtio PCI Card Specification written by Rusty Russell. +For details about the virtio spec, refer to the latest +`VIRTIO (Virtual I/O) Device Specification +`_. -As a PMD, virtio provides packet reception and transmission callbacks virtio_recv_pkts and virtio_xmit_pkts. +As a PMD, virtio provides packet reception and transmission callbacks. -In virtio_recv_pkts, index in range [vq->vq_used_cons_idx , vq->vq_ring.used->idx) in vring is available for virtio to burst out. +In Rx, packets described by the used descriptors in vring are available +for virtio to burst out. -In virtio_xmit_pkts, same index range in vring is available for virtio to clean. -Virtio will enqueue to be transmitted packets into vring, advance the vq->vq_ring.avail->idx, -and then notify the host back end if necessary. +In Tx, packets described by the used descriptors in vring are available +for virtio to clean. Virtio will enqueue to be transmitted packets into +vring, make them available to the device, and then notify the host back +end if necessary. Features and Limitations of virtio PMD -------------------------------------- @@ -201,37 +205,52 @@ The packet transmission flow is: Virtio PMD Rx/Tx Callbacks -------------------------- -Virtio driver has 4 Rx callbacks and 2 Tx callbacks. +Virtio driver has 6 Rx callbacks and 3 Tx callbacks. Rx callbacks: #. ``virtio_recv_pkts``: - Regular version without mergeable Rx buffer support. + Regular version without mergeable Rx buffer support for split virtqueue. #. ``virtio_recv_mergeable_pkts``: - Regular version with mergeable Rx buffer support. + Regular version with mergeable Rx buffer support for split virtqueue. #. ``virtio_recv_pkts_vec``: Vector version without mergeable Rx buffer support, also fixes the available - ring indexes and uses vector instructions to optimize performance. + ring indexes and uses vector instructions to optimize performance for split + virtqueue. #. ``virtio_recv_pkts_inorder``: - In-order version with mergeable and non-mergeable Rx buffer support. + In-order version with mergeable and non-mergeable Rx buffer support + for split virtqueue. + +#. ``virtio_recv_pkts_packed``: + Regular and in-order version without mergeable Rx buffer support for + packed virtqueue. + +#. ``virtio_recv_mergeable_pkts_packed``: + Regular and in-order version with mergeable Rx buffer support for packed + virtqueue. Tx callbacks: #. ``virtio_xmit_pkts``: - Regular version. + Regular version for split virtqueue. #. ``virtio_xmit_pkts_inorder``: - In-order version. + In-order version for split virtqueue. + +#. ``virtio_xmit_pkts_packed``: + Regular and in-order version for packed virtqueue. By default, the non-vector callbacks are used: -* For Rx: If mergeable Rx buffers is disabled then ``virtio_recv_pkts`` is - used; otherwise ``virtio_recv_mergeable_pkts``. +* For Rx: If mergeable Rx buffers is disabled then ``virtio_recv_pkts`` + or ``virtio_recv_pkts_packed`` will be used, otherwise + ``virtio_recv_mergeable_pkts`` or ``virtio_recv_mergeable_pkts_packed`` + will be used. -* For Tx: ``virtio_xmit_pkts``. +* For Tx: ``virtio_xmit_pkts`` or ``virtio_xmit_pkts_packed`` will be used. Vector callbacks will be used when: @@ -242,6 +261,8 @@ The corresponding callbacks are: * For Rx: ``virtio_recv_pkts_vec``. +There is no vector callbacks for packed virtqueue for now. + Example of using the vector version of the virtio poll mode driver in ``testpmd``:: @@ -250,10 +271,15 @@ Example of using the vector version of the virtio poll mode driver in In-order callbacks only work on simulated virtio user vdev. +For split virtqueue: + * For Rx: If in-order is enabled then ``virtio_recv_pkts_inorder`` is used. * For Tx: If in-order is enabled then ``virtio_xmit_pkts_inorder`` is used. +For packed virtqueue, the default callbacks already support the +in-order feature. + Interrupt mode -------------- @@ -372,3 +398,8 @@ Below devargs are supported by the virtio-user vdev: It is used to enable virtio device in-order feature. (Default: 1 (enabled)) + +#. ``packed_vq``: + + It is used to enable virtio device packed virtqueue feature. + (Default: 0 (disabled)) From patchwork Tue Aug 13 02:07:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiwei Bie X-Patchwork-Id: 57641 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C77EB1BEB1; Tue, 13 Aug 2019 04:10:03 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5ADBF1BE96; Tue, 13 Aug 2019 04:09:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 19:09:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="327540083" Received: from dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.71]) by orsmga004.jf.intel.com with ESMTP; 12 Aug 2019 19:09:55 -0700 From: Tiwei Bie To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 13 Aug 2019 10:07:30 +0800 Message-Id: <20190813020730.10038-7-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190813020730.10038-1-tiwei.bie@intel.com> References: <20190813020730.10038-1-tiwei.bie@intel.com> Subject: [dpdk-dev] [PATCH 6/6] doc: fix format for virtio guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch removes an unwanted empty line in a sentence. Fixes: 71afcefbd53e ("doc: update virtio ring size and header size") Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- doc/guides/nics/virtio.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 011954ff6..bd0116176 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -7,7 +7,6 @@ Poll Mode Driver for Emulated Virtio NIC Virtio is a para-virtualization framework initiated by IBM, and supported by KVM hypervisor. In the Data Plane Development Kit (DPDK), we provide a virtio Poll Mode Driver (PMD) as a software solution, comparing to SRIOV hardware solution, - for fast guest VM to guest VM communication and guest VM to host communication. Vhost is a kernel acceleration module for virtio qemu backend.