From patchwork Thu Jul 25 10:26:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 57089 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 838591C2F2; Thu, 25 Jul 2019 12:27:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id B82D51C2F1 for ; Thu, 25 Jul 2019 12:26:58 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6PAQbdn009313 for ; Thu, 25 Jul 2019 03:26:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=+Uvw4NbT6RvTNzd3QsaF0RKkAOaGpz7CbsjeAs9mKz8=; b=y15YU55ctT81f29SNiM2sRJ7cURcNdCuXVggptGVoxoR0VwjGO5nM5BrmVBA/hxI53cX fnHT2FKllNri7M6MjOAk5EbSS3uwp6IoiVegiD1065xLi3BrI0vPWJ9ufLG025Dbgbj2 8vKSd1UXGSSgTa855z4YZBJ89pME3v2VXkO9CKi8I3nSMcJ95vKJ26bo+WUSLV2it3Os WzxS6xkp9X8FFXMbnxc4sBUieprrxFgd0rUy3f9iX0Uxuv0d6z75r0AUJxoWyDfj3+Gj VTGoojz1WEOL/iXzBCctD5nOPJ+opYX6uNO2D/syJXHgcSOcDm0LPueHMgNRKTd9NIvO ig== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2tx61rh14n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jul 2019 03:26:57 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 03:26:56 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.51) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 03:26:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gL/ccQVuj2cFHhC6K4SPBrRc04aYibfC1NxfOxmaQ7KsB3kecMqWu18eeEdzFUZc41v1bioEX/pIqmpvk4zko4XRPNmze/m0sG5jSaRH1A9KLSQ8agFlX5BI7kb6DWi4vtEmOv5qEt5k8vLzUIL2dnL6/6anRGGcE/Bhvdfwi03hWv4IIktr7h8lPDC0KVfboLoxIhroz/0L9OqU9knogdbsNZBN/N/VHb0M1WOPD54r3zTo2Fbo4KYLrs8blvoyqt/bn4SmBQy73ZlhtPk5AUOXFM0nPuS2oOjmXFnmhM6VAoXWFrfZjUnxtsrXyBz8xMMY981Q48mcxAgl++/f/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Uvw4NbT6RvTNzd3QsaF0RKkAOaGpz7CbsjeAs9mKz8=; b=V+yvduJpj+woggIF+o/u5Wcp1jtMfAW/+XIvkQCx0OFF6W8jxw1cFEIjbeJIhWb09K4tDczb3v/7gYDbbSzmyKqCIQ/O+gyOYQtOZeqgoeS7qBNgNRhBU99SG2lcJYykxLI/tOSvG88H95RnaTx5ssKZFlKU1zMoObeZPiDp6lbPk1z6OlB+9rsVH+SYKpNZsdK4QnEcId6pElahrLg0Lfj1jpxYa9iFDG4YTrBhmqUsADfW6OQ0xHzHdtwS3Bgxc12dzSPsUJu+LRBFOJtJVZZKVB1jh7qSU758mQXaOcB5D8lQFhXrcQZCKygN0plI2IY9pHtBqj5ohEDnTaB4DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Uvw4NbT6RvTNzd3QsaF0RKkAOaGpz7CbsjeAs9mKz8=; b=OByUC2iEHAA9l/8CyyQcoq8Fdp2jpn4WUBtWrTEyxCkoMT2zpK5u1WZNYVfXl0N/E5qVBUWy2NRBs9LDSJZUrpxoxVANP+RQTgM86fHhfNVBhJRtW9Sga4W5Ia7su355trrICEpgipHYngHxRUzsGVIyawoXZoqmbJmSpS0yGFk= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB2847.namprd18.prod.outlook.com (20.179.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Thu, 25 Jul 2019 10:26:54 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2115.005; Thu, 25 Jul 2019 10:26:54 +0000 From: Harman Kalra To: Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru , Kiran Kumar Kokkilagadda CC: "dev@dpdk.org" , Harman Kalra Thread-Topic: [PATCH v2] drivers/octeontx2: fix recursive qint interrupts Thread-Index: AQHVQtN61dn6MKptXkOVZBOe0R4QKg== Date: Thu, 25 Jul 2019 10:26:54 +0000 Message-ID: <1564050397-12361-1-git-send-email-hkalra@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR01CA0162.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::32) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f62618bb-33a2-41d9-e664-08d710ea9cfa x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2847; x-ms-traffictypediagnostic: MN2PR18MB2847: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(189003)(199004)(54906003)(68736007)(305945005)(476003)(256004)(2906002)(486006)(2616005)(7736002)(110136005)(71190400001)(6436002)(14454004)(316002)(36756003)(6486002)(71200400001)(6116002)(186003)(3846002)(52116002)(99286004)(66066001)(66446008)(26005)(102836004)(53936002)(66946007)(66476007)(4326008)(86362001)(81156014)(55236004)(107886003)(64756008)(8936002)(386003)(6512007)(478600001)(25786009)(50226002)(6506007)(6636002)(8676002)(5660300002)(81166006)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2847; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qdYAaHq5ZxqqYWhKvG81cd3QoIGZLtGN+YklSp1ZXquWHBlZWu32+2APeWQJ5L3xwezXcdKssrOfB5L6MXSPqmLuOBwKCd6wkluCg6/9wCPRYRryBfpcouB0sdCOQifqmPhDH6rXFPrMEZjKizpGI2pk5//SgOjW8KVugj6u8ilj5Q4+UbUs3Wy7SWqDutH1WVKayae6D2mnomihxS4Jbr1rtLSrqWY9s/mDvb3SQZMQJlbI4M4vZrueYg5bK8f5MJDkUryXCByEdBe29IOHBRqRL9ibmiekNdv105vAugKPt1skxUkwaXPY7lYE+1hDlElt1Z7pgPQl2O511YlqR7wYhg5JFbJbulaj14ICHVFC7cW13u8dExh39T/U7BIEpPIwtYUeRB0lIAqfE2BWx7GS7XaWeIgVwkRAOzxI6aI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f62618bb-33a2-41d9-e664-08d710ea9cfa X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 10:26:54.0483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hkalra@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2847 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_04:2019-07-25,2019-07-25 signatures=0 Subject: [dpdk-dev] [PATCH v2] drivers/octeontx2: fix recursive qint interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case of QINT interrupt occurrence, SW fails to clear the QINT line resulting in recursive interrupts because currently interrupt handler gets the cause of the interrupt by reading NIX_LF_RQ[SQ/CQ/AURA/POOL]_OP_INT but does not write 1 to clear RQ[SQ/CQ/ERR]_INT field in respective NIX_LF_RQ[SQ/CQ/AURA/POOL]_OP_INT registers. Fixes: dc47ba15f645 ("net/octeontx2: handle queue specific error interrupts") Fixes: 50b95c3ea7af ("mempool/octeontx2: add NPA IRQ handler") Signed-off-by: Harman Kalra Acked-by: Jerin Jacob --- drivers/mempool/octeontx2/otx2_mempool_irq.c | 2 +- drivers/net/octeontx2/otx2_ethdev_irq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/octeontx2/otx2_mempool_irq.c b/drivers/mempool/octeontx2/otx2_mempool_irq.c index ce4104453..5fa22b961 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_irq.c +++ b/drivers/mempool/octeontx2/otx2_mempool_irq.c @@ -123,7 +123,7 @@ npa_lf_q_irq_get_and_clear(struct otx2_npa_lf *lf, uint32_t q, qint = reg & 0xff; wdata &= mask; - otx2_write64(wdata, lf->base + off); + otx2_write64(wdata | qint, lf->base + off); return qint; } diff --git a/drivers/net/octeontx2/otx2_ethdev_irq.c b/drivers/net/octeontx2/otx2_ethdev_irq.c index 9006e5c8b..2256e40b6 100644 --- a/drivers/net/octeontx2/otx2_ethdev_irq.c +++ b/drivers/net/octeontx2/otx2_ethdev_irq.c @@ -138,7 +138,7 @@ nix_lf_q_irq_get_and_clear(struct otx2_eth_dev *dev, uint16_t q, qint = reg & 0xff; wdata &= mask; - otx2_write64(wdata, dev->base + off); + otx2_write64(wdata | qint, dev->base + off); return qint; }