From patchwork Thu Jul 25 08:02:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 57067 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D99FB1C2A2; Thu, 25 Jul 2019 10:02:23 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 229231C29F for ; Thu, 25 Jul 2019 10:02:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6P7xjuF002344 for ; Thu, 25 Jul 2019 01:02:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=enDDJiAgWGScN5QGfiBTXIduFmKh86kOYsKL+tDh/l8=; b=fkUywDmZjJ1G9THtNurZ7gerJriB+9/ETi1T64np09hC8QbfiCDltT/R8eFjp6SEdReu gfG0zFgj4rMSqD0M33No+SCnaMqOuHVPIOOQ6tjdz/O3+GcJ3UW1jeeSBoTk5L4Jss8l 9Yw5qZw/+ufitoZRKnl5Hro8tujdrDN8g9MjPuw1mfnWIKH+mV/p+Rwc0qDOieyeS8+7 HXM1wWl4rVnlYT06jBXD+EvkvoG9ebfzZLxJOIm6uT1H2gHI3UTqAmxkj1VH+C1Ma6oG vUylmZdSkHRzT7kT6CQIRbVeQ++ZwLwU1lkuK60RRTf661um0M+E9eS2/C1qdR1hVapU mw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2tx61rgha4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jul 2019 01:02:21 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 01:02:20 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 01:02:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MC08LglWvJSNdeHcWjQ7kJm9wmGYkLYDpUi53ER9REvKiP3KTpDa0voRPd9bqO9T0tcbGR4FGVIQuf1qqF370+eUp9TFeFwFWg5wxio35EmH5nUvGFva9hB8mCZvtsm73dBjLw+6rq40YIOwsgVm331cBwHBG1+w6kmAWr4J2iG+kmQ5xoQfO8jBbO+UFtENGwQOIF1IVbgXqGJ2eUygPNMnwfmNsoKnO9xLYe895ZrqHGRFnfsCJkKi6ysUV1DIGSuP3X8jsUtAIfitfhu8pnHYHkrh3vsfwxaMQip3Vf+Pl8xQICHdb3LHdAnqAbUAFSUhyXtFezXbZDLgmzFOcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enDDJiAgWGScN5QGfiBTXIduFmKh86kOYsKL+tDh/l8=; b=ctRR0lGu/FkVOM87KewKruhboEQfpz2ME/gMTjhKDRVbEp/DruA4KXbtwXWIGwjUaokviRhzCb2364cyCjcb2w/R3VVkTuk0lKUPUkQ2YW+vNifL4/rYe+FBK7fiZLM77WpoMyM1YTulD7gZJnaRL8Qwczwoa+IMUV5HUFsbghL6ElMHkZWmhzp/BujV2Fb0LtQOS2Gi6Pqw6iPeNaLsempX5mjD0y1AQCnYLgc/Eq0FnhkVBaFdz+7O4izZfGEQd9vVDh0hnEVXngWnPiXzrl71nppacJaqMRZoIJQMOC6KfVFY/TACOM9ZXeHkIj/dBkYQv54kfmNSGSCIeJwH6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enDDJiAgWGScN5QGfiBTXIduFmKh86kOYsKL+tDh/l8=; b=S4TPYEmQkF9kvpX4PeCcKU2C2ZpIDa1UKzi4/i7qXeRVV7yGK8Q48aGXE44tojUrpR3oc4KGG6SLKG9xP6K8u/SukY+DkUgzlIKaoJT/KjwTOrsA0YPokigMGsBsUw8db0UaekzAXeuQfvVlWk3y2LWuTXoobqxnTF2w7x5VGGc= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB3358.namprd18.prod.outlook.com (10.255.238.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Thu, 25 Jul 2019 08:02:18 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2115.005; Thu, 25 Jul 2019 08:02:18 +0000 From: Harman Kalra To: Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru , Kiran Kumar Kokkilagadda CC: "dev@dpdk.org" , Harman Kalra Thread-Topic: [PATCH] drivers/octeontx2: fix recursive qint interrupts Thread-Index: AQHVQr9HonGdirNb/ES8IR9IZhbVsA== Date: Thu, 25 Jul 2019 08:02:18 +0000 Message-ID: <1564041699-28219-1-git-send-email-hkalra@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::26) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25962892-8173-47d0-a04b-08d710d669c8 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB3358; x-ms-traffictypediagnostic: MN2PR18MB3358: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(199004)(189003)(7736002)(86362001)(6116002)(71200400001)(71190400001)(50226002)(2616005)(476003)(3846002)(66066001)(486006)(6486002)(66946007)(66476007)(6512007)(66556008)(102836004)(66446008)(6506007)(64756008)(52116002)(55236004)(386003)(8936002)(68736007)(186003)(6436002)(81166006)(478600001)(26005)(110136005)(99286004)(53936002)(6636002)(54906003)(316002)(4326008)(5660300002)(107886003)(256004)(14454004)(36756003)(2906002)(8676002)(305945005)(81156014)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3358; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WHD9R87RMjvDJCsOjZGyHrI8SJaugxhvy/g/qthBi1EW8fjg3jbGstYiRvkXzn6a4FnjTTmQ2EI38NLAHwYccbxRFdjjE7Hp0A5++vLF0FYfgRpWfsaMdKm63B3tTGDk8hBRHIr8P6ZFjMW7d0zvYl/O1qH6RI7FpX7A2mtYSn9IV3h7hZfdTBv2GGF5yDsDGGIu/QXS3TiMJ1HQBzfEsU6GxfzEXkRLdgW79tV99NF3C10Ahg2dbtZh2g32NRyNGCABW3XyUUE7jpJXzzEyJiAQvSgzXIiTXiJ51CW6i4d8e58zMJLvHlJ5t7knqXf7Iin3GN0larMxlEFJq64GuKmy4SjQZ9RWbesA2ICTnVEEdjxcZI7FF1uN6oqfl9YKXzw0RnrAqMZ0+mW1t1V53QLvWYAphxxedfbr3Y/mpjg= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 25962892-8173-47d0-a04b-08d710d669c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 08:02:18.2974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hkalra@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3358 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_04:2019-07-25,2019-07-25 signatures=0 Subject: [dpdk-dev] [PATCH] drivers/octeontx2: fix recursive qint interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case of QINT interrupt occurrence, SW fails to clear the QINT line resulting in recursive interrupts because currently interrupt handler gets the cause of the interrupt by reading NIX_LF_RQ[SQ/CQ/AURA/POOL]_OP_INT but does not write 1 to clear RQ[SQ/CQ/ERR]_INT field in respective NIX_LF_RQ[SQ/CQ/AURA/POOL]_OP_INT registers. Signed-off-by: Harman Kalra --- drivers/mempool/octeontx2/otx2_mempool_irq.c | 2 +- drivers/net/octeontx2/otx2_ethdev_irq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/octeontx2/otx2_mempool_irq.c b/drivers/mempool/octeontx2/otx2_mempool_irq.c index ce4104453..5fa22b961 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_irq.c +++ b/drivers/mempool/octeontx2/otx2_mempool_irq.c @@ -123,7 +123,7 @@ npa_lf_q_irq_get_and_clear(struct otx2_npa_lf *lf, uint32_t q, qint = reg & 0xff; wdata &= mask; - otx2_write64(wdata, lf->base + off); + otx2_write64(wdata | qint, lf->base + off); return qint; } diff --git a/drivers/net/octeontx2/otx2_ethdev_irq.c b/drivers/net/octeontx2/otx2_ethdev_irq.c index 9006e5c8b..2256e40b6 100644 --- a/drivers/net/octeontx2/otx2_ethdev_irq.c +++ b/drivers/net/octeontx2/otx2_ethdev_irq.c @@ -138,7 +138,7 @@ nix_lf_q_irq_get_and_clear(struct otx2_eth_dev *dev, uint16_t q, qint = reg & 0xff; wdata &= mask; - otx2_write64(wdata, dev->base + off); + otx2_write64(wdata | qint, dev->base + off); return qint; }