From patchwork Thu Jul 18 06:51:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 56703 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 979F22BC7; Thu, 18 Jul 2019 08:51:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D938D28EE for ; Thu, 18 Jul 2019 08:51:16 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6I6oU2e024711 for ; Wed, 17 Jul 2019 23:51:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=0poqJJj+lrr6RreSuWDwsA+reloNbo4JNEHyTPWTa8o=; b=nigEE98I0+JAwPe1Jp1QvpSFA5n7XxlrHFuRc+o7zfL6+eNAcEKUPbSw9JiO1Ww/wQJj ckNFe91lviopPnbErI1f6ge9C4MhtIGZ8xcotzgy76WTlvtSglTq8hlG1FWifIe8Gus7 cTgWRhkYWCWIQAjn7tjwe/Kj8wmR/yYu770ujHlGWk/Y11NSAWHx5zNg99nWqiNzncwg z19S12zl6HJDiaITEu7f814Ykf5WB8KV1gHTRtwTAAnKtn5w+eg3gzkxSfktRbXYZ/Sx eMYKXpHfvNFFhdaNcwkBRtM6MGDtsJWNeRK49wD9no23c6xu13BZDWoHl6c1v4eoOmIb xA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vkkph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 17 Jul 2019 23:51:16 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 17 Jul 2019 23:51:14 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Wed, 17 Jul 2019 23:51:14 -0700 Received: from BG-LT7430.marvell.com (bg-lt7430.marvell.com [10.28.10.255]) by maili.marvell.com (Postfix) with ESMTP id 1F8783F703F; Wed, 17 Jul 2019 23:51:12 -0700 (PDT) From: To: , Nithin Dabilpuram , "Vamsi Attunuru" CC: , Pavan Nikhilesh Date: Thu, 18 Jul 2019 12:21:11 +0530 Message-ID: <20190718065111.1766-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190717184013.1072-1-pbhagavatula@marvell.com> References: <20190717184013.1072-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-18_02:2019-07-18,2019-07-18 signatures=0 Subject: [dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Since direct register access is used in npa_lf_aura_op_alloc_bulk() use __rte_noinline instead of __rte_always_inline to preserve ABI. Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined differently which may lead to undefined behaviour due to handcoded asm. Fixes: 29893042c29d ("mempool/octeontx2: fix clang build for arm64") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c index a60a77a4e..ff63be567 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c @@ -54,7 +54,7 @@ npa_lf_aura_op_search_alloc(const int64_t wdata, int64_t * const addr, return 0; } -static __rte_always_inline int +static __rte_noinline int npa_lf_aura_op_alloc_bulk(const int64_t wdata, int64_t * const addr, unsigned int n, void **obj_table) {