From patchwork Mon Jul 15 23:41:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 56464 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E9462C18; Tue, 16 Jul 2019 01:41:48 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 19B482BF5 for ; Tue, 16 Jul 2019 01:41:47 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id u17so8459137pgi.6 for ; Mon, 15 Jul 2019 16:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TZQJvPTbpRFT+Dy2aelLp+km3z0bj0bVmepSsHuInEo=; b=uEX5571Sxg4DGgEYhdk1IaJJ0r60nNKxNvOv+TaFARXF8XhUlywhGVUaPR2sH6vI2i RT2r7YgrkjPNoeoYlc0j6gwxgppaCtDzr852417Cc65R3x3PZH5D6XH4H6GnKC5RsH0C kWm0AMS+U9tb1eJN8YMVbupYvDZzFpI4EYw4xonfLWGWjSLOFyP2B9v3V7Dd9/64sbi0 Awa29OgmPxNpoJQjRTH55x2FHhWbglnnUphhsoh+ovkyW+9uRIGip8zyM2EpHxT3hUM2 w8epKWyaqn6K+yhlEFBOf195GA8Ek2lMa/MCPIeFvEVtey70+7OtEwtBXWGHbxAPcwUA 5sTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TZQJvPTbpRFT+Dy2aelLp+km3z0bj0bVmepSsHuInEo=; b=aTS9xut3MyOx+/BEZINrckj26byfETVCgdjeNV1+IbmjI5pM7Vk7+pePvM/bn4fNTj 1kko8Z9oszrUwq52E398WAsK+i10VwN0ofa3duJ1YMKVfQRJgYfziuw08s25VHrpZjoX umGSDnciCrAgiNiljddA3m3h2rz5x6w2K/cNlhrCMycAPniKCKiaBKG4MTeZ8o8C/JWs /0T/hZgXPAHy/91+5LJyDULZjXxVGG9chyHYWcdGDgyEOoxMCsOGKHvp4NF+CPHV5eUG nZGmyrmn8TLp0T2JXKcYMNHUwnYZJqFR6jZbPxUlV+vDTA7p40B3K5fOhoJ6tAXbkXyk OrbQ== X-Gm-Message-State: APjAAAUViaxGr1dewaewVbbZu7zHCx+PUfzvpK9R+TwUHaaaLbRpADlL TT/+NrIMJFwJCW+eEMfrGmlvAkNE X-Google-Smtp-Source: APXvYqxAe3F2f9N08lV0CUBT3CsITZdFdGx6dcgV7tablyQ2SIAInjqlHSkJ3G/tf4a83Tjfd7UocA== X-Received: by 2002:a17:90a:3590:: with SMTP id r16mr32513059pjb.44.1563234106175; Mon, 15 Jul 2019 16:41:46 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z2sm16509347pgg.58.2019.07.15.16.41.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 15 Jul 2019 16:41:45 -0700 (PDT) From: Stephen Hemminger To: thomas@monjalon.net Cc: dev@dpdk.org, Stephen Hemminger , stable@dpdk.org Date: Mon, 15 Jul 2019 16:41:36 -0700 Message-Id: <20190715234136.3526-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If DPDK is built as a shared library, then any application linked with rte.app.mk will not find any PCI devices. When the application is started no ethernet devices are found. This is because the link order of libraries on the command line matters. And PCI is before EAL. That causes there to be no dependency on PCI so linker ignores linking the library. Swapping the order fixes this. Fixes: c752998b5e2e ("pci: introduce library and driver") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- mk/rte.app.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index a277c808ed8e..470b92e4d73e 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -90,8 +90,8 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) += -lrte_stack _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += -lrte_mempool_octeontx2 _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring -_LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal +_LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE) += -lrte_cmdline _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER) += -lrte_reorder _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched