From patchwork Fri Jul 12 08:32:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "A.McLoughlin" X-Patchwork-Id: 56386 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AF131B9BD; Fri, 12 Jul 2019 10:33:03 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 49D581B9A7; Fri, 12 Jul 2019 10:33:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2019 01:32:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,481,1557212400"; d="scan'208";a="193684050" Received: from silpixa00389822.ir.intel.com (HELO silpixa00389822.ger.corp.intel.com) ([10.237.223.42]) by fmsmga002.fm.intel.com with ESMTP; 12 Jul 2019 01:32:57 -0700 From: "A.McLoughlin" To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: dev@dpdk.org, "A.McLoughlin" , david.marchand@redhat.com, stable@dpdk.org Date: Fri, 12 Jul 2019 09:32:21 +0100 Message-Id: <20190712083221.4987-1-aideen.mcloughlin@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The 'Accumulated forward statistics for all ports' incorrectly displayed double the actual value for 'total_tx_dropped'. This was because 2 lines in the same function both incremented total_tx_dropped every time a packet was dropped. I removed one of these lines to fix this issue. Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on demand") Cc: david.marchand@redhat.com Cc: stable@dpdk.org Signed-off-by: A.McLoughlin Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 3ed3523b7..c41bada50 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1555,7 +1555,6 @@ fwd_stats_display(void) total_recv += stats.ipackets; total_xmit += stats.opackets; total_rx_dropped += stats.imissed; - total_tx_dropped += ports_stats[pt_id].tx_dropped; total_tx_dropped += stats.oerrors; total_rx_nombuf += stats.rx_nombuf;