From patchwork Wed Jul 11 06:38:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "De Lara Guarch, Pablo" X-Patchwork-Id: 42884 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D2711B5C1; Wed, 11 Jul 2018 16:44:43 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 09B021B50F; Wed, 11 Jul 2018 16:44:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 07:44:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="244846950" Received: from silpixa00399466.ir.intel.com (HELO silpixa00399466.ger.corp.intel.com) ([10.237.223.220]) by fmsmga006.fm.intel.com with ESMTP; 11 Jul 2018 07:44:25 -0700 From: Pablo de Lara To: lee.daly@intel.com Cc: dev@dpdk.org, Pablo de Lara , stable@dpdk.org Date: Wed, 11 Jul 2018 07:38:44 +0100 Message-Id: <20180711063846.47189-1-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.14.4 Subject: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is a naming convention for logtypes of PMDs: "pmd.driverType.driverName". Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal". Fixes: 490e725b95b2 ("compress/isal: add device init and de-init") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- drivers/compress/isal/isal_compress_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c index 0f025a3bf..a3b28f29b 100644 --- a/drivers/compress/isal/isal_compress_pmd.c +++ b/drivers/compress/isal/isal_compress_pmd.c @@ -465,7 +465,7 @@ RTE_INIT(isal_init_log); static void isal_init_log(void) { - isal_logtype_driver = rte_log_register("comp_isal"); + isal_logtype_driver = rte_log_register("pmd.compress.isal"); if (isal_logtype_driver >= 0) rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO); } From patchwork Wed Jul 11 06:38:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "De Lara Guarch, Pablo" X-Patchwork-Id: 42882 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA37B1B562; Wed, 11 Jul 2018 16:44:38 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8532C1B535; Wed, 11 Jul 2018 16:44:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 07:44:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="244846952" Received: from silpixa00399466.ir.intel.com (HELO silpixa00399466.ger.corp.intel.com) ([10.237.223.220]) by fmsmga006.fm.intel.com with ESMTP; 11 Jul 2018 07:44:26 -0700 From: Pablo de Lara To: lee.daly@intel.com Cc: dev@dpdk.org, Pablo de Lara , stable@dpdk.org Date: Wed, 11 Jul 2018 07:38:45 +0100 Message-Id: <20180711063846.47189-2-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180711063846.47189-1-pablo.de.lara.guarch@intel.com> References: <20180711063846.47189-1-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- drivers/compress/isal/isal_compress_pmd_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c index 585f22802..0738fb9c4 100644 --- a/drivers/compress/isal/isal_compress_pmd_ops.c +++ b/drivers/compress/isal/isal_compress_pmd_ops.c @@ -167,8 +167,8 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id) if (qp->state != NULL) rte_free(qp->state); - if (dev->data->queue_pairs[qp_id] != NULL) - rte_free(dev->data->queue_pairs[qp_id]); + rte_free(qp); + dev->data->queue_pairs[qp_id] = NULL; return 0; } From patchwork Wed Jul 11 06:38:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "De Lara Guarch, Pablo" X-Patchwork-Id: 42883 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 476CE1B5B8; Wed, 11 Jul 2018 16:44:41 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 565191B535; Wed, 11 Jul 2018 16:44:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 07:44:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="244846954" Received: from silpixa00399466.ir.intel.com (HELO silpixa00399466.ger.corp.intel.com) ([10.237.223.220]) by fmsmga006.fm.intel.com with ESMTP; 11 Jul 2018 07:44:27 -0700 From: Pablo de Lara To: lee.daly@intel.com Cc: dev@dpdk.org, Pablo de Lara , stable@dpdk.org Date: Wed, 11 Jul 2018 07:38:46 +0100 Message-Id: <20180711063846.47189-3-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180711063846.47189-1-pablo.de.lara.guarch@intel.com> References: <20180711063846.47189-1-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Processed operations ring is created for each queue pair, but it was not being freed when the queue pair was released. Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- drivers/compress/isal/isal_compress_pmd_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c index 0738fb9c4..c61acd40c 100644 --- a/drivers/compress/isal/isal_compress_pmd_ops.c +++ b/drivers/compress/isal/isal_compress_pmd_ops.c @@ -167,6 +167,9 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id) if (qp->state != NULL) rte_free(qp->state); + if (qp->processed_pkts != NULL) + rte_ring_free(qp->processed_pkts); + rte_free(qp); dev->data->queue_pairs[qp_id] = NULL;