From patchwork Thu Jun 20 16:42:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Eads, Gage" X-Patchwork-Id: 55129 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2487E1D410; Thu, 20 Jun 2019 18:41:49 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2BC671D40E for ; Thu, 20 Jun 2019 18:41:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 09:41:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,397,1557212400"; d="scan'208";a="150990479" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by orsmga007.jf.intel.com with ESMTP; 20 Jun 2019 09:41:45 -0700 From: Gage Eads To: dev@dpdk.org Cc: jerinj@marvell.com, harry.van.haaren@intel.com, nikhil.rao@intel.com, erik.g.carrillo@intel.com, nhorman@tuxdriver.com Date: Thu, 20 Jun 2019 11:42:06 -0500 Message-Id: <20190620164206.3972-1-gage.eads@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] eal: promote some service core functions to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK 18.08. They can be considered non-experimental for the 19.08 release. rte_service_may_be_active() is used by eventdev and the sw PMD, and this commit allows them to not need any experimental API. Signed-off-by: Gage Eads --- drivers/event/sw/Makefile | 1 - drivers/event/sw/meson.build | 1 - lib/librte_eal/common/include/rte_service.h | 15 +++------------ lib/librte_eal/common/rte_service.c | 6 +++--- lib/librte_eal/rte_eal_version.map | 6 +++--- lib/librte_eventdev/Makefile | 1 - lib/librte_eventdev/meson.build | 1 - 7 files changed, 9 insertions(+), 22 deletions(-) diff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile index 81236a392..c6600e836 100644 --- a/drivers/event/sw/Makefile +++ b/drivers/event/sw/Makefile @@ -7,7 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB = librte_pmd_sw_event.a # build flags -CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) # for older GCC versions, allow us to initialize an event using diff --git a/drivers/event/sw/meson.build b/drivers/event/sw/meson.build index 30d221647..985012219 100644 --- a/drivers/event/sw/meson.build +++ b/drivers/event/sw/meson.build @@ -1,7 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -allow_experimental_apis = true sources = files('sw_evdev_scheduler.c', 'sw_evdev_selftest.c', 'sw_evdev_worker.c', diff --git a/lib/librte_eal/common/include/rte_service.h b/lib/librte_eal/common/include/rte_service.h index bf25aec35..d8701dd4c 100644 --- a/lib/librte_eal/common/include/rte_service.h +++ b/lib/librte_eal/common/include/rte_service.h @@ -162,9 +162,6 @@ int32_t rte_service_runstate_set(uint32_t id, uint32_t runstate); int32_t rte_service_runstate_get(uint32_t id); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * This function returns whether the service may be currently executing on * at least one lcore, or definitely is not. This function can be used to * determine if, after setting the service runstate to stopped, the service @@ -178,7 +175,7 @@ int32_t rte_service_runstate_get(uint32_t id); * @retval 0 Service is not running on any lcore * @retval -EINVAL Invalid service id */ -int32_t __rte_experimental +int32_t rte_service_may_be_active(uint32_t id); /** @@ -389,9 +386,6 @@ int32_t rte_service_attr_reset_all(uint32_t id); #define RTE_SERVICE_LCORE_ATTR_LOOPS 0 /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get an attribute from a service core. * * @param lcore Id of the service core. @@ -401,14 +395,11 @@ int32_t rte_service_attr_reset_all(uint32_t id); * -EINVAL Invalid lcore, attr_id or attr_value was NULL. * -ENOTSUP lcore is not a service core. */ -int32_t __rte_experimental +int32_t rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id, uint64_t *attr_value); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Reset all attribute values of a service core. * * @param lcore The service core to reset all the statistics of @@ -416,7 +407,7 @@ rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id, * -EINVAL Invalid service id provided * -ENOTSUP lcore is not a service core. */ -int32_t __rte_experimental +int32_t rte_service_lcore_attr_reset_all(uint32_t lcore); #ifdef __cplusplus diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 5f75e5a53..c3653ebae 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -378,7 +378,7 @@ service_run(uint32_t i, int lcore, struct core_state *cs, uint64_t service_mask) return 0; } -int32_t __rte_experimental +int32_t rte_service_may_be_active(uint32_t id) { uint32_t ids[RTE_MAX_LCORE] = {0}; @@ -754,7 +754,7 @@ rte_service_attr_get(uint32_t id, uint32_t attr_id, uint64_t *attr_value) } } -int32_t __rte_experimental +int32_t rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id, uint64_t *attr_value) { @@ -814,7 +814,7 @@ rte_service_attr_reset_all(uint32_t id) return 0; } -int32_t __rte_experimental +int32_t rte_service_lcore_attr_reset_all(uint32_t lcore) { struct core_state *cs; diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index 824edf0ff..fc26b9503 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -292,6 +292,9 @@ DPDK_19.08 { rte_lcore_index; rte_lcore_to_socket_id; + rte_service_lcore_attr_get; + rte_service_lcore_attr_reset_all; + rte_service_may_be_active; } DPDK_19.05; @@ -383,9 +386,6 @@ EXPERIMENTAL { rte_mp_sendmsg; rte_option_register; rte_realloc_socket; - rte_service_lcore_attr_get; - rte_service_lcore_attr_reset_all; - rte_service_may_be_active; # added in 19.08 rte_lcore_cpuset; diff --git a/lib/librte_eventdev/Makefile b/lib/librte_eventdev/Makefile index 53079f4c2..fdaec7d06 100644 --- a/lib/librte_eventdev/Makefile +++ b/lib/librte_eventdev/Makefile @@ -11,7 +11,6 @@ LIB = librte_eventdev.a LIBABIVER := 6 # build flags -CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) ifeq ($(CONFIG_RTE_EXEC_ENV_LINUX),y) diff --git a/lib/librte_eventdev/meson.build b/lib/librte_eventdev/meson.build index 6cfe60e1f..f623d74f8 100644 --- a/lib/librte_eventdev/meson.build +++ b/lib/librte_eventdev/meson.build @@ -2,7 +2,6 @@ # Copyright(c) 2017 Intel Corporation version = 6 -allow_experimental_apis = true if is_linux cflags += '-DLINUX'