From patchwork Wed Jul 11 06:07:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42780 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 749E91B463; Wed, 11 Jul 2018 08:08:05 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0041.outbound.protection.outlook.com [104.47.34.41]) by dpdk.org (Postfix) with ESMTP id C5F6D1B45B for ; Wed, 11 Jul 2018 08:08:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DsppX8hlY+yGSEn/zFUhXFjPO3/YnZVWs5guX5URqBA=; b=g4FLCa8RzjOi/HT6aG4+QsWCbrYzyp718CKOVOoXOhi4lIImR634JTSo8/DdJX2ze/S8zU8pvxxXR926OCYYwWGsiDKA61hw561yStX7HL8yL3l2pn+4K9B1tLrev2QTmZsherONQxhb5osytTReR0hq9J1bV3l/CwRpzcoI0qI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:00 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:17 +0530 Message-Id: <1531289248-20025-2-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3d3833e-696f-4ec7-0018-08d5e6f4a90d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:DFq2ZTfIabmMwc9z7FYFBts90m/eCgEJpIkjjRaZb56Gh7cRLTnoZJy17vME3FynezwFh82EpfHgkez7QYexPx9a4/QCo1juyg4g1eNRCgvXafHVdn5ZlQPNRiB1fPSgdlQ93fQEEjqZHy0eOgn6DJrfshMs8XIZ1I75dlrOtceK3m3OFe26O5s3phca8KwcDz1NZMcSsiuda+zEPbnRcJXMZ4WNgAdkNSpe/U2YNzQsKprKnjjYz8i30PLXiaj6; 25:5NVP88hSBmMPnZdYUY2ILEAngm6H6nzF88jnYvyhWfiweTZRRg38XxjXYHJmwNWcxF4E5hhy5NEou/uxSsCSUhyKpqHTso22MqHSNLL3+oEmRo2v5uQNNxIXlgerV6A4HIy13y48wjJkxxwBnOK6T53ZoKxuYlKvgW+d6JeAZKzPLZS2Ej023RiLTPHg3BZr5TvCEXibPcTMYKJCHIEtwxs1ftpYzEyvr9Qq0T0PnWFMG5cSiPCzuH25h0P9cTB00b/obSZi8LSeRBmjnD3eqhGqD6oLI7MXg+QZWP/P7/LTRN5bkp1JAZ5mWleH0wCcqUKLQeWbfEtlImhsIdXYbg==; 31:g7GVKDcouksWW/np1eb9g70OAbIaVEAlvd1XD1m/38aoM8xCa0gUy7u/AHbKBHuo/lhcmIgenOfM78DoSmW9uHrfn7ZRQCuGBbvb4q6o2xUUjxD+IR1CVqJ/qnUwpb2YHv+D+iPgZN6BNkC0tpP7k1+kg6BL41CcvhRXeWy4WLsXTWvX3Fo4rv7oSdHeKEgmzN9f70RL/PTVj/pg3yh+Js1BQdMeqx7zSCWlR95hR+E= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:CcDwC7R7iW3LIOpbZ0CDAc/SZ91dFzwHOoxFdh1uT5YQELSaI4SPv9Bowen0hqhUaWsTzF+ZwAfhWoad9ZwivQ9JVLGS1pQM19c4MzK/AG0pDjeNOSn+OVrCwg9grGGCwU40Hw9xj9ke7XTg1C/U10GBxuHcjXNnVXslAqZ2c5Wc3rwBAcbak7CJlY6v0+TFm96sib1uasMCg/mKjXiE3ISSaqCI0Ig8VWFAbcvF47k3B+bWVG/jpk+TPaBn6PboaNw5pg6QSuqU8YA1L28arh5Z1Pf03hsQOk6mLx8zaZsMeDEfHEfD6uFUqelKQxYAMY6FadY+Z37aQ9HkktTH6tQi6k65i5Kiw3fgU9aMqTnt+o+FITWrXoKqbRn7nsq0+FHTfShwMMd8aETmdzWoqe3H5dqQ9Y28jh+7bf0CYaX2maKG/dee5B/3G2gwIAG9HYx8KxD/n2xS++KWXcf1QtJkJa0u1+F3wZmeWUt4XdgaHPt4UZ33FvcmFx5gwY64lIOiUDOwpbnonZL7ovqO1hAzUJ5QjB0tiJ6mL0BO8n/Rs7RoIKYiF9vAir2dSDIWsKfAau4XOt0iFbJZSP/dPEYS/+sCTzwha35EaEQZXtk=; 4:9AsDwwf22TmHaXOGW53P173lHt9mYMxp3YgeENVjhKjvOLz8ACZwGNENQ2qvnGISD4wh//TQ/R8FZmw6Kl0C6ZD7dAXvgjqLxjNS4ofi3+beIZBvm+LG9r8/MaA+t7Mv5D3z6OPNAS1YPBhYnR9SWivTgBx0iylc6FQ+DFuaPm6jk7RMEMAzLGxiYdVL5eX3s/x3iuvGrdQHoOXUt6yAxllr1nfjPluRjhughT3GY2AexVCa2N8LmNC+iPLvdQ/s7YPYyuUhS4LcQstJM0PeCw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(575784001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:unK1kfdbF6rCJOZ1v+B95UXoSYDAyy1/62X74U5H8?= LJMYM/J9tevuS35duexPgO8cxtS5QGTf5wE59YLAbZ8xIRlT6L8N2Fvzjh6bh1KpJRFbRw1Lfgulumi7fUl74K1SptHuafTOj5ThVyqJPgabvMHTgPgufuLsJ5b3zp80s2tq9LwW6o7MLEl+J0PAaimdq/xwTOdFRgSsB5IgmUVcO41oLyX8oibU3IhcaaTHkY0tHkYdV8by3gn9I3Ty59geEWkK4GohJqHmIqYipOZy1Qua4i8qDJsJkx1b0zOcsz6rDIgPhkxOn41zBJvVDbtBMWhHToWVWBosKDYRQUxZF2OQTLXyeShqBR/o0/3zv3xIdlKPvtuC2Q2qCjdAfmpamAsn/5o6HItSOK8iVZjEWUdjCW0rZGZiJ04G/EQmL7AJ9kY4UrGqX+XJ2TDu6z0VpuF6BU4BorLTleeNfezpx9MIZ1iy0c6YUsfXG7255IGOj/e3z1piynQVtpP3zZQZ+kZaSxnGDkps1tsbtIjANCF1YIgn6J0tp/r6rDw3smvPDvFv/8nr1cyiEkpujYQZKznxQOG5EgvNdtrQI6YGjMHDhIpo7kBTrklqrV4xhP4xCk+DPZyOS+lvpZMkry6wI12qXA6JFMmaKcfZEY8annml9L2s9W20xoCtASxvIR4mUOqNgC47qM8ymBaLRZ3KO5DlzxYJjgcEHMMAwBOF5mqKJC7YEc8ZNPbysoDcQslRghePJwsirCnX5tIBaG0Df6l3Tx+n4/Uq0zCZ6P2FkAakPoEnnE7UMrsHtEsdTcWrA/iNA+231UJLmpG1VSBfgEv2i0i6kGi4qL9bAlKdAh+rV8DbGOB9EFX6IhRk8kl1Nj2R/JHhRRe2uEcdptLNN/oSvE0hXNmSykj6agPCqbLTUVxKUPU8rczJvNTsPwrrfcpRgoR4uxgjXKXeTitZ9/XpEsgYPmMH/gV8KwkKVMEQJdZxuNOz+RlBxvUOjlC8ME4AjiBZNwQmj5WWxvVmIdYibOIbMUKoMFpgGSXb/eUo8cO0XerVSowlOqV1gnR0Z0Z6XDKyv6+TsoiFqCxfsUzV6VvVjMYoufoa9/8eCmUufr/IJjSWT4ldu+YklxmyQBtdatL8TFr4S1uHA/HvGbjm1cvmiYme40NYAr4zxxGnQMwtZ8i6EgZj0yXloQb3RH0WQzImXsmKpt+k6tepv4qyiu8pHu/LArFKom1rMfIHYp77egwPT8EIyIjwt4vXh+gJjgniKoyx3AEdGD1 X-Microsoft-Antispam-Message-Info: UXuhK7ib55CGloHl98Aze3x6qIX5rhiS87Lx5raGpKNnB2fSHOgh5VN5amk4AeNITHv0gbsrPC+s4Hc2QXrb+ckmAHPn5uh0SfOROEKrn5sz6yXJoPyX9wcuRGaZA2XI0U4ic8smBvAHm9OUulJsgjHsM7locCBbBVXDUzDGtQNj+6WpLWsQsaWvgZjFiPlwiGfOWqUcNPflibKA0B4aRDA8kJ4W38lQL1e1jHe9g/5SHPX6s4V1X4wmisW141YS+RPaZuJ/wYq38Uz8spm6XL7btM84WFuLI8R2MD9gEQG0S6z54E5I3yp+bgQqGZ62t9+ISs1A/6BR+aRBLvD0CxRrNDPcXiObqcbLsMUJFFc= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:aV9JMytj2pGTbVDmGGo9iWb1pACo1kiC71bV9w6xGWBVBRFdU1mwUm1y/s44GwOFlEPIXw/NTwUwYhm9UEtdyxy8+7sHP/qwoDIrkrc9LQeZ9y/9tqbyI1txgN4zpHhu3SYSngG60/Z2HNv0s6phZRVdzIaZoslsXKF3SU8dXtyBFELtExhsxchU77V4fEeh4Fujd5z4qnIkms4Vck38PrY/M/IA7YTrdM2eyPdCXJCPIv/HsespH0Of6ZwHbzmTHg+W+gtXgRTN/aGVwU8g0qoTGEGjrnbTqEerDlblr+QplcTypOBgQMdUMbvWVDogMozoyNZyUC2j3DuzlwE56FQIu8Kb2Kw9hC96cXeyNsWCMlmCSsH1h4nnRnh34Ur1b0nsgJpAgzcRxs9KpjMm7abiFMtEWR1GZiAGFLBKPWrdV6R8le3reMBCRSWX1RjCmNPsP2zJVDGGQqkttdsYkw==; 5:gqIRW2i84EsPo0+Akvdz0TPScUpgK+umdCsZY6aVxBHyNZGLJiXpDXHHjkSfeDrHRYmk/2nEulvU7WR2Pv03tRz2IsnyIjLT7FCgHfjxLrJmnpdrRJa14Tr/peyURZoB/pkaOoHwQ/JPXlm9CT+TRmeKTgxTzcwTHIujHy5Db6Y=; 24:DTGoXS6+dnUMqhiFthI/PwUbuvpQSZ2jIzMqqn3d21L+ueVibWGkG+jtUwlx7o2tdhjnFBF+olizoed/Bj+TP0i3AF/weePS38q82FmUlJw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:xxaUyCtxCYyveDBwzbz/U0oqAJqL00IQb8f/+4A1SrAru+2WukUA7opua1EvIXeIRTKth+rgb1xH+HsMOUu1o/JwvduqfYTSAaCL4kiDLr9QHsBzd3Fx++CtogSLSNHB4ICL9JjZFSeyGqWgbp5NhKXYWwNpm9R8GFwQM8U+JTN/nYks2MQbbYdivJjFPNCeUy65b3dhbCP5PgusJBjx+1LljsYRSpUaAYCxZmjuvSiZiGE8/DyMS2aNDZ8mGRwA X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:00.7590 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3d3833e-696f-4ec7-0018-08d5e6f4a90d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 01/12] examples/l2fwd: move macro definitions to common header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Anoob Joseph --- v2: * Merged the patch which was adding the common header v1: * Retaining Intel license with copied code examples/l2fwd/l2fwd_common.h | 25 +++++++++++++++++++++++++ examples/l2fwd/main.c | 16 ++-------------- 2 files changed, 27 insertions(+), 14 deletions(-) create mode 100644 examples/l2fwd/l2fwd_common.h diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h new file mode 100644 index 0000000..fceb0c3 --- /dev/null +++ b/examples/l2fwd/l2fwd_common.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2010-2016 Intel Corporation + * Copyright(c) 2018 Cavium, Inc + */ +#ifndef _L2FWD_COMMON_H_ +#define _L2FWD_COMMON_H_ + +#define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1 + +#define MAX_PKT_BURST 32 +#define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ +#define MEMPOOL_CACHE_SIZE 256 + +/* + * Configurable number of RX/TX ring descriptors + */ +#define RTE_TEST_RX_DESC_DEFAULT 1024 +#define RTE_TEST_TX_DESC_DEFAULT 1024 + +#define MAX_RX_QUEUE_PER_LCORE 16 +#define MAX_TX_QUEUE_PER_PORT 16 + +#define MAX_TIMER_PERIOD 86400 /* 1 day max */ + +#endif /* _L2FWD_COMMON_H_ */ diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 6908435..9f873c7 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -39,22 +39,13 @@ #include #include +#include "l2fwd_common.h" + static volatile bool force_quit; /* MAC updating enabled by default */ static int mac_updating = 1; -#define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1 - -#define MAX_PKT_BURST 32 -#define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ -#define MEMPOOL_CACHE_SIZE 256 - -/* - * Configurable number of RX/TX ring descriptors - */ -#define RTE_TEST_RX_DESC_DEFAULT 1024 -#define RTE_TEST_TX_DESC_DEFAULT 1024 static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; @@ -69,8 +60,6 @@ static uint32_t l2fwd_dst_ports[RTE_MAX_ETHPORTS]; static unsigned int l2fwd_rx_queue_per_lcore = 1; -#define MAX_RX_QUEUE_PER_LCORE 16 -#define MAX_TX_QUEUE_PER_PORT 16 struct lcore_queue_conf { unsigned n_rx_port; unsigned rx_port_list[MAX_RX_QUEUE_PER_LCORE]; @@ -100,7 +89,6 @@ struct l2fwd_port_statistics { } __rte_cache_aligned; struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS]; -#define MAX_TIMER_PERIOD 86400 /* 1 day max */ /* A tsc-based timer responsible for triggering statistics printout */ static uint64_t timer_period = 10; /* default period is 10 seconds */ From patchwork Wed Jul 11 06:07:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42781 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79E881B481; Wed, 11 Jul 2018 08:08:08 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0088.outbound.protection.outlook.com [104.47.36.88]) by dpdk.org (Postfix) with ESMTP id 33AEB1B46D for ; Wed, 11 Jul 2018 08:08:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VGQoASB3h4xiHsXJsx7zUGKaGa19P6Llsjc5XRlpg/c=; b=VGYsgm4x5EZHbL4BXewAV4UzLmIlGMs8Ty837LNoSv1eoELexrO1cPtwkzNAlA7Ze0UufImoGOwsIVB4NjZyjJvpw6k8VyDrf2jcAJa61GSBKZxvC2qy8+LWc6RKaVuPjfxkLL+seeWx7TNBdUAdKTc1oPviqzvUEZtubQ6KDQw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:04 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:19 +0530 Message-Id: <1531289248-20025-4-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bae1a8d5-d9be-44fa-adb0-08d5e6f4ab22 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:V1ux87tqyllOzkbdevrSUfyyYS5AwHn4qLAqx/cYCdo0qdOfgPQDmGI8PAA4WeL0a8a8kR912Casp+sg98zG+TkvoMFYtZDeBQlp33BwHscsh/rPBMQuxfMehJES43jBT5LqcmWuMtMdPxF6HyaKmgDjY2q/9EPXl6b7qq3EmU4spnNW9cE8H5/f0ENSG/lQPgXjxTIxCA7Xwj2bD9C5qtFNGqqjR2v12DuYujRBgVkBtsMAsPAvm3MFkVYP4evG; 25:/I/DMjqLiVhb7clFi+80K2e2tguzmVluSGWpq3MUgYSgDm5b2Sf2EpFLJXaOOFc+UjLbL6ABvDyL4CEBdAViA3yyojLZrpuy/qY1kJj9FMPiWPcLY/e5PTMFNiJ5y3TPk1kSPO6V0AWnE4I7QY7H6vCYn5B0rE2lFl3nprLIEk8hpExiL+cvLoqD/NwIm1JU6mj/KpSjzt2Td33fGEd4+u6Dsomf2AvNehncebpMyRgHfz7z4HFhi4zrahwTkvJ6CV9u3jlzPmD/VSSFesQXepwp1F9ztHHMT3DBbAdgcDiRT1mfJK0ZYAK6wKqhFO0c/wYrDcuVWJOadSDf0Xa5HA==; 31:oGz01M3V9BZFGazqEZvTvH7M5SXmikixS8q8SKLfjERE+WSMijW8Lo5CRmHDsszeV2nePaHxuo1o+CxyLrfBpwkZNLSKEn+d9Zay3y+Nn3zq8yTftontCAeVKeQ2637W7Haz8PNNg9TiumVnZsx1jMooVP1H53gEpHD492Z+NSy4EJ3j1+lP0bf0Hu/Nt/1vYIIYW0tQTO0kvx7JgQ1nXgCrbWMD1Wkc2/Nq3u2oNuU= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:SZOTMoMUfkoSPw1h28EXtVScJyktdHnzWeJo5kvjpnmvIDpflXtFrcxjUAYgg1GOZyKPn7lKnpI5WynLp2gD4F43O9aj1CiE3ornVfs6q69kxGTdk1a/Ijr/6svs3INhWMZvYi6PD/FsqNJprewJIv4KoNBb6BH3FUaSLPZJ5wQ6dzhQ8jIbYwdDBCOmnNHFZFKQpTTuU5QJRmNLGLKXb/HDzpiDjkb6ezZKSIHOIezMRdyruaOtmVkB2hQI9aJdxZFDMYt6G7WibgLdDdpVo8m+bPT65CimlnuelenX2E+EtaEDK1D0yGpTEOcDlxHcuIm4Iemrk2y4rqFDU3mPardxcKy+nZOkpTAqCiFovsJGL9oGKq43T3iCZyL/guyxef8TbBJyeTKbuEjwOv/3Yujv7SpYqhaewGB7ln9ncP9tZyspf9par6TRFXCU1GG7TkZpYdL02lLFiIUXFQEPATXpZtd5Gv1dMRJMgGBz7esW1XbBnwg3E9JqfipUvxBV4RCI7FVIN8UC628soySuxLSQrg/Kdiij3HdmypzayzZ79PbR9+adhKPHG+Z0h8+CuDK6TV+7H68omyg8ZynJxllHs8ynzZsfnuf2VuDcTU4=; 4:/uD6PdSIwFqyVpC/K2SB/vUtLT2MczOimV3Au0BljqXoOCsUwPNBpqMUc54wlZIICUWa1jkJz1rIAkCQj/Y8l/Od9OM33Lz/XRJQIgurtjEHb7ayxt8ZFFrLGi0qbeT51X/5Kyo0sLN8DH3zpX8tGAJJwJhWhlN1oeJTGJNUKBRj1vpQz5Q93DTe1uXPWvcjf4/165j2MAX+n0XYB13JAcy0l1LrOIuQmvASJeHROMl4ppYbcVN9x4b0+C75aIRME3EToK8gkLkJB+4SSf8aHw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:G0jTG+ch+vOjfqqxV5Vf3kkITCPRtipyYbSqB0TEl?= CDDBkEkq6gsg/g6l+T/JJ1IU7bgaiD8nGDebYPsO3ulEuhun1XGgeQ4obHbwv7/bAjT52JEL6llxOaf1fT9+S/JAGbmz1mDXBwfZ2pVbGm4EMxwIrdbmoLUTU6o1lcob6MC5KFf1BEpNaK99ViUGSQ0td4TbFfeJPWlx6wS7Iedh2dytbXDLJeQc7U/9czpDXD+/sE7SxEDeawgBv8sTfyqUg+jpoH4pkNSAWguAER5ha6fzJNSsmAUN1lzKLCKFpMyzXb97OIh0clVchBrrg8IXvGmbDaJQ0O6XDbLWsy4QggXw+R1VXHSnOaPA56qKsqe0NgzP7xhQMbUT8mOd7kWhsyUbneupZRlR3iaFeu0scbQI1Os05yOtojpivCSccvwtQr85NnNHdCZNBZ3y+ETrgbvjUTmAh6xQBD1gD/0ycuUD4jYe8exT07qU6VWmXzdprdCxbmWQXJ/V9G9G9y319E9whB9ZE59DfXycb0x2C0eNr7EAHe9eKN4DMZND6UudKm6rYKjJPnQ0n5EHUghwO3HIJDDDgoXumEpos+M5vAgz68nzYctUBj95ws/q4fgZpEvIn/tJ736AT/Gw8n6qf2ztlC0Za8t98u7Fec2wUi6k4vZmp2U7WDYFvtxG2TSDv0OGgIYyYrnJO95RFYHgDPQ2yjAYvT8xtdCLwNxKTx2JQWOaYb8pYv/4YIbD6pq5UdabpjjpZJn3x0oim0LHDWcGnzw3WbcMyAGH0F1Q8AGhXpmG93ANV+P8TTohr5TgaqAvNapHRNzt8ZJ9u1wSyEB+BgGL+2MmpLt0LI10+vL/83n3wZ6EYNyS7y+wZfV2+8KUMBm6NPZVyvovbLYNpdN7n1LlJhwUnsp70/QlnBdNetVBkYB1OkppcKiUl77PWOMrs2zlqR281qrJRBi98Lop5Mu6l3M3IwnqUXyDAWEk8QZFjxf+QrC31cldovYFz9elmRPxkd4su2RjwJwQybg8FUZWNHmizQ0ZXQ6yG6zgDzoV1fKbpSfoImBiqghFvKpH7IgsdVzOXzk8M0s0nAb6RqIRwQ8VmnOwU7qgBkL3W6VgmsXjcz4/hg1fenlmdxTkXdVp3nkTTfbpbalL902FVIvScGPb9F6XncXdzxMWDefCztMC5XVGraxF4N3tHs90kf2+gwkfHFU1B+fLLxiQpWqVVnZgkgDacRQbRdaAOclVrepRAAxnKaN95I= X-Microsoft-Antispam-Message-Info: GtEoKFG6BUtuNyeJViXM4JGVrdONKQSiNUfZc2Th1woNJNC9ObjCMTM1+X1idsatoPvdtuxoN09o1ELjeykkLnSbQblwInlNky3BLXNenFGwCi+3TG5Ny3MrngXXXGHfw3MN4m/+EdDCc0901kk3CEVryqnDm61CtHL8uH4qnQ3VEqk0K+cLwC2+1pBMMeQ5n7Ax+Om+hRi/sYZ4h3UbxhNbCnfWxT5NOhi1iDFLjPluicsDetFMMY9Zn1dRQ/bO768wQWDhOdpe7p92iIH7/8j3czayHTOcowQeuglMkmyUd2EYqnZcF6Dor3AKqVJllON4jhs+Lt42j0fLbOnKr3Ksaw3nSJAEJ4YC60h/2j4= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:g2BQto8YtJRSGWTN4XWhq2anz0PQDM0Y9uhnG7/4kYOMAsifPfnf3Fs4i+QQgyGgtuwQfHwnIjf3aZApaM9C1Ry2QJ6uuyE0+8wEvKAVJ9SwYrQp4J300RYG5gjtYsud7Iv+IV4EpX5oTSNhyz7Di5NiS0WtFh00gKDRwyH6yEZjg/6cstrC0Eixwljp+jRWd94nx/GA3++UWKaqujUCxdXFsWuNaRUG9pd8eolgcgSZD9WKbg+TXL01jr7s2G5YvYlrJ/tXRw7X7RI8eDpkpowHvoC/64LlupxaQXAnzbJ4ziphOya6S0n2K4QEpAnzKum6uEsBhZuOxwUxrztwAcm99NuYlzDZ5jRWV9Z2jHisdcWcG36wPEdeu6H6i7nZAQTON+nPRQwBiWsoP00Wk5dCTgvjj3hxI6FrKh68C9Tb5EGaCuqKXFzCAl9L1BoXO09E5ubWAzIgyD57Gkge5Q==; 5:Xb4gKfYZy0IfWv43iHeWw5XGiTv43olqvrpacVWZ9bo/Ye+GChh+GjD2ziUtEOUgUXf8PFcd1uvEcadMjfRZW5PJJbwJV2dH4orqWNu19xvSBHeksMy8c3krM1owfyJqyxBTq3cWGIGLyGUGl1AFjvEXNU6d3kWLDtCxABGlwfA=; 24:HyHW2D5iDm3d/9rb3Zh7j5Qtr0qiX1srwrJCD7FVTdG8pfTgViGmUNx6CZj+TfHO0H797CW340O/0/1pCy0Qp7LdNikyLS4db6/dmBf0P8c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:2XGE7QpO9/X+3BvMMJdH/9Fjv0gG//fPWIITmlG47ly2MNdyQpYToVP9gWQNSUGWYkEElpgH8b9Dpr+ww8agoIUbFQkf6/5VGHRgKuUD/fJcDbon1Mx9YLepDdc6g1lfl2n+I2B7Hi0D8R7Z0vg7diO6dBReZ/Cx588pFtJMdoCSVrNNDzpNisqxFP0LcCvaZf8W8wtM3iBh/3jqxIIzfilQcYHX/tgiAPe1Ag5Q3xdkEqI3m2XKKVHuilG8dBr8 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:04.1835 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bae1a8d5-d9be-44fa-adb0-08d5e6f4ab22 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 03/12] examples/l2fwd: move globally accessed vars to common header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_common.h | 26 ++++++++++++++++++++++++++ examples/l2fwd/main.c | 41 +++++++++++++++++------------------------ 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h index ca82e29..dd9f268 100644 --- a/examples/l2fwd/l2fwd_common.h +++ b/examples/l2fwd/l2fwd_common.h @@ -5,6 +5,10 @@ #ifndef _L2FWD_COMMON_H_ #define _L2FWD_COMMON_H_ +#include + +#include + #define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1 #define MAX_PKT_BURST 32 @@ -34,4 +38,26 @@ struct l2fwd_port_statistics { uint64_t dropped; } __rte_cache_aligned; +volatile bool force_quit; + +int mac_updating; + +/* ethernet addresses of ports */ +struct ether_addr l2fwd_ports_eth_addr[RTE_MAX_ETHPORTS]; + +/* mask of enabled ports */ +uint32_t l2fwd_enabled_port_mask; + +/* list of enabled ports */ +uint32_t l2fwd_dst_ports[RTE_MAX_ETHPORTS]; + +struct lcore_queue_conf lcore_queue_conf[RTE_MAX_LCORE]; + +struct rte_eth_dev_tx_buffer *tx_buffer[RTE_MAX_ETHPORTS]; + +struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS]; + +/* A tsc-based timer responsible for triggering statistics printout */ +uint64_t timer_period; + #endif /* _L2FWD_COMMON_H_ */ diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 11ca170..a6089a1 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -41,29 +41,11 @@ #include "l2fwd_common.h" -static volatile bool force_quit; - -/* MAC updating enabled by default */ -static int mac_updating = 1; - static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; -/* ethernet addresses of ports */ -static struct ether_addr l2fwd_ports_eth_addr[RTE_MAX_ETHPORTS]; - -/* mask of enabled ports */ -static uint32_t l2fwd_enabled_port_mask = 0; - -/* list of enabled ports */ -static uint32_t l2fwd_dst_ports[RTE_MAX_ETHPORTS]; - static unsigned int l2fwd_rx_queue_per_lcore = 1; -struct lcore_queue_conf lcore_queue_conf[RTE_MAX_LCORE]; - -static struct rte_eth_dev_tx_buffer *tx_buffer[RTE_MAX_ETHPORTS]; - static struct rte_eth_conf port_conf = { .rxmode = { .split_hdr_size = 0, @@ -77,11 +59,6 @@ static struct rte_eth_conf port_conf = { struct rte_mempool * l2fwd_pktmbuf_pool = NULL; -struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS]; - -/* A tsc-based timer responsible for triggering statistics printout */ -static uint64_t timer_period = 10; /* default period is 10 seconds */ - /* Print out statistics on packets dropped */ static void print_stats(void) @@ -489,6 +466,20 @@ signal_handler(int signum) } } +static void +l2fwd_init_global_vars(void) +{ + force_quit = false; + + /* MAC updating enabled by default */ + mac_updating = 1; + + /* Default period is 10 seconds */ + timer_period = 10; + + l2fwd_enabled_port_mask = 0; +} + int main(int argc, char **argv) { @@ -502,6 +493,9 @@ main(int argc, char **argv) unsigned int nb_lcores = 0; unsigned int nb_mbufs; + /* Set default values for global vars */ + l2fwd_init_global_vars(); + /* init EAL */ ret = rte_eal_init(argc, argv); if (ret < 0) @@ -509,7 +503,6 @@ main(int argc, char **argv) argc -= ret; argv += ret; - force_quit = false; signal(SIGINT, signal_handler); signal(SIGTERM, signal_handler); From patchwork Wed Jul 11 06:07:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42782 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26A5D1B470; Wed, 11 Jul 2018 08:08:12 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82]) by dpdk.org (Postfix) with ESMTP id 32BE21B4B8 for ; Wed, 11 Jul 2018 08:08:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TL9v8IraDOTkk6gXrXwk+rn8kR0O53bMsvLolUrcvFs=; b=Ek/8sE3wukOw7E9k6soOPYAjP0f3uOepfkhevsoaJLhIzKE36TXjCuly4oxGFWD1ON3/y0sUZP0M0QTKFba8LjMjj/a1cNiax3+KTFysVFzUNQRqSBvHqOFCxsa5RPRCDloSiGAeKwAWwHj1XfoRUpEjgyrS1sOO5KkJoCdTzJE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:06 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:20 +0530 Message-Id: <1531289248-20025-5-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a8198a1-633f-4202-9004-08d5e6f4ac83 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:DWa49BFmNHwIq7+aMRKjA1A/I/m2rvEyZ/LLpigI9sWjGYR+3/6NQx8xr0ipDQVG0FKA7mcJnkT7FLBOF35La/EVNJaXxzIcYfnIcHCqs29BG8qAJ0nN9vH5eTepoLENQePyXK39Quug6jNCZThjAzKoGo3Ri+F9MCv1iotUtjSdg0lQHzkAILolkrsDk0jr+PCoM25Pzb36jPeeTpuBCKBOI5UAFIcttTkN9o9Ws4DbkQHCBug168tEfBR0b0j9; 25:jIvJaVvt/UHcayyvMi3zsx/yliWaGyLSLjr8ZIWN3o8ALHerQeedJ85N9SejUEiKaOgNJMivNML3U0JpnrZPoMcRGL45CcivnXYdralw0IlwmE+etz9KKodkFumhV+LpH/8A3swLDVhh532JPHpAFsumAs2mq0r7za0bt96FGdnKE4rONpyXMWY66x/vah6ONBYYKH35ud22lMQMtl0OFF7YZRASCHyPcCXQhN+jcDng8j6Mg5LU35pxUx4NfQOOhsem1Qkh7O4vU90PWf/dQpw1a4Eb9NWaNg2LlSestbGBuxrvD2AWxBy4KHOwVoPgHAidj2+0EPLnazo7NQwNvA==; 31:z8NpEwScAEbdQt5FU/zZJ0yx0qlOx6Kkx5j2NByqVuQDF9jUtigGI4qumV6Ggazhs1YPiqGtWcGyAA1c3bjIzzKcJ63En/dxFSXbplLyVZuGf5BPY+zcC1x7aOdDljSbLplLG/H7kUcpD6GFJUpB+MPhKCnxCL/0n09/7vDZTrsZWVexQhwI5ma05qdMFKUCrdHZ4YMzpGMFERnMQb/IbC2g/qSQC0fOT+AtZLLGtm4= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:MTSKHY79VmtnMtlcaCJ4rmrZgOWzb7pBWHjKLS5U8rR6tFNzfrPChtOTzHniYFk/AiDKW1ShwRBz47+/WLXSeyn9vmuvkotjVsXaobQTjUJlb5bOW7wDwBblPqQxHPUmsIPv6+4ODJ5kCBhjv2EtxmNpn/k/KTQ/ijUSYP9Dxi14FXIudU9iEasbMg8UXk0L0MzDpc05Yc0E1dOPULiQ2hw8NoM2pWPnzLWuoplj2fUiM/WMbRXNCl2Cd1cxOTKVYMfBgMUT0FO17JTO9YVPU0sz9QNYrbVEAxU2pLnWI92DKhW1AhSMKqONODRO/aoQkTkNz0lLcLspGIHNLqq7YPhetTlcL4Zax1tlb5ca2gFobvCzF8H68Bf1S4472Qg/qmq5Dv1g+LkF+fV63G02FkJHCwpbbRvdyDREqJViMDfYFadRjdRYcc5vY6z8L8XXN+Hg5To0P4FBr877TINlD0RPoCdj3VKk7oypJj5TTxKEmO1UB5DgklSa+P+VeVXCfLY2cFHpOBMdemZ1nO7O4XRs5hp47iV2RWwkGaXTmwa1jRFoGGeTTWDih7dpgHD4iaaBE7Pfexp99HImYRijrn5N5/YaAqSozqW7qP8YWEg=; 4:le2X3NKqMIBJs/nc8iFotV5xsTWC0U/iN4A43rcwWLJ4d911CkulV0iR7J7N+lyPG5HxuYhMTaN0RtI8ZZNXxYzaGIGv3TkRYfCs7nODn4tk0GwB+nJYH3UB4i9GPW5dNvII1twJ1vHvRVjlOzNUUu/hgIEln1VgVgJ66zY0SRimo7jniQbOE79a0KDvGEXUsZbQGjZL5rFzvk/g0ATxK9tWcS8tZjXmfjo+TmPQfKu9ychoII/VMQSxIR8mqdRsHSGOuYnGFbOkmTXv0t7RzQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(14444005)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:RtAxGe/37YenW7wAo5ioWnkHRw+/f8UZCpDWZhLIW?= tf5/aWwNcldsNBIHX6p8O7F7kT8nK7GZHi+27hfzBTuz0rPtniVTbuLhw6ToW616s1TB6iVQ0/63mTqdyZtTmwvMAj/yKutra8Rkag1TaDIJqU/H+Lyj7FOsXYIuHmT+sEtyo+1p3i3JZgx8/8edQJI2AS4XTYlekC4RPakFBCxwLv0tl5KVpYbhagLc1mJeaGmxiMHNEP32SziF7h4GD90y3lw1xKvsCOM77Tk2WzhkYG4NxZ8u08K0wvXkpF6vH3nOmkg9QvzQb0dTF563C8W4AssL3idrueGKRdcYnTBCRhThxYvmCMHeiB0QEq0EuwIr9CTvwbRkiDdtxsijJnrfTm+1LbpjeS/7tXkrqNyOUaSLiU8S4b0I2RrEjaTMju6sTv8KSTnyQKBA8EzHbHPvdOZ40fpoC03zDMLCeJ1k2O57Gxfkrlzo6//FwnYCn/I6u8w+ktUg+3MQBm+3sqDyir/vsMAgtRPF3fpRFrE+00sMrCkSPuWzYWDSLkP5Z6oXz9067lmo8B4y1XXZUwt+dqGTEIeCgv060hYnARfaI1zonb5yR9GK5O6m1U1a8ihWX6Y63QJQMG7mXZYMrzLvDU96hJ8tTFgkRY34P8aZX2hdfUyJ7I1rhdp0B2umCRmc5q6enBNZRPqEwdNMdCJ9tPIGn71VerwPZxNMAzRR7W+WxlAPPccH530SUo4Mcd1/uT8djmywaoO6GVlyWq//GWlLBGTbKeBzv/C9aSKi8F+tkcewJql/pkS64pR59u0fLgeHbj+KDDo3gzDqmuhFb/1Pe/M+OJ2UCmqZ5n7SsJEY/TI4Ps/5y03cGeQjeCdJHHOu1V00jH2iFWkEa/8bH2IPFwralWqwdtiGlZBZpnDwET1AUhDWapMpJqhYJs+cjt+X/9rmEfWpID2/cyfdHQ0kXUE3R2+wqxlWkkImVtTYTnu+JQ5YKrWOK/3XpKizeYfgoPHtNQDjEfH00bbO1NwisbKYRinIaaf88V77T2CJJLXB4FDher1iQw7n7hoSXXoumorTfmN9FppLzAleFK3frujBJZYNphG+jtoFwdkg7yFd/Pc20Ia/WFUq7Rvgf6CulMpXUVAgbWqZzhu2SfJLmeu6NAjVSw9qB0EBZTrK9u6zcfbEJjNo+7BrnPr04k5nwUSNkCmTba9pE9q50cUsypHioLetPz09QcYiPNaRXAdU0pbAu1YA9gdDmAO/wMlUAQgC+auwc95RCAo X-Microsoft-Antispam-Message-Info: 3tZae72aM6FIaj32A8FycIGS92n77/Jb673XxYE3voB258LCaE9dX/WzqtUrbQ0UsYLAKvg9n07sv6Qy6AlSuiGdD7pbl7biwl365OJS3vTRuUdvuehxG5dV3wL6He/7424bSpz2duKIx/OHZUbM97j5X6YfaSpSC/k9Mm0ahmQ2uM+1MOyE6sf9jDr9ND1X5e7aZ6w1L2OO2BZUczXG4BZ4o8ztX6Fa2JlOCd35SUQ5rcO95gxS5Z+Dwwh4QQGLqrekoxAB8vRTTX2IZQJqLEUpZUneMIvQpPh9zIZWMaz86RbD9H/GMwU8S6YQnBWlK6OKedUNQb2V14PlozIDK6ElW2onsLGxIBFeOVla7V0= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:7uJWc9blMy0KTM1aH88YKJS3S8oSJhp3aFccWkydcYEoubaCxq+P+WhT2JbPzNMueUbaB2xiH4Wa07Q6FYHinl7Jqpby0qX/VAr//TlXwohNlCYg2BfHCq5HI677tbv3i+GFHisJMRtVYB5WZ7TOmNQQyZRNv5QDw9ZcakFktcca0p4YRs4NglqEbJlBgYVqPoduPZKZ3kyp4lfn6ByoVVVKnLSQIVzDjVwr3HtpY+HKt7sPMR3EPAiu19Rw2327ITmuXe2MtKqQMDZzuDkPJsuDw5zMXFPDRB4B9HBJmoymdJTBvlcX9TCSF1jURNsrjnAsDvCUtZ1hgZPlopQ96cGYhAHxDQ0HfDkwaiuF4LunQbVh1PiUtBqFs9gtq6YC4WSuvjtt+cG2EY/KXhTZJQCCAaBaO5obFRBthnjcYr15xcIrPJ28RkIBZ2tRdIb429XG/a2koMugHP5B2UCyDw==; 5:Nz4itIq31iq3sf88wSfQrLAqZSKGS9cj+o5bv/CYyDIfiAKWTfGqxwQEVMOQH4QO18SzLfapCmEQihdo7w52a+1AOfAPZXXG7R8twdtlGi6y3kFAVmKgOMCeUND/MG75corlTkGGLNZUASBrZYgZGRQKPprXwPH4Gr4fj4m+PVk=; 24:SHhCGIoWvt2xAahGEpsIPqTh4A1Ti7rYftWt7wh4eSTMWyBCHFK95lToaHqJGqBjGtKvW1AgzwOIRCMTwT/60vqsTBjUyhpt12OmojPSi98= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:jCKPz21XPpJw1XbfoUh3um9Hgy1uA8obm/YdQcBLOChJVilAYibAmtjpo3ffKwI9wL2oHDZ6XjcZWmBkw8ik0aw2fxoD2VbGk0kjP+hVfSblJsxNcyTtOOF1O1NSd6/TsiIIo7WW4aAnLvs9RVhj+PxaTj2pFP0L8BmzFWkxZcJqtPdh7e6cC5t8ReFkODBo63QPM0sAJOscMpwyZqNDj0hsIkVabGLc54zni02TmSuXposuiep9hRkrpEOI7jQz X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:06.5622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a8198a1-633f-4202-9004-08d5e6f4ac83 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 04/12] examples/l2fwd: move dataplane code to new file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Anoob Joseph --- v2: * Merged checkpatch fix patches v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++++++++++++++++++++++++++++++++++++++++++ examples/l2fwd/l2fwd_worker.h | 10 ++ examples/l2fwd/main.c | 186 +-------------------------------- 4 files changed, 245 insertions(+), 185 deletions(-) create mode 100644 examples/l2fwd/l2fwd_worker.c create mode 100644 examples/l2fwd/l2fwd_worker.h diff --git a/examples/l2fwd/Makefile b/examples/l2fwd/Makefile index a8a47ad..24d1e4e 100644 --- a/examples/l2fwd/Makefile +++ b/examples/l2fwd/Makefile @@ -6,6 +6,7 @@ APP = l2fwd # all source are stored in SRCS-y SRCS-y := main.c +SRCS-y += l2fwd_worker.c # Build using pkg-config variables if possible $(shell pkg-config --exists libdpdk) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c new file mode 100644 index 0000000..663c505 --- /dev/null +++ b/examples/l2fwd/l2fwd_worker.c @@ -0,0 +1,233 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2010-2016 Intel Corporation + * Copyright(c) 2018 Cavium, Inc + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "l2fwd_common.h" +#include "l2fwd_worker.h" + +/* Print out statistics on packets dropped */ +static void +print_stats(void) +{ + uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; + unsigned int portid; + + total_packets_dropped = 0; + total_packets_tx = 0; + total_packets_rx = 0; + + const char clr[] = { 27, '[', '2', 'J', '\0' }; + const char topLeft[] = { 27, '[', '1', ';', '1', 'H', '\0' }; + + /* Clear screen and move to top left */ + printf("%s%s", clr, topLeft); + + printf("\nPort statistics ===================================="); + + for (portid = 0; portid < RTE_MAX_ETHPORTS; portid++) { + /* skip disabled ports */ + if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) + continue; + printf("\nStatistics for port %u ------------------------------" + "\nPackets sent: %24"PRIu64 + "\nPackets received: %20"PRIu64 + "\nPackets dropped: %21"PRIu64, + portid, + port_statistics[portid].tx, + port_statistics[portid].rx, + port_statistics[portid].dropped); + + total_packets_dropped += port_statistics[portid].dropped; + total_packets_tx += port_statistics[portid].tx; + total_packets_rx += port_statistics[portid].rx; + } + printf("\nAggregate statistics ===============================" + "\nTotal packets sent: %18"PRIu64 + "\nTotal packets received: %14"PRIu64 + "\nTotal packets dropped: %15"PRIu64, + total_packets_tx, + total_packets_rx, + total_packets_dropped); + printf("\n====================================================\n"); +} + +static void +l2fwd_mac_updating(struct rte_mbuf *m, unsigned int dest_portid) +{ + struct ether_hdr *eth; + void *tmp; + + eth = rte_pktmbuf_mtod(m, struct ether_hdr *); + + /* 02:00:00:00:00:xx */ + tmp = ð->d_addr.addr_bytes[0]; + *((uint64_t *)tmp) = 0x000000000002 + ((uint64_t)dest_portid << 40); + + /* src addr */ + ether_addr_copy(&l2fwd_ports_eth_addr[dest_portid], ð->s_addr); +} + +static void +l2fwd_simple_forward(struct rte_mbuf *m, unsigned int portid) +{ + unsigned int dst_port; + int sent; + struct rte_eth_dev_tx_buffer *buffer; + + dst_port = l2fwd_dst_ports[portid]; + + if (mac_updating) + l2fwd_mac_updating(m, dst_port); + + buffer = tx_buffer[dst_port]; + sent = rte_eth_tx_buffer(dst_port, 0, buffer, m); + if (sent) + port_statistics[dst_port].tx += sent; +} + +/* main processing loop */ +static void +l2fwd_main_loop(void) +{ + struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; + struct rte_mbuf *m; + int sent; + unsigned int lcore_id; + unsigned int master_core_id; + uint64_t prev_tsc, diff_tsc, cur_tsc, timer_tsc; + unsigned int i, j, portid, nb_rx; + struct lcore_queue_conf *qconf; + const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) + / US_PER_S * BURST_TX_DRAIN_US; + struct rte_eth_dev_tx_buffer *buffer; + + prev_tsc = 0; + timer_tsc = 0; + + lcore_id = rte_lcore_id(); + qconf = &lcore_queue_conf[lcore_id]; + + if (qconf->n_rx_port == 0) { + RTE_LOG(INFO, L2FWD, "lcore %u has nothing to do\n", lcore_id); + return; + } + + RTE_LOG(INFO, L2FWD, "entering main loop on lcore %u\n", lcore_id); + + for (i = 0; i < qconf->n_rx_port; i++) { + + portid = qconf->rx_port_list[i]; + RTE_LOG(INFO, L2FWD, " -- lcoreid=%u portid=%u\n", lcore_id, + portid); + + } + + master_core_id = rte_get_master_lcore(); + + while (!force_quit) { + + cur_tsc = rte_rdtsc(); + + /* + * TX burst queue drain + */ + diff_tsc = cur_tsc - prev_tsc; + if (unlikely(diff_tsc > drain_tsc)) { + + for (i = 0; i < qconf->n_rx_port; i++) { + + portid = + l2fwd_dst_ports[qconf->rx_port_list[i]]; + buffer = tx_buffer[portid]; + + sent = rte_eth_tx_buffer_flush(portid, 0, + buffer); + if (sent) + port_statistics[portid].tx += sent; + + } + + /* if timer is enabled */ + if (timer_period > 0) { + + /* advance the timer */ + timer_tsc += diff_tsc; + + /* if timer has reached its timeout */ + if (unlikely(timer_tsc >= timer_period)) { + + /* do this only on master core */ + if (lcore_id == master_core_id) { + print_stats(); + /* reset the timer */ + timer_tsc = 0; + } + } + } + + prev_tsc = cur_tsc; + } + + /* + * Read packet from RX queues + */ + for (i = 0; i < qconf->n_rx_port; i++) { + + portid = qconf->rx_port_list[i]; + nb_rx = rte_eth_rx_burst(portid, 0, + pkts_burst, MAX_PKT_BURST); + + port_statistics[portid].rx += nb_rx; + + for (j = 0; j < nb_rx; j++) { + m = pkts_burst[j]; + rte_prefetch0(rte_pktmbuf_mtod(m, void *)); + l2fwd_simple_forward(m, portid); + } + } + } +} + +int +l2fwd_launch_one_lcore(__attribute__((unused)) void *dummy) +{ + l2fwd_main_loop(); + return 0; +} diff --git a/examples/l2fwd/l2fwd_worker.h b/examples/l2fwd/l2fwd_worker.h new file mode 100644 index 0000000..8971a6a --- /dev/null +++ b/examples/l2fwd/l2fwd_worker.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2018 Cavium, Inc + */ +#ifndef _L2FWD_WORKER_H_ +#define _L2FWD_WORKER_H_ + +int +l2fwd_launch_one_lcore(__attribute__((unused)) void *dummy); + +#endif /* _L2FWD_WORKER_H_ */ diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index a6089a1..05f9d28 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -40,6 +40,7 @@ #include #include "l2fwd_common.h" +#include "l2fwd_worker.h" static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; @@ -59,191 +60,6 @@ static struct rte_eth_conf port_conf = { struct rte_mempool * l2fwd_pktmbuf_pool = NULL; -/* Print out statistics on packets dropped */ -static void -print_stats(void) -{ - uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; - unsigned portid; - - total_packets_dropped = 0; - total_packets_tx = 0; - total_packets_rx = 0; - - const char clr[] = { 27, '[', '2', 'J', '\0' }; - const char topLeft[] = { 27, '[', '1', ';', '1', 'H','\0' }; - - /* Clear screen and move to top left */ - printf("%s%s", clr, topLeft); - - printf("\nPort statistics ===================================="); - - for (portid = 0; portid < RTE_MAX_ETHPORTS; portid++) { - /* skip disabled ports */ - if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) - continue; - printf("\nStatistics for port %u ------------------------------" - "\nPackets sent: %24"PRIu64 - "\nPackets received: %20"PRIu64 - "\nPackets dropped: %21"PRIu64, - portid, - port_statistics[portid].tx, - port_statistics[portid].rx, - port_statistics[portid].dropped); - - total_packets_dropped += port_statistics[portid].dropped; - total_packets_tx += port_statistics[portid].tx; - total_packets_rx += port_statistics[portid].rx; - } - printf("\nAggregate statistics ===============================" - "\nTotal packets sent: %18"PRIu64 - "\nTotal packets received: %14"PRIu64 - "\nTotal packets dropped: %15"PRIu64, - total_packets_tx, - total_packets_rx, - total_packets_dropped); - printf("\n====================================================\n"); -} - -static void -l2fwd_mac_updating(struct rte_mbuf *m, unsigned dest_portid) -{ - struct ether_hdr *eth; - void *tmp; - - eth = rte_pktmbuf_mtod(m, struct ether_hdr *); - - /* 02:00:00:00:00:xx */ - tmp = ð->d_addr.addr_bytes[0]; - *((uint64_t *)tmp) = 0x000000000002 + ((uint64_t)dest_portid << 40); - - /* src addr */ - ether_addr_copy(&l2fwd_ports_eth_addr[dest_portid], ð->s_addr); -} - -static void -l2fwd_simple_forward(struct rte_mbuf *m, unsigned portid) -{ - unsigned dst_port; - int sent; - struct rte_eth_dev_tx_buffer *buffer; - - dst_port = l2fwd_dst_ports[portid]; - - if (mac_updating) - l2fwd_mac_updating(m, dst_port); - - buffer = tx_buffer[dst_port]; - sent = rte_eth_tx_buffer(dst_port, 0, buffer, m); - if (sent) - port_statistics[dst_port].tx += sent; -} - -/* main processing loop */ -static void -l2fwd_main_loop(void) -{ - struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; - struct rte_mbuf *m; - int sent; - unsigned lcore_id; - uint64_t prev_tsc, diff_tsc, cur_tsc, timer_tsc; - unsigned i, j, portid, nb_rx; - struct lcore_queue_conf *qconf; - const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) / US_PER_S * - BURST_TX_DRAIN_US; - struct rte_eth_dev_tx_buffer *buffer; - - prev_tsc = 0; - timer_tsc = 0; - - lcore_id = rte_lcore_id(); - qconf = &lcore_queue_conf[lcore_id]; - - if (qconf->n_rx_port == 0) { - RTE_LOG(INFO, L2FWD, "lcore %u has nothing to do\n", lcore_id); - return; - } - - RTE_LOG(INFO, L2FWD, "entering main loop on lcore %u\n", lcore_id); - - for (i = 0; i < qconf->n_rx_port; i++) { - - portid = qconf->rx_port_list[i]; - RTE_LOG(INFO, L2FWD, " -- lcoreid=%u portid=%u\n", lcore_id, - portid); - - } - - while (!force_quit) { - - cur_tsc = rte_rdtsc(); - - /* - * TX burst queue drain - */ - diff_tsc = cur_tsc - prev_tsc; - if (unlikely(diff_tsc > drain_tsc)) { - - for (i = 0; i < qconf->n_rx_port; i++) { - - portid = l2fwd_dst_ports[qconf->rx_port_list[i]]; - buffer = tx_buffer[portid]; - - sent = rte_eth_tx_buffer_flush(portid, 0, buffer); - if (sent) - port_statistics[portid].tx += sent; - - } - - /* if timer is enabled */ - if (timer_period > 0) { - - /* advance the timer */ - timer_tsc += diff_tsc; - - /* if timer has reached its timeout */ - if (unlikely(timer_tsc >= timer_period)) { - - /* do this only on master core */ - if (lcore_id == rte_get_master_lcore()) { - print_stats(); - /* reset the timer */ - timer_tsc = 0; - } - } - } - - prev_tsc = cur_tsc; - } - - /* - * Read packet from RX queues - */ - for (i = 0; i < qconf->n_rx_port; i++) { - - portid = qconf->rx_port_list[i]; - nb_rx = rte_eth_rx_burst(portid, 0, - pkts_burst, MAX_PKT_BURST); - - port_statistics[portid].rx += nb_rx; - - for (j = 0; j < nb_rx; j++) { - m = pkts_burst[j]; - rte_prefetch0(rte_pktmbuf_mtod(m, void *)); - l2fwd_simple_forward(m, portid); - } - } - } -} - -static int -l2fwd_launch_one_lcore(__attribute__((unused)) void *dummy) -{ - l2fwd_main_loop(); - return 0; -} - /* display usage */ static void l2fwd_usage(const char *prgname) From patchwork Wed Jul 11 06:07:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42783 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02C001B4DF; Wed, 11 Jul 2018 08:08:14 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0045.outbound.protection.outlook.com [104.47.34.45]) by dpdk.org (Postfix) with ESMTP id 235871B459 for ; Wed, 11 Jul 2018 08:08:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uVvzH8Ibx4532XAX4HWT/GmWvNtrPJOuT2mLd3bZRkg=; b=VK2IOcM2jG0cjO78KVr/2ozzoGp2vseCyuesOwqO7/U/myV0VhskYAOs3dw7O3IdaGNpxpIuU6wGxWF/77TSPwrV3vbQ04u9G/WcVNr6LNUy/t6gZv0boTfD9Mn09nBoNNGKUBrLs3XJzwRSsI24m30CcaMnXg2qBAJXo1Y5AUk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:08 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:21 +0530 Message-Id: <1531289248-20025-6-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e71a2455-2e24-4813-b8e5-08d5e6f4ade8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:q9c59L6n7FZx49RqjaSyHbEVRgSD0Xzpg+FU3+Y8JFyZkoLbyGjUX8DUx+3PomnzzlUUnfbqUokJoPPtTzkswfmTYHcqW9OsWH7F90owex5GpX49ddbkuMtRiwsVXBQyrQ0feRKSTiJkRtHxX/dX3R2CEarwosSJj8Ev9TJw6Z5AMGXKoiQ4vGZptZ3lcK5urpCpeo2cCxszzV4X2NWrEqnW1jLfx1EBPYiGfQMsCf71qUTjesRUg1Tk43iGngg4; 25:kQNqmBY5ZvPV5oLFqfljjtjXFpWe3hjKeiRv0ZLwRoiWX/y+DuG0USf3d2RBQOvm3wVnCTQrjKEMHf8LJfLgG11s/Vmbm8+rBnO8/ekht7Ne5T97ubh8PIbgXrIYJLBNSQV04/GkZD7kC04mqKCjgR3aKOWCwqKeLVVsEV6CrPnvdZyIZCshkdMpCDAoUxclYcI2w2lQGmmjO0lMf75zyYHYg8uzUCq9czN4FzobAZKliPsujEgJRheVODZerybs4Ypvw5pnauLToODNV+cRHy1OqrMpy/Zm0xNjAGxIFj3s4R/dWWA2k01JsjVpXxuTqclOFWwruohncqz2ac0IdA==; 31:wLfjSYXrfaXXVO3fgTbmgU0EmTN1k7HmZvtaNMkrKs0+JKG3U4yugGVOcY5xzJ/qHnpBrKL8WJ/0pfIBT/utAlus4e0QFNbngQs5b+ULvOs1CtCLw9HquQtnP1fEqhn0HGc2Dol6/lroIsZznzwxPmyM8l2tHDwPvKi1+ww6E83qHGOOBcuuPNQvgnhUCiqi8GNOEyd7dtlEb7A7Fq9NcJ/ABRED9zI1255bopHylLE= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:QOG+qKJMYtITMBsSyJv0MnetENuEG6Vcsxdth6n1YpHz/P140uTHjCpacVd9Vorc0ehFQSDGA60csDLXVUqXKIcQnCCkqKCEtI/enMM2Rezkp9U3VPvSAE+rgbRIg7Pi3lKbK559QD5BHKmukaVFKdmkBwDY+i9L4hB1Wjkv/JEFvmme4J5yWPHmbNOyXynrCJGXiio/o5YnqfvWJvXuGOYJguiykobyprWE4AnjSJSXbYCKQ+88Y1ku2ix7W0fUBF0myz1bIml1/KXoetuFBMexgQtT5/XTbiqDTtg61fSLbbLVT1+SEqIfEIJp0sAAf9hMPQD/L3ImTQagu5g9e2hilXfEn5/UVdgY/eVjWwS3ruupyGltV/ucTqwFpgTw0NpTruAxO25QL+M91KZEFGmFHH8fF1l3zbSKDP2jtLEsqJh4QuJTZR6g4ZHM4+3OLzV89Ooh3yTeD7wp4c3SIaYu3+y8Hc47VRQafOak8lRS25+5zkarF0yjFeKEX2t9Z4y02nrEYIUqsddr7OlLEzFhysbrVWyIn/mDBH1dwHZ+OykG3jlHk6Nsu5TU8MGC6PBO7orJ5n7pHvMO0ioxZfSPF2CzLvXTl67kl+fephw=; 4:ZH5/SvFZ9HSxLuUYpQ627GY+9H9yzhuCFOFrQwYkG5IfB3RtNnXNe2NFUodNHQjNDpgP1eLi4bT6Ape9AtoQ3w6fbes9VUFNnAUElBktHStL6wsYFJETFkGGO7EjxXIGlns2LhkTztzbYaZkAlkTXXZxXvc6VP02G0jZZKRPmhhyn5wA1v/+CKsFCLVvvE3p+/04meDyw78DfAxxXLJNqZJAUHAUgdEEgF3byzA3fP9RSXVVeCQ9hnHYORG/sjYv8kfTHA8xmqXdS9pxxkoLeg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:Q16jFNLKIWYt+GqPU23oAGuUZ+sCi9IaRGveSTYqt?= ZyJHqOtkGbP7DivV0ksU9k+y89ZqEOprY4cpDSPjPhnAEWZi/4TTEEZcIeWqiG/0n/3BYaxsGxq3A1GegouUCE6k61twDA6aFu2m4YRFupTwOM/Ice43qOjtQe4/iwHrawgbpsyiZdBh0MglETRPptYaFv3FxyvKBu52n/RNOwPv1JNr5wJ5uxZtekTgtMXPsx2XaIUpJwra0mNE7tLT+ChkSD4XKzFjgKT1EPMPnsWg3IAFA4x3d2KEpktfIZLao9iZ1cMAog5v72HtNMu/HXEGpEj8/U1SaHgIanFDH/ihPYtQ7mn+eWoogcx2fm8LIIjXo0tsjzdRsJtBJwq4xysSMzDBVv/KEAlpJNVRSNCXYKHMS8k6jgNBLHFqrSCOrwBvxjRe2aUEKPfPk2N3SNkh6DWGncU/bAvNlgvRumlKDAaWezEOr5a/FrvGsL0IjVJnqO4pPXSuXCWyFF/nupY0HQy6+5uXNcNc6QnjlUYsI9PSTG9EWGLA8hODAPVxYx9AKFEwzy0fUqS3rYSA73uw0h/ZtA1y+Ms8jwW5wV17OqryWZ+TmzCZHpVMtXDaITSsm6P6CK7gf3XgFHIBygZYz4lX4FFGbTx21YmJcoiYTG2jJvH5b2YTxSHBOqNbIzvXpDVnMsfR/yAEnhBFBkPKYL0aiuQeQiw0q3bb6L0wbA1H4BWyisOzResSXe7qwuG3e5zRQvXgDxk7+mXk94G1WbDSB8A5lqPXkdN2E/44gpcmzI1RrxO9qleBoUTzn+C9/melpKFWp1h0pNzu0FwW0OtMMUOQ599tBjdtUsUZ+D9KnC7skUg/aeuLSlHFJtgKD0lx21iJ7e40N3wnToGLH0tTwALjm2RvmjavWcC4Akq0yuW3BmDLclQzFkBiRave4oaQiALjDvpxLShAduHsmNfdgZUu7BQwv+Cf1duSO+o2D7sfxRqkCAmkL1kpkJTrAVUo/uV5mzjafxHQL2Ebu6Du5xF+LE682x9EpIoX71AN2pQ38TKLKJ2CUqaYgppRpAJGjbVaX0BOnTjMZlc9ktjnLbHnWrReBzhfKqcixjapyIKX0j3uOcL7QoU/tv9q+72MGoOkphT7v7UsYQ+ijoIFDftFvOeUg8K7fmZrkdJ+Yn3umHwjO/JpTezYbaB+ZnoUmV2cjJk3ncwL7ZMg5NMTKaMF0mBjKay0rn8fN+UqWfxTz1UquAalNgx2WI= X-Microsoft-Antispam-Message-Info: KKTSt0CZB54PSvpIFUoBxj5OGkhRalVeU2r4kZtdlxAXrhW92Wra5PYnyleFHxSGTx4keHgwBIw3yE1RpjdiXqoPKVVlHcNvf5WO0av6fCmtS17GJrwNboOgx2aF76WQnMbbbwNSt+/UOxqEvsrxzqywgW0X1uPYlAUSXrd9a6pmCaSdEsS2kCuXk7/mJL/rwSHgyVI7iV26aX5NK7vTs6Fm0m5VRD9V/72KVhLwI1yfw6ksRZcn2JWAZ6DDdGYAULAApfHbKzcVDZZ47B9/k1p//6iFZEjJ94ZqxQtLbbycvp2aC6fdPg+nQfbhUOm5FvBigckcjZ6Ac66BPBMYWSUCgj0D6b49ZX2p08Bie58= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:GF1W3wolQqO+NhuO8B8VsI46+4CCqTjKIYzvKjtqHZnqXf2F0H/8uRUDRvqy+h6arl20dnDczRIwYj5BWaHcTTAcTCC0pGF2UV6xAY+di/nlaDcH0PE/ejtVuMKkoL62B2rKpT5bAX0rdLJ1Z14IJPSyhErTQ4NkLDHoDeukwOpUX6BwUI+CCXfMuWpNdCBrbRQyLWAteDvNPSxMWa9ZQOUNPBeNRgDwjQbR74z0oN/cd1u2KgZ68y1ec+2XySFBdGTQ22+U5G46X65/h2OrYC8ewJZCiXcRGFin/e+iNHu294fM7qmChxnjhRWH2jCEHpb+nU2C8ogypL/6apqBVUgnzS4ZArSJJaj1lU2odS7vvFFizbQ6MBLkUR5hMFLkokanimDZ1gpx1KS0uPQS6anWMN0qfCnok1MDO4czioQIj7n+ATF63sxCZhNn7W9TzXZEBoDdUU+kEPP6SKFgFA==; 5:CLiuNUHAvoTyLRbaK+RSVVfayAqwmezLBe8CMVa2+PBH+vn0lOzm4rAQotcGu7dem5hPdgI6A859eD3CAySpDkwVXP4VVkqCaiUSH2YeEwxKexEMHaa3rzN1ggbXg16BF6F5OOkyo1iMskMXHqkiwXr0xiwYTlJF6Jg1swvLBuc=; 24:+nFPgztb3cOY/VkXYvN+GKgxNPT07dZgvRYND3a3tk2MqxYEVZeKE5cGORBVmaS1FQ8uLohjLovpeYvapupwEYiIYP4TTo4NaZ52bpzNtf4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:vNvYXx2SoQQtjocLUBApXiObQeeU+TkSgG55ltoB/nTIrDRK7p+vKXB07OwJYK9GkqAJs3c9IQtL4eX2jD39lGqbA04hwVm+2Qqbst3tXF8BoDs4lSbbY7E7ieYldJQ4HZ4M1z42d1k+ds/zyZij9k6nXVdLJYhEvrBUgs9rOVNeyqGh5H3JOOSsoe+rXYjnp09y++3tywL2YcRpQlXF6W+NEYmdL5TRtb1i+coVs8gXqr57sH8FO9LkZk3YhITF X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:08.9199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e71a2455-2e24-4813-b8e5-08d5e6f4ade8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 05/12] examples/l2fwd: remove unused header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_worker.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 663c505..ad5468a 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -13,30 +13,18 @@ #include #include #include -#include -#include -#include #include #include #include -#include -#include #include -#include -#include #include #include #include #include -#include #include -#include -#include -#include #include #include -#include #include #include "l2fwd_common.h" From patchwork Wed Jul 11 06:07:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42784 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E30C91B4E3; Wed, 11 Jul 2018 08:08:15 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0049.outbound.protection.outlook.com [104.47.36.49]) by dpdk.org (Postfix) with ESMTP id 65C621B4E3 for ; Wed, 11 Jul 2018 08:08:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dd42LBRG75zWmITQduYidyMFICNYaogevNt2bB1Eeq0=; b=SjygG2Sg42rrW87fiSS/AmX8Y408bho7h6fehm6QctbJJDGeHDTS+5JNBI6knArl63XnJu5ANGZAsr8RLXGQsr8Ek/0/7O0frOaDeqZ0sVUCqBWDzP2e3MqJPXkNbEq4tFZZEKwr9ODORjMUlK/Tm2t5sQRCOkUJLJsDyo/BLoU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:11 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:22 +0530 Message-Id: <1531289248-20025-7-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43a2d9f2-4c73-4573-bb89-08d5e6f4af61 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:CEgdkgOw662FCTlbJZzaRLrdH3wnp8IPaenmFPLPK6QHl31pO2T5Z395g/gspfkMev0kyIo2A3MSK3RfN/FedNnMwZYxdckghv9/8cC5Np9Yb6Koc6xOFV995OW3lsfo9XyK55fs50PyvvHjqOMUa1wQp/hxEImfpB9r5f9EVIFtN3crvFDhaQpDzf/Rj2NjoWpBHZZkTDx7EEi54U3L+G2Q8Sw0ChryKYH6iV4AOdcjZIVC5iQU8iHCCQyIlBOr; 25:ycfZ/wdg4WH3eWYZt1XHEbn56ecyN5YkwBCRLLuIkMSQZyPeQdakXYFu17H4K8IpSLoNlaz0jkzFVP+k3rOpMBlqdTi7gVmiK9LXUteteQXLx7e89JjFfS0IEVvbE/28jsZBbmLt1f3TZb4Htq31jvhsXpCBywOacUIc3WRzVtNQ3yqlqKzxCLkcHSqxqlInxqOiAxrkyzEInSADlL2XTP+PGRiVZ1CGwvaR7stgrdnvhV08OpyS+aYjmbES/TqYJqNgMtstutobVNYC78ix+WiuAe01gqjfzB3zufzxPpYNoRLmL+CyYsHDJnkrBSD4j3FjpiPkmaf9bs+Aad7/qQ==; 31:OvXM7YtTjph37nYTYYvrQxF8ArbZaMiYcZ2p1RQRYaoGdkgKOKHezC24FmHXXw88JZTaD5EtHpU1UcVRaM3wpaT259szoLZGGVFAIYCZokTBhKFRtzU2ye/IrzhmOeV3A4XzVzq5vq/cyv1zL2vd6h89zuUGIwO/ya+dxfKHwZBWQTpBXFMnt9CY6l2KJCLO1yTFMeKneVST+lnydhZ/yzoaIeaaXW/C5mxxP3QR444= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:r4DyXxRAOuSu0Eg/qn20ihNsQsB8bQewxzltzwe5UzFvGj+fs6BCe1/taqLyzkOzTxgroZvwdWRU54+JwhWdhQ7+Kxs8IHjtTQr/STSD600kZsHIyvNyMGh/+Uk24rbsCtcU7rLsHa1aNMUbUKrCS1i/7SyOS12v/630BzGAN8kpLnsPQwldWhtQ8uYUrX+jChZsV6FeRvVPoyNiBhXORhuGOBLQnoVsBE4ylbhDztEc+zGIKngtq2spXanzaaLP3MUXF9mIBTWNVdWz8hsJHcXcXCOWBt+XNY2vqu47X6dX5KXkHJ6+0WI6CVrju7Is/V18ucu2I93H4ZJXO6l1Woi0WUzeF3plGMUALSPoPg93NeHdM/XcPsGnkCEVQ1HHRMaL7U6KyYl4jJ1dSZbjEKEEzy3wNB9ixqJoHTh5YX8eMr2/qSengcg7fOVlGc2Kl5hTbmAeQarUylAoezkTyDrCr07ZGMxNLfPneWux5MCSBDYKPxCmk0yX4CBikLIbHPfQitFxBVs82N7BnOVX9KRQptgoSAsHj0ptW5OW0kGPZ0XuH0FNqToBMREa2zFYXfqgXp8T7nVrd76kiWadzW1wV2EeONo7kg4EaLSr2KY=; 4:Q+oAo7EYWfYOZJ9fQ04xVrVzeANpdb8wsU9Mvzm8WEwdHOe7mzDOwLeBiJSRskt4mgqxWWkTftG9S+RZzOyisTE+iDSwnI7vkXm0xyLhZbGNWfnT5dweHABL9a64xNeOKNFt4qWAgvnfwdGn5rKj46VWGqoZLiFNNZ75rzVYWyMicfXmMp5zR7hFz3pxAODGMSEoP6ZS1kxvopO3PT2wzQT1fnYlPb+o8HCcoLKBeiyNe+PV/MNHY4jtChmlQoYalDHQHguujflYiqxsX4Vs4w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:rB/DUhK9YM77yVYGO5bU3A69maTVqurZvb6UqzoS7?= fTHxdhlSQn2Z2ruvyMscJ5aC3y+qs1SPwdvW2RwshdsE7/XUsNk1Aq/Y4WOt0Ov2qSe2BGUiqKmoyBbqBWcptEyhy3l4ZaW0wgVdV1MPNx3A/dMGbVmWXTOaOIdnoKrsEnAgzm4DqVNPrle8vs29hveTUQ9pOtxu5tc02IT+l9VV3SoTwCbvs9QPnMSt3BPffcLGCmBMIgthF6W++7NuA+o3lpxbWB/vSeWQsx/c+MGteXTPvNt2Q9nOJ5jzFVM1u/WWnK2/wSw2QFh+HpxeBIGXHkaw61G3+VwWPhA2wXiveDto9fctkbEv68ztc2mnjUP6/KCepEogTWogSupqhfQTx2V0PF/WC495bM3v7+kIZHqRTyIadvbMbdYMn2FWyXR9rmO81QGuxOrW7k4KuXWkLYnEyq6+YIz2Vk0ZPnc+x2XO8Iikxs5xCSMUnEotYZn3WiVPxqnUWWlCYD+YR9wf/41L2Cb511vih2sVenDB0tr0onxas1WtkVU+egjEk8YDVMVNXIfLqZ4owoOc1beXBKthBm/Rli4jpqr9KxV2vrbwJtry2us8GG9s80G5OKvruIpKco+XKYQ1EwsT/DX4HDlmnrEQzhV3xSm8bJBZrOb+nu5r55jMj4ke/6oAQScztYSKWSoG/fsVqPr4Z9y2yINi0N91xluZTed9hv+bmoTIr32uM5mvYIojDCgOVBhwQiqVeeneE7UlQYJS1yUVSnMCrH2JZGE5Rq5Jvh9wC8YvskNjoUlRj7XgpA74ADQz+TMnJwRmgTUorbwG5BpKP81GlQhexlqz3t3ifeS+r6EV53xRtNHlYM6lJC5oz82kA8kKUQ29W4gyJtTBwoeiBSGI3TIOFHObNib1fVrDNuIVeiTWxaeUMSdbEC9viiugDeH5UgLQFbImItEkq2EYGHNRXOOX3jCLWUJ7C+LJhS/USYq/b0vXQY4Sl7G3JX0r7CmQsThibgDaT0Inko0pjdtCldVQ2vlQHqjk0qbPQXMiOgHqruLkq0JJmBvzGGtuZqynPNjGrnzCvgJo7Ac3dE6bYR3zlRm7OY48bLlm2dSJ53/iI26EsEhQIe785xZ7jbN9tYWwtu9q5Dd9czEk2PBzpg3cwuAioh/HDl0k3BHNits7ze0rKZqoU6DDsPEqcWU5t2WcKuHR0uEKwLlAG3itkVFbMV1T/xmvcwpd0vTLVjcfOQKqz6YJPAh2b8= X-Microsoft-Antispam-Message-Info: 3bOxIaLTqdybPGyftFWlAENiod65esKiMZkyR+vPsohD1BGKW6Tpkp5mxz/hBvZEDpsm5nPuYGHd1BKivNdIdWqwDoLMFdd+srNNecJQg6dyBtUbYIL+uwJAXXizt5k1RpyY3dqbD5QsLSmltLaAiAo4yLbsq4vmNdLsDoP2BE/Ep15DYEDEhZHCgpxGm798TTfxduZBC7CHXx5uQI8n662MfLUr5Fp0Bo0AaKygxwr7dO862a1misQtr7sBQuJRkteQ48RdruawhHbKtDfFwqY/FA+WVKVVfnAMkw8MGzze/ZeREL56Ax2XTFeCrYhgFLfeCR++0+s7pLgJtUltzfbjL/RG2WoR2+YIrhu5Tpk= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:gCz50+nLjvrCETeKifLIvDLSDVoqKiOBsClsxCijvn7/96tHqnqJo409pA6x1Vd0ojsL3UWUDFu+PZI3ojcWz0bquY27KyM7/0utuhmzo1fDwNONSqkdFyPZdCQCSvdFYePYODimMSoz6gvpg5zIl5NFDeugysQVDI6jd3EuabX9wwOSerzuBD0QMDDxQgSg2Rk/hw9WGbM1BCzJnPJ2fEorgiKCZY29VJI/W/0nqW/96XG6fJeZV5udlHHMV2m4C2hEk84WiaXc7MoBgMQAzCOKFvknQKiBusXoy4ZMsPm23AijoG+U8eH42Uc9PWFDtoW/QvrrMDhc8YDs43FFI8/pSqaoaQq/F11+TLI2lA+0GjF5zO6+ZCx6ni3qb5p2XvA8zWdRMHEbtDJYuaNzeH1xS8FxVs5YkkmFYoM7XKmbtlwwSnkNUKCVuMKxtXHZ+rOtMEmWYLX/GQfrhaZPbg==; 5:O3mHNT4KsMG1SHMnexp45LvoZdFV1j/J1fR8wEW1L+A9GdD4PFntzisz4VoD1gazLGZ4/wB3KuHCoDfKbhKeitjxWbW5dJ6SoZqswVGjAel/E/I7JL/hXN60F31m7t+vndWLHYI4PR9HfFuvodZ4a0c5edVGjMXzDIk98H5k9IM=; 24:SR7Ibkdyc0Ut85an3NDydhjDmpT4rZmCJOy9L5S9AUpW9Ky1+JL1+Arcq001egGKH1uHnXNO117JGmtIFTa6GEmcHcAkjwRraJwWzKQ87W4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:qO5uXA8N0u+E/mMuDveoZqOHGQsGC05kZyjBzyOgVCfPgKHPcqkbVcEJIOZ7hIqvaMwSGSoeplNnJ6h6jSjNY2R38AhLRBz2grL2+L1KR+H0d5n525G2JRIHEZAXvD60Th2ixY+iq3FWAMEG2tt5eVRv9odWmPuxYowUBZZKF2r21uR2GwFSidl7kMI8v2HjTl5b8vN6xqiTF7lGmE3mnvgIL6H2mEyMyVM4W3uWowYfaLGBULgT84JanW5EVGkK X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:11.3436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43a2d9f2-4c73-4573-bb89-08d5e6f4af61 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 06/12] examples/l2fwd: move drain buffers to new function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index ad5468a..dfa78ed 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -76,6 +76,24 @@ print_stats(void) printf("\n====================================================\n"); } +static inline void +l2fwd_drain_buffers(struct lcore_queue_conf *qconf) +{ + unsigned int i, sent; + unsigned int portid; + struct rte_eth_dev_tx_buffer *buffer; + + for (i = 0; i < qconf->n_rx_port; i++) { + + portid = l2fwd_dst_ports[qconf->rx_port_list[i]]; + buffer = tx_buffer[portid]; + + sent = rte_eth_tx_buffer_flush(portid, 0, buffer); + if (sent) + port_statistics[portid].tx += sent; + } +} + static void l2fwd_mac_updating(struct rte_mbuf *m, unsigned int dest_portid) { @@ -116,7 +134,6 @@ l2fwd_main_loop(void) { struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; struct rte_mbuf *m; - int sent; unsigned int lcore_id; unsigned int master_core_id; uint64_t prev_tsc, diff_tsc, cur_tsc, timer_tsc; @@ -124,7 +141,6 @@ l2fwd_main_loop(void) struct lcore_queue_conf *qconf; const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) / US_PER_S * BURST_TX_DRAIN_US; - struct rte_eth_dev_tx_buffer *buffer; prev_tsc = 0; timer_tsc = 0; @@ -159,18 +175,8 @@ l2fwd_main_loop(void) diff_tsc = cur_tsc - prev_tsc; if (unlikely(diff_tsc > drain_tsc)) { - for (i = 0; i < qconf->n_rx_port; i++) { - - portid = - l2fwd_dst_ports[qconf->rx_port_list[i]]; - buffer = tx_buffer[portid]; - - sent = rte_eth_tx_buffer_flush(portid, 0, - buffer); - if (sent) - port_statistics[portid].tx += sent; - - } + /* Drain buffers */ + l2fwd_drain_buffers(qconf); /* if timer is enabled */ if (timer_period > 0) { From patchwork Wed Jul 11 06:07:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42785 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC9B41B4EE; Wed, 11 Jul 2018 08:08:18 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0085.outbound.protection.outlook.com [104.47.36.85]) by dpdk.org (Postfix) with ESMTP id EB5791B4ED for ; Wed, 11 Jul 2018 08:08:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xgahZgU0yDb3Q91i+NBHoUiIbzYG6M8DWrBi1JohPfg=; b=Ah196d5pG2kaCT7EWRQzN8PBFrEhctYy1Kpb4GmQfPxluAtWQbly6tXhOmNRiFZr8foZ0pTstXvKT2A3FeUVWIE1H/lx16tINB0ujvjSmLT8lJDOOqnkGwiZlHijbnMKTcSJums7Xm4zHbTPo7UdLlgz4YlcgaOLCrd1DC8TMW8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:13 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:23 +0530 Message-Id: <1531289248-20025-8-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af62a0e2-ef17-4bbb-e83b-08d5e6f4b0c4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:rPC00sSBRrp7BashK5xAPAfKr7pvFK1wPOBkanRUTrFjn9I4uMp5dd4pov6uwxEAJMuhJyJUR5uQl4VTOj80XJEm/Kz7AiHnXLPMauL2GZs1HiK8kNOfKQ7Qy5MNaRszYByduHLdIRpmt9XgerAh1ZeBry9+Hq4CU3y1zwLLdVB+wffxSNzivxpcFtgKjHdZQ6JiUGJ2BnZKlOZUjsupVhzNCgBkXMixHYT0CMXoK2/RgUvt760qWTcSLJMT88KR; 25:sAOHiAuTGmJ+TjYiHLs002e0+QEXs3m61jn+4Q3OYhgUOb18G7bUOwS0eymH2G2o2LF8hu0e2ynItmZGeUTR5ItNFz7rblekN9ud60eIOPFv88EjxrAbGTlPZQmpXS0CghZZAW/B+4jHZH6xphxBzzMDFnlbJPl6pAATZEPU3mAqUBAJ/IFsPSv0I+2sabDL3sCJOcR6A2l7a1991On5jrPcE6WmrKPsNp1fDI8tTFD1xXiyLI7iXAvsitjXm9mcveweinxzlCaO5x9Z1vlM8J6jB0SR1T+94plYYcvu9n3ncZT53UHJ/NDtt104iEFBLCZJZNOzKcoayDEDsqVuiw==; 31:2mtj2zjXDga4mF4e3FEX0gX9gF2FXjuygTdUxjdmlEalddztvyPGiLiwWRlirufA6W3LQ6dHzjVVgzUQBND+vXo+2G+skq0ydU0M0IsSFuO5/OdVd2OPJq6pD86BCKSOHJbTfy3j2frzvQhC6pmhMrk9jhMa7Lg3HdjjdEZ2yL5hz/fH1jm+g1dbp89KNfO9BqIewtPTIyBeLQ4ie8Q55hZKRQRDFrqt/PW9kUN7V2M= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:6Wst+TbnvYqZ7HIhaC/MEd1VTzaAAA2+srb5ToX2xTBsqNkG9Hv3crclvtTGKofP9YPHfqTFh84nM2EksIEgLleqgAT4YlHrjcW6t7Hi2T8NshE2Dlu2uZSYWUSIebPcXjCEs2yXCnSyBgWEaxZ2ZeJTJTyeIBUklympg5odcGWl50wKRxW2ek516USK97BIadIjqL3kP5EKOAXg4M0B3bftinCAZVsAn82OqH8imLmWSQpbnUL54GU/yiaTb9AmWv5xymmY0kuN1vxoDVbq2JmgX+WqjW9S+qKlxx6JdSUyN4wABn/Szp2EH6y0cZZaDLZ6VpCgLCIRDSrJq2yc3IJZwY+tUyWESXu7kgonRay42MCt3Dfl3g0NGYkLrkQ2ii1Ldrz/zzMeDfTxhFHJAamO04mySEo+T6xEOcq/DQJdZHetrEKjqku3Nr9SEpY+50qDZ06SV6EsZfKQCkqmNvVGEESvLzgAeP45cfP54YTgi5TuzPw0poLRcK3bIb4F3IQXdKOJ+Zw5NCQPZgqGwRsiyoildKjsahm0jzoTykkFmyuDIX+Qj4+ABW24UntVDdswKY1N3ld7oLX3vdcYKDRi5DhV0HU61pXcpTAbu4A=; 4:kABPtKo4jx6Rc0KDyh6NligDnabtmVspZ1WuASbEG0jfTla42/TGV4bq5HRdOCbpaOIDughMif08Gm6MYC2Yqfislf1hmQcc6xPososxBzeqVanHOwwKy7MAO6lVDab0ofzH2kmDKLcCraqb1Qtpc/Y6z7tT4AhWRSs7I9WqR6EXJJFFijiToSVtPNxESl1D9t+7NL5kcwtJBUmWjafAyUMd9E3+XpvftccEN0OC70DqCJqNXQtrCqT4GxMO3UqQnZyBLK0+sRKOFUTxUKnRaw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:uxdWqEoylUyRfYbfUcTxUZf5pyjpyd3QwUGIQQKMJ?= 75A6WobRxVYq4T9hi4iXoy2GCgMSa1pX4JeAJDj7q27LWbqesxILFkZWfhutE1Y5u0mOA74fnuWAXolH0XmOeVtR6WCj7IZm3novO4ZEpExrglZMnj+0cwEQsYh6QNBXLQRZH/+D4u8cxiHfUtmuX1hV7DnnEWnUsEI4eSnVeWxHVU4RU3oxQxvA35FohuqXGHIUj3QVMKOe6+vn4kdKdkqmRS7x/kFfG2PSO0eV2Kb7r83bgWAI86K8T1Aqr7j+yJ3B+KicZwbt4DHexxUhjzm0mGYNbT18xa6HZULmJ9G7t2znKT+9MqEg8dG+9E57dkWiFWRn7vgbyf/Z31y2y4rW5fnOvLqqHAfj0HVTLZu14p0pX1xRqVgghUyv8R25q187jzCI46jK4pGCzc7MdvwxDZhiHmXnT3hdEAgSZSiWCGDF+NbGIBnchrjgpU6CDRyTHya+28Zb8shQNlFEUHmmzINTsz/O09QmV0B+FIHJqgwF8MOUeFh52nVY3XQVMmi1jzHqy9BJ7Bm9dcKqmUTkC4uiEmpV9H1EVE5AJUIghmjbpFGf8fdijjiZ2UxB/RbHel4tAVHoJzX2wk9gFDtMpZMvsIRE3kt4jzAi35EiG3ensPvgVrk2L9dHX2QlnqlqQmXZh7+XL/dUqA7VXS55YaYZ9ClXfPjbn2Sfqg7rjqACNu8AYp6jtb9Itiw1YQt5eFlzffsXSLJEZqXSIDUl1rhkEV0ognFm33LQVk2tO7W1U4glRplU+znWWGJwno706W5a9qR5+cGjrI1xF1HJWm2jXq85dpioR5naUAyJznIpqDyi1RUoUKeOtqxr3jT0419jYcONITOhjYs2q5ZJrMEZ6l3x8tTO6xdU1bWuKr9su0dcs9X5YtByZqvkVUIv6oMLjRzeuJTPoDjLKdEaEcE4e3uXaPngep+iL5XADn3DQ9jvFmKFfaQL7jNIfFJRby0qk/77wTERHpx5IpwQqQYaNCjvuie0uTXnaoRMSj1Rv2nYZPFVodDbURuqVhQ/HOTg4h4Urkc1t5W8BNGyqwoO6DBQ4p1GAsitup7L1kxw4QsP84cfc3WT3LD30zHmhFhQKCh6l3+58qD+8ZNzryXGsx+oumUD14qqojgsnYUvsFL9d0NRLn2pinWCA7TCVwXC08rGVCoWIY1/39TfUqQKCONfrvow9wr/BMn+ZQcxwZY9sgpA8U7mJx3S1s= X-Microsoft-Antispam-Message-Info: DVdES69+2wH7P4JPKkzDVIDHavXP7bHyxwEBa2j2Kys558zmHn0XXvOwBxERHZ9Jl67dAgOAuc5bSYSS5b9A/cRQMSwTHT6aPQzyxBbn8Ewm4AepXSxnbrNTeGQHN4K0c9oOdIx23SpiOnJ7hOik3Bx/uG03yMYsGi3zyTwwXNSik7rbCNVK872t5yZN7AYXY5XjtppwuVsO6vEdyE7sL3+mh921WceLWnmlvlLPUmFGQzOzNx2jTIbqjR2VbunvkfnC7jtOMUeTHeRwDmBGZcNwOzHF9SFtOVARuGdTDYvcn70L6fGVcCGv9pkAoLX94nOMzYG2/yx2PjhoIFg6zf/osFGXm6k/O+HtjhS5d80= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:xl0iz2ZqJzbXQ3borMPx9rJ11oPO0lOcVBq+CW158cvDp5NnAxWVJWVKehlWCWDb+ZCI1hk56++TbiNNk4Azpz37uOiA+MkqWvrXTS5AB5U91S5uqR4rsK0SJ2GSASw510hlvGYRIyzCYS6nBjG4gmhC6DflSpgDzru4brQ2l+3YdG4b9CNb3Ozzd4jj2VHg3OzNokG27+2yMRM4xsa56JY35wFEkDwPY0zI7c/jcZYXiUHIy+zb+JsAQtyRp5O65j7AcTCKyW6Ee5FcznafefvxBu6rX6FQ0eB2d4+2CQjXOBFVshPrqqoxYFyN6K9BPffVUdP1alYsf3pyH9S0cgw8SBvNs2Uksz+ohrarj6C5veKiP0sUA4ibxhnVjUt6Nb80vKa00rHp6ClahRm0qTBef0JrTYn9bVy3YY4Q6lKPlyBl8QnjGBns6z4OL8myahOZk46x4jrEBpapP+gYkg==; 5:/Ri2IE3wOkjlcSmgZf0oWv2dFZ+u6zyUvCvnnPk5u9YfHUO8dypyOZciBPS6VY76mSTlZTwTfkria+PLpXVfV07h8FNb8u1J6u+5hNB/BPqIPMeMS/HkEHXuJJvQksGPWy+QJknd52zz9f7G04Uz0HQz8F76auuks23cN1rZfsQ=; 24:aacTxgm9j/8M5N8SVaPlsJEYWWMTMO2aSkCOMicYc5BDpjyVzfVhL4hmvWGUY55JCsJVgBShkagNFBP3wYew3EtNW8aFXxnfIkiPstbd/Pw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:naTjDimBju7F/wXXMymSVv+JgDNeTHch1txpo0mCh0eqGMKIIbIFAlneDDapUpaGLOIEjOuv+g187pC8g31Um5POvXyieE5NTyIRxOF38E4qHsGIknDAVZKZM1Cly44wPOyGw9aWr2D5EGyHd3GTNOuDbDPRxcKYTR1OnJQz/nPFtJe5c+kvxlB+PSSd1LgiYEfAmlK9VhPfcLaf4AfXajBu/C4mym5Aj54VQ2V5gpZ6K1WTkWC/JOVvPnb81RRG X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:13.6553 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af62a0e2-ef17-4bbb-e83b-08d5e6f4b0c4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 07/12] examples/l2fwd: optimize check for master core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index dfa78ed..f847832 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -135,12 +135,12 @@ l2fwd_main_loop(void) struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; struct rte_mbuf *m; unsigned int lcore_id; - unsigned int master_core_id; uint64_t prev_tsc, diff_tsc, cur_tsc, timer_tsc; unsigned int i, j, portid, nb_rx; struct lcore_queue_conf *qconf; const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) / US_PER_S * BURST_TX_DRAIN_US; + int is_master_core; prev_tsc = 0; timer_tsc = 0; @@ -162,8 +162,8 @@ l2fwd_main_loop(void) portid); } - - master_core_id = rte_get_master_lcore(); + /* Set the flag if master core */ + is_master_core = (lcore_id == rte_get_master_lcore()) ? 1 : 0; while (!force_quit) { @@ -188,7 +188,7 @@ l2fwd_main_loop(void) if (unlikely(timer_tsc >= timer_period)) { /* do this only on master core */ - if (lcore_id == master_core_id) { + if (is_master_core) { print_stats(); /* reset the timer */ timer_tsc = 0; From patchwork Wed Jul 11 06:07:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42786 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 064961B4FE; Wed, 11 Jul 2018 08:08:21 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0045.outbound.protection.outlook.com [104.47.36.45]) by dpdk.org (Postfix) with ESMTP id EF40D1B4F2 for ; Wed, 11 Jul 2018 08:08:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTUWZ6YXvnUOs7mzK2kAno2elRpdK5zaoty3pQKLr9k=; b=DKaBUOC7mR+QVa6E2isuu7nAVFF5S5hWG8LdnSC1bXW1tLPBCRvLiiUpwVNPKDd8hZ4KVs5rRPZcEmIdTKSc6X1lFjNbPcsgL3Sr+nucMv5O0UQUGvAXzznBwEyPAiD+Vay1LL4QuA/yyPI9cHWmYBK417nWXMe4wrl9pPZ+DAs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:16 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:24 +0530 Message-Id: <1531289248-20025-9-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e3c51fd-4696-421c-e889-08d5e6f4b234 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:8RPOgI3PdO8gWfUb3SvdZ7Fvs3o50RqoTltyWrvEfUsNDvjKSHgqUVwispm9Ijhk3Nzv1bDZGSVjTpe+zxZrkYRlDLPpnh57F+XEB35j42jkaEV2X3SqNu++qxXKxhpTgyZS05059uaN50O8yjSOKgA/B2jwZ4VVCoTDdMTSQqMFAyqHLQ1skOdX44hMwLeA/pKLNh8XFmrFZlYB9wKtKGRewiVK49FK9LZvgnzKC7TmeC+vSul/6p5Gq0OfsoXy; 25:hrgt8dhJFRE3m1JqMIRZ4cByNVNho7mZbM0D/24Ys6zHEw42qgqSKFk99vxIbOseyELm1vHYUsGz+b5ADpSjmgLm4VRRAnLE6LAutS5r2f7sr6G5RX+YlUw9v8bXRu/yXTt/NxUJiZMWDWOsm3tcKfbTF6hX1sdRI5/TB9aLJeloKc5jv7lRZFG5cjdQmjH7wnrkT8yGICAa7DOYhgWBI2hv6JATJ60DyESr+QM7Ee4EKdvvI/TL/Jx5OCrW/xYH3bTv0DoEIyvuqKCbGEn5UAfbQQoXtCKluwuqKSOSXHMb2Cd4Et1MbHfMRKcUyZVgaC9S2aZEHaCk+VPoSlvxkQ==; 31:H2CHQifbfF+DQWKxrayczTHw9bZFi4+wym/sdEal3XQCfsfaGfXDoIfUmUfulgc44cfAfWfdV1Tva4eySJFtnMP/3d5TsG3WIYtpK5Yt+Jgh8uazzCGYSr6uXfkMMBpcj0Wn32bqi9Pnc0KV60NHRXgvwphLgRSECL/WDlStOKCCM2fUCFsCHwpd+4jqn/3QgFdWIwV6I/B3RaTnMNmoJOEApHjoYM0CNS90Mf1fmTA= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:YrDyFQBKeKGlomtrMbp/dOm2M2YeKi7EaolJtjljsKDJKGHm2ciNKdmRqdAzphc2Gym+5K4lRGoMV8uoAnrblFC4ndJt8/mQRfVY81ZlAjduAyCVDsCHTSjyVBGkukS9fk92HMBsU1GX4EUatkQBogrwt/HklG2jN6ng0qQoukfqMFRRj4i4Gz9kGt9Pge8w/WqKDKjv+R4H9BllFFQkxV9I0PNS6eHHkWwldmkR59WuMD+6zF1GB89oaBcscxuihtstmJs1UdxgjDEb9Q2SyfE+Xp4fYBnbkPk6zPWC20AVnnahfxfum5krAjOE42FzIU7sY6CiM1Tc5txR5y3v+VKEl+9inEe9S3CoJFhsAbPxyanL9Au5WAjI3Dk5LF5gMxmCXtD4iXvgCotaHpXRCWkLVYUuuxzF/DTq70A8sbn0myUan3qwVSp1T3LKbh6ALoWhxfcFJm8fobC1UDA8w2eGMS2lue8cTGCnE0temReUCrcdb3QQGUrm50dL+oTSZsldSq0O20Q6h8ZFCFD1D7e8aHcTRK6Re5ArKmQRP50ri4zutiLURa185XmJAwxOuHys8soMi9MKE+Plmsxmb30bC/+YJN/I/qjJq8grxkw=; 4:MPZI+/Mkfcuh2aYHWvRgZQczJw75qBRiKM+iZawP5HhHSFY2YWY5esSJMlD1ZzU5Wf3jOhtMZoj3348gMVoaR/Lg5Bm8iaJtZAkmLRLR9Q27k/ORWCL/zaZVhLXBK9UxH8FlH9cfCMVK/BWtrxymNGiQ3GYvy5nPrfW1CPlABr7ZB+gPsULzrSDnOqlvjnBOqAlDfTQBPlq9pbbpSuBc65ensmc4FyIh/aqo6rUidEiZ2Hg/5ZW4056NL7a4gpcn27IteS01ncimjllp4NWw2A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(575784001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:2J8SH9rXGZsQ5PzlDdjD/4jk1/xzx2NLhwHTQr4Ss?= c3a3GGcaVWk+LPtqbyULcnmkdT4RYBt4bRa2ZQFPeXQEShUO0DN8xOpr4BQl6XlQQJrnnJU+QpHvDvgX7/7+fTSwnZ43i50RnrIGCorUp7lfjLMJnNCErdOdy9MHB2ECO8a6hdzIhozkoxcq0h9da1ANC97/EaEvhtNk2BcZPnvCWuYVuiMwj9be5dmtk4TWt+tnLc6kBI0q88Z9uc920sQfXj+kMULl4sDyk+4/z6w22zXKUqjyaY9KImeVO8CKT19JEdenpYWqwCNA0pUwI2rynWMsaHwlYPhou6tEVRqAi3ko0fW08W5UtO71EsNwaNgMf++mdM+yPrKlb79NN7fVECWUdB8cI36rsbJKbFXYO2Dc2OR6yfR424cVa9Vmfihss9Px1rZyqqZbkE6FTyiL2XTgcjHa7SgCb7XJxCXv8L17Fr0bBg9CEuoX5DRbJrg4d8EViT/x1xENbkCMniWV087tfoOzcekMp5N13Qb2lgfXn8e1/3CCBX7n8qRJdyNMu4pRaw3R3KIObpMWIPGMcQkDuxbciwzypbenylJRNzAvxI49t/2UOVeGp8H+gGlGMTLeRlOTHOvmqztPvjIFGRzro7HyGO9dLTGGKaxgsyJqj3HpdnW1LToV1zh629kp2aCc7WgnzbBfJKETGW1VJdzQyhVtQThihCVArKWk8Zo0xzibGUTJiekOzCbo6rKyOXamLaFSnDB512nGCgc+qd+AVfHhPUMgvuu8WxHXuTYq+n1DVlK4wMB0ytUKksCHhX3e9SooBo68GDXSAUxp6c6hv1pNEwKd38CxDFs5xDGgBveerCh9tw0/p/ShdWSP2lQLeK4dosl4dDvHzb+c1qPKpP7MXh0tAScib/91zPHa2NAGgZXNVpqco0mepu3e0jEFI4Kw6Ie7IcC9h3Rs0Mk1Ylr6wzKUPa8IIWE+5dhWy2YUeJ3ye7gcay0+nXvrcnYDQh5Q/qG6j8evLPa27rRwMpJB69a10nOYmU4hjLxYIa0Q859X871JJIKVNOUhmsj7h9MvUQy9cCgqankb8Ol64YELiVNGeqTOByW4r6TkCpyeAfS21E5yZh1JaEh0ZAf682hmYCJJ6fyWFBGXfxFA7J2uCufTWJB9lJe4ErxlFBEEYmr9fMhxYP1ZWfkA8E2yC+R76xysqgdvXiqGV7m5u1u8BO/X8es0mU3MvEQUWS53FJZtIbYi848iopHJP1RO1gmKe94AM9c3kdg X-Microsoft-Antispam-Message-Info: pVowWTX8jjecM9uWDNdv3J093xWu56sQ4ja19UeEsgKsf1jO1oEcTGqdBoMcVRUSPgpUmcn/h+T81hNuFVl3Tl4dMzTseBurF+ttlHd05fAlsqWmKyiynItC6OXPhz2xZcK2lOIhUtw0BpBx3iIfpGHd3Gw/cjXShH8uRoYIvMVBixC9Hxi+no8vNibHR0ieL2dS7WdD+ONl1fKHFCZk78+1y8R88HPBwz7iU5PhDBMcdWfDBX8GgKNJVcrhfbpkZQXmlQE0dk1RyieA6cNFh1c6Ls9OQjSs2I/vTgpHBDJPrYyJBlY5sac2TJ4WKdWxklj9+pJSlUzDSCd9WcyfSAxaU0xQ4XmoRgviFv5o0UA= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:SXlJq3I29XprYMBfX3NWtUho+exvWFld03zOV66y3LZimIC+CiB2olQTz+jf1FrrFfzeNSAxHrimcibeoPL2yHDdtDkIBeZBP8zxp/Ku4wc6OfM348zlwxnvrGZr1NY28E7cXQJxkhVzCuj3dTdVCIYeMZMKb89K5cRFoijokaCF3uD6dZO8zXK+GaGA0F+vYxES6WvhYwbrV7G8ZMZQaNUOLonNRjqkrJNUc8Td+mlXCM+woZYAXIzzFazVneHk8lhM+290Vp/ymh2EW4pcn8kQb7GWJ1LLceO0Lh5jhF8U16gPx+jEQxHWOkxDk3MHuHaP2S+vwFqe98yyAMf1wWeUQApoY93JI8cbqQQrYo/eCzduR5Si119IkEfgXqKeftTqgjx7jiBCctXsH4z4sFgJh+UobxYa7tKiWBiPyV9OAVT34mUOBXEdOS3enbSp31ppuo2z0YFjmnH8zRJesA==; 5:b1tFC4cFXUeSOBxmMJU0e5geIxjwyY237FI/8lw2kcnlj8lchq9RGKMeXhFCcX6yo7oLs+gNfSTkcwhyEjwSNWOQTpXlYij0FOETQ6+pRg8uhYxDFDryVujo1AueWP8Xgp9X2zPmlNqtEOgGQNjOZvDC7YxT4bt8rOub/KK16Ug=; 24:QtpPgOGraAmK0T6VGrGTE+QXU3gQ1fC/eZ0suG51/Io3KlvFG3XhuwKsA17Qr0dhSeXrLmeT4sSrIdcaLd6SnUl9WgwmWKhx7i8dkS9NM5Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:XRfwccNcGyJ1p12ZqG92lbTJ7YDqjj1MgImEf04gu6qAQJwfNclGFQ83Gh1gMBRPyPAVDQSCusGm00kPn5OwfcZpHXnUYDfToPxIB7Sibt1vDMo1EkxvpW8T1eDOEGfbRnm+D+/MiT5azTE6XJH9f8SxC7sDOLuIxDKiOy+WpLwpoCtBpMeVH1Au6FEepOnqc7zGvMMgnvQXWkHuVXDyvj9gb7oxE2RZ6lqtR5sOizqYfKpgO6Qn90wdFK90bKaO X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:16.0050 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3c51fd-4696-421c-e889-08d5e6f4b234 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 08/12] examples/l2fwd: move periodic tasks to new function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 83 ++++++++++++++++++++++++------------------- examples/l2fwd/l2fwd_worker.h | 6 ++++ 2 files changed, 52 insertions(+), 37 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index f847832..868d0c6 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -94,6 +94,45 @@ l2fwd_drain_buffers(struct lcore_queue_conf *qconf) } } +static inline void +l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf, + struct tsc_tracker *t, int is_master_core) +{ + uint64_t diff_tsc, cur_tsc; + + cur_tsc = rte_rdtsc(); + + /* + * TX burst queue drain + */ + diff_tsc = cur_tsc - t->prev_tsc; + if (unlikely(diff_tsc > t->drain_tsc)) { + + /* Drain buffers */ + l2fwd_drain_buffers(qconf); + + /* if timer is enabled */ + if (timer_period > 0) { + + /* advance the timer */ + t->timer_tsc += diff_tsc; + + /* if timer has reached its timeout */ + if (unlikely(t->timer_tsc >= timer_period)) { + + /* do this only on master core */ + if (is_master_core) { + print_stats(); + /* reset the timer */ + t->timer_tsc = 0; + } + } + } + + t->prev_tsc = cur_tsc; + } +} + static void l2fwd_mac_updating(struct rte_mbuf *m, unsigned int dest_portid) { @@ -135,19 +174,18 @@ l2fwd_main_loop(void) struct rte_mbuf *pkts_burst[MAX_PKT_BURST]; struct rte_mbuf *m; unsigned int lcore_id; - uint64_t prev_tsc, diff_tsc, cur_tsc, timer_tsc; unsigned int i, j, portid, nb_rx; struct lcore_queue_conf *qconf; - const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) - / US_PER_S * BURST_TX_DRAIN_US; int is_master_core; - - prev_tsc = 0; - timer_tsc = 0; + struct tsc_tracker tsc = {0}; lcore_id = rte_lcore_id(); qconf = &lcore_queue_conf[lcore_id]; + /* Set drain tsc */ + tsc.drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) / + US_PER_S * BURST_TX_DRAIN_US; + if (qconf->n_rx_port == 0) { RTE_LOG(INFO, L2FWD, "lcore %u has nothing to do\n", lcore_id); return; @@ -167,37 +205,8 @@ l2fwd_main_loop(void) while (!force_quit) { - cur_tsc = rte_rdtsc(); - - /* - * TX burst queue drain - */ - diff_tsc = cur_tsc - prev_tsc; - if (unlikely(diff_tsc > drain_tsc)) { - - /* Drain buffers */ - l2fwd_drain_buffers(qconf); - - /* if timer is enabled */ - if (timer_period > 0) { - - /* advance the timer */ - timer_tsc += diff_tsc; - - /* if timer has reached its timeout */ - if (unlikely(timer_tsc >= timer_period)) { - - /* do this only on master core */ - if (is_master_core) { - print_stats(); - /* reset the timer */ - timer_tsc = 0; - } - } - } - - prev_tsc = cur_tsc; - } + /* Do periodic operations (buffer drain & stats monitor) */ + l2fwd_periodic_drain_stats_monitor(qconf, &tsc, is_master_core); /* * Read packet from RX queues diff --git a/examples/l2fwd/l2fwd_worker.h b/examples/l2fwd/l2fwd_worker.h index 8971a6a..65650aa 100644 --- a/examples/l2fwd/l2fwd_worker.h +++ b/examples/l2fwd/l2fwd_worker.h @@ -4,6 +4,12 @@ #ifndef _L2FWD_WORKER_H_ #define _L2FWD_WORKER_H_ +struct tsc_tracker { + uint64_t prev_tsc; + uint64_t timer_tsc; + uint64_t drain_tsc; +}; + int l2fwd_launch_one_lcore(__attribute__((unused)) void *dummy); From patchwork Wed Jul 11 06:07:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42787 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05BAB1B504; Wed, 11 Jul 2018 08:08:23 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0085.outbound.protection.outlook.com [104.47.34.85]) by dpdk.org (Postfix) with ESMTP id 7722E1B502 for ; Wed, 11 Jul 2018 08:08:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lixC/zKtJ1we0PYtNKIVcQdUFbuAk9EhQY18T85fbY=; b=IvSFluRRcRZBUUr3DaeFbDWGwHlQeXfW1tJ+5iB+MQJUjH8oGNjBb8GZUB+nsu1zKxBTWeh9qYqsQSRmYZRrOKgQGvEZHNNrbcHCKThuKu81mmaHBHFz+0Ltq8YgrRad/PsyrzIRhGxJufPIJz//kQEtTwOR+OMyjKMyiCABDm8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:18 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:25 +0530 Message-Id: <1531289248-20025-10-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48322009-acc6-4756-34af-08d5e6f4b39c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:VICy+ULkma873lDL4/kB1qLMUvf9ps35kbeAd9ND8QEeicXjZawxP0plKNFEWNyflzRJRYLZH6dClTgL4femKFMNFZGRFrxDKjcaxrbpA8guOpdUicogr0knxCtTq2sMrsKyV9D1tYAO4hht6vx9nsYGxuvqrtodd2DgG8sgNkuPHiRVVDbEcfr1mPTOk7eY/F4A3kANYR3Bk0sEav/M0hln3Tt6d9Cw8QF0ET6nnwowstNYvgAZoQcUx/JWOrXE; 25:EGdDsirZA+EOnPHgz429a/BuHVEcz1j8ECyON3kTqTuy5XBjwEgoRGyPXZiCUxrf1o7jSY3XmQBHuxPnS4aAwxKTOSp12NN0Q5w3hEPZjpQnJmv8seiv7HUgNAAO9BPSneeYXRJMDBpfPrrI63NgeP9jmiYqOSqZzICajeCKUxlXUjsbtFviHgLOKTJ1NG5H6zW3vq5ugmZ63GwUydyu/kKqAA72jfVhTMbUSy4FNGGkrfaJkP7BIbA8M/wspwUy5JMflq3DoLqpFbFe5j9jhdMe5qWRBOpy6k/k6Ai2onKfLAgh4qveYF/pFoK4W4FRRqfXQo+M/8gZrv4s8wk4Aw==; 31:MXt9nZoEcwoRswFHVL4rbLyEM7DubODdshdgogIOOnyudD2cLyZRJxnJVEhg8NNUreZ+F0sz8mlzhuSwe/sYgKPrXsJK5RuE/Tgaod0Q9zONc5i/B6/qKvVRHNEDHBmQPSGCax7YIojQKElypmKc8vJn/I52JcD08patLoAWnmt3fgJvGYOtj9tQWI+7/XEwoEWkOj7+FdmQV/MfOdOpPi/pYw17VkYn6gh1Qf1nuYs= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:XpyxOcnCYdc/a738QqkQqxvmWvMlypS4SWSsiXkzrNw2AIyw59zP4GILadHkzsAZOQoF84hnG2fa66a4QTsyw7W+2f1gqU27vkY1qElUXy6agLUhXcS5rcfwgUmn0YT4nJEO5uumeKHRNh1lHj4OK9UgiIqZebVkb9Vct43sBkyjoc/3PLJ0Pno075SJW6xaREPrsFZq+fJtXhmTrFRs5jmbamKCQ85H+yM3yayw5/n0ZCcep15OL6EAdYPASxGgTAUpxPxtvEhXc6rnhX6SiKlffcp0lEp2IB7nfp0jlpHBSx+tQFa+GEaXPjyfJsPJoFXgzbZfAoSRtVLQacEyt1J9KPGwi58L5hmqP6P1OLkB+uAv2vuQBdD8iBM71UGgWSIWOzyXFdspKg3hHyBN/q52/6dG/y41ZWg4iw9izVN6ZS7BPsBjjd5ojomTlSoeXGxdonJyBiIosRMZjeDG4c1KEpkl3h/n+hrj404dhjrrYL4CvmuIb3wg0wuRyryX1wRUeaRtSYYzcez1CigXPawTJHKmvkg2lcJROU0sX3QiPlHZIaZfuFrCEXzcaLpbAyOKb3GMMXQr+LsrEVKUcGgReZvYKMf1drCfWGTJXe0=; 4:VaTLm38sgV4z9H/Y1eDXF8LJWiieE9mJhITKJBOt3H0Bk6uERkCS7JLqueHMzUwjl6b826Aq7pRUrpNfaMWc3LlAwblBR3QH+5Bi/oZDzxpDphTw8qIzLDgpR+vPbMoKLKWEPr78ip6ZFe49ePO/MYyxKhjXxfFpPMvw4WSf/o2xD3fU5BfftsXwT4dq9qYMMibhrZ0p/i2/IYsegCbECptEjxdCJJwbUd762VSBXx18GQV030GVjG2NvAP2ri9F8FVRQPXr8RDd/kDh9S7qRw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(575784001)(72206003)(15650500001)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:ksq/P41tsqVCxEIvE898i7N/DVYlBxlKDYNq6HHWD?= lLBmSQKqz2yj+xMhIHhfbgkzv6ZBLpjjm3yFEWvYGQua/YA0XHEJiBY27KabTj73hLYKYqDFzOEvcb5cjDzj4cmKovZ4DMwOlxneQMi90n7RMk5NFqG19tQgjXiyoPXbbxbbFchYSGKrNRoHAAb5SZiN6fVIWTgehlDhpSbPVr6+Q5BWT8DKwiuUz9G6XE7uOoWtaUTwzB3tYRCpp1al+psR38BAhq8ALRtkw8gjgwYINi0MUEEbM1LLGRO6H58ry9fj0PsBT34w/wB8i9WuHzlYR4LC87UjOnsn0n42m5dCAPlRTxmtAiCgge4gwsk/eswBF8PKcwNYuJWGOC90aSYyv5FAUnB6qPVvStB0KSvLgsZ+s4nycMdSo1l19JXkX5ly78OykbpRN0MA/Cff3TRjRZU0wAGrOUvaKAnj/HOq4a7HFWwJkytN9giyPzMRmBJ2gL2XZ4QEqOZmNuuAnzrULZ4n4G1j4wQeSCif3jd6UGCC/vfVXa83wZIi8N1a0PLOe2AdbFY0+G5GTs9Sj/NrLPd7zujKZHWdWawCpteR3DhBb1z2uGISTwn0saXmDz69KXr+V+b8hNuFlM7LMYPhyFtvgTafxFT/kstqoDsCsgYJQu09BpcHbGq5384Dp3mMMoHOb1NnF+Frs0sNblKBJWA9I6kahu/geKOBKaTe7+C5G94VcwKTtP6CaDHq6ZL7zPxNN/qYZspGj2NtGfkpIYn3WsnWMF7R/DvHdK8Fi5MfF1BeSCwrDIem6C+S70i3nIr1kPG6yoLh5hoqzg+K/UR9ywPG4voJE9Ai1kV5LnRFt3KnjjL6X9nrjZiYuBjjdpaQoW0ZSh+k9IfWhRGbNjKNX1+7/S+6kcP2EgRTI9VI7aYTZhH7UrC9YcE3SYLVX0iGC2suRddZYrDcYNJ9XAzyRX8Ze/235B5mXTgu+J+lYiDtQWh8XTEPvqNpfxRzWwpdJLpzU2HnmAhmG2T3KSEc6nT3m3vo1EdgdoL0yb8d7Jw4xmF1fr+E5faLPJiYydMajn+ri8xJJr4M0xAV5wosr9tq1AjEmYgz5+LAkKGpnExNYUL2S9AE8e64E6CX39dM6rjn3busHp7LR+8TMNw2Ydl5eQ0PAzYpCP1abbJOU7h5BqlL2jhDitFZJAk2j5OgsGfwfu4qct7behSz0/xTTiKTMOfqZYzc7eQDovy4IKQ9QUjtDP2iJvYGVXF05CCs1pEmGouDa4rXlE+GG/Q5L2kX2jkmJICNWi7C4WONgxm+mG4UjJgx6JM13k= X-Microsoft-Antispam-Message-Info: ZKSYoTdjOYj9P3G+ARplJ+s497/NBBJnUpb2hp6NhaWdLPNdRIF3RVREqoJT9WeGXvdBiOEdM+I9bt76xbMa1aNFHYusmHFMZAcvIykzPlz+HUyVadkdjajeyuO1b1SycsFPjYFtIF4SSc8UQQA1bH7F/A+Veft9rpCBmRY/i9RZ7YA/89TPtcitKPbq4DUpCS1KuH4PlL/tLShEnX/YIM0WOCXhskptKF/p+qAFrAwjxLgkVJSS5rFFvV1TfG2SnFJzWqwxDtTDQd5i/mNHltienVoIlGkvTstl+WPrD6aa4o3re40ENx7n9JXnuPbxh7bTWNDWlTURULLN1gJT8n/SDRhf2XpAYryNTmXcWGU= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:KLPsLaU+B9R5jcpKLOQvKeIu99EzsDyU2Qm2T7GypN265OnG8mGoDB+3P06D4HrSG6qiZdgsmkXGN9QWmLEB1fwBblHOMRfUnEe4aE8IqiZEmzwCen9eu4K2Nk0MU6qobA6ynNVlWPSPlW7uZKoIMCDP4m3UUHWUPMTvurnz6ybmRUlvpn7/EtpmKhXu4WwT8cXaQ8PH8oWCq/KmYh+1+8WdDNKLGqgb7eWJBr1dKqZ6cml1cBnTXbOY6Lge7c2GCECfjHpmPPEmnCyy/2kE4H58EQ12t02abZwQEs1BV/s3QqEtACW1a03801A/kDq0ZJa1ZE0QK9bEYu7oP3OUBudYml87rlksK3t+CUeU6gpqPxcWYt7ZjJ2bk8O/ySHZ8Qy6SH4rmUzE6tRWBUu8MuYV4sCX78g/Cq2idPKIU1kACyjvEgWtoqtRJtZpzOrW3GP7k2lgOmo+chdaOwmLtg==; 5://iZONchbjk41p9d5XIKqOReSeRF7ukvgqCX0YDRqIrtpsVl9b5Xw13sRfi69HpKVAuDR3d6QZEMefwQTIvKQaygKZfFe9EArAgAYu5Qu2FM25ZxtyG6/PwSHygij8Y7Cj4zA5egSgpsndQN5y9FGYGZARfeMT168AQV+7XZ+Wg=; 24:mosLc9IuuuMf+abQJDZxgFeWfWaFFDLt+3Hi8GL9lHXLuhWAkxFtpsRLKvbFMYtIm5kF5T77zjy78DA242FuP3xVGbNEbZkdSbEAOJVXFxY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:oOMB7lFQ1x3IM0x/cxem5r+A5wQDz+rejMoLJ/dlaqCSk6549SeAV4zTuQdrit3JL0bwrJASzoEB7k/r+unVBMe0/CnkVZgYtwiyBKOqwQYZmhLde2OfRPQO1LaRfy5wx+1HiSp2RAUdP2i3Cbyb8Abop7ACdBOou1nP1dKhdn5ziMhf6RyO+nMOrybASTlPxpDhrCPJqWJlSWctnTyIhqOjUv58a0P3osA3GudQm+ce08KNbeWjf2gAjiUSFG/f X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:18.4537 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48322009-acc6-4756-34af-08d5e6f4b39c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 09/12] examples/l2fwd: skip timer updates for non master cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/l2fwd_worker.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 868d0c6..d6a5e90 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -111,6 +111,14 @@ l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf, /* Drain buffers */ l2fwd_drain_buffers(qconf); + t->prev_tsc = cur_tsc; + + /* Skip the timer based stats prints if not master core */ + if (!is_master_core) + return; + + /* On master core */ + /* if timer is enabled */ if (timer_period > 0) { @@ -120,16 +128,13 @@ l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf, /* if timer has reached its timeout */ if (unlikely(t->timer_tsc >= timer_period)) { - /* do this only on master core */ - if (is_master_core) { - print_stats(); - /* reset the timer */ - t->timer_tsc = 0; - } + /* Print stats */ + print_stats(); + + /* reset the timer */ + t->timer_tsc = 0; } } - - t->prev_tsc = cur_tsc; } } From patchwork Wed Jul 11 06:07:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42788 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADAC21B50A; Wed, 11 Jul 2018 08:08:25 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0064.outbound.protection.outlook.com [104.47.34.64]) by dpdk.org (Postfix) with ESMTP id 1376C1B50A for ; Wed, 11 Jul 2018 08:08:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dteIzrH7qdYUosOHLe1EbhEQ7SeYm02yyfookXaLQho=; b=ZQSeN/N3LcxRmkSxihU938wOZSWvuso4b1zIr7qyQcp49xv5KFKQWtJ0q38trcBOrhNxzopSotussx8OirTyxqzR83haD/tARCFcyYO//htJs2GYL3vUavhJkfF9NZiws82+tG4wBb++cuWmLPfBfsvx0PlVp7vSDXJhNc8PiR4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:20 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:26 +0530 Message-Id: <1531289248-20025-11-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9e746c3-bdce-4f07-538d-08d5e6f4b4fc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:jciFdC44/+4/0dybW+R9pcN2pCjwHeWcyyX7Pbi1JPvLWvUKEqQIpExCWuVkWDBP42gXSalMKno47PsJn3hjpzoyZHia2ptzpn8pOISEk2T0tYzOzmmfpLYDzT+JyL/vBulimOA+sBidoGLkl4dcxvzwAFLOmg9IIULDsYE9nGBd1CilUAeyga934kVbZyJxNmtvfeFPYQShFc/1XGXh232694SVxG+7EMviPRZZ08q5BkoV7ihYNIw2uwl88w8b; 25:KvJD0JQqgMkNiikOl6gnL+TEPBb/Fk0rQTgbzMGrXPD4Ot8nDz12EjCtZfR6N8gTJ36wEZ/vY8I98dJUZHL++uEZaluIn4lc8kxxfa+wj9+3HjS12zXqMfFc7EAtMHCGdJv4S0DfvznGL9aDqwQw2cWav3/Auk5Zd+2binNUF/48oRbpjYIttzZ9/S9FjdRTP4D+V4OT0OhwWwFUykdA64MzVRUujq3L8zrIU10FvjdVzChmnfj6eXyRjEjFbMsbpGbOrxu6Cd5nhTpMlld5eT1SgWbXYlzdnF8lnX//XYh7NeMVdc8g8omqZZt9qPeePRvL02Vb5Wdv0Vn17CjTHQ==; 31:Q5TisN0G7YupBNLvyNlIFFLMrEX/6HJrXHH8lKxcFyQnIPRbYZJ+ZZ9g+OwyhZVkOAqak7dDcu/jcLaUYaDKZvNtqeLwd1hMQPjNI39vs9iBMFSTzE6IcTYK96jvwaHQF8r4AEoGRpEMy//qGCnR0V28RMD8kzaoE87QxGfjLm3uPfJoBH3aGyJgrYDySGXLKCm98I71C/ELV6+QvFaa029V8b0gAeOzV3+sgVrT4Ew= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:naGrrqRshpBatG6IbXs0hor1eQKGNDUx3n/kd+qytONlQf45USh4xMNqQvPwGPEYMDsU1IfPfdZmieQoGSaYrcXWYwXtgD2Q6GIELWi2urw7iq6MfBaXYFGPHCi4F4sxnxhYWAxIJQ0Y8RwngBf4BoKqfFQbCUq4w9N1Q9C30o2U75Rt0kXxupsvo1vofABACaZ7bF11Mv8UPDcAmZSFvA+y+m7wP4ZinS4q140gzDnGFDlsp8MtukFVRVnURdshfFFRRfKK2n16X2K5JwNcKslCuJPoIbV1YEY+/kJ5VqpsPkBi9mic5ME2zqRhkms9F2D9ZqtmvasLdySyotimZ0opB2ZCFD+bhCcuwvbZ+SjFGYfcH7DKh9X8s6sKXwPCkPOt8/ztyr0xwJvJSGSLkWuATw6TfT/5Musz/7OoVPMtyD70Sd1dD2/6z6V8m6+etM9RaRkSkAyf9gQONHXY6wacBjHFkYPGvhADkMgsvS30GEoo5oMb1zmBJ/kbkdYeNdZh7pccaICxfylfk2o8grJXJmfpBkf94dN37fBStX9SkBUa6C+SoIfqFrfcM6t7Bvxgn+wndkhGD7FlnWxxfihjFhMjbTsAMyJbaIX6cJo=; 4:DLtcQp0j4qulUTydDtoenGebp1kuywAEqrjezOsFr4sU7dxkTubulttGSpfP7ASQHz9UUNnMc2b2Wv37+AbtBVvIijCOkzFzTCsnExr2I3FlJr9CNEx+Gi0yI0pWktqg2SIP6R3RFc7TG2XZiWlCqut206T4RqgjEsgdLS4zv1UWvuIIOf+a1WXJBBCGt+J4JBCy3CDRa/3IzgYov1O6BpTcHNS0jCRd75YqQF+yTg0vGCvytS8ksOPtpUp39w/ot9Q4AS0zP4MO/qWwKj5Prw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:8AeaWEIyvRxYawfe2AyeFvbhgl3M2HZz/p57CSVEc?= xatNxkOGKt87dEXhG6pkngUFVBLlr6E+Lu16ovWDnt9l3G7Bg3o10ZVccpG9Lil8pv7XMQG9CT9IRf+rtgik47zMCuJH60hKFh/dTC9MEErq2Y90WD8yJZTt6LXxWke6gm6G1v0oMsfk7cv0vpgteVSLoDa+Uhhm6J6f3ikvCmtLl2SFb51gOutplV4+Fz5rnvUDf56kUMYK4mV1EHoIUrVKvjUs9q4HL2JkbFotX3du7tPpmpO/agQTuQoJRhfCvsyO55Yt6KPeGS8gGeW9gJZYUf6pYD2405c21v0v0tKxspSg8iS7Q/3aJTm0ZEAukWxgoCkpTWwNUINAmXPyfKhpDtnrtv0pEz6cRu6KtCbD91CmXHdW/hsDEi53zx8XtTTZPQfdtupvp7usMqHiQxZ6flvMGbCE0oahIDmva056S69TvwRyz93K/WWeUQJ8W45Sxq+YacSzDG+Ees3YeD7EbdyZxPfD0xW8c4iPELyPr+yq9dhpAJz7BDrD0p4m3oxm5eE7/qd8R14bJfxntvoZmlSFs/tukmMp+qaGPoDcT8VtmUxJIeIbWHOEQHsFKkQqhbYDxX66JQGJ/pYqNObWqozYFaKz2S2rpFXffA2e2Vzg/M0K1aNc9XGr+3rVu2rHN1sflmaymtw+kqzaAQDQ6bstKZ/TEdGhOV7kW1unCsUv6NzhKEPLD7TpUBt4pvxL/VnR33qTqNKIaX5nfzt1vkTIXAx5OE6zVmRR9YtfJ6AX/CE0oGxX3AnuBHvz0xpOkWA/H+zeds2O7HI+q/v8ozatrPHX3Hsi8zcJgLgY5pTF6ey19xoWffQXa818iSWqhJWs1IAZECvYvpwk0LHN2yfTzl4PRxU54NO+zkMJDQWcS17vdWTfLHZXjd6FreX0OgAZLrXMV6wtUzVQ9+93XnETzUbbcKMX2mixwYxxYN7Av9K+Zuzku8dJg77EX2YdPiMzdLIs2nBQ2Ea8zNtfZ4VqcPzg2XkyUJoUaNyjKiTwUMZ1WkYJojsa8qDuv7EewaGD0USgcY7KgWrpwXkOMeVHS+6JHYbJ5/BCVeCk0D2KEPNNx5XRnx9hu85HGAbiUVLh7KuhHvwKc1EB8izec7DIv1o22CJasnroJQHRrvMEvKd78aJsXA4rJpFqUS/unlFAK4yYEVtnBq6ucgHDzKPZdxAosfEqG+ureJ7PQ== X-Microsoft-Antispam-Message-Info: gxLRwO4SWJlo6SM1fJht71dBq6vMBl4iGGLbYH/Bssx6EnqA6wFHcjkf+XZjga0QxLuysBFfda71hA8NjrXHJvdzcN6LBd6c6ZDmZpJbyQb8i6qRT8pZXavkjTobbJV8Dpksbqhe/7mqAzYpzoiWZ5XTNQu6eVXuh5SvpwWnDG8+63Y49H6RemJa98Mj/Nf/UfhdzzpGKLe2e3XcCMVGYqtlI75834XKTiYI5FO7FDjhv8HTkCk6ziql82/2ZxvibOdqcO1Eolnwqfuk1z2Pe2WcqFm7QoRdhtIMoLOUJoDsSOJIkAGEFnYGWXZVfBHQVAn88nso8msrrz86QziGYM70jdUHvYXo77BjCNRanjs= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:sLnZFveowIE7xeKEWe9EcP/5+lrufMe1F7+hTrwhKtw3pBtmsGrW2dTrkTCJrzUaJ7AcI7ICHVx/5VOhHOHqm0MkUaWxkO9qGHkTGgXtIC6vtucDW8fcKz/vcdkgTIB3LSp4tNbcM9YmPXqkTes1h7o9rEcxxHKyzuNfaZa4eY71bMA4oX8S0Znq3BQHKYKPpAwKOr/hMO1cNVJGQ6mXl5glAM/vK/b3Gjfk7RCXN5qaWQdmvyqH8ESwRyl2/hUKhrvjzJEQHdZ09aMhq4RM5VCRlO/omKFimC8zzid/Zstv/llNuuNQA0xAiKvxA5hTKfsp9DmZR8SYwpUx9zl0COeWGEdmVYAFlvHzCeMQ6fy0YYko8EDCMokrbbZg0NYv8EigLxETt5qBdp0vF2uCDJNE2a2xGsuhIwk/buh+PgwyMIv2iCmIhQmnJz7XEc/CZpyyOXsLMDneK5nPBpm85Q==; 5:fkqqtxxYQuvIIB2WPTRnDCPEBUI+LYvl3ZJ2SLkjbUUtl4FfSrfuKryxob3J/PibfrXoT+B9vsMxG6Q4JGJNUcWthUVyZZ2GxIeBFRxgmMF05VC+WructQTfDsye9EwZxar0w72ZiNWkeX5PorKNiZD8yBBoXOvkRwkYBbnUqao=; 24:bcWPgaNcKpYD+GKdzjUwZvJpqtyk+D6VDXV61wfcQ5jAJkuDKNi4atZDKFOGR6JU4y1+ERybn0YgOFQ4Uu1JpeCqeXDwaWcEmg6oDxRicjI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:KDjetZgmB29QbDoltKlsMIu90G89lk9NBSoYwi5ndefjDptEctnmPTePPw6L301dj+L8suIhxsfSPeOwoLkeU6vjYs1Mw1lAS7bHoVGjnVdz8PMLsI08FwtKUOtL4VmEprNXV3LKJkFDWJnGp9IKC1LVJVppWduRZTVLZeQXrtWwRdbNWTLYNrL3YzL74WmFjsPqPJQUQm0CoVS5G8TmSKwhz8K6QYqj5cirUhx2hxGnMcH5J+LkNlOL6mAKEKKr X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:20.7864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9e746c3-bdce-4f07-538d-08d5e6f4b4fc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 10/12] examples/l2fwd: move pkt send code to a new function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Anoob Joseph --- v2: * No change v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index d6a5e90..bac1946 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fwd_worker.c @@ -154,22 +154,30 @@ l2fwd_mac_updating(struct rte_mbuf *m, unsigned int dest_portid) ether_addr_copy(&l2fwd_ports_eth_addr[dest_portid], ð->s_addr); } +static inline void +l2fwd_send_pkt(struct rte_mbuf *tx_pkt, unsigned int port_id) +{ + int sent; + struct rte_eth_dev_tx_buffer *buffer; + + buffer = tx_buffer[port_id]; + sent = rte_eth_tx_buffer(port_id, 0, buffer, tx_pkt); + if (sent) + port_statistics[port_id].tx += sent; +} + static void l2fwd_simple_forward(struct rte_mbuf *m, unsigned int portid) { unsigned int dst_port; - int sent; - struct rte_eth_dev_tx_buffer *buffer; dst_port = l2fwd_dst_ports[portid]; if (mac_updating) l2fwd_mac_updating(m, dst_port); - buffer = tx_buffer[dst_port]; - sent = rte_eth_tx_buffer(dst_port, 0, buffer, m); - if (sent) - port_statistics[dst_port].tx += sent; + /* Send packet */ + l2fwd_send_pkt(m, dst_port); } /* main processing loop */ From patchwork Wed Jul 11 06:07:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42789 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6EFD51B513; Wed, 11 Jul 2018 08:08:29 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0064.outbound.protection.outlook.com [104.47.36.64]) by dpdk.org (Postfix) with ESMTP id 2EA2E1B4FA for ; Wed, 11 Jul 2018 08:08:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puwFSNeE7JIfAFZClEbSwkYfi5uyDiStkF06Pkt36JE=; b=JJ4mAqjkzg1RuquKjS/Uw+QXNVvrLmZa2rtZQDskzhbJtrMMhi5Ko+wCkobgCDKPzk+x8ZodIHeumDMVWBhmBWDupNutwykivUNaMQK6FwCeQsHUX3NX7lDn4F1tAHx/VjgD79h8gcdr+vYdTBfsH9j83NxssmWXGjgXx5swanw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:23 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:27 +0530 Message-Id: <1531289248-20025-12-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ffa6116-3e51-4a10-c54d-08d5e6f4b66e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:OhxSm7/aYRN6zcxilNsvWNLIosDDEe4dmhQnM4YAfUWW/zyqdLdJOrhJtpTMeTuKgtrKIbZEyw2HXlt+u7/YDZvMNdljWk1llQKmZ/S+WKKrVWt/qqPttvIvGhz3C0WQ6oWMeyKvd6oXHSSY+8JEhQcgpLoFIrVp6q/zQC1hmC93TxPSPzsQeHkHU9pkoUtQA/MerYxV7I+V/bxd/Sgo6MgNLgH5ADZFihoO6RWapr/ceuU10w2l3o4wN5TuKUd9; 25:RBbJkElQYiHXzKSembRBLTJ5jY0/QxfN3TPPfpazZXcriOpRDwsK/9L7svXCsAH+UwjjyAmag+5XiKmvO6W3vEyeJEYSSG7p6GwCd5CN4l//IMKymoqRd9S6aq5qKgdk8wIHiIetmGobCtCy4c7YC9LJPHujy39HuGs3XohMn94jYPRHpvrcKIbwMDjGcChV4T+LWmVpdeQc1DurNRV+fEGfOjlaJUARebYt1Nvn/Rk4nRYZ3odNPyBMHhl7aAgtKdp9tWOjRjIOeWypMvBlfNzoznGY5DNxOCK2ZUikERO6gc3lXQjV7rzBUy2IW23HVVJ9BjzEiLULEyaIy4ZuXg==; 31:gjMMSI4+u1sCUyAdLTg3PbDnTEuviewbPo9PwuD7YQtfMZwqMP3sGXogv4TwlJa2kVq9kReOfeXm2PkA+DUM/Mzmaw8lFMES8kZnHH+2N/mzM3hXmtBgmzeEo6nWmNV7QX0Ebl/4KrAVJG/8owXw16BMlD4BxilM5BCMllMHdjUVlLD31iHR9zmRdD3Ecv6qgw4BTFxjkf7aG7ceaQsOeokHqsLnp06nQpkvSNTjMw8= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:OqMlDUULyQFp2Q8zhHhu72oE0citJ+I1CyxDJGZaCHAGwFiPuDcFJhpL8O6Kid99z5akZkZO+UUOUWMGrw8yjwFbKdch6U6DE6HKF8+qh+Ch9HnvJej8nY5ELVv84hhsRepw3CPHaa3HcqbIBXJuSnm/gfYwl+nDDMZRz+WuvULF/ogbyzE5DmVdqxFBO0LcpC7Bvnv6KjM+p2WUsBoCd3OW0QSBQFXOBm2tat3J8hj3k66WQ1FP0NB8ssDFLsilAXCrFxkcNAeUanEv8hOGKkCanzf7cjvCAfAwec1RdAYHybjginVGeQV8piWAdbEF1Rh0BWxqCoB2jdjJhqQbSYIeB8A4e4ef6fE09P1pVQNkfL60WHsR6WOZyzLN8It+igXXbNU8q9Ik2MjhbQ6wUCGa1n29WIHv67MN41V1XfoKVWOLleczQrMlNqLdNaUQqVvLF51wONnQC2nqsBgkx5TEaf6fCoqK6qvWNJek0eNAoQjyx0N2rUQZNt+Lbsxme8eNTS/caPmglzrAEiNUBLdwIWHSyQlJtnYdufMryIC52NmwUcU2Ou0h6N7sxEmDWgV8lb/ReAvvFgXqEEqQjMRcmpOmsqv5Fc4AzHAebjo=; 4:PmdImJ5+9p8wU9xYq+TRgeVcRII/cvVTGRdRd+FYLBPQExcVJ+7gYUkKape0Siii7m4vDuqitWYsaYZ+oMzPdg7f0fD3DEs3+M0erNzoOG1ptLb4tppzlsHa29onaeL8BpskL/tVt2nMD5YXFCEckxKzQ1WD3dKmsJZbTZWF57f7F4KUigUnyJLtQ5Mp7+mr91cksrvOgB3RQDM07iUy5JwO7K1Z3c77tNn4AiLG3PqelYSoCsIgwy7yaMnxVqPkHhK/letEhVKzx/ZzhwtAvQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(14444005)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:CHL1QxhZUTOxawOSxRkwJQSxjKoQDCd+GMeQegHCD?= 8+0z03J1LMkxt6+QpUL97o/qH2Tgl5bKfcZ2cM73PiIHbU/iREL2bGU38Z2SICn2SjZmacXjIfB6JePGPXC1PgknnIx2huhV/iBeBBuflz+qEUsCk8VzWUQZFoGnVy24Iu/oTYs1c894+GMc9QPGIv5VNt1rNm0wdVX5oOIEhSI5GM3M6m3BAZ3/A8056bMxdrk6Q0KscTpMAdp5nXOAYoHIad2LL3ANrN6kemna/S12OBbKu/wlWS2azaxR6nZ7WDUrS1w75g1G4/qJy3chHrVNQ2opKsByBujvrLSMk4lR04UMcUD3aGrmFkUL4yY4w7Lyv8urHRjGUM8HoHlavP6cXk/nTL0z1yoJNoPI/oB5ha4w/PZqhaovL8eLwGelEoE6cjh52TH3Cxmn8mKnWzq8eHhGh8aldEOYd8j4kf7w9bu09xkL7IqGaMUHjvjRctTyuzWPsdxYRaB6WDumVY7BhWQF3vSR0gwx922u4K3wxKqJUdj085KizIwqCW+qj6M4dkfQRU800hL2YkcLHNmfolWG0HBloDbuTt/cUDbxgXJXWPktOlndH1FGKRPbSrgWA5CnAA186Lrf5gj3G8n+h1Y18mIRVCIpajR2qDsZccAJ/ayCKGSf3qzciTR4mQn+WM3vo14xp57szhTgJoLDy+T65I+Xa4xuM3g4j3gMD+T9sJUolMPn8dzBtvNsusjWWmRYKNZyhyvYEkgdL4DJfXfT1BRhY4HURtA7KRZ7WoTiwfepBDjscGDo7XuDRZ/QiWBFaLtHaSdZ3e1MYF77OX52cxkP9/XI6tE53lIM5jb1Qf0sJIcTTL+FFOAHyImxmVIUr6cu8R7FI3kuEaZgEypyV7BoHYA1Z0eFhIKD8OIawF8VCQriBtXpJqPMQWGYNF51jPP/zmZLugL8gJWjMZr32byVC3zUp/jszxzunfH6TuOkRruInF4/yo/FrQu1uSWEOX+B0YAsk7ZWVI47ZPlpdzUC/4XexaBSVNGqurUxYCuhMYywc2EiHnccvA/v2Xsgd6xxEmaP4ljW7KyFhh4SL4uDosKOR/Ns0Ei1ph6KWr6qb4a/3fGsFELGxvwU+n2n4Upo7XLPOQBXcUUMzG17ZroINi5M0IguTlR+d8YMnqs99OuGd0ikNcFI2xB+76VgT4HhPJaJ8aWijTHkn9LKxwqe2xxQXXmz0FqS7/Q4diVdevUm8z6KR6BP7k= X-Microsoft-Antispam-Message-Info: xOk3I0xx6Tnf0QJhrqYlbUEGIxZFK4ygQbK/k1dtLmoNyZIM363KM7yEIygdpXVQLELn8c/xeay6RzZFO8OT9u1Dr3kW9b7XCqIjA41oQh5XZh0A2qGhf3/VImq3soZuEpKJAQQCqMoIOCBqz11EwDyy77YxwA1ZgQEUTjXIHrkZWqi2OkWSmkAvqkxomGr3bwyTDLoh5WZO4ilx0wV7HbPwupvyU6fK2+uNntlWKg2098evmC4gKK6j9JdNvyBWckevJAA5ycsXcIr6MMwEgU3FlH3fsYRiEPzKhfp1a5C1ww9OlA+rJF75WXK55KsfjsY+ZYhCsb4BYl63DqY/TS92AAhzZZWI15CUL0kp29M= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:GRmBYQ6zZlyvDMid7cx8RkF4Y14ub6ErY66/9aYM+E/O9+jY11k9yb/WYNc4nIemlpAJsl1tnwYUqrMq6knZk+yc0dATAACn9EH7mBAW7nN04MgtppW+uq3hKK3m02ITLghpgN4TXj5PR7EyaPJ7imtrv1gm6rx8zqtdDsIHS7PZRNzm4C+yywr4bZXQawrcNVFh8l6x+IS3MT2QUnoWKRLfnSp1sZGwmRopftCDVNL7li0Ku6b9eQqGS2umQm+GyAs+zcp7av1NTQ95yNh/HjHDId+abvf3Tawmg8moqBi8X5zQwpDjeRcrBm/J5W3UNXaKuB+XaMQ/l5ge7MlPOb5KcN2EFErqYNBoqwGXDhTO5Kdji7pCFs0ubQX5hYIj3mruE3SgAD0z+4ocFw7OOWBAU7brd7wCmTBfqEP8UpXaykh6fbc9tCx4wnpQk8JnR4rSGpqsZuBEOyPwXWHMeA==; 5:yZRKFIFPOgnqs1spFyiyYZ/gvgTkIHefPgC8T3DGHh6iqhndrka5ZqF1t0vSrzbt56lLuzT0Dfco+Mgt30JikhJUek531uenjBU1n5s1AS7ol1JvQe+caJMK78gNb3DbR/omK2m4d97leh4fA/qTy9Rsyiaq1MHnN8oaYtGQnzg=; 24:HOC7MXvp1ewzyV6sASx/Bw8HsE1syEiTG3XPq7t0vqoYQiwbIpH+52jjp/J3s09ipCswgx3Ivp9FeBJlwW9XWTCTOLRhHwcPpzRnKxB4I/8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:e9hhViVbkTCmHjuoy5rGJ5SM5RgzyIVcNtFldAhuxa6nV4MPIMYBfW0Jr8jaIhNP/KhWD3Im8wleiXNBDumMBuVkHsDecDygVczounEBmpdpNKX4wM09/aZPThngkvtF2b7dIMRYnOp8nLdUj6t67GEQ6kBiM/Y/ODdRZupwL3VshxjmwvEJTjvjxg32SKFCd80LFheJhotFeD/bAtlTlWdOAXqrQukqByQofRc21h/iGr+9PC9HdNydyR8piOBi X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:23.2191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ffa6116-3e51-4a10-c54d-08d5e6f4b66e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 11/12] examples/l2fwd: use fprint instead of printf for usage print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 05f9d28..3b697d1 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -64,7 +64,9 @@ struct rte_mempool * l2fwd_pktmbuf_pool = NULL; static void l2fwd_usage(const char *prgname) { - printf("%s [EAL options] -- -p PORTMASK [-q NQ]\n" + fprintf(stderr, "%s [EAL options] --" + " -p PORTMASK" + " [-q NQ]\n" " -p PORTMASK: hexadecimal bitmask of ports to configure\n" " -q NQ: number of queue (=ports) per lcore (default is 1)\n" " -T PERIOD: statistics will be refreshed each PERIOD seconds (0 to disable, 10 default, 86400 maximum)\n" From patchwork Wed Jul 11 06:07:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 42790 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E08CC1B522; Wed, 11 Jul 2018 08:08:32 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0064.outbound.protection.outlook.com [104.47.34.64]) by dpdk.org (Postfix) with ESMTP id 92DC61B513 for ; Wed, 11 Jul 2018 08:08:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3BZbcVQThU5FwlXcQ5zeaP4n+jukuTG4Yw8ix9NISk=; b=PjpX+GIbe52SHNbh2A9x5RLzBflsvkMdWiEMc9q9o/RFwbpgKAuTb+cdPCVZ5T2zAQMhDOQHpjO/9Bl5wFlq+4WghipupUacXLkyiF/1g2XkqwBzuUVUqeAx+pYw8WTn2l838NB10cYiTDnByfSenUBQLwMnremP4QlqquDfh4Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2) by BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Wed, 11 Jul 2018 06:08:25 +0000 From: Anoob Joseph To: Bruce Richardson , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org Date: Wed, 11 Jul 2018 11:37:28 +0530 Message-Id: <1531289248-20025-13-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b11e029-6ff1-4f27-83c2-08d5e6f4b7ec X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4898; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 3:EN1zc7kEnMf6B92CHJ1AsPAa79Pv4CEVmlkAJc1MOXL5VB5vlifTP+Ah1WcyaJ0gz2CS7ePU7iF85i1Y9SlLOdCCyzf5PJiYLGz4H7EETYzvJhD1z0/vVxYs1VotzDveHMDzgKVgoC2WCf5NfjsPiBUxpLQZEw9f/DdzdhxbPxzYehvMAj/e8nm1eUVa2nHlyqruCVUU9qAiEuQYo5RK1QPeiEnxAD7n6tDItCziO0bfmfiwTx42jd6mHUIK7PRd; 25:SRcF+zo3R6Y7Rq25HVVrg9LG4QdW6hCqU9PwKd6f5/JelDJ6sRm7lHeXRzkuvZaCYJnZnIACR3OvMcICdCTbmvfAqajn3ZiPACfeCMMIJ1QQVWsM0AwJ7yRJMY8ZXPeR3kQTtD4ZuT6a9teYgKP182vIp7LyuwvB3lFTV/l+C47t2u/oM2Jt8/sQU34qrmtfFIuFhlSRhOZUA1EsPcy2S8BlmKLHcKRbRtmP96yPtx8b9IHDuZnEHbDYIdB57vmAEP/kA7YXCqUCfM7tb321e1SbB5B5mpUINUjpvg3o7lynEryITxN36hmoSfTAVYqplHdJbN0r9DFV1RN4JK88Gg==; 31:ZCtHKqHrAXxdvGk4frguorH6WmhB59LINroNHYSj0RCkf5/xOTWuKKHrz/8ra5iFdDfWzYXnyU6qTfJu9U5ISAF4uyLU+wCVknVKnk7rkX+NIcq2jZ7bY4rJk2Z7oz3cVAQSV6hQ4YjpisgCyayPPidMY3MfZ1leYifcOVOTsQkiteJHlBLvViQmrkDRrsyPQ+BqnOGp6XPH/eFSJ2ma0DaCKiE0KamKuRHa7NHeTYk= X-MS-TrafficTypeDiagnostic: BN7PR07MB4898: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 20:Dn/Gd9H3FsRIbBtC8ReAGyQ8JVqBX7P/JZ5Ic9UEHMntR14i5e++Rv9MAO00L4CFDCtQZU5V2c/kvXU0YYtp1hLcMrH0rDUVSSrj/Szx2BrmZy57oMDUiTsuNMsprfcq9Eubfy3xlX58EuvN3lfL4r2ge0kGcxN0y1WM4+CVmppyN4YgJhlKic0LjwsWKalDkiVu4NnV15K7hiXItSaKjvXpyolIerddQyoF1kaEZVkZ5tKK7eoVuQnKw6zAyEeSDtcxcXJ40iKzEduJK7KB8wbuNqQtnlyc6oNESer2/bnwdr6Id2o32bZ9ha28U8pYw4uIZXL7pcGkChFLo9Oqjl1cdx56DjBPxpCbCwtkZyXZNwAkzEQ1Vq4/K6PGOR5/E+W1+BRU3EgCxsMJ8M+gyfpQUC58YFsntcyIHjXSvrjGtN/DlLFQYB9eFfGS4pGeuifVWjMQZnG179fHxAzfEu7sL8HDG6p8z83wF6q4m22rqNBicg62hswC26UyT99IhoiWcENQHFYnPpj9QY3uJSEdg97e67hMgcKW8XPNYUTfO5cpdezIENmgEnKhkIlAGTiM33DUiJj6X23mvfXyV6utLTzTCLNcmhm5ZzXj2RM=; 4:cyrFCHlqLG5r6hBuF1hagDMFUKxMlxGM+Qiq7qF3MuPxjcjvHz7pXLR/IaUDxMHP2MnpUeSqLgVttJ3SQc6aP/qKpASfVyWF/4TzefK/IEA3H0XS+N57vA8EmlBmrw+DkM4adc3RCa2vz+O8QzRQbDJfaJfoFf4NlUIqNcWcdVvfzF+1E+PN4zMNctwSqyedqorWpeI/VBK0p8O3M5zKVHkHfn9/zzHSa5c1/W25IuWJAVB6JwbP4D2Z9TV6orIBEQCrpsxoNV25/022N2o2Dg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(72206003)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898; H:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4898; 23:UZOzlWOHSRYPffKqcCqgKF+yZQQZUIO8a736uflAL?= vp7wvUwuHCFo64toWj16iRSF/WqLYYCyFnFQS5geFeEQjzrxvPnK+cMX9/7u6YqUndINOElKMBzoEdGq4RLruSw2eFwuiLS+HV4+Z1nXlIXgoTqGPdoslaty2btBX7ff+ShHIUytfipFuMyyS8HQuYyK9bdwVYwIEOVHk2hQxAo13PG5tRJtTqth4MUcP2Fd9AXt7VZHqiXQI4+KnQU8UaCOdqZLBl07ToDcQBTMKr9jFp3ksgru84joV3j1Pg3mYrIh3rC3KMWT6U42b6NXKSsrZhBM1FRxWYJtB4Wo/QKm2Tqtqh6UxR63J/uC1rxHOdRevI7/hPfJL/zTnco0n+SCx8dUeKGKzIB+7FELlrJozg7vr3CTYU/p89alNAeziRdvL9qf5B2ow34CAnkpG9cpiDmJKyjiSWdRTgfEOUPUsiihniDxprfQjVZ7fSQEpx4ixymg7Kd6a0ypBZ7EHDKBHofshH3fYYbqyDho8eMuY7u1NNoAN5cvXdgxeoYzYLvC6MOwR2fSgcl2tyscRK07fIw84dPhIRhJiRtrpxqijB7daGyQW/6/ejZVfmbWIcugS2KFk6od/EBd5dN5USOx0B6iWJsNk+JsZPetN98jZIc5apJwNH+fVKB/JWYnPpP48Svk4Q6MyfzuIh757d6ok7KcxZkBcB3t2iFyTyPPyRKehX920nLwxsNec7AbMCwpH73WVgVODCurTRH18DOquk29IIu3xk4Teb5JD3bX+c4IA3ysJjV1G8BOEUZKC3t37cIcAf8Dg8+Shq/HAK0oYu6DYLXeCSQd9CMU8yf/sNW/KZVyXfkGNvP6RNVcuNk039w6srFbeEFn/hvQXYefJDVvdZrWZqn0/hhfoi2HIzhTxcs3TdZ6O1SwguKb7pLs6AEuQ6b+qKwt2bFp54wG6OBRfznUfIGTdJ9kVvVR15BEzoqFeXWG0/rtjLFFTlTp/IhFZO6FpPTkw+5Q+RygtcnO8Cvi9uR8uMnXyI7HFVfwMqEYXP/byXYwBF1g5FTCkQPuug7KaSwlhyzTnX/uSHMOmE/QHUMt2Lf23HQvcJB4oCoHF2vpQKJikLeOo2FG3PQ0s4lzb38F++OgFa7DujtCkwIzi9cl03E0pW3UZ9Vx6rlrEy+LqGhDskR50uquDbFDWDFpiAiDhbTSqa48zWtwdK+qLQz4gGXwQOPLg== X-Microsoft-Antispam-Message-Info: Jme57G8uYhiLZQTHKk+S1rn5dhA7s+C8j/xMqpyXh6LgqC17UYAgf0VM20FmQfRyBRauAlgRR6CzyIsd/R61aDcy25hXy8VpH8Sti0pVgomvYeXsS9bzkhDA9WnSDP9dZkoAvGZ5bi2l8kqm09ZpGIXIhGsx9eGk0mrnpzIdp6LOX6XHZLcsXYpGecE2lKK82zcgaV77DuX3S9JTeDiFjjGTx4UcYhzqQ7EKnOrpQrB2H/2lEPAXH9f4uADf/p4A1S96Fq+d/A+03biAAx0ly89mgwoc5uoG3TGxrg6s7VBvE5OYi0XtN02rohm6c6sNyFS/4G/UZxE6WAcZfBMDWJHUYFE2VSVmg8X/wHyJn78= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 6:j7NGgTSFL/JjE9FUXexcXuNqPODHvdNEW/XK3yTgICzeLXBrboesosS3w/K/DarPnWdwt8WRUHnjbz5zDwQC6YlauvTcVlNysgm+XjI1kHQ1JwU0u/ioCpYHXJgN+cNDAs9/g17S7pfckFOsx9WrEYWEu6kyoZinknBE0CwdyQSmhsPRfVqhpUWCDN2CKCzwcuk/bnlA6y5M1A3oh8faeRcnchu8ohMv1jJhZyNFgCqum58l68F3of80sH3MwBOLzok9fAl5ue3O6uMzQaIxpLS6V8Zs4ud47F+NMCfoY3rsfO1atQIGe0H6FpxiIDAVFytRJTeFW3LARVhBK1DrEXVAXrjKWt/3p7jAfc9521FxcKOJvNPHJJ2HfplYxjork64wT9TFluoOXEJxrxmTcvtJ+GF4db4OZ3f9bNOwkg/Sm7ZZIknTYFhgYOkv+i06XmrJVf09rHlUezZFiFS5bA==; 5:zVCv1UIbdM0Y6ow7qo/ZJ2qdbA/+MqfEWWpwvgJjhResqIp70VYbOxdvQAMr/DIVxIf0sSDCO7UQZVQWuKlYJdWBPFzpAXGYNQfzT3scqkjwl03/F6JRl3NrniJV7QbC1dKqcSuIdNg90MvOUJrtFcWufAd9FoKwLXghbiS4/hU=; 24:oF5I6dLd/Jsd051dCqGFsmndrsxhFu2zQVc6RoF1uojhWuK8xUMm1FI/8eoLKWKoEJmApq7WiZY8b+Lv5UNImPMAJYnJZ0nh7Ft8K14+ZsU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4898; 7:rwuBU6CGJwrPmQym6tdmlrMQwHoiEv0liodayg95v0ijd1DVIvPsmFChw5hQJ+oZV8cp5Y4oydOItWSO4d4s3di2Efk1NtmbJbw3S8NZIS1VyvWq/vdOrVKE2gjfI9nQzdDsY0QClN6e3U4XY04mwY653TbUxIWGiDpDXxk9F//WFaX7IYyyDh3NY0Ivy/2EJJ67Lr9vb6xFeZd9m/WAlqDHM0qnt24C/d84kDgk4NA5QGIZ0pXLKFo+hHXwBpDr X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2018 06:08:25.6879 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b11e029-6ff1-4f27-83c2-08d5e6f4b7ec X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4898 Subject: [dpdk-dev] [PATCH v2 12/12] examples/l2fwd: improvements to the usage print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- v2: * No change v1: * No change examples/l2fwd/main.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 3b697d1..ac81beb 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -66,15 +66,20 @@ l2fwd_usage(const char *prgname) { fprintf(stderr, "%s [EAL options] --" " -p PORTMASK" - " [-q NQ]\n" - " -p PORTMASK: hexadecimal bitmask of ports to configure\n" - " -q NQ: number of queue (=ports) per lcore (default is 1)\n" - " -T PERIOD: statistics will be refreshed each PERIOD seconds (0 to disable, 10 default, 86400 maximum)\n" - " --[no-]mac-updating: Enable or disable MAC addresses updating (enabled by default)\n" - " When enabled:\n" - " - The source MAC address is replaced by the TX port MAC address\n" - " - The destination MAC address is replaced by 02:00:00:00:00:TX_PORT_ID\n", - prgname); + " [-q NQ]", + prgname); + + fprintf(stderr, "\n\n"); + + fprintf(stderr, + " -p PORTMASK: hexadecimal bitmask of ports to configure\n" + " -q NQ: number of queue (=ports) per lcore (default is 1)\n" + " -T PERIOD: statistics will be refreshed each PERIOD seconds (0 to disable, 10 default, 86400 maximum)\n" + " --[no-]mac-updating: Enable or disable MAC addresses updating (enabled by default)\n" + " When enabled:\n" + " - The source MAC address is replaced by the TX port MAC address\n" + " - The destination MAC address is replaced by 02:00:00:00:00:TX_PORT_ID\n" + "\n"); } static int