From patchwork Thu Jun 6 14:25:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asaf Penso X-Patchwork-Id: 54500 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DD541B95B; Thu, 6 Jun 2019 16:25:49 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40040.outbound.protection.outlook.com [40.107.4.40]) by dpdk.org (Postfix) with ESMTP id A24A21B951; Thu, 6 Jun 2019 16:25:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+k3MldWbB8muFZJFhIGkxcldep4Zgv4UK/Irg+NaKUs=; b=LSqYHsjI6FI4gggC4GPOFN3tzsS2i7jkOq8tVx1o8+MbllfB6J8+0wbmTYAS+Yh/fdhXm1N+J64pMlWNmd63VHfqGK3dAC4321/Y4EmcaROqROEPeLHJ7B5fbTZHK4lMEL/Y80EwdoP4qxyFDaGZ2e1NuB/xXQ9zzK2t2UjqA/Y= Received: from AM6PR05MB5736.eurprd05.prod.outlook.com (20.178.93.21) by AM6PR05MB6295.eurprd05.prod.outlook.com (20.179.4.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.14; Thu, 6 Jun 2019 14:25:46 +0000 Received: from AM6PR05MB5736.eurprd05.prod.outlook.com ([fe80::6445:10f6:796c:e1d9]) by AM6PR05MB5736.eurprd05.prod.outlook.com ([fe80::6445:10f6:796c:e1d9%7]) with mapi id 15.20.1965.011; Thu, 6 Jun 2019 14:25:46 +0000 From: Asaf Penso To: Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" , Ori Kam , Asaf Penso , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix check for rte calloc return value Thread-Index: AQHVHHO6p9IWZP9al06wASG60HMRsQ== Date: Thu, 6 Jun 2019 14:25:46 +0000 Message-ID: <1559831132-176061-1-git-send-email-asafp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0297.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::21) To AM6PR05MB5736.eurprd05.prod.outlook.com (2603:10a6:20b:95::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=asafp@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.8.3.1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 289c6c4f-e3a9-45ec-a10a-08d6ea8add3e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB6295; x-ms-traffictypediagnostic: AM6PR05MB6295: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(346002)(136003)(366004)(189003)(199004)(8936002)(54906003)(186003)(81166006)(81156014)(8676002)(50226002)(6506007)(386003)(14444005)(6486002)(4720700003)(5660300002)(316002)(6636002)(52116002)(68736007)(86362001)(99286004)(110136005)(53936002)(478600001)(2906002)(26005)(85306007)(71200400001)(36756003)(73956011)(66946007)(66476007)(6512007)(66556008)(6436002)(66446008)(7736002)(64756008)(305945005)(476003)(14454004)(450100002)(2616005)(486006)(256004)(71190400001)(6116002)(3846002)(4326008)(102836004)(66066001)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6295; H:AM6PR05MB5736.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: N0eggkpef5JBzjV4dsodF+J3PHk/a9nYfqO8pfmQ3Ofg5qbCPQpWz9+V+XLMuaC3bLlc42qyMGfq+HZ2vJc/Tno/tZqBopQgXWzZwhnhw8XtmkF7gSIo41RwOf9MQa6tloIK3/TB7ADARl9PuL8fWzRZSSNpZOr95QOF+umVK33yLzFBDncgctM1LWyDPESjXb7owz5bdTGRA1T/lpZck0/6jSsBT67Ipn5o518VvA8nhF3wQyc23uhEe2dg+FYfwoWavMzcnIpubx4qCSGD2IiY/uuElsN/Jx/bjiMRUTDPKYLxAH+zWT2fZVM6vGj74K58ss0leD70lfuPFH8sNor9vY/weEuyqNQh6eO6lug9yLliMiYS+MncqD6O9XviiTq4qiIUY4FkqNy5U9tP5JP7z1LEifgwxRkBusaAQgk= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 289c6c4f-e3a9-45ec-a10a-08d6ea8add3e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2019 14:25:46.0957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: asafp@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6295 Subject: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_calloc functions returns a non-null pointer in case of success and null pointer in case of failure. The return value should be checked and the function flow should take that into consideration. This patch adds a check for rte_calloc return value in function flow_list_create. Fixes: 84c406e7 ("net/mlx5: add flow translate function") Cc: stable@dpdk.org Signed-off-by: Asaf Penso --- drivers/net/mlx5/mlx5_flow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 9887018..a5821e5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -2092,6 +2092,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority, else flow_size += RTE_ALIGN_CEIL(sizeof(uint16_t), sizeof(void *)); flow = rte_calloc(__func__, 1, flow_size, 0); + if (!flow) { + rte_errno = ENOMEM; + return NULL; + } flow->drv_type = flow_get_drv_type(dev, attr); flow->ingress = attr->ingress; flow->transfer = attr->transfer;