From patchwork Wed May 29 12:43:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pattan, Reshma" X-Patchwork-Id: 53806 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A0201B9A1; Wed, 29 May 2019 14:43:24 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B7F781B974; Wed, 29 May 2019 14:43:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 05:43:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,527,1549958400"; d="scan'208";a="179566964" Received: from silpixa00400214.ir.intel.com (HELO silpixa00400214.ger.corp.intel.com) ([10.237.222.119]) by fmsmga002.fm.intel.com with ESMTP; 29 May 2019 05:43:20 -0700 From: Reshma Pattan To: dev@dpdk.org Cc: kevin.laatz@intel.com, Reshma Pattan , stable@dpdk.org, bruce.richardson@intel.com Date: Wed, 29 May 2019 13:43:17 +0100 Message-Id: <20190529124317.30611-1-reshma.pattan@intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] lib/telemetry: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Free the `values` pointer before returning from rte_telemetry_command_ports_all_stat_values() to avoid memory leak. Fixes: c12cefa379 ("telemetry: fix mapping of statistics") CC: stable@dpdk.org CC: bruce.richardson@intel.com Signed-off-by: Reshma Pattan Acked-by: Kevin Laatz --- lib/librte_telemetry/rte_telemetry_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_telemetry/rte_telemetry_parser.c b/lib/librte_telemetry/rte_telemetry_parser.c index 9bc16eef4..e9297021a 100644 --- a/lib/librte_telemetry/rte_telemetry_parser.c +++ b/lib/librte_telemetry/rte_telemetry_parser.c @@ -342,6 +342,7 @@ rte_telemetry_command_ports_all_stat_values(struct telemetry_impl *telemetry, goto fail; } + free(values); return 0; fail: