From patchwork Thu May 2 13:35:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 53217 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8621A5F28; Thu, 2 May 2019 15:35:33 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 314315F34; Thu, 2 May 2019 15:35:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:35:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="167006533" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by fmsmga004.fm.intel.com with ESMTP; 02 May 2019 06:35:30 -0700 From: Ferruh Yigit To: dev@dpdk.org, Thomas Monjalon Cc: stable@dpdk.org, harry.van.haaren@intel.com Date: Thu, 2 May 2019 14:35:25 +0100 Message-Id: <20190502133527.87937-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190416153932.21788-1-ferruh.yigit@intel.com> References: <20190416153932.21788-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 1/3] build: fix meson binutils workaround X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The '-mno-avx512f' compiler flag is not passed to the compiler, detection of the binutils and setting flags works fine, but the flag itself not used by compiler. Removing the interim 'march_opt' variable and using directly 'machine_args' and setting '-mno-avx512f' to 'machine_args' Fixes: 566b4d7a968f ("build: fix meson check for binutils 2.30") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- Cc: harry.van.haaren@intel.com --- config/x86/meson.build | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 2b2d06281..ca4d12506 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -1,15 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017-2019 Intel Corporation -# for checking defines we need to use the correct compiler flags -march_opt = ['-march=@0@'.format(machine)] - # get binutils version for the workaround of Bug 97 if not is_windows ldver = run_command('ld', '-v').stdout().strip() if ldver.contains('2.30') if cc.has_argument('-mno-avx512f') - march_opt += '-mno-avx512f' + machine_args += '-mno-avx512f' message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97') endif endif @@ -19,7 +16,7 @@ endif sse_errormsg = '''SSE4.2 instruction set is required for DPDK. Please set the machine type to "nehalem" or "corei7" or higher value''' -if cc.get_define('__SSE4_2__', args: march_opt) == '' +if cc.get_define('__SSE4_2__', args: machine_args) == '' error(sse_errormsg) endif @@ -38,23 +35,23 @@ else dpdk_conf.set('RTE_ARCH', 'i686') endif -if cc.get_define('__AES__', args: march_opt) != '' +if cc.get_define('__AES__', args: machine_args) != '' dpdk_conf.set('RTE_MACHINE_CPUFLAG_AES', 1) compile_time_cpuflags += ['RTE_CPUFLAG_AES'] endif -if cc.get_define('__PCLMUL__', args: march_opt) != '' +if cc.get_define('__PCLMUL__', args: machine_args) != '' dpdk_conf.set('RTE_MACHINE_CPUFLAG_PCLMULQDQ', 1) compile_time_cpuflags += ['RTE_CPUFLAG_PCLMULQDQ'] endif -if cc.get_define('__AVX__', args: march_opt) != '' +if cc.get_define('__AVX__', args: machine_args) != '' dpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX', 1) compile_time_cpuflags += ['RTE_CPUFLAG_AVX'] endif -if cc.get_define('__AVX2__', args: march_opt) != '' +if cc.get_define('__AVX2__', args: machine_args) != '' dpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX2', 1) compile_time_cpuflags += ['RTE_CPUFLAG_AVX2'] endif -if cc.get_define('__AVX512F__', args: march_opt) != '' +if cc.get_define('__AVX512F__', args: machine_args) != '' dpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX512F', 1) compile_time_cpuflags += ['RTE_CPUFLAG_AVX512F'] endif From patchwork Thu May 2 13:35:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 53218 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45B5A7CDA; Thu, 2 May 2019 15:35:37 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 935126833; Thu, 2 May 2019 15:35:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:35:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="167006589" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by fmsmga004.fm.intel.com with ESMTP; 02 May 2019 06:35:32 -0700 From: Ferruh Yigit To: dev@dpdk.org, Thomas Monjalon , John McNamara , Marko Kovacevic Cc: stable@dpdk.org, Bruce Richardson Date: Thu, 2 May 2019 14:35:26 +0100 Message-Id: <20190502133527.87937-2-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190502133527.87937-1-ferruh.yigit@intel.com> References: <20190416153932.21788-1-ferruh.yigit@intel.com> <20190502133527.87937-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 2/3] build: fix crash by disabling AVX512 with binutils 2.31 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Skylake platform, with native build, KNI kernel module crashes because of the corrupted values passed to kernel module. The corruption occurs because the userspace kni library works unexpectedly. Compiler [1] is using AVX512 instructions and generated binary is wrong [2]. It turned around gcc does its job correct, but gas is generating binary wrong. And expected binutils 2.30, 2.31 & 2.31.1 are affected. Issue has been fixed in binutils 2.32 with: Commit x86: don't mistakenly scale non-8-bit displacements AVX512 was already disabled with bintuils 2.30 [3], extending it to 2.31 & 2.31.1 too. [1] gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2) [2] gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 [3] Bugzilla ID 97 has the details. Bugzilla ID: 249 Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- v3: * merge if conditions in meson v2: * Release notes "Known Issues" section updated --- config/x86/meson.build | 4 ++++ doc/guides/rel_notes/release_19_05.rst | 6 ++++++ mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index ca4d12506..0a7bed75e 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -10,6 +10,10 @@ if not is_windows message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97') endif endif + if ldver.contains('2.31') and cc.has_argument('-mno-avx512f') + machine_args += '-mno-avx512f' + message('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249') + endif endif # we require SSE4.2 for DPDK diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 439725c8a..468e32539 100644 --- a/doc/guides/rel_notes/release_19_05.rst +++ b/doc/guides/rel_notes/release_19_05.rst @@ -368,6 +368,12 @@ Known Issues Also, make sure to start the actual text at the margin. ========================================================= +* **On x86 platforms, AVX512 support is disabled with binutils 2.31** + + Because a defect in binutils 2.31 AVX512 support is disabled. + DPDK defect: https://bugs.dpdk.org/show_bug.cgi?id=249 + GCC defect: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 + * **No software AES-XTS implementation.** There are currently no cryptodev software PMDs available which implement diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index df71e4a8b..ea40a11c0 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -27,7 +27,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),) FORCE_DISABLE_AVX512 := y # print warning only once for librte_eal ifneq ($(filter %librte_eal,$(CURDIR)),) -$(warning AVX512 support disabled because of ld 2.30. See Bug 97) +$(warning AVX512 support disabled because of binutils 2.30. See Bug 97) +endif +endif +ifneq ($(filter 2.31%,$(LD_VERSION)),) +FORCE_DISABLE_AVX512 := y +# print warning only once for librte_eal +ifneq ($(filter %librte_eal,$(CURDIR)),) +$(warning AVX512 support disabled because of binutils 2.31. See Bug 249) endif endif endif From patchwork Thu May 2 13:35:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 53219 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADCD97D4A; Thu, 2 May 2019 15:35:39 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6AC006833 for ; Thu, 2 May 2019 15:35:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 06:35:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="167006626" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by fmsmga004.fm.intel.com with ESMTP; 02 May 2019 06:35:35 -0700 From: Ferruh Yigit To: dev@dpdk.org, Thomas Monjalon Cc: Bruce Richardson Date: Thu, 2 May 2019 14:35:27 +0100 Message-Id: <20190502133527.87937-3-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190502133527.87937-1-ferruh.yigit@intel.com> References: <20190416153932.21788-1-ferruh.yigit@intel.com> <20190502133527.87937-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 3/3] build: reduce indentation in meson check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Just syntax change to reduce indentation, no functional change. Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- config/x86/meson.build | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 0a7bed75e..bb23771b4 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -4,11 +4,9 @@ # get binutils version for the workaround of Bug 97 if not is_windows ldver = run_command('ld', '-v').stdout().strip() - if ldver.contains('2.30') - if cc.has_argument('-mno-avx512f') - machine_args += '-mno-avx512f' - message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97') - endif + if ldver.contains('2.30') and cc.has_argument('-mno-avx512f') + machine_args += '-mno-avx512f' + message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97') endif if ldver.contains('2.31') and cc.has_argument('-mno-avx512f') machine_args += '-mno-avx512f'