From patchwork Wed Apr 24 17:34:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rao, Nikhil" X-Patchwork-Id: 53060 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F26A41B565; Wed, 24 Apr 2019 19:35:24 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7390B1B565 for ; Wed, 24 Apr 2019 19:35:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 10:35:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,390,1549958400"; d="scan'208";a="340451647" Received: from unknown (HELO broadwell-dev-4.localdomain) ([10.224.122.193]) by fmsmga006.fm.intel.com with ESMTP; 24 Apr 2019 10:35:22 -0700 From: Nikhil Rao To: thomas@monjalon.net Cc: dev@dpdk.org, Nikhil Rao , jerinj@marvell.com Date: Wed, 24 Apr 2019 23:04:20 +0530 Message-Id: <1556127260-13145-1-git-send-email-nikhil.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com> References: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com> Subject: [dpdk-dev] [PATCH v2] eventdev: add experimental tag back X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add the experimental tag back to the Rx event adapter callback and the Rx event callback register functions due to API change to be proposed in a future patch. This patch also adds the experimental tag in the callback register function definition and adds the function to the EXPERIMENTAL section of the map file, these were missing previously. Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable") Cc: jerinj@marvell.com Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++---- lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++ 3 files changed, 18 insertions(+), 5 deletions(-) v2: * add patch explanation to commit message diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h index cf23cde..32b52a7 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h @@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats { }; /** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice + * * Callback function invoked by the SW adapter before it continues * to process packets. The callback is passed the size of the enqueue * buffer in the SW adapter and the occupancy of the buffer. The @@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id, int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id); /** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice + * * Register callback to process Rx packets, this is supported for * SW based packet transfers. * @see rte_event_eth_rx_cb_fn @@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id, * - 0: Success * - <0: Error code on failure. */ -int +int __rte_experimental rte_event_eth_rx_adapter_cb_register(uint8_t id, uint16_t eth_dev_id, rte_event_eth_rx_adapter_cb_fn cb_fn, diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index 8d178be..e6001e2 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter, return rx_adapter->service_inited ? 0 : -ESRCH; } -int rte_event_eth_rx_adapter_cb_register(uint8_t id, - uint16_t eth_dev_id, - rte_event_eth_rx_adapter_cb_fn cb_fn, - void *cb_arg) +int __rte_experimental +rte_event_eth_rx_adapter_cb_register(uint8_t id, + uint16_t eth_dev_id, + rte_event_eth_rx_adapter_cb_fn cb_fn, + void *cb_arg) { struct rte_event_eth_rx_adapter *rx_adapter; struct eth_device_info *dev_info; diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map index 88c3ce5..9bfc666 100644 --- a/lib/librte_eventdev/rte_eventdev_version.map +++ b/lib/librte_eventdev/rte_eventdev_version.map @@ -124,3 +124,9 @@ DPDK_19.05 { rte_event_timer_arm_tmo_tick_burst; rte_event_timer_cancel_burst; } DPDK_18.05; + +EXPERIMENTAL { + global: + + rte_event_eth_rx_adapter_cb_register; +};