From patchwork Tue Mar 12 20:41:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 51141 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 160F54C94; Tue, 12 Mar 2019 21:41:17 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 62E6444C3 for ; Tue, 12 Mar 2019 21:41:15 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2CKZu1i007660; Tue, 12 Mar 2019 13:41:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=WOCWmKf34wh+aYygwqqeSR6ZeI8pEWMz1WBH3Sd9PBc=; b=TUu3kES+2wY2S4Fyzp12uVTxkIvXoA9PFf0IJFxD3YRX7xiEYnnjk9Dzm8qE1gH83Bbf YPiVq/EQ/P0kISuARYR8Kkr+yirrnu7tjk0mK+vbrjbk2ghzuQtVX1KYSKXzVl74HoUZ wGCvXxmEEVprPBkxvB5+/TifguiM1jMh+RIZ5u7WDip+o92O33FkURXMv76PaqhXfF/O ldazWo8r9vRO88C8tmz/HfVX4X8i/VIHJbQsdjnur29lOn5gsb9NJoNfVMVE0oJQUBhO ScCQJBBpLKBm3RdDU2l3OxnHK6e8Ciug32hZuffDgjyMNwFY4OSvoVldGOV/jygNPM/S DA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2r69kgtacj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2019 13:41:14 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 12 Mar 2019 13:41:08 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 12 Mar 2019 13:41:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOCWmKf34wh+aYygwqqeSR6ZeI8pEWMz1WBH3Sd9PBc=; b=cyVP0+69iNNx3q+08zWqGJp5S+2+3nYdONzg7VGixDHkaFKXPX8dSImjcJZDjneT3MsV5a+AeF278/f2M4U2ckUgL7D4WRV7R6cC30ZaRh+E6D1FQmMo3HLMghf8qqg71FWqerbRYJk2kTJ07FryKoUo/zA2YsWUqdlfsby1jeI= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1848.namprd18.prod.outlook.com (10.171.255.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.21; Tue, 12 Mar 2019 20:41:06 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa%2]) with mapi id 15.20.1686.021; Tue, 12 Mar 2019 20:41:06 +0000 From: Pavan Nikhilesh Bhagavatula To: Jerin Jacob Kollanukkaran , "harry.van.haaren@intel.com" , "nikhil.rao@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" , "john.mcnamara@intel.com" CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula Thread-Topic: [dpdk-dev] [PATCH v3 1/3] app/eventdev: start event producers after eventdev Thread-Index: AQHU2RPqv+esPUlEZ0CD6tVh7+4I+w== Date: Tue, 12 Mar 2019 20:41:05 +0000 Message-ID: <20190312204037.16141-1-pbhagavatula@marvell.com> References: <20190227200019.1085-1-pbhagavatula@marvell.com> In-Reply-To: <20190227200019.1085-1-pbhagavatula@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::15) To CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7a::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [117.216.244.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d1667b4-0d05-4bf1-0847-08d6a72b0c4d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:CY4PR1801MB1848; x-ms-traffictypediagnostic: CY4PR1801MB1848: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; CY4PR1801MB1848; 23:qAOh80001gvan08vruk8imxfdWnBA958EtexW?= =?iso-8859-1?q?ZGjD75CEmsFOplGep6S08h7m1?= =?iso-8859-1?q?IroOBvLEM5Uzxnvx13AYtnJI/8v8XXKA5bYFJQn0ZnHYSI1DbVm?= =?iso-8859-1?q?Se10RlMELHfVZNXJEYGEP9CIw36Ml7+vbCtiaJRDBmm3Z48r8/R?= =?iso-8859-1?q?jqcie/9xiVLH2qw3tLaJcHt37sFGKKSt1+8h3DtVqjIkgPWSA+q?= =?iso-8859-1?q?KANfxUZMzOVgYGr6jnsmw+n4b1xrf3ElkAT4GlqX/5PFMme6Ybl?= =?iso-8859-1?q?o+zMpHTLuCskrS9tIpnhL4swFnJ7G0K0Q5lvZGDcDdg3LoCa9jl?= =?iso-8859-1?q?Nw/YRf+03CUwjFSzR3ryiCb3jxOUgkL6U3DC5zv+5A5ILO6cJVM?= =?iso-8859-1?q?DmjiwptX63ku8iHA3/zA1goNTkuPrlE+0QkO3A+k+uS0tQf8h36?= =?iso-8859-1?q?soWe77wunzxymQ4PAAKajkVK4mGSAYKLthYrUkerbBlIJpC7C8r?= =?iso-8859-1?q?y/ElGgDzb/TNbPSjQ8No8y1FHJSmW38zROEQMYGr3GHxS0MUyMJ?= =?iso-8859-1?q?imlkWu08FA6+5CTN37hWWsyl96Tf6qYPFcB7mybHHItTNOGNPxJ?= =?iso-8859-1?q?OJQ9gOYYZTHT9OXz3tntX5hD6uRmvuLIbacCpdvejT7n8KuZprG?= =?iso-8859-1?q?fnt29VZQgwpBmLTekJ2IKWsR0WjeYbjtZ7xTgtxANRDAkLZtwfP?= =?iso-8859-1?q?k6Rj1+UNlbMp6eYphB5em9S+fL56jTpNT8oAXhjmdQI82oFwrkH?= =?iso-8859-1?q?wLAfs1+Vb6HJiPuJUp8cwrdUJ8RQKMprU3inyiKJ2nCjxxaUXsE?= =?iso-8859-1?q?CBAL6TAG8J1SPaOpkBh+1qKPotyl+iYCJjADAtfPqE/4RLvO5o4?= =?iso-8859-1?q?/WxhQDOprSzgZSSEQpN9hMjUafGV52DZ6SNSScZUwHdzqNkGZ/X?= =?iso-8859-1?q?X5pGaMtE43vM+i56C6KscFKsJebKomyE6ZndHK4vhm2kQWtQqSd?= =?iso-8859-1?q?aXSjsXCLCShWlqJimZ5yh3QSJoCfZ1XtOtyaODXr7iYUeofDZdf?= =?iso-8859-1?q?JBRXL9IeBCwLItqMQGK/kFEi+RaR0Sb+cMp6mnQsEC308dJxW1q?= =?iso-8859-1?q?vO0SdrU/NlMW+diOPKN2rrbokF4Tykbt5W9XlzLNZhVtnyrcA2+?= =?iso-8859-1?q?4oixd+D/Bd61tD+UTlgaxs7X2BMb28rk/TiGEphhUJ2W6qxd1lx?= =?iso-8859-1?q?fz8UK6fr/lUSk+0gmlpbtHktG9r5ij2oab819p65hAGbrHIbLyh?= =?iso-8859-1?q?JKW2xnim/D6NPQMkjOhsZ5UY31W9LTSXZfv10iNDJYG+T0DDNDe?= =?iso-8859-1?q?PiKOD8BZrno3DkQpj3Kjetplon3hp0D8b5GnMhPZRpV2jkNB4rE?= =?iso-8859-1?q?0D5FZX8Mx+DxIa0g=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(136003)(189003)(199004)(55236004)(25786009)(81156014)(3846002)(81166006)(11346002)(486006)(476003)(2616005)(316002)(305945005)(8676002)(68736007)(2501003)(8936002)(7736002)(66066001)(6116002)(446003)(110136005)(54906003)(1076003)(186003)(256004)(14454004)(99286004)(106356001)(71200400001)(6506007)(105586002)(52116002)(50226002)(107886003)(2906002)(86362001)(71190400001)(4326008)(102836004)(2201001)(5660300002)(478600001)(76176011)(36756003)(26005)(386003)(6436002)(6512007)(6486002)(97736004)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1848; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ogU3REWFZHfqCsLrTXtKBx2oCeRGUrZAht19mlLckMrtLdksK4Rj9pPbIE2Eu+IP+uZaJd9uM6TNbMowNFPAX+TPNTmv6KkwALgFq3XZ6EvRcdAwbOqm3O5w+mpKXLqCsEaVKHtYV3BGcNq8kA8ia+RF5g4okkpDdCiOmdsJqsVZ4R0/H2WND8YL3sbKtyqCO5WM/2Z0kkq4P/mNjeoEJLjwlTeoc6i3QyrxJU0x9EGY8DAve9xaby7jST5QBCFPtE1PKwS/Zgf0JwOcfJcKFEBiUuWRfiw6Xhe4AbjQ5u1n81aWvZ+9Jjoyw8t1TYNzfb5G9afXsm4ftam9Ps+S86WObagtDvV3clksCDchj3NVE8yeqN49653GdxnazRTzIhVCCFD1WwgtHQaRe63iHgYCVnHi63n7IUMtSyzzBCE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1667b4-0d05-4bf1-0847-08d6a72b0c4d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 20:41:05.9106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1848 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-12_12:, , signatures=0 Subject: [dpdk-dev] [PATCH v3 1/3] app/eventdev: start event producers after eventdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Start event producers after eventdev i.e. consumer is started as in some architectures it might lead to undefined behaviour or events being dropped. Signed-off-by: Pavan Nikhilesh Reviewed-by: Jerin Jacob --- app/test-eventdev/test_perf_atq.c | 31 +++++++++++++++++++++++++ app/test-eventdev/test_perf_common.c | 21 ----------------- app/test-eventdev/test_perf_queue.c | 31 +++++++++++++++++++++++++ app/test-eventdev/test_pipeline_atq.c | 13 ++++++----- app/test-eventdev/test_pipeline_queue.c | 13 ++++++----- 5 files changed, 76 insertions(+), 33 deletions(-) diff --git a/app/test-eventdev/test_perf_atq.c b/app/test-eventdev/test_perf_atq.c index b76ca605b..73f31e564 100644 --- a/app/test-eventdev/test_perf_atq.c +++ b/app/test-eventdev/test_perf_atq.c @@ -157,7 +157,9 @@ perf_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt) uint8_t queue; uint8_t nb_queues; uint8_t nb_ports; + uint16_t prod; struct rte_event_dev_info dev_info; + struct test_perf *t = evt_test_priv(test); nb_ports = evt_nr_active_lcores(opt->wlcores); nb_ports += (opt->prod_type == EVT_PROD_TYPE_ETH_RX_ADPTR || @@ -236,6 +238,35 @@ perf_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt) return ret; } + if (opt->prod_type == EVT_PROD_TYPE_ETH_RX_ADPTR) { + RTE_ETH_FOREACH_DEV(prod) { + ret = rte_eth_dev_start(prod); + if (ret) { + evt_err("Ethernet dev [%d] failed to start. Using synthetic producer", + prod); + return ret; + } + + ret = rte_event_eth_rx_adapter_start(prod); + if (ret) { + evt_err("Rx adapter[%d] start failed", prod); + return ret; + } + printf("%s: Port[%d] using Rx adapter[%d] started\n", + __func__, prod, prod); + } + } else if (opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { + for (prod = 0; prod < opt->nb_timer_adptrs; prod++) { + ret = rte_event_timer_adapter_start( + t->timer_adptr[prod]); + if (ret) { + evt_err("failed to Start event timer adapter %d" + , prod); + return ret; + } + } + } + return 0; } diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c index f99a6a607..24ece75c3 100644 --- a/app/test-eventdev/test_perf_common.c +++ b/app/test-eventdev/test_perf_common.c @@ -393,21 +393,6 @@ perf_event_rx_adapter_setup(struct evt_options *opt, uint8_t stride, return ret; } } - - ret = rte_eth_dev_start(prod); - if (ret) { - evt_err("Ethernet dev [%d] failed to start." - " Using synthetic producer", prod); - return ret; - } - - ret = rte_event_eth_rx_adapter_start(prod); - if (ret) { - evt_err("Rx adapter[%d] start failed", prod); - return ret; - } - printf("%s: Port[%d] using Rx adapter[%d] started\n", __func__, - prod, prod); } return ret; @@ -461,12 +446,6 @@ perf_event_timer_adapter_setup(struct test_perf *t) } rte_service_runstate_set(service_id, 1); } - - ret = rte_event_timer_adapter_start(wl); - if (ret) { - evt_err("failed to Start event timer adapter %d", i); - return ret; - } t->timer_adptr[i] = wl; } return 0; diff --git a/app/test-eventdev/test_perf_queue.c b/app/test-eventdev/test_perf_queue.c index 8efdec6f9..d89491364 100644 --- a/app/test-eventdev/test_perf_queue.c +++ b/app/test-eventdev/test_perf_queue.c @@ -158,7 +158,9 @@ perf_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt) int ret; int nb_ports; int nb_queues; + uint16_t prod; struct rte_event_dev_info dev_info; + struct test_perf *t = evt_test_priv(test); nb_ports = evt_nr_active_lcores(opt->wlcores); nb_ports += opt->prod_type == EVT_PROD_TYPE_ETH_RX_ADPTR || @@ -251,6 +253,35 @@ perf_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt) return ret; } + if (opt->prod_type == EVT_PROD_TYPE_ETH_RX_ADPTR) { + RTE_ETH_FOREACH_DEV(prod) { + ret = rte_eth_dev_start(prod); + if (ret) { + evt_err("Ethernet dev [%d] failed to start. Using synthetic producer", + prod); + return ret; + } + + ret = rte_event_eth_rx_adapter_start(prod); + if (ret) { + evt_err("Rx adapter[%d] start failed", prod); + return ret; + } + printf("%s: Port[%d] using Rx adapter[%d] started\n", + __func__, prod, prod); + } + } else if (opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { + for (prod = 0; prod < opt->nb_timer_adptrs; prod++) { + ret = rte_event_timer_adapter_start( + t->timer_adptr[prod]); + if (ret) { + evt_err("failed to Start event timer adapter %d" + , prod); + return ret; + } + } + } + return 0; } diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-eventdev/test_pipeline_atq.c index fc4cb3bb7..998a56cfd 100644 --- a/app/test-eventdev/test_pipeline_atq.c +++ b/app/test-eventdev/test_pipeline_atq.c @@ -442,6 +442,13 @@ pipeline_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt) } } + ret = rte_event_dev_start(opt->dev_id); + if (ret) { + evt_err("failed to start eventdev %d", opt->dev_id); + return ret; + } + + RTE_ETH_FOREACH_DEV(prod) { ret = rte_eth_dev_start(prod); if (ret) { @@ -451,12 +458,6 @@ pipeline_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt) } } - ret = rte_event_dev_start(opt->dev_id); - if (ret) { - evt_err("failed to start eventdev %d", opt->dev_id); - return ret; - } - RTE_ETH_FOREACH_DEV(prod) { ret = rte_event_eth_rx_adapter_start(prod); if (ret) { diff --git a/app/test-eventdev/test_pipeline_queue.c b/app/test-eventdev/test_pipeline_queue.c index e35e9eb4c..7da89dad5 100644 --- a/app/test-eventdev/test_pipeline_queue.c +++ b/app/test-eventdev/test_pipeline_queue.c @@ -456,6 +456,13 @@ pipeline_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt) } } + ret = rte_event_dev_start(opt->dev_id); + if (ret) { + evt_err("failed to start eventdev %d", opt->dev_id); + return ret; + } + + RTE_ETH_FOREACH_DEV(prod) { ret = rte_eth_dev_start(prod); if (ret) { @@ -466,12 +473,6 @@ pipeline_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt) } - ret = rte_event_dev_start(opt->dev_id); - if (ret) { - evt_err("failed to start eventdev %d", opt->dev_id); - return ret; - } - RTE_ETH_FOREACH_DEV(prod) { ret = rte_event_eth_rx_adapter_start(prod); if (ret) { From patchwork Tue Mar 12 20:41:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 51142 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 428364CA6; Tue, 12 Mar 2019 21:41:19 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E801E44C3 for ; Tue, 12 Mar 2019 21:41:15 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2CKZQLY007220; Tue, 12 Mar 2019 13:41:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=sv6gJo2AnW2tikztRrAWA8Qhh7TnElX91+vlvS0jNZg=; b=Nn6TFksCXAS/qP7cOEXvb3LFxdCC+k+UQzBZVbhhGTaNUFA68FfNLYv+RzfdUkjBSglz FBtYf84+YP94hMlV/Hdw98rirXnmbk0KvtkhYFpfXGTOW1eKPjqyqqweO5EDENOopuhf 5DGUaXOIH1DVlwE12uQlSO8jlhxbTq/IzICgKla6wfCQoaNU9gkZOVR2PqLQQxOVdCxn xj5ITJKtKjwOZ8ZLjjOpRag7inZlfZjrnVwGp4ep8RSG1nvxv/gX/MJt7jbhF5zTeM5w MWnN3bXR/Z8gaInCYM+KWE/m4zRf4QxhW6CFe7KE83HVc8s233rmGKN4q8L1UBHsZkvd hQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2r69kgtacn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2019 13:41:14 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 12 Mar 2019 13:41:13 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 12 Mar 2019 13:41:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sv6gJo2AnW2tikztRrAWA8Qhh7TnElX91+vlvS0jNZg=; b=hL/7zyBRxnBKDy0My5zTcxfAb0m5b7YtOC1pJ1ZkO9mSwl+F6UY0o+uCj3wXWf0oBssYAK6fhdAEL9DU7lVlFteSqJkR2Z2JUgyBslSyifDRarpgueT/v46Me4MUhlYIB0dwX8ZAOMFnCnif3qfejwBVxJENSXD7WIklLT0w8o4= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1848.namprd18.prod.outlook.com (10.171.255.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.21; Tue, 12 Mar 2019 20:41:09 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa%2]) with mapi id 15.20.1686.021; Tue, 12 Mar 2019 20:41:09 +0000 From: Pavan Nikhilesh Bhagavatula To: Jerin Jacob Kollanukkaran , "harry.van.haaren@intel.com" , "nikhil.rao@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" , "john.mcnamara@intel.com" CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula Thread-Topic: [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after eth adapter setup Thread-Index: AQHU2RPs8Nbc/si+CEGxwh6gooznfg== Date: Tue, 12 Mar 2019 20:41:09 +0000 Message-ID: <20190312204037.16141-2-pbhagavatula@marvell.com> References: <20190227200019.1085-1-pbhagavatula@marvell.com> <20190312204037.16141-1-pbhagavatula@marvell.com> In-Reply-To: <20190312204037.16141-1-pbhagavatula@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::15) To CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7a::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [117.216.244.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 196f618a-21d7-42dc-1e5d-08d6a72b0ec4 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:CY4PR1801MB1848; x-ms-traffictypediagnostic: CY4PR1801MB1848: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; CY4PR1801MB1848; 23:i9uZBDvlwjFOGuc8sezEId3jF9PMix4RicwOx?= =?iso-8859-1?q?L6wSlOEjlMV3YW92txjOgdrOc?= =?iso-8859-1?q?uLBMUL4yW19BZ+InIaoZWR8GgCG8VvLd4p+lB9237P1l5e3CRg0?= =?iso-8859-1?q?dXGVVejmsXXoK1MufZBn8t1s6PniPHWvp1W04F7DHXqqrd5cY5i?= =?iso-8859-1?q?nNGyCXd2S1gjvOxOOF7cLdg61A+babDeOaaumHNgNXRU/9OYZA8?= =?iso-8859-1?q?E7hwI5+aw5bJ3+yLN0fecefv6lmNTbYSL0EUs+YMu4rq7I3nfdh?= =?iso-8859-1?q?bV1ntf7E+8HdPZClEC9EvX5qNEe/VRQ2QkNp5vluXBJ4udHCwXA?= =?iso-8859-1?q?1jLUPHo9Wz+wLhTywBOs+x5gy0icbFHIJOfzpA98Vfx3+NGWhnH?= =?iso-8859-1?q?Htf6arMZLV4S0fLG+45dDIgTXtbfRb81gPVe20bbDxqqdtOKPhf?= =?iso-8859-1?q?Agj3tW1IYT07kMVElcesdjPCp5vUaSWsDb7LkDIBEhgWjiYoxjL?= =?iso-8859-1?q?rE56EZS9o+oTughs0Pfqd3ww+xEsWTaZU8n+b5EFV8o2dBSD+az?= =?iso-8859-1?q?5akcCVSwnURfEN9gvRzP3/HceTkkWBylLkKEI3/jPXmKH1OCmFn?= =?iso-8859-1?q?FVNTDtFDRwZtFc9YB2xIRI5dzPEuO+j+AWiibYlwuVuyWZfBEGK?= =?iso-8859-1?q?kSkqeeJaYjAIO0n3oppNhzXV/f4Nab4q/dIvKlTmX8TIzMyjsDO?= =?iso-8859-1?q?pMe6Y1oDhKUGcVwIgZDA3tJRDvPZZZDVAHzNV6VqiIk2yzL/1lw?= =?iso-8859-1?q?oCMyyKtJ4LFqs/sEbu9SOtjxMaKvhvOMDBrmsiZxK7Zb2T1USQp?= =?iso-8859-1?q?vgDmFJgSu4jU+lhU9gMV4ZSQaP9a0EiGBhOPBRAY6gTE2/pRoHa?= =?iso-8859-1?q?HLek9PE/ENWUt4Ov0VMWXcCLKKFP2mpy+OaPOpsJiuCcVpbg8MQ?= =?iso-8859-1?q?YEUEFlc4fCYqaDoaGmthiL5TbovKKOAdMao3YCvngNE7dTI5hqz?= =?iso-8859-1?q?Iwoyhe5ZZ2rM60X3vpzVORks4CulCHLz5yQyWAm2qeogKVomkmV?= =?iso-8859-1?q?3KBRvgLFXMZ6qKw680kVWYq4Hp1nnX3GqrbAJIWwxhjDGc6k1Gp?= =?iso-8859-1?q?6Igl/RtH3jwc2qC7EvbUASGIe2fMDYwKMDtA5xeRZQPLLLtu8Me?= =?iso-8859-1?q?+LZqwCLlU+z83UyfXMlB3S/uepnc+zPd5fWsngQP2OiN+WoS1TO?= =?iso-8859-1?q?56qjJHisEa94ev0e2Tzc2mFrZi/4OkmjZAcflOVgaJvj8G0cjGe?= =?iso-8859-1?q?umY1aHH58bI8sNJcmJN2kZVRYL80FvYrUxkCVRIYHn5tPEfyts/?= =?iso-8859-1?q?MIFdo9Xq1DhT0ZkkvnMjSxweWSJ+gkeDagApkL9th4JMwzgk2eG?= =?iso-8859-1?q?V6Z7ps2Sq04s79PVPwQ8zmjVhKCiaBCmFoBV8=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(136003)(189003)(199004)(55236004)(25786009)(81156014)(3846002)(81166006)(11346002)(486006)(476003)(2616005)(316002)(305945005)(8676002)(68736007)(2501003)(8936002)(7736002)(66066001)(6116002)(446003)(110136005)(54906003)(14444005)(1076003)(186003)(256004)(14454004)(99286004)(106356001)(71200400001)(6506007)(105586002)(52116002)(50226002)(107886003)(2906002)(86362001)(71190400001)(4326008)(102836004)(2201001)(5660300002)(478600001)(76176011)(36756003)(26005)(386003)(6436002)(6512007)(6486002)(97736004)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1848; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3O3AI72ErUbRZ6O3+SArG1GfZiwCocHDsZ5yEHb4Ershz46fk+gEL4GYixMy30EQ34f6xqUrpCk8X7CEbZaOOyQCJVRxrt16fRn1Z+KPFiIH3f+aJd1NegdLx+CZswpKif9DnwtpAqO5Du72jxtYijUqanB1ZD7VNOHcVU745NTtXuq7/ExtsDsuhJbN9Z3/nMMpXnlk4a/PKzt4I/joXP+A12IoZRfmR9WZBPLPJ9pVMPcpj3Tx4gwaZPYUAixWOe6fktSKIomkepJsh7qnVFk+GzXaLsWcp5EofJE6WzPRSuDnFefK7lspJuKABud5Pt4reppQPIPlxbIuJs8EDJ/szMV3xF8XMisRoqQfipseUwLCQuawQdjBI3EAe7ViaDIAnk+e2CxDSKvHyoevbk8E9inGxULua5efOTOw4mE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 196f618a-21d7-42dc-1e5d-08d6a72b0ec4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 20:41:09.5762 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1848 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-12_12:, , signatures=0 Subject: [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after eth adapter setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Start ethdev after the Rx/Tx adapter setup is complete as in some architectures it might lead to undefined behaviour or events being dropped. Signed-off-by: Pavan Nikhilesh Reviewed-by: Nikhil Rao --- v3 Changes: - add the same changes in examples/eventdev_pipeline examples/eventdev_pipeline/main.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) -- 2.21.0 diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c index 92e08bc0c..22ea75e7b 100644 --- a/examples/eventdev_pipeline/main.c +++ b/examples/eventdev_pipeline/main.c @@ -316,11 +316,6 @@ port_init(uint8_t port, struct rte_mempool *mbuf_pool) return retval; } - /* Start the Ethernet port. */ - retval = rte_eth_dev_start(port); - if (retval < 0) - return retval; - /* Display the port MAC address. */ struct ether_addr addr; rte_eth_macaddr_get(port, &addr); @@ -440,6 +435,7 @@ main(int argc, char **argv) { struct worker_data *worker_data; uint16_t num_ports; + uint16_t portid; int lcore_id; int err; @@ -507,6 +503,14 @@ main(int argc, char **argv) init_ports(num_ports); fdata->cap.adptr_setup(num_ports); + /* Start the Ethernet port. */ + RTE_ETH_FOREACH_DEV(portid) { + err = rte_eth_dev_start(portid); + if (err < 0) + rte_exit(EXIT_FAILURE, "Error starting ethdev %d\n", + portid); + } + int worker_idx = 0; RTE_LCORE_FOREACH_SLAVE(lcore_id) { if (lcore_id >= MAX_NUM_CORE) From patchwork Tue Mar 12 20:41:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 51143 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E87404CB5; Tue, 12 Mar 2019 21:41:28 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id B69514CA0 for ; Tue, 12 Mar 2019 21:41:26 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2CKZQLZ007220; Tue, 12 Mar 2019 13:41:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=L84WuFmoy72XrmFh/MPNo7FcqYc2kyiN0GHwnAEAo+w=; b=IYSqLXSvoiYZBQLGiI5HZFxnTFVfb//p/VwE4ke5jJHLJr4ZUrmbZLcsbq6Yr/p6lcPb HV76Tqu4WttQAGwdMDt/41H5fh8kYO1CaYsAL1NVZK+sTUDumF9v05/+z1hQIFmkM9X+ ec72uRb5QSMMvUBECm447ARvGiIGktZFqxhXgT7zg14ubpPvfrC5MO2q9gE9E44I+oLx XcZsGXVZqR9s3akktWxA8lX8yNbUC+6FWOmU/kP0I+dH62QQc/+lAGRz09LLGXnFyMvE W0Ci4ffTbuV9+1xLnCmBzbZGdsXc0gt9EzzxwByby1Sa1q+dgAKiv3H/cuXwOpqGSaDc 4A== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2r69kgtad3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2019 13:41:25 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 12 Mar 2019 13:41:14 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.58) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 12 Mar 2019 13:41:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L84WuFmoy72XrmFh/MPNo7FcqYc2kyiN0GHwnAEAo+w=; b=VR61rOUubo760KNx1YX42HGJO6VZKasUf641q0TuaR6Q5T+/8XSQ+BsyVXCgSySnUzJFoDxAlGOwCWlxtSgQm3zrOX4X/jHShrRQ82xq+MaaB141rUzP3XYlQCUl8SDkr1hCEJlb7J1qYzLWbQgn4pBxeTQOjIRheN4TgqqZU0g= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1848.namprd18.prod.outlook.com (10.171.255.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.21; Tue, 12 Mar 2019 20:41:13 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::286d:5e93:974e:8bfa%2]) with mapi id 15.20.1686.021; Tue, 12 Mar 2019 20:41:13 +0000 From: Pavan Nikhilesh Bhagavatula To: Jerin Jacob Kollanukkaran , "harry.van.haaren@intel.com" , "nikhil.rao@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" , "john.mcnamara@intel.com" CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula Thread-Topic: [dpdk-dev] [PATCH v3 3/3] doc: add notes about eventdev producer consumer dependency Thread-Index: AQHU2RPuISJr0AKp9kejkVBtGVqXVA== Date: Tue, 12 Mar 2019 20:41:13 +0000 Message-ID: <20190312204037.16141-3-pbhagavatula@marvell.com> References: <20190227200019.1085-1-pbhagavatula@marvell.com> <20190312204037.16141-1-pbhagavatula@marvell.com> In-Reply-To: <20190312204037.16141-1-pbhagavatula@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::15) To CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7a::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [117.216.244.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89fa0551-30f8-47c4-57ae-08d6a72b10d7 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:CY4PR1801MB1848; x-ms-traffictypediagnostic: CY4PR1801MB1848: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; CY4PR1801MB1848; 23:AKanqgvP0kuncziGwO5IGlDT6qDVHLfZcX4T2?= =?iso-8859-1?q?hSMswJyibZZCBnbEM3LUjVd+X?= =?iso-8859-1?q?Gx6evAvR9kB6qyKfc5WpUMEeJubhzUr+wk+49vliPvkGndlRn8Z?= =?iso-8859-1?q?qy9c86s67CzVDyE8FO0RXaILYj2I4MZsp1YW22VKuxjZbgOy0J6?= =?iso-8859-1?q?uAFPYaISEulW1Kj7I4YLIDbhCsMxuxDzqc1csOwfFZkK624oV4u?= =?iso-8859-1?q?hYlzrGkqit5DGmYgzeDZ+2sjy7haIVw2gTQCHm+X444E0okFmdy?= =?iso-8859-1?q?h6Hv2ZxB3fgtHw559YwBHFMf70KtPgGa8CcBXoZkKXnapWMvaGt?= =?iso-8859-1?q?yrV4mJeIC6fG8CybpPdgt+Mdu7iZa1+5FK0eT9frC9iNYG4zobQ?= =?iso-8859-1?q?6k0TDQOZ3qW8aJNB6jlAXXRjYzdEVSSvsl9w/UTOSjEVp7cmi0d?= =?iso-8859-1?q?cXlWr8u9qXF+yzY5lbedam7C1GRRT1j7Qx2NsHeVBRyUttK/Izt?= =?iso-8859-1?q?A6lL9q5AKmo4vvK3DisqnBfont8SaYeeygtZtI4wKq8TUn46ivs?= =?iso-8859-1?q?zI2K5QnB9QDv6GB88++/5jQZoJDLP/pkR/sPzXoCYyJjYwqidH2?= =?iso-8859-1?q?2S/doP5dp67voa/u7SmXERv1bmY13EWecjp8PGxYjXNlNRAflYO?= =?iso-8859-1?q?fA+yh+26P/9qX4FGL/Tqg4G/fmP1CYXa+QLuB6023XiHXdiPzcd?= =?iso-8859-1?q?LolNsYliKFom2gJ20vey+zqsOEmw9k7GQXRsf3cgqqD0qGUanmR?= =?iso-8859-1?q?5aP82wc8qFPYyxTkNuubOlCRwR1V7IcifsHN/dyGtejLH1yG8vc?= =?iso-8859-1?q?32JXxgqo4PCSBPvB33amFLW0kn5iiAxiA6O5Q/tJ/7TjyemG5PK?= =?iso-8859-1?q?jbgIjKxEgnP2A0+gBvC93g88n9ORKucwt5v6tklMo7e9/EesZKx?= =?iso-8859-1?q?KsydYukVIzRHDq+uXuJEhYcSGTgtatW7Q4ksA3kRFvI/JFsQ8Qw?= =?iso-8859-1?q?NKeFVig5Oo3gyInew7fRQYdr0KbhRK8BMKR6WgBMKy8SOLi2fiD?= =?iso-8859-1?q?5hoodSBhy7SEn1RWTIhpeXMxcPv3z+Jr3aCj7jFNHU3x9llngLA?= =?iso-8859-1?q?IAGS81lG2dikhddj5j50FhYGyFZgYnM88XePIwkkCeElGkMb1A+?= =?iso-8859-1?q?AN69IOQ5YPXjdI6bmUwmZzFxSOACg8wvFYREcUVFpUmg/kIP3SS?= =?iso-8859-1?q?7WK4vX2jDFbLavOJgAFM5rtAVuoTNhOwiCNydEW85vMV+RBhniO?= =?iso-8859-1?q?Kov8QogMQkpiqkWxujuyoH9w6TwsANhi1aaPbaCZIpWK2niXmIx?= =?iso-8859-1?q?R+kNJszz68wjgFPv09JddxuZfVLPtTnb9eaysRxWhKnCmYpjIGU?= =?iso-8859-1?q?pxM9TwJY5R+kBGryp5Su8FzfqpDXaDSx/Qjjo=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(136003)(189003)(199004)(55236004)(25786009)(81156014)(3846002)(81166006)(11346002)(486006)(476003)(2616005)(316002)(305945005)(8676002)(68736007)(2501003)(8936002)(7736002)(66066001)(6116002)(446003)(110136005)(54906003)(14444005)(1076003)(186003)(256004)(14454004)(99286004)(106356001)(71200400001)(6506007)(105586002)(52116002)(50226002)(107886003)(2906002)(86362001)(71190400001)(4326008)(102836004)(2201001)(5660300002)(478600001)(76176011)(36756003)(26005)(386003)(6436002)(6512007)(6486002)(97736004)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1848; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jMGETyS/WzXZbQn6dZIvvmuPqqos3ASPgX4u9f4iQIizw6TcKHMeLlBkXkJ1v7OwWws3ZYNBPnuq3l/EmvDVwWUzPye4nkTapYKpbVr8+znO8CSQfkEsge3bGItARcLM/nXU0leutOejMkx4iFy02oYJ1Ueu+oNmUaN0QI97Npew4B0OkFJBCznpMuNinJoyY5Q3GR34fB0ohz3ZtaTu+wMaSrbTltvSmtvZ+lohfqr/ikZYluV3zi/o0r6flxPyoK7+8DFl8eHcbMuQBp0WXVs9diUlRMnrS26/nlnwwH+nK3YbzJWeLU9lIO3SDObR01lTXYH0ajkitA/kXHdF6S58RMG+Ee4wrp6P1gpUMObEkPaF1sEzhrVtqz2OADwIGEkuqbdUbmXkuEHDIvjHElD1Ucj8teq93Pbq+XTs26g= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 89fa0551-30f8-47c4-57ae-08d6a72b10d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 20:41:13.3768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1848 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-12_12:, , signatures=0 Subject: [dpdk-dev] [PATCH v3 3/3] doc: add notes about eventdev producer consumer dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh EventDev i.e consumer needs to be started before starting the event producers. Update documentation of EventDev and EventDev adapters. Signed-off-by: Pavan Nikhilesh Reviewed-by: Erik Gabriel Carrillo Reviewed-by: Abhinandan Gujjar --- v2 Changes: Add Notes to doxygen API. doc/guides/prog_guide/event_crypto_adapter.rst | 5 +++++ doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 5 +++++ doc/guides/prog_guide/event_timer_adapter.rst | 5 +++++ doc/guides/prog_guide/eventdev.rst | 5 +++++ lib/librte_eventdev/rte_event_crypto_adapter.h | 4 ++++ lib/librte_eventdev/rte_event_eth_rx_adapter.h | 4 ++++ lib/librte_eventdev/rte_event_timer_adapter.h | 4 ++++ 7 files changed, 32 insertions(+) -- 2.21.0 diff --git a/doc/guides/prog_guide/event_crypto_adapter.rst b/doc/guides/prog_guide/event_crypto_adapter.rst index 9fe09c805..1e3eb7139 100644 --- a/doc/guides/prog_guide/event_crypto_adapter.rst +++ b/doc/guides/prog_guide/event_crypto_adapter.rst @@ -286,6 +286,11 @@ service function if one exists. rte_event_crypto_adapter_start(id, mode); +.. Note:: + + The eventdev to which the event_crypto_adapter is connected needs to + be started before calling rte_event_crypto_adapter_start(). + Get adapter statistics ~~~~~~~~~~~~~~~~~~~~~~ diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 0166bb45d..e95529974 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst @@ -135,6 +135,11 @@ This function calls the start callbacks of the eventdev PMDs for hardware based eventdev-ethdev connections and ``rte_service_run_state_set()`` to enable the service function if one exists. +.. Note:: + + The eventdev to which the event_eth_rx_adapter is connected needs to + be started before calling rte_event_eth_rx_adapter_start(). + Getting Adapter Statistics ~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/doc/guides/prog_guide/event_timer_adapter.rst b/doc/guides/prog_guide/event_timer_adapter.rst index 3b4446ee9..eb195ebd4 100644 --- a/doc/guides/prog_guide/event_timer_adapter.rst +++ b/doc/guides/prog_guide/event_timer_adapter.rst @@ -179,6 +179,11 @@ running the event timer adapter. This function calls the start entry points defined by eventdev PMDs for hardware implementations or puts a service component into the running state in the software implementation. +.. Note:: + + The eventdev to which the event_timer_adapter is connected needs to + be started before calling rte_event_timer_adapter_start(). + Arming Event Timers ~~~~~~~~~~~~~~~~~~~ diff --git a/doc/guides/prog_guide/eventdev.rst b/doc/guides/prog_guide/eventdev.rst index 8fcae5469..dcdfeb75e 100644 --- a/doc/guides/prog_guide/eventdev.rst +++ b/doc/guides/prog_guide/eventdev.rst @@ -296,6 +296,11 @@ eventdev. int err = rte_event_dev_start(dev_id); +.. Note:: + + EventDev needs to be started before starting the event producers such + as event_eth_rx_adapter, event_timer_adapter and event_crypto_adapter. + Ingress of New Events ~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h b/lib/librte_eventdev/rte_event_crypto_adapter.h index d367309cb..a7419e91c 100644 --- a/lib/librte_eventdev/rte_event_crypto_adapter.h +++ b/lib/librte_eventdev/rte_event_crypto_adapter.h @@ -472,6 +472,10 @@ rte_event_crypto_adapter_queue_pair_del(uint8_t id, uint8_t cdev_id, * @return * - 0: Success, adapter started successfully. * - <0: Error code on failure. + * + * @note + * The eventdev to which the event_crypto_adapter is connected needs to + * be started before calling rte_event_crypto_adapter_start(). */ int __rte_experimental rte_event_crypto_adapter_start(uint8_t id); diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h index 863b72a10..2314b93f6 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h @@ -405,6 +405,10 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id, * @return * - 0: Success, Adapter started correctly. * - <0: Error code on failure. + * + * @note + * The eventdev to which the event_eth_rx_adapter is connected needs to + * be started before calling rte_event_eth_rx_adapter_start(). */ int rte_event_eth_rx_adapter_start(uint8_t id); diff --git a/lib/librte_eventdev/rte_event_timer_adapter.h b/lib/librte_eventdev/rte_event_timer_adapter.h index db98dec46..cc4518d41 100644 --- a/lib/librte_eventdev/rte_event_timer_adapter.h +++ b/lib/librte_eventdev/rte_event_timer_adapter.h @@ -339,6 +339,10 @@ rte_event_timer_adapter_get_info( * - -EINVAL if adapter identifier invalid * - -ENOENT if software adapter but no service core mapped * - -ENOTSUP if software adapter and more than one service core mapped + * + * @note + * The eventdev to which the event_timer_adapter is connected needs to + * be started before calling rte_event_timer_adapter_start(). */ int __rte_experimental rte_event_timer_adapter_start(