From patchwork Sun Feb 24 09:41:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dekel Peled X-Patchwork-Id: 50472 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 428632C2F; Sun, 24 Feb 2019 10:46:40 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id BE4712A6A for ; Sun, 24 Feb 2019 10:46:38 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with ESMTPS (AES256-SHA encrypted); 24 Feb 2019 11:46:34 +0200 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.128.130.87]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x1O9kYKN005250; Sun, 24 Feb 2019 11:46:34 +0200 From: Dekel Peled To: matan@mellanox.com, shahafs@mellanox.com Cc: dev@dpdk.org, orika@mellanox.com, yskoh@mellanox.com, dekelp@mellanox.com, stable@dpdk.org Date: Sun, 24 Feb 2019 11:41:09 +0200 Message-Id: <1551001269-62890-1-git-send-email-dekelp@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1550995648-60249-1-git-send-email-dekelp@mellanox.com> References: <1550995648-60249-1-git-send-email-dekelp@mellanox.com> Subject: [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Original patch changed logic of function mlx4_flow_merge_eth(). The setting of flow->promisc was wrongly removed. This patch adds the removed setting of flow->promisc, to restore the required behavior. Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN") Cc: stable@dpdk.org Acked-by: Yongseok Koh --- v2: Correct typo in 'stable' email address. --- Signed-off-by: Dekel Peled --- drivers/net/mlx4/mlx4_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 3abde30..b7af324 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -250,6 +250,7 @@ struct mlx4_drop { if (!mask) { eth->val.dst_mac[0] = 0xff; flow->ibv_attr->type = IBV_FLOW_ATTR_ALL_DEFAULT; + flow->promisc = 1; return 0; } memcpy(eth->val.dst_mac, spec->dst.addr_bytes, ETHER_ADDR_LEN);