From patchwork Fri Jan 25 08:10:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 50046 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3AFD9343C; Fri, 25 Jan 2019 09:10:35 +0100 (CET) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 755533256 for ; Fri, 25 Jan 2019 09:10:33 +0100 (CET) Received: by mail-lj1-f195.google.com with SMTP id g11-v6so7627131ljk.3 for ; Fri, 25 Jan 2019 00:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AYSjVfplfQUNhBlTdlrtxT7QsglGiZbpAJ08JjRFSFk=; b=PF5Z9w7Ll6V6GRpR+Iwd4cyMopz+CVmnLo+WvjghWXS65mssooeJkPLp07ir+fUKoP SlF3I7kjiNfG2xiCzyVkcVyQ0p/ZivqmhMUiq3iBjjUd1B9Uc+Ue8I/nrtfhEOd0Qgud 1i5J8nK7UFk4vP4qbkQCHZENHadCpaNfDzYLo9T8XlZ54Uwy/t0X+P2sXXWsZaZXHFWG gvHIFMyqeUSAuYLiv86JReRz9iEaH2mJ63LaYcrwDH0mgA/wLRsi1psWwRqxWGV57e3a Zvg0nmS4whWpZxghCMNPBSz6kr6b6HpzjhewK69ZFTfgqax93mO0M2d0zAy9WwZnJkyC mfcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AYSjVfplfQUNhBlTdlrtxT7QsglGiZbpAJ08JjRFSFk=; b=S5nqw4loR0kz5VX4rPAZcbfDHSUI3k3Ebp+7NaBKXrF4P6mZZqvhVtQD0pFrpk6FTq ymW+2ifqrzeuthJhIiVnaGX2lWC14HhLo0WplQ/fzXkspZXOqzY4xEjH/OcBFATGJ/UM gliWwhv3QMnlyTX/dOiq6vuP9H0Wy2SAPN2dzarylQ84Zi/DYabLELkaytsguX6uFRI9 AYLaaXsHOo98QM/bTcRIJRaPsFQL/w2BEfGSlvq6p5zD0GUXM7BVOkT8L0uQo1F+/P3m bWxHF09Vg+XjawaQQ6SdiI3aoYbTQy4fEO3o6U4NLlrMOPEU7oYmNMhpZzdz/+PV4d7J dtlw== X-Gm-Message-State: AHQUAuZt93gPPDH+rinvoJ+Og7ugz+Wfx8SgOai+n4drgsKe7uXOGgvi ZrwTy6cwJ9WYUCGWMdeafFFMTTQOwZ0= X-Google-Smtp-Source: AHgI3IZoptlhydUKOiH7a6BBqxDuXILYzpoO2maeNRyPHFWbEY9moWm0YYZJ+bkaO0+SbswgBe9m/A== X-Received: by 2002:a2e:2246:: with SMTP id i67-v6mr2708423lji.154.1548403833039; Fri, 25 Jan 2019 00:10:33 -0800 (PST) Received: from localhost.localdomain ([185.157.12.197]) by smtp.gmail.com with ESMTPSA id m21sm1358664lfl.97.2019.01.25.00.10.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Jan 2019 00:10:32 -0800 (PST) From: Michal Krawczyk To: gtzalik@amazon.com, mw@semihalf.com, matua@amazon.com Cc: rk@semihalf.com, dev@dpdk.org, Michal Krawczyk Date: Fri, 25 Jan 2019 09:10:24 +0100 Message-Id: <1548403828-31870-2-git-send-email-mk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548403828-31870-1-git-send-email-mk@semihalf.com> References: <1548403828-31870-1-git-send-email-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 1/5] net/ena: remove lcore constraint from max queue number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The number of queues was limited by number of lcores in the recent ENAv2 patch. However, some apps like symmetric_mp, are configuring multiple queues although there is only single lcore used. To prevent failure in that case, the lcore number constraint was removed. Fixes: ea93d37eb49d ("net/ena: add HW queues depth setup") Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3022dda..fde5fa7 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1687,8 +1687,7 @@ static int ena_calc_io_queue_num(struct ena_com_dev *ena_dev, if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) io_tx_sq_num = get_feat_ctx->llq.max_llq_num; - io_queue_num = RTE_MIN(rte_lcore_count(), ENA_MAX_NUM_IO_QUEUES); - io_queue_num = RTE_MIN(io_queue_num, io_rx_num); + io_queue_num = RTE_MIN(ENA_MAX_NUM_IO_QUEUES, io_rx_num); io_queue_num = RTE_MIN(io_queue_num, io_tx_sq_num); io_queue_num = RTE_MIN(io_queue_num, io_tx_cq_num); From patchwork Fri Jan 25 08:10:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 50047 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A82E4C6C; Fri, 25 Jan 2019 09:10:37 +0100 (CET) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id B42F432A5 for ; Fri, 25 Jan 2019 09:10:34 +0100 (CET) Received: by mail-lj1-f196.google.com with SMTP id t9-v6so7601481ljh.6 for ; Fri, 25 Jan 2019 00:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RZjRj/gtlFNU1dw/fs+wmHHlDj97aQhEXAg4/4t231M=; b=tdzqTCJvbZN6iv8I4k8gHsIViVUEOJ4vhzL3SJUwWwithlla6mgms8pzCeu6hu8g+6 fiOMyvtzlKP35kHTGthfIk/QvxZtiVXdI03SE9Ra5TwyGDg7UaKU2vaf6qfLHcVunBUk Xk/EEF3ZI2fERM3/M5xjpG4y+GnhNOLWyt1/AswkGLkGiLVzmke086FoihrWpj8IkXDM qt5DoQQ4VY06uA58TUE+/j3enUfAiuPOWy+mCUv2UKh7JpYZr2/Drv1icp5Ps14R6SQU gYplwIvx9Rn4hrSXQae2n7JftUl2+2wHD1zOcpfosqMNWu/vk5ld6ShpjpXc68gwZWuv 6kAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RZjRj/gtlFNU1dw/fs+wmHHlDj97aQhEXAg4/4t231M=; b=IBwqKROj3sbtFkk0I7ZrU1rcNGgcxsggbTAKUJw7mxpYUtslAlbYxxN3/konrPvEGq uLSED9fBNqALZX7jutmJXk9npNMw9gqMmX2wE4C+z4iU1E1cQJfNQeP5OyPLaJEh5Z8E P5hz/9lRhyFEpzzpfYKJ751mR35/iZs7Mh7JgNRvXT8dRYbqxl5NDYskbRuPLnUSx0iY 83f2ryC3cQDhoRPAHgSTnwuIjQbD5f/j5J1/cEnraP3DBhp0K5gMFyTNPxhFg0LHcdaD B1DEkFqWDKAFNUUi7fz+nPkk8/DUCyeU7c5hom5xrQO0gqU8xYiZ6Oklqn7psoJATJtm x+nA== X-Gm-Message-State: AJcUukcK5Tqw0EBAaPbJkDs8QD5gnWvyORldENe/h5qh9NTUeZV7BYDV SfbWogv48f7j6fQShNdGRYEW3w== X-Google-Smtp-Source: ALg8bN4vbEahm8Kkx4jvf+r6lXCPy5HiiARHj8a0FKhJsNk5vZs/pEiNRduZJ1l/PBBtMkpiiMKodQ== X-Received: by 2002:a2e:9603:: with SMTP id v3-v6mr8062486ljh.15.1548403834312; Fri, 25 Jan 2019 00:10:34 -0800 (PST) Received: from localhost.localdomain ([185.157.12.197]) by smtp.gmail.com with ESMTPSA id m21sm1358664lfl.97.2019.01.25.00.10.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Jan 2019 00:10:33 -0800 (PST) From: Michal Krawczyk To: gtzalik@amazon.com, mw@semihalf.com, matua@amazon.com Cc: rk@semihalf.com, dev@dpdk.org, Michal Krawczyk , stable@dpdk.org Date: Fri, 25 Jan 2019 09:10:25 +0100 Message-Id: <1548403828-31870-3-git-send-email-mk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548403828-31870-1-git-send-email-mk@semihalf.com> References: <1548403828-31870-1-git-send-email-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 2/5] net/ena: fix dev init for RTE_PROC_SECONDARY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The check for proc type in eth_ena_dev_init() should appear before modyfing adapter structure. Calling memset on ena_adapter from secondary process context, was erasing all structure information, and it was causing the crash of the main process. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index fde5fa7..747390b 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1715,19 +1715,20 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) static int adapters_found; bool wd_state; - memset(adapter, 0, sizeof(struct ena_adapter)); - ena_dev = &adapter->ena_dev; - eth_dev->dev_ops = &ena_dev_ops; eth_dev->rx_pkt_burst = ð_ena_recv_pkts; eth_dev->tx_pkt_burst = ð_ena_xmit_pkts; eth_dev->tx_pkt_prepare = ð_ena_prep_pkts; - adapter->rte_eth_dev_data = eth_dev->data; - adapter->rte_dev = eth_dev; if (rte_eal_process_type() != RTE_PROC_PRIMARY) return 0; + memset(adapter, 0, sizeof(struct ena_adapter)); + ena_dev = &adapter->ena_dev; + + adapter->rte_eth_dev_data = eth_dev->data; + adapter->rte_dev = eth_dev; + pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev); adapter->pdev = pci_dev; From patchwork Fri Jan 25 08:10:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 50048 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F055D4C95; Fri, 25 Jan 2019 09:10:38 +0100 (CET) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id 2FCC537B7 for ; Fri, 25 Jan 2019 09:10:36 +0100 (CET) Received: by mail-lf1-f68.google.com with SMTP id l10so6263447lfh.9 for ; Fri, 25 Jan 2019 00:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BU5BFQG7xvAPnopFsAruFjmtdZXrMEc9pXRWh1ibPPc=; b=UOqPiEGgwovPtBkvrR/2Uz4gGlhHDgdk05ZwpmgsRustub+TetxyFGTTPEavy9GJRE hITB9Yi6Nn7xCBLYq/3NyN/sMf6tYHWJcbIhLBtabPH19nCfamLOPl68ezv27xy2NFOx oWAcfvOgcvfXvTmMAOyEmvIzQjAajVx79aztKLHwweYwpywJBcp94iV86CnOUNrYL7RB mltFmqy90S6s382CtbSg/UnKVLisMZasjUdJWQO7uSaG5jExpIwQ9mN5EPm+HRjCIbqp +apH0kNsooUuTbL15QxqjKrPPw0cLZopXGyk5rfqK1hzmLPoG1vwW6T6wvjpzkl5mrX8 0+Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BU5BFQG7xvAPnopFsAruFjmtdZXrMEc9pXRWh1ibPPc=; b=M47NmJoCUteL4v31qQUT62NnTtmcDM2QI2myAn80FN3UcOVXDC5mHuQiicg3KmkHBS N1UP9Aw/hyPcFerot28cL0OlFsNF+bPnQHRfeqZPoc0qjZsknIbjV4FBdMvOzY9UW528 qYwZ53o7/edWi5tKr1hhKHGM7mdAc+2CnRpZekSN3r2WSO/9KUmwLN8dTDc+fUEY57bM iEnjxOqPMoN3MLIQsxaFHut8z63qmE7Xj8GIkCwP67/X5gwEXO4axRkD90tAXJyvKYDV ISlk5dtsYvL1j9cTQMAbA4I/XZtwm1cVwCf3m0fcmovfj/vNJ3VZwdwu1veMmORIGbTm EeqA== X-Gm-Message-State: AJcUukeFq6jGWg84vO0jBGMUnICu739RI2Rkb5VnjywV7ZbjyplxknpD Jo3qkZ2K0NRxT8Q+8n95xTXcfg== X-Google-Smtp-Source: ALg8bN7jh9bpgtef7MTmfyvXqre7A/67Eh3f5VYpKrRDc8AU6znM/AxJLG6SGimKUlAu2d0DTpmC+g== X-Received: by 2002:a19:6e0b:: with SMTP id j11mr7793387lfc.124.1548403835687; Fri, 25 Jan 2019 00:10:35 -0800 (PST) Received: from localhost.localdomain ([185.157.12.197]) by smtp.gmail.com with ESMTPSA id m21sm1358664lfl.97.2019.01.25.00.10.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Jan 2019 00:10:34 -0800 (PST) From: Michal Krawczyk To: gtzalik@amazon.com, mw@semihalf.com, matua@amazon.com Cc: rk@semihalf.com, dev@dpdk.org, Michal Krawczyk , stable@dpdk.org Date: Fri, 25 Jan 2019 09:10:26 +0100 Message-Id: <1548403828-31870-4-git-send-email-mk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548403828-31870-1-git-send-email-mk@semihalf.com> References: <1548403828-31870-1-git-send-email-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 3/5] net/ena: fix setting rte_errno to negative value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_errno shouldn't have assigned negative error codes, so it has to be fixed. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 747390b..8bb05ca 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2178,14 +2178,14 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, if ((ol_flags & ENA_TX_OFFLOAD_NOTSUP_MASK) != 0 || (ol_flags & PKT_TX_L4_MASK) == PKT_TX_SCTP_CKSUM) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } #ifdef RTE_LIBRTE_ETHDEV_DEBUG ret = rte_validate_tx_offload(m); if (ret != 0) { - rte_errno = ret; + rte_errno = -ret; return i; } #endif @@ -2198,7 +2198,7 @@ eth_ena_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, ret = rte_net_intel_cksum_flags_prepare(m, ol_flags & ~PKT_TX_TCP_SEG); if (ret != 0) { - rte_errno = ret; + rte_errno = -ret; return i; } } From patchwork Fri Jan 25 08:10:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 50049 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BC4E4CA0; Fri, 25 Jan 2019 09:10:40 +0100 (CET) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 632A64C88 for ; Fri, 25 Jan 2019 09:10:37 +0100 (CET) Received: by mail-lj1-f195.google.com with SMTP id t18-v6so7618800ljd.4 for ; Fri, 25 Jan 2019 00:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GPMau5C0fTTK+brFl6SbWPGnNHy7Dmm+5d+/DkN1oBY=; b=rtqFhJ/PswjSgYw0JbaCto1iEHGOd22oEMxfc1qXnsSm82FRBS+l7A+JjRxsm69R3G 2C+K6ogReGJel2MGWKtxmIDEaeTpAE/IgDcn5/ag74e3XB6BMjgAcTq+H7K+ukot4Vmu tFHCvDPl+n+OWMyolhJFVVwIWYiJ7X2YTR7GTmWHKyxznO8tq0JUHvc03JHDDj7fcPIQ hWYlG1VmkxCC29EgICOp8/w9rMcr/aHAhxev68AxcS2mVCmCvN4ip9pKVSRAJclSjOqB yf110vxmmDr+3UXAIkOW7jxTVE60g0/j+iLtXQ/DH457UilSieqjxA4szcmXX7UJYBHC 1HCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GPMau5C0fTTK+brFl6SbWPGnNHy7Dmm+5d+/DkN1oBY=; b=g9z+AlzaXKsrEOqUPteKuKSA8hifFahtSitwDgQz7QSXzhVH0HkLAI1oHjKIk2kJ84 mY3vg+2ahFW9H3ZarsCltRBcvgSvp/1hn2uHVLJZt0OU3CfYRpt0IakO95j+6h0Kl/uA LBqgijrey7dO17ecXT1nqqh6/TZyBCkETowNlAvk+VhlWXERrV60l0mn8qay1ASwWVej gyqHlhTVmwM4ISNDFZT1qTe+lIDjxYb8I7y1rqKlJxVhTVjhIAehH5FaaXa0KQnwFNUf kFYeHuzPgOxHx5m7jGNaVarY7JPxRPFyPM7U5iXMY4nsrx+Yqh6CePSIa5b8Fa6AQF7A inrw== X-Gm-Message-State: AJcUukfpXvBwgVoyMyptcp9T6ML+266LgpUz+1Z1HEV8y3/X/FogEthh e5y1JdmlXJGtlJl1fvAUZpovHg== X-Google-Smtp-Source: ALg8bN7lYQ42tzRi++Dck+VUF0rUBMpLd/jXfkl6yakcaS+U+44Uu2VKLJyEkAqyD2VrgrMV61AVmg== X-Received: by 2002:a2e:5854:: with SMTP id x20-v6mr8125938ljd.31.1548403836981; Fri, 25 Jan 2019 00:10:36 -0800 (PST) Received: from localhost.localdomain ([185.157.12.197]) by smtp.gmail.com with ESMTPSA id m21sm1358664lfl.97.2019.01.25.00.10.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Jan 2019 00:10:36 -0800 (PST) From: Michal Krawczyk To: gtzalik@amazon.com, mw@semihalf.com, matua@amazon.com Cc: rk@semihalf.com, dev@dpdk.org, Michal Krawczyk Date: Fri, 25 Jan 2019 09:10:27 +0100 Message-Id: <1548403828-31870-5-git-send-email-mk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548403828-31870-1-git-send-email-mk@semihalf.com> References: <1548403828-31870-1-git-send-email-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 4/5] doc: update release notes for ENA PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik Add changes in ENA PMD to DPDK v19.02 release notes. Signed-off-by: Michal Krawczyk Signed-off-by: Rafal Kozik --- doc/guides/rel_notes/release_19_02.rst | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst index 57c595b..15a92d5 100644 --- a/doc/guides/rel_notes/release_19_02.rst +++ b/doc/guides/rel_notes/release_19_02.rst @@ -155,6 +155,25 @@ New Features the intel_pstate kernel driver is now supported, and automatically detected by the library. +* **Release of the ENA PMD v2.0.0** + + * Added Low Latency Queue v2 (LLQv2). This feature reduces the latency + of the packets by pushing the header directly through the PCI to the + device. This allows the NIC to start handle packet right after the doorbell + without waiting for DMA. + * Added independent configuration of HW Tx and Rx ring depths. + * Added support for up to 8k Rx descriptors per ring. + * Added additional doorbell check on Tx, to handle Tx more efficiently for big + bursts of packets. + * Added per queue statistics. + * Added extended statistics using xstats DPDK API. + * The reset routine was aligned with the DPDK API, so now it can be + handled as in other PMDs. + * Fixed out of order (OOO) completion. + * Fixed memory leaks due to port stops and starts in the middle of + traffic. + * Updated documentation and features list of the PMD. + Removed Items ------------- From patchwork Fri Jan 25 08:10:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 50050 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CEDB4CC3; Fri, 25 Jan 2019 09:10:42 +0100 (CET) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 88998316B for ; Fri, 25 Jan 2019 09:10:38 +0100 (CET) Received: by mail-lj1-f193.google.com with SMTP id v1-v6so7643522ljd.0 for ; Fri, 25 Jan 2019 00:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YtNRAFXCgAo7zxbcXVuSuG4kMeAwt6MZeXa/0z8AVDg=; b=huz2SrGkKwuuhjYPMQu6eM4GSLushijiRInsx9x3Dhqkq4FJVY9+XyRAWf16woM6i4 eBqAKBsy1tpCCodykk+DOd2acv4ltOJMSZoV34I5vBVg0bzEYdUUbV/5vDPrwsOjX641 yflMWVwYROqjbeNUYpsSBeYzZbJpo8xtuHY3ETSE8e1UQBh6mSjDnr+etXIWgi8AUSBV rDnZXPpRP9o+enffw32m6hOREtqNcITBlUMFrkgFwBWxhkAnaUUjOhoeBnZJP1oZcb59 rHJD0DVAOXDyBpiqb9VFt1DJN0WPzualhCFRa7Dn+AUPrnK93lDL1h2jp4eVL+u7iF34 EPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YtNRAFXCgAo7zxbcXVuSuG4kMeAwt6MZeXa/0z8AVDg=; b=cxnc+UaVgU716nFgB1KA32LeYzVh9mjE370ybdBq13+tKrVfjD5Esd9/BQhFoNDMz2 g4HiEpnZG+Cwd+dJ/53A2Wc53wzHl18tmkyriyuzAXpoHlPxEw2eDp9OIdXrJlSCicUg 9Fx+8nX2QSiJwsE+eVgFZEy38X0bcWHnArFPVNNzYZX+uf4uHMS5aBNLI9D6sSaUkvlG lfVPGWkLNpaM3iApOGKjmpwLBBbIfV2rbQ6qxTkziPD+ShaHD+HUEoFR0o+q8ZyXF4cw RcEEjEtRM2DuRx5ovwYTvQu2vza1KeSrDTSaNrhPI1RzoOG2rokJKbI2PhCOI6p6EbS0 jkJg== X-Gm-Message-State: AJcUukfyB9wYvkqXchVvC/5cLWQj09eYQk4EPU1O6VJhyWde8bsxbdQW aUs3UFYwFkD7mUgZ+dFFza8NZRAPGEg= X-Google-Smtp-Source: ALg8bN4HfIEUJ3AZnUGszWPLHOXCd28vrlPELJ7BpwdONX5nsiGsgr56GlumlQHz81jhLE9Eijkiig== X-Received: by 2002:a05:651c:14e:: with SMTP id c14mr8326692ljd.20.1548403837996; Fri, 25 Jan 2019 00:10:37 -0800 (PST) Received: from localhost.localdomain ([185.157.12.197]) by smtp.gmail.com with ESMTPSA id m21sm1358664lfl.97.2019.01.25.00.10.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Jan 2019 00:10:37 -0800 (PST) From: Michal Krawczyk To: gtzalik@amazon.com, mw@semihalf.com, matua@amazon.com Cc: rk@semihalf.com, dev@dpdk.org Date: Fri, 25 Jan 2019 09:10:28 +0100 Message-Id: <1548403828-31870-6-git-send-email-mk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1548403828-31870-1-git-send-email-mk@semihalf.com> References: <1548403828-31870-1-git-send-email-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 5/5] doc: add instructions for enabling WC in ENAv2 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik ENAv2 hardware provides Low Latency Queue v2 (LLQv2). It needs kernel PCI driver to support write combining (WC). This patch add information how to use it with igb_uio and vfio-pci drivers. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- doc/guides/nics/ena.rst | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 9f0a650..80da4b6 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -183,10 +183,22 @@ Prerequisites #. Prepare the system as recommended by DPDK suite. This includes environment variables, hugepages configuration, tool-chains and configuration. -#. ENA PMD can operate with ``vfio-pci`` or ``igb_uio`` driver. +#. ENA PMD can operate with ``vfio-pci``(*) or ``igb_uio`` driver. + + (*) ENAv2 hardware supports Low Latency Queue v2 (LLQv2). This feature + reduces the latency of the packets by pushing the header directly through + the PCI to the device, before the DMA is even triggered. For proper work + kernel PCI driver must support write combining (WC). In mainline version of + ``igb_uio`` (in DPDK repo) it must be enabled by loding module with + ``wc_activate=1`` flag (example below). However, mainline's vfio-pci + driver in kernel doesn't have WC support yet (planed to be added). + If vfio-pci used user should be either turn off ENAv2 (to avoid performance + impact) or recompile vfio-pci driver with patch provided in + `amzn-github `_. #. Insert ``vfio-pci`` or ``igb_uio`` kernel module using the command - ``modprobe vfio-pci`` or ``modprobe igb_uio`` respectively. + ``modprobe vfio-pci`` or ``modprobe uio; insmod igb_uio.ko wc_activate=1`` + respectively. #. For ``vfio-pci`` users only: Please make sure that ``IOMMU`` is enabled in your system,