From patchwork Mon Jan 14 15:01:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hyong Youb Kim (hyonkim)" X-Patchwork-Id: 49798 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B50891B296; Mon, 14 Jan 2019 16:01:35 +0100 (CET) Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id B09C41B227; Mon, 14 Jan 2019 16:01:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1011; q=dns/txt; s=iport; t=1547478095; x=1548687695; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=mW72NErNC4uswC6PWsuTVimgaDyDQB8i0c9UBmtDGsY=; b=MMgnEm0ktShsydHMBalQJvxuafL1nYfk2DiYDcyxKahzAyRBo1PgXQar t/q9leAdR3oMCSsdrUp9B9+ssAawFrBa5SkVvd5I6x6YcbE7acGAy+HrF LCYzEHcoesDUsqb16bKmpnqiC/QplfL+VXfLhkiRPnGMKXSpdKG/nmrCx g=; X-IronPort-AV: E=Sophos;i="5.56,478,1539648000"; d="scan'208";a="225214298" Received: from alln-core-12.cisco.com ([173.36.13.134]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 15:01:33 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-12.cisco.com (8.15.2/8.15.2) with ESMTP id x0EF1XdA018012; Mon, 14 Jan 2019 15:01:33 GMT Received: by cisco.com (Postfix, from userid 508933) id 366CC20F2001; Mon, 14 Jan 2019 07:01:33 -0800 (PST) From: Hyong Youb Kim To: Ferruh Yigit Cc: dev@dpdk.org, John Daley , Hyong Youb Kim , stable@dpdk.org Date: Mon, 14 Jan 2019 07:01:21 -0800 Message-Id: <20190114150122.16999-2-hyonkim@cisco.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20190114150122.16999-1-hyonkim@cisco.com> References: <20190114150122.16999-1-hyonkim@cisco.com> X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-core-12.cisco.com Subject: [dpdk-dev] [PATCH 1/2] net/enic: remove useless include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" libgen.h is not used, so do not include it. Fixes: fefed3d1e62c ("enic: new driver") Cc: stable@dpdk.org Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_clsf.c | 2 -- drivers/net/enic/enic_main.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index 9d95201ec..9e9e548c2 100644 --- a/drivers/net/enic/enic_clsf.c +++ b/drivers/net/enic/enic_clsf.c @@ -3,8 +3,6 @@ * Copyright 2007 Nuova Systems, Inc. All rights reserved. */ -#include - #include #include #include diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 621a984a0..2652949a2 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include From patchwork Mon Jan 14 15:01:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hyong Youb Kim (hyonkim)" X-Patchwork-Id: 49799 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 708781B39C; Mon, 14 Jan 2019 16:01:42 +0100 (CET) Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id 50FC71B394; Mon, 14 Jan 2019 16:01:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1132; q=dns/txt; s=iport; t=1547478100; x=1548687700; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=nYSgz2g8RR5YaAxEvfRrjcWSm90XzMkjyQwtmYyKk2A=; b=fo2p7cqhyzzqEu2MfcM/ZIoypZi/p/ru3Uxpt4X5NPh5iQYRe3cEJnNf cpAYFwFyQuJnobSE4itoNWAyVck2/1Zsldd5/9abf0Fgx4ugi0I9Uad4r IFkYoH8EGmII35aT27dii52mPO4tti1n0bI7o9hhrMgLI1V1KLB8XtL6U w=; X-IronPort-AV: E=Sophos;i="5.56,478,1539648000"; d="scan'208";a="508564562" Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 15:01:39 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTP id x0EF1dJg013153; Mon, 14 Jan 2019 15:01:39 GMT Received: by cisco.com (Postfix, from userid 508933) id E0A8420F2001; Mon, 14 Jan 2019 07:01:38 -0800 (PST) From: Hyong Youb Kim To: Ferruh Yigit Cc: dev@dpdk.org, John Daley , Hyong Youb Kim , stable@dpdk.org Date: Mon, 14 Jan 2019 07:01:22 -0800 Message-Id: <20190114150122.16999-3-hyonkim@cisco.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20190114150122.16999-1-hyonkim@cisco.com> References: <20190114150122.16999-1-hyonkim@cisco.com> X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: rcdn-core-12.cisco.com Subject: [dpdk-dev] [PATCH 2/2] net/enic: remove redundant log level check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 8d496995346c ("net/enic: support multicast filtering") Cc: stable@dpdk.org Suggested-by: Ferruh Yigit Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_ethdev.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index fbbec2266..8d14d8ac7 100644 --- a/drivers/net/enic/enic_ethdev.c +++ b/drivers/net/enic/enic_ethdev.c @@ -647,11 +647,10 @@ static int enicpmd_set_mac_addr(struct rte_eth_dev *eth_dev, static void debug_log_add_del_addr(struct ether_addr *addr, bool add) { char mac_str[ETHER_ADDR_FMT_SIZE]; - if (rte_log_get_level(enicpmd_logtype_init) == RTE_LOG_DEBUG) { - ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr); - PMD_INIT_LOG(ERR, " %s address %s\n", - add ? "add" : "remove", mac_str); - } + + ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr); + PMD_INIT_LOG(DEBUG, " %s address %s\n", + add ? "add" : "remove", mac_str); } static int enicpmd_set_mc_addr_list(struct rte_eth_dev *eth_dev,