From patchwork Fri Mar 1 13:13:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugzilla@dpdk.org X-Patchwork-Id: 137675 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 853EE43BCF; Fri, 1 Mar 2024 14:13:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F5544335A; Fri, 1 Mar 2024 14:13:29 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id E50FA4026C for ; Fri, 1 Mar 2024 14:13:27 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id D821543BD1; Fri, 1 Mar 2024 14:13:27 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/examples Bug 1390] examples/l3fwd: in event mode tries to RX for not ready port Date: Fri, 01 Mar 2024 13:13:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: examples X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: konstantin.v.ananyev@yandex.ru X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=1390 Bug ID: 1390 Summary: examples/l3fwd: in event mode tries to RX for not ready port Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: examples Assignee: dev@dpdk.org Reporter: konstantin.v.ananyev@yandex.ru CC: pbhagavatula@marvell.com Target Milestone: --- Running l3fwd in event mode with SW eventdev, service cores can start RX before main thread is finished with PMD installation. Reproducible with latest dpdk main branch. To reproduce: ./dpdk-l3fwd --lcores=49,51 -n 6 -a ca:00.0 -s 0x8000000000000 \ --vdev event_sw0 -- \ -L -P -p 1 --mode eventdev --eventq-sched=ordered \ --rule_ipv4=test/l3fwd_lpm_v4_u1.cfg \ --rule_ipv6=test/l3fwd_lpm_v6_u1.cfg --no-numa At init stage user will most likely see the error message like that: ETHDEV: lcore 51 called rx_pkt_burst for not ready port 0 0: ./dpdk.org/x84_64-default-linuxapp-gcc10-dbg/examples/dpdk-l3fwd (rte_dump_stack+0x1f) [15de723] 1: ./dpdk.org/x84_64-default-linuxapp-gcc10-dbg/examples/dpdk-l3fwd (400000+0x107e167) [147e167] 2: ./dpdk.org/x84_64-default-linuxapp-gcc10-dbg/examples/dpdk-l3fwd (400000+0xf1e5c8) [131e5c8] .... And then all depends how luck/unlucky you are. If there are some actual packet in HW RX queue, then the app will most likely to crash, otherwise it might survive. As error message suggests, the problem is that services are started before main thread finished with NIC setup and initialisation. The suggested fix moves services startup after NIC setup phase. diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 3bf28aec0c..0cfcaf45a6 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -1577,7 +1577,6 @@ main(int argc, char **argv) l3fwd_lkp.main_loop = evt_rsrc->ops.fib_event_loop; else l3fwd_lkp.main_loop = evt_rsrc->ops.lpm_event_loop; - l3fwd_event_service_setup(); } else #endif l3fwd_poll_resource_setup(); @@ -1609,6 +1608,12 @@ main(int argc, char **argv) } } +#ifdef RTE_LIB_EVENTDEV + if (evt_rsrc->enabled) { + l3fwd_event_service_setup(); + } +#endif + printf("\n"); for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {