From patchwork Fri Jun 29 10:24:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41934 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5864E2D13; Fri, 29 Jun 2018 12:24:42 +0200 (CEST) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 2414D1B4CC for ; Fri, 29 Jun 2018 12:24:40 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id l12-v6so6915383lja.1 for ; Fri, 29 Jun 2018 03:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+fL6fuPc8F52ludMma2sKMyIvFsnG1EOxbLEAP6gj/k=; b=foO+W7icu6cAZG0Y6VkWYEkSA3SEQfgMMXgIcPuWYZzYWNw1jRP+ZWvF0N8kJ1IuO5 6dR/4kXkPOn8uOLeLENsq+0PwtzN6l+l2s/SJ8/VejgJUILNo5GRT9QVw8ZEuLcuiD/o eOfcIDtFVgWM6JKSlkJwx9W3M4YmTwNeE8njEdVfmb4+nP74a/jlwcG6ApkfGdMqScC6 Yh4bbn5hb65k/3Nv9KzFXas8+14pYD0R5WVWD2CeloS206NzqQvMCqdPtS0g/quSCQMF o9L2AeRdyD1YcnSYVkVguhCEoXM9a68HFAn2jVkhKG4/aQ8DJhg/Z/IptbUtk/ousTk9 8z/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+fL6fuPc8F52ludMma2sKMyIvFsnG1EOxbLEAP6gj/k=; b=NOsbvVLKEvH0i+m5rZ96cCLmKTQkKng7CdBh6lwSQWkFZ4JeTn2OBF2e/YtiPLaXf2 ihSXO0eFVt/E8/NE0Knd3oMjzJdvxvNPaBe3W+VDLdCdchF6U6CgFEuamzpu3aZpuSw+ Vl6Osdog+sXgONd9HBj+g7Pb2bNbBbi9H0shhAHoFECgTp1SwbOfYa5t4skkWXBaM94g 0h9LtUM0f7xTYuXacAhXBN5HLnG613IJ66z8N/3y0tnuBHcQvvUK9FjD6bYBbIkV/k6F Z35lTtnwdUalUQUJN3N+l2MHB3MZF9cAqz1vupPy2wFtfOHWsUFsMY4n67CrfOpZdnEv KN/w== X-Gm-Message-State: APt69E3MN85nLgQVv0R60AxVzc9GO1x04YxclYNJW5wMJW4j22X1YnvW ue0G6E6JCaq8iaScMJ0OrIHJAvoerCIWag== X-Google-Smtp-Source: AAOMgpd+C5jkRdEJugE/FyZ1cJlWVJttCdyPrKctS4Fgz5s/rcSmf2ou21DMyDu5+9bpOMqKwZWtyw== X-Received: by 2002:a2e:259:: with SMTP id 86-v6mr849014ljc.107.1530267879370; Fri, 29 Jun 2018 03:24:39 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d79-v6sm745514ljd.50.2018.06.29.03.24.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 03:24:38 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Rafal Kozik Date: Fri, 29 Jun 2018 12:24:30 +0200 Message-Id: <1530267873-7236-2-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530267873-7236-1-git-send-email-rk@semihalf.com> References: <1530191753-18689-2-git-send-email-rk@semihalf.com> <1530267873-7236-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v3 1/4] igb_uio: add wc option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Write combining (WC) increases NIC performance by making better utilization of PCI bus, but cannot be use by all PMDs. To get internal_addr memory need to be mapped. But as memory could not be mapped twice: with and without WC, it should be skipped for WC. [1] To do not spoil other drivers that potentially could use internal_addr, parameter wc_activate adds possibility to skip it for those PMDs, that do not use it. [1] https://www.kernel.org/doc/ols/2008/ols2008v2-pages-135-144.pdf section 5.3 and 5.4 Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- kernel/linux/igb_uio/igb_uio.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c index b3233f1..3382fb1 100644 --- a/kernel/linux/igb_uio/igb_uio.c +++ b/kernel/linux/igb_uio/igb_uio.c @@ -30,6 +30,7 @@ struct rte_uio_pci_dev { int refcnt; }; +static int wc_activate; static char *intr_mode; static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX; /* sriov sysfs */ @@ -375,9 +376,13 @@ igbuio_pci_setup_iomem(struct pci_dev *dev, struct uio_info *info, len = pci_resource_len(dev, pci_bar); if (addr == 0 || len == 0) return -1; - internal_addr = ioremap(addr, len); - if (internal_addr == NULL) - return -1; + if (wc_activate == 0) { + internal_addr = ioremap(addr, len); + if (internal_addr == NULL) + return -1; + } else { + internal_addr = NULL; + } info->mem[n].name = name; info->mem[n].addr = addr; info->mem[n].internal_addr = internal_addr; @@ -650,6 +655,12 @@ MODULE_PARM_DESC(intr_mode, " " RTE_INTR_MODE_LEGACY_NAME " Use Legacy interrupt\n" "\n"); +module_param(wc_activate, int, 0); +MODULE_PARM_DESC(wc_activate, +"Activate support for write combining (WC) (default=0)\n" +" 0 - disable\n" +" other - enable\n"); + MODULE_DESCRIPTION("UIO driver for Intel IGB PCI cards"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Intel Corporation"); From patchwork Fri Jun 29 10:24:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41935 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7D581B4DF; Fri, 29 Jun 2018 12:24:43 +0200 (CEST) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id B14D11B4D1 for ; Fri, 29 Jun 2018 12:24:41 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id v15-v6so6909139ljk.5 for ; Fri, 29 Jun 2018 03:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x5Giy6T7jTc0xkzs6uZkO8Y34Kp/dn62PInFN4x016Y=; b=BhS0tulcbaEq8mm7jr2H7A6G/CSJ3UZa410Dp49rdDKEsc4P0NSXSZGTcxHpp+YteW KMWRIQRO9CNumYbV4d8B5CP3DsgxJipOnAsTMrfj1PWpoISlCGovn83ow7W7JeePCGZX QEr+5ZrwXGDoBuxIbQo63/Dx9YV5+zaFo2RyZtUi8HCEjtTT8NKCRUiFJ7hb5QvaYMhK nieOalxQHuhY+Q58gZwjil205OXX3Av8ivrfTrUAozM4KiugU5eGUxuZx0r0sfsnruMU 9j1PDvG7RQStPPYrjr+GxO708bbJfdvPvii/1gpe5TZXUPb7xVNRY1hWsqUbp7EJURnH Drzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x5Giy6T7jTc0xkzs6uZkO8Y34Kp/dn62PInFN4x016Y=; b=ZzkTAWyIcKmvzpDWRTtFSOtgqErLtfpOhhzjtrBOh5IByJekQSpnP4Oe+MMMDFJeHf gTju9LQyCDjoeHiMQaNw3mS0jOVlvVTNbc7e/SWPqJ+jbJ/46L8Xva+YA9yTKIUAZf+I 4qAbnLr5en3Q1Dv8sNBGbo+4bgWlHDdKN39qFN4PuUIpwNeg4OtyIqWEmDzZtZNGYNe6 YBCxM+MDPhJTHZbYH4p95gRK5gF5GxL0Di1sAKxQw6ZH2CT+WkIqX0tcZc4V16fGlDoJ thAycbos8dnb7Ur25ij/Zh798RIXpabekQXm0/Zf1y9qxZ3G4IZ+Pbwn4c9ABRxJ6V4d MgSw== X-Gm-Message-State: APt69E1t88RxVCkUc8LPK6WvTeubTOoH+4NT95JwCF5s/xuwMICTnkYE fWEffz0eFLZ6uasUERtDrNvsPMjG/wnhkg== X-Google-Smtp-Source: AAOMgpcJyOuXIbBKUi3BaMOBDy4iO65oAfXjteG59dORpkYM7vl3mIQzJsq2A60Y4tLwblrlMZ2X2A== X-Received: by 2002:a2e:1d50:: with SMTP id d77-v6mr10068268ljd.104.1530267881264; Fri, 29 Jun 2018 03:24:41 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d79-v6sm745514ljd.50.2018.06.29.03.24.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 03:24:40 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Rafal Kozik Date: Fri, 29 Jun 2018 12:24:31 +0200 Message-Id: <1530267873-7236-3-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530267873-7236-1-git-send-email-rk@semihalf.com> References: <1530191753-18689-2-git-send-email-rk@semihalf.com> <1530267873-7236-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v3 2/4] bus/pci: reference driver structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add pointer to driver structure before calling rte_pci_map_device. It allows to use driver flags for adjusting configuration. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/bus/pci/pci_common.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index d8151b0..8f5d77f 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -158,17 +158,24 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, RTE_LOG(INFO, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id, dev->id.device_id, dr->driver.name); + /* + * reference driver structure + * This need to be before rte_pci_map_device(), as it enable to use + * driver flags for adjusting configuration. + */ + dev->driver = dr; + dev->device.driver = &dr->driver; + if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) { /* map resources for devices that use igb_uio */ ret = rte_pci_map_device(dev); - if (ret != 0) + if (ret != 0) { + dev->driver = NULL; + dev->device.driver = NULL; return ret; + } } - /* reference driver structure */ - dev->driver = dr; - dev->device.driver = &dr->driver; - /* call the driver probe() function */ ret = dr->probe(dr, dev); if (ret) { From patchwork Fri Jun 29 10:24:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41936 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10EB81B4E9; Fri, 29 Jun 2018 12:24:47 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id E39C51B4DE for ; Fri, 29 Jun 2018 12:24:43 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id n96-v6so6437946lfi.1 for ; Fri, 29 Jun 2018 03:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lKm5iTnEQ6Sk/dL/jb/9lbPgyy2fSSjwpCqErLvTbqQ=; b=GIz3NuDLma9dfgJY0byVA81lygCG3Mmxl+ccCnbI+GSgBH1DjiWcK5Vz4Xm8+Fe17y Pw9AyVsARtTKZIA8rn0uMB/v2qn/uQ9p/0JbOth8iVOL2cAmrrCFhpddQg5P/gB2w/UQ 8cPQgKwtFOhmC8LdUwy7XyqhnlbkOLbwz58jC7yZk1qzv5zXOovboU5S0hFyd1Tc+WSv btNsWrtLBP0Kb0Leg8s1QgF/mJe72cv9+JOfyt05G+swS7OJEwPImLMcg9JBoGPr/VQ/ uuY7IqfdmRndy3mZ6nkiQj0tzGlLD5qseNGvOPqDIDlTIkomEPvdJ/iR/Av0UCodTsyY ZxMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lKm5iTnEQ6Sk/dL/jb/9lbPgyy2fSSjwpCqErLvTbqQ=; b=JSSxU0xNX4+7uwE018k8hRcgXuRVU2ET76qyaCvi/7fFJ0VYroj8rTUTAData4FAOu 0OoE2dhVYkXL7xBYuI9RbfGVLyWaMz2FmspDJ2WQsKGvjeuU8dxl6nhtG6FR48P4hoqz QSBNrsJr6jJGZUgnnMKG+3x8LFvUW1SKC/C3wkwnO6RuHTyvM0X5BMsz6igLDlusvmAs nwuFrG2LIJDCNEP049mtMQbAPi8eI8r0ubfyOnYMpxZ1QLkN0/XlAEIProM8MS7+xFMW 51+Y6bpO7nltIAOXK4MxI35a4RLTv0h92iKN7uerkif6lU5R4eSO8Oz0G8w6cSeXvkdQ RCnA== X-Gm-Message-State: APt69E0b0ibH60FixmwBp1feuMkuBMo8++dUjKyMQcHKD7BxwyLeot6m L5FhePDcHSP1ys5qwysB6rbhFR03hN8fvQ== X-Google-Smtp-Source: AAOMgpcd0qLtEuPn8rNol5RoQ2/gl/KqbiinPVk3V2+CdG8OacR5PAblRo537VL1aspvb/JYediSrQ== X-Received: by 2002:a19:c64c:: with SMTP id w73-v6mr8952178lff.2.1530267883151; Fri, 29 Jun 2018 03:24:43 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d79-v6sm745514ljd.50.2018.06.29.03.24.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 03:24:42 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Rafal Kozik Date: Fri, 29 Jun 2018 12:24:32 +0200 Message-Id: <1530267873-7236-4-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530267873-7236-1-git-send-email-rk@semihalf.com> References: <1530191753-18689-2-git-send-email-rk@semihalf.com> <1530267873-7236-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v3 3/4] eal: enable WC during resources mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Write combining (WC) increases NIC performance by making better utilization of PCI bus, but cannot be used by all PMDs. It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in drivers flags. For proper work also igb_uio driver must be loaded with wc_activate set to 1. When mapping PCI resources, firstly try to us WC. If it is not supported it will fallback to normal mode. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_uio.c | 44 ++++++++++++++++++++++++++++++----------- drivers/bus/pci/rte_bus_pci.h | 2 ++ 2 files changed, 34 insertions(+), 12 deletions(-) diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c index d423e4b..fb02f0a 100644 --- a/drivers/bus/pci/linux/pci_uio.c +++ b/drivers/bus/pci/linux/pci_uio.c @@ -282,22 +282,19 @@ int pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, struct mapped_pci_resource *uio_res, int map_idx) { - int fd; + int fd = -1; char devname[PATH_MAX]; void *mapaddr; struct rte_pci_addr *loc; struct pci_map *maps; + int wc_activate = 0; + + if (dev->driver != NULL) + wc_activate = dev->driver->drv_flags & RTE_PCI_DRV_WC_ACTIVATE; loc = &dev->addr; maps = uio_res->maps; - /* update devname for mmap */ - snprintf(devname, sizeof(devname), - "%s/" PCI_PRI_FMT "/resource%d", - rte_pci_get_sysfs_path(), - loc->domain, loc->bus, loc->devid, - loc->function, res_idx); - /* allocate memory to keep path */ maps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0); if (maps[map_idx].path == NULL) { @@ -309,11 +306,34 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, /* * open resource file, to mmap it */ - fd = open(devname, O_RDWR); - if (fd < 0) { - RTE_LOG(ERR, EAL, "Cannot open %s: %s\n", + if (wc_activate) { + /* update devname for mmap */ + snprintf(devname, sizeof(devname), + "%s/" PCI_PRI_FMT "/resource%d_wc", + rte_pci_get_sysfs_path(), + loc->domain, loc->bus, loc->devid, + loc->function, res_idx); + + fd = open(devname, O_RDWR); + if (fd >= 0) + RTE_LOG(INFO, EAL, "%s mapped\n", devname); + } + + if (!wc_activate || fd < 0) { + snprintf(devname, sizeof(devname), + "%s/" PCI_PRI_FMT "/resource%d", + rte_pci_get_sysfs_path(), + loc->domain, loc->bus, loc->devid, + loc->function, res_idx); + + /* then try to map resource file */ + fd = open(devname, O_RDWR); + if (fd < 0) { + RTE_LOG(ERR, EAL, "Cannot open %s: %s\n", devname, strerror(errno)); - goto error; + goto error; + } + RTE_LOG(INFO, EAL, "%s mapped\n", devname); } /* try mapping somewhere close to the end of hugepages */ diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h index 458e6d0..828acc5 100644 --- a/drivers/bus/pci/rte_bus_pci.h +++ b/drivers/bus/pci/rte_bus_pci.h @@ -135,6 +135,8 @@ struct rte_pci_bus { /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */ #define RTE_PCI_DRV_NEED_MAPPING 0x0001 +/** Device needs PCI BAR mapping with enabled write combining (wc) */ +#define RTE_PCI_DRV_WC_ACTIVATE 0x0002 /** Device driver supports link state interrupt */ #define RTE_PCI_DRV_INTR_LSC 0x0008 /** Device driver supports device removal interrupt */ From patchwork Fri Jun 29 10:24:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 41937 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB8611B4F0; Fri, 29 Jun 2018 12:24:48 +0200 (CEST) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id D7F6E1B4DE for ; Fri, 29 Jun 2018 12:24:45 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id l16-v6so4143517lfc.13 for ; Fri, 29 Jun 2018 03:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f6yWG44YI6g9KqH5tp/Dp20sb4gCLsQaNH2i9MGPUmQ=; b=MNcxy2No8p407pe8rCDyzm98Z1gJZGrITLF9l2KskORRQdDgI/jPK8b5wTaCR6DAMw 5WZ79ph0SWPBhkn8+WiYzQagGldCmojcoO86ZnnW7e7vQKUDEmQVTN1xHwKsAqvpbFzY 7rG36iB31kiwjgRGpCy/ZO/kHqTWC5y8hWYlh/LTMoIevvWOkrm/YNaGAcO7AXZufidB gu5UcWiO/Q6LOTchWZhS5w/Nyj8EMSpmhiqZ1EvVvrDpAEA0c80eH+hvodY0omZDXLO2 bcgjxlAIRtcoOGMkPGcONy8g8i4yvRa2HVyPTaInA9zuZqXMSnEAPpQymVGmDohOYF7j t5Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f6yWG44YI6g9KqH5tp/Dp20sb4gCLsQaNH2i9MGPUmQ=; b=YTL7gnVR0sybINx2s76g6P80NrE2DNYTqCbKsHPDbOdQOkB8t946LFJ3Gx1jDaolse 1iGZDPRJgrmPMldaRQmoLH+cesP6OIOlfpM5/FXf+FWVi0WrlQL+DkUihGpCNB5cyWIU Wb6ylYTsqmJ0JyiTvlgO7lTpmoqAp+k36vih4RYH6Fi9ooyls2t3JW/m39oMQ6ZvrQH1 b/8ahH/QBdZTqfILEqhUw1aJTH+zjI+2JSLF5nScTsm3uF/GVwqbExWJtWx4F5qnfNlq OD2m4FWjU/JPKRHNThqq7xxqt/CW096UVWyRIw576xzUsWrwBGMNkvJfjaunojiWt1JU tfMQ== X-Gm-Message-State: APt69E2fln/0rQ3G9SIpryaCDwGi68Nt8gAQhgaWunodTM/yvLxu5uC7 zGUjogxacv3YKSus+bzwHzXuWobIgGdsjA== X-Google-Smtp-Source: AAOMgpdjYIQUYGrrxG35hczBXHiEmAl1YLUam0r6ebKzn1VaGKd6VmCZ7as2rRpdodWLjh7oLLYHmg== X-Received: by 2002:a19:29c7:: with SMTP id p190-v6mr9846218lfp.146.1530267885386; Fri, 29 Jun 2018 03:24:45 -0700 (PDT) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d79-v6sm745514ljd.50.2018.06.29.03.24.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jun 2018 03:24:44 -0700 (PDT) From: Rafal Kozik To: dev@dpdk.org Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, thomas@monjalon.net, ferruh.yigit@intel.com, Rafal Kozik Date: Fri, 29 Jun 2018 12:24:33 +0200 Message-Id: <1530267873-7236-5-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530267873-7236-1-git-send-email-rk@semihalf.com> References: <1530191753-18689-2-git-send-email-rk@semihalf.com> <1530267873-7236-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH v3 4/4] net/ena: enable WC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Write combining (WC) increases NIC performance by making better utilization of PCI bus. ENA PMD may make usage of this feature. To enable it load igb_uio driver with wc_activate set to 1. Signed-off-by: Rafal Kozik Acked-by: Bruce Richardson --- drivers/net/ena/ena_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 9ae73e3..1870edf 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2210,7 +2210,8 @@ static int eth_ena_pci_remove(struct rte_pci_device *pci_dev) static struct rte_pci_driver rte_ena_pmd = { .id_table = pci_id_ena_map, - .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC, + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC | + RTE_PCI_DRV_WC_ACTIVATE, .probe = eth_ena_pci_probe, .remove = eth_ena_pci_remove, };