From patchwork Wed Feb 7 17:04:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satha Koteswara Rao Kottidi X-Patchwork-Id: 136498 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8044F43AA1; Wed, 7 Feb 2024 18:05:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70E4F40295; Wed, 7 Feb 2024 18:05:19 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DCD314026E for ; Wed, 7 Feb 2024 18:05:17 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 417GO7po021722; Wed, 7 Feb 2024 09:05:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; s=pfpt0220; bh=MrBa3s1UYKPtBtZmPnakl opabd5SfQUBnikv0fqA1N4=; b=Vfk0BVIYsDEVC5YGAmAo1aNHKxVmtXt1Pl7Pv Kts/ENpkR0D0hgMXyWXPbYWAIC/Jzm1F36oaItpaULl963hbZQeICVe59MNTYrY0 EJl0d8Jpvg4ZaWex4LcyOaX7AXIPeHuWAlKqrLsp6unCsoFFouNTVdEP6sST4Off q/TCsmsEeX5dktI0+BZz6FgUtXKrsZSoAknWJN7bLqTr3Lgs1tsewlMF+bT98QZB ICXzyjtwhWQ+B/++SL7F2qY68fy7UmHih53wDwlE0U+cyAClUHaL7GKt/H2x+nSw 3OGtVvBiSwZN4tU6L9i8BjX5nC/buZLAGdVz0bsLptx2PB4DA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3w38u88ehb-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 07 Feb 2024 09:05:15 -0800 (PST) Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 7 Feb 2024 09:05:11 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 7 Feb 2024 09:05:11 -0800 Received: from Cavium-PET630-BM22.localdomain (unknown [10.28.34.26]) by maili.marvell.com (Postfix) with ESMTP id 4A7063F7052; Wed, 7 Feb 2024 09:05:09 -0800 (PST) From: To: Aman Singh , Yuying Zhang CC: , , , Satha Rao Subject: [PATCH v3] app/testpmd: command to get descriptor used count Date: Wed, 7 Feb 2024 12:04:59 -0500 Message-ID: <1707325500-10188-1-git-send-email-skoteshwar@marvell.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1706795562-7099-1-git-send-email-skoteshwar@marvell.com> References: <1706795562-7099-1-git-send-email-skoteshwar@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 7XuKV1_UcF-U3GgEzGZ3rdjJejeXU0JO X-Proofpoint-GUID: 7XuKV1_UcF-U3GgEzGZ3rdjJejeXU0JO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-07_08,2024-02-07_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Satha Rao Existing Rx desc used count command extended to get Tx queue used count. testpmd> show port 0 rxq 0 desc used count testpmd> show port 0 txq 0 desc used count Signed-off-by: Satha Rao Reviewed-by: Ferruh Yigit --- Depends-on: series-30833 ("ethdev: support Tx queue used count") v2: extended rx_queue_desc_used_count command to support Tx updated testpmd_app_ug with new command v3: Updated help string, log message as per review comments app/test-pmd/cmdline.c | 116 ++++++++++++++++------------ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 10 +-- 2 files changed, 70 insertions(+), 56 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f704319..d8ea2b7 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -237,9 +237,8 @@ static void cmd_help_long_parsed(void *parsed_result, "show port (port_id) rxq|txq (queue_id) desc (desc_id) status" " Show status of rx|tx descriptor.\n\n" - "show port (port_id) rxq (queue_id) desc used count\n" - " Show current number of filled receive" - " packet descriptors.\n\n" + "show port (port_id) rxq|txq (queue_id) desc used count\n" + " Show current number of used descriptor count for rx|tx.\n\n" "show port (port_id) macs|mcast_macs" " Display list of mac addresses added to port.\n\n" @@ -12745,11 +12744,11 @@ struct cmd_show_rx_tx_desc_status_result { }, }; -/* *** display rx queue desc used count *** */ -struct cmd_show_rx_queue_desc_used_count_result { +/* *** display rx/tx queue descriptor used count *** */ +struct cmd_show_rx_tx_queue_desc_used_count_result { cmdline_fixed_string_t cmd_show; cmdline_fixed_string_t cmd_port; - cmdline_fixed_string_t cmd_rxq; + cmdline_fixed_string_t cmd_dir; cmdline_fixed_string_t cmd_desc; cmdline_fixed_string_t cmd_used; cmdline_fixed_string_t cmd_count; @@ -12758,73 +12757,88 @@ struct cmd_show_rx_queue_desc_used_count_result { }; static void -cmd_show_rx_queue_desc_used_count_parsed(void *parsed_result, - __rte_unused struct cmdline *cl, - __rte_unused void *data) +cmd_show_rx_tx_queue_desc_used_count_parsed(void *parsed_result, __rte_unused struct cmdline *cl, + __rte_unused void *data) { - struct cmd_show_rx_queue_desc_used_count_result *res = parsed_result; + struct cmd_show_rx_tx_queue_desc_used_count_result *res = parsed_result; int rc; - if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) { - fprintf(stderr, - "Invalid input: port id = %d, queue id = %d\n", - res->cmd_pid, res->cmd_qid); - return; - } + if (!strcmp(res->cmd_dir, "rxq")) { + if (rte_eth_rx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) { + fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n", + res->cmd_pid, res->cmd_qid); + return; + } - rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid); - if (rc < 0) { - fprintf(stderr, "Invalid queueid = %d\n", res->cmd_qid); - return; + rc = rte_eth_rx_queue_count(res->cmd_pid, res->cmd_qid); + if (rc < 0) { + fprintf(stderr, "Rx queue count get failed rc=%d queue_id=%d\n", rc, + res->cmd_qid); + return; + } + printf("RxQ %d used desc count = %d\n", res->cmd_qid, rc); + } else if (!strcmp(res->cmd_dir, "txq")) { + if (rte_eth_tx_queue_is_valid(res->cmd_pid, res->cmd_qid) != 0) { + fprintf(stderr, "Invalid input: port id = %d, queue id = %d\n", + res->cmd_pid, res->cmd_qid); + return; + } + + rc = rte_eth_tx_queue_count(res->cmd_pid, res->cmd_qid); + if (rc < 0) { + fprintf(stderr, "Tx queue count get failed rc=%d queue_id=%d\n", rc, + res->cmd_qid); + return; + } + printf("TxQ %d used desc count = %d\n", res->cmd_qid, rc); } - printf("Used desc count = %d\n", rc); } -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_show = +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_show = TOKEN_STRING_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, + (struct cmd_show_rx_tx_queue_desc_used_count_result, cmd_show, "show"); -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_port = +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_port = TOKEN_STRING_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, + (struct cmd_show_rx_tx_queue_desc_used_count_result, cmd_port, "port"); -static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_pid = +static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_pid = TOKEN_NUM_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, + (struct cmd_show_rx_tx_queue_desc_used_count_result, cmd_pid, RTE_UINT16); -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_rxq = +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_dir = TOKEN_STRING_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, - cmd_rxq, "rxq"); -static cmdline_parse_token_num_t cmd_show_rx_queue_desc_used_count_qid = + (struct cmd_show_rx_tx_queue_desc_used_count_result, + cmd_dir, "rxq#txq"); +static cmdline_parse_token_num_t cmd_show_rx_tx_queue_desc_used_count_qid = TOKEN_NUM_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, + (struct cmd_show_rx_tx_queue_desc_used_count_result, cmd_qid, RTE_UINT16); -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_desc = +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_desc = TOKEN_STRING_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, - cmd_count, "desc"); -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_used = + (struct cmd_show_rx_tx_queue_desc_used_count_result, + cmd_desc, "desc"); +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_used = TOKEN_STRING_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, + (struct cmd_show_rx_tx_queue_desc_used_count_result, cmd_count, "used"); -static cmdline_parse_token_string_t cmd_show_rx_queue_desc_used_count_count = +static cmdline_parse_token_string_t cmd_show_rx_tx_queue_desc_used_count_count = TOKEN_STRING_INITIALIZER - (struct cmd_show_rx_queue_desc_used_count_result, + (struct cmd_show_rx_tx_queue_desc_used_count_result, cmd_count, "count"); -static cmdline_parse_inst_t cmd_show_rx_queue_desc_used_count = { - .f = cmd_show_rx_queue_desc_used_count_parsed, +static cmdline_parse_inst_t cmd_show_rx_tx_queue_desc_used_count = { + .f = cmd_show_rx_tx_queue_desc_used_count_parsed, .data = NULL, - .help_str = "show port rxq desc used count", + .help_str = "show port rxq|txq desc used count", .tokens = { - (void *)&cmd_show_rx_queue_desc_used_count_show, - (void *)&cmd_show_rx_queue_desc_used_count_port, - (void *)&cmd_show_rx_queue_desc_used_count_pid, - (void *)&cmd_show_rx_queue_desc_used_count_rxq, - (void *)&cmd_show_rx_queue_desc_used_count_qid, - (void *)&cmd_show_rx_queue_desc_used_count_desc, - (void *)&cmd_show_rx_queue_desc_used_count_used, - (void *)&cmd_show_rx_queue_desc_used_count_count, + (void *)&cmd_show_rx_tx_queue_desc_used_count_show, + (void *)&cmd_show_rx_tx_queue_desc_used_count_port, + (void *)&cmd_show_rx_tx_queue_desc_used_count_pid, + (void *)&cmd_show_rx_tx_queue_desc_used_count_dir, + (void *)&cmd_show_rx_tx_queue_desc_used_count_qid, + (void *)&cmd_show_rx_tx_queue_desc_used_count_desc, + (void *)&cmd_show_rx_tx_queue_desc_used_count_used, + (void *)&cmd_show_rx_tx_queue_desc_used_count_count, NULL, }, }; @@ -13345,7 +13359,7 @@ struct cmd_config_tx_affinity_map { (cmdline_parse_inst_t *)&cmd_config_tx_metadata_specific, (cmdline_parse_inst_t *)&cmd_show_tx_metadata, (cmdline_parse_inst_t *)&cmd_show_rx_tx_desc_status, - (cmdline_parse_inst_t *)&cmd_show_rx_queue_desc_used_count, + (cmdline_parse_inst_t *)&cmd_show_rx_tx_queue_desc_used_count, (cmdline_parse_inst_t *)&cmd_set_raw, (cmdline_parse_inst_t *)&cmd_show_set_raw, (cmdline_parse_inst_t *)&cmd_show_set_raw_all, diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 53923ad..468f70b 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -264,13 +264,13 @@ Display information for a given port's RX/TX descriptor status:: testpmd> show port (port_id) (rxq|txq) (queue_id) desc (desc_id) status -show rxq desc used count -~~~~~~~~~~~~~~~~~~~~~~~~ +show desc used count(rxq|txq) +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Display the number of receive packet descriptors currently filled by hardware -and ready to be processed by the driver on a given RX queue:: +Display the number of packet descriptors currently used by hardware for a given +port's RX/TX queue:: - testpmd> show port (port_id) rxq (queue_id) desc used count + testpmd> show port (port_id) (rxq|txq) (queue_id) desc used count show config ~~~~~~~~~~~