From patchwork Thu Nov 9 07:33:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 134005 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31CB9432E1; Thu, 9 Nov 2023 08:33:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 113564021E; Thu, 9 Nov 2023 08:33:44 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 362CD4013F for ; Thu, 9 Nov 2023 08:33:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAk0yPRYbykF3aNvQJD9UzBTo2rHIDLK/cwf8JnxwK4gQmE3GXpXH4fzSQH+UaYtL/XAAQP/LR0KxfpUUik6uaPgi6/dN/8nXGIYKNvb9SKRbBiSAsdXr5Pmq/oJb0q6kVzCKfbW5+dHNj0Q0pnZjZOKOcsbiqORSQLXE0rF07aNNaWD8GtCNyV09puM2KuL7fY4mTt/MULrbfYGLDTXdqiGSIg+M00fO0lgofcKBKPanMnluIsHIUpJzZWCr+p+cOPQIpvsgCUX3YnouK5/Ti0Xm02mi9chS2TAUJjosh+aaKAUj4IsHsGvDsYgHMcL29Twt7AofawB9IQrDtuv7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eE93Vgc4khDyjBGh/e8nCtFA53553mPjDmbTZaOVot0=; b=b2lDpBU6q4C7iSQMWR8uQKeCSH3Fd+RElsobT+8Oz476rxNIzzJHtMIUDpZapV46tXAfDTWAiRavmlKG4AzjBlafQYbMvpqHKYtZGqOStbcK0iGtj9HmnEvAqAPCZ7/77fpSVktHDKthlOBB9HAUpRGrtnnXaGGchuqPKbCakWXWBPyhTbhARRggWlWuAL+60vK2pAyekT+CcDIZhvNVno/GaFBP+eO3G69aV719BSxAdYeUrTE1DdsF10IuWzDyORpELfC8QVxUPUVr5MB4pzCeW7QcE56SXR+Y+bI/HeFzYPUxMitOoOpHvvPp9r6LYdHyQNImbRXjfyn7+ICPlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eE93Vgc4khDyjBGh/e8nCtFA53553mPjDmbTZaOVot0=; b=oZrLYeslaEa0qcxKKv1CBnP+0/8dKs2si3k7fjGTrrY+zzz/fwCwrbxKFKg+C0FzY6bvQArlVfXVOHLs+Jd4Kr9TVpK4Okh1SjWDkzLYTD+wuJWvLVOJrBhWwYA4aHQRwS79HelDLhopfIUS2c2s35qQKuhxXM1lyGEiuIFWGNVxFm5M3Hifb8OcdmJ9lFCJFaT3eZMd42VvAECgnn71z9KF819pARUmFA3fT2PGaKUPhfKoPP5Rk8ykVlYLfyUNmdBUPf6z+VwlggNGsZQw3FhbFbDdlR2Igss9M1TJDR3acB5wNVXF/fkO+++VFkQeA4e+CwQmCwnSbjlY+lQT1g== Received: from SA1P222CA0053.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2d0::27) by CY8PR12MB7313.namprd12.prod.outlook.com (2603:10b6:930:53::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Thu, 9 Nov 2023 07:33:41 +0000 Received: from SA2PEPF000015C8.namprd03.prod.outlook.com (2603:10b6:806:2d0:cafe::34) by SA1P222CA0053.outlook.office365.com (2603:10b6:806:2d0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19 via Frontend Transport; Thu, 9 Nov 2023 07:33:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015C8.mail.protection.outlook.com (10.167.241.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.16 via Frontend Transport; Thu, 9 Nov 2023 07:33:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 8 Nov 2023 23:33:34 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 8 Nov 2023 23:33:32 -0800 From: Suanming Mou To: Matan Azrad CC: , Subject: [PATCH] crypto/mlx5: fix crypto dev leak Date: Thu, 9 Nov 2023 15:33:17 +0800 Message-ID: <20231109073317.1311513-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C8:EE_|CY8PR12MB7313:EE_ X-MS-Office365-Filtering-Correlation-Id: bd4ed95f-fe9b-421b-9b1c-08dbe0f6322c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bDhRR5nDPNTP3ShAHkxWTY+fHkg1Zb9rEdFvae/82eNky/ZyjGReEjNUdSzN98DXRTF8drUWj/CRlxL0Ks9Ndm/c3R790QSJxpMpvXhTHDRgJvLywjNwcLZ3pjhX2nN6E1Uve6kxwEfgFZxo97IfAhQbDFjUVQbfiX96uih9sKyQ5Z9CqlEK3ayeuN4XuHc1S5/UTnVgLxASw+xFUxZ3jUjdUcTPK3BYX9Mx89xF5EOZ18k6Wa9lolmqsbPee+Rkel1Cnw4hMy2QWeenBmDXILmSodwSh9W6PJxTcMWRUv+NeA7yC+g6nnznG2Ak/49vC4WIU2HYwiY4ozWRiNZ7lHGsKgDQwxie3EcCzvmg/HgK+Ii2VJeq58Uk/GQycOw/u3J6qnbPJEJ8jZxGX2mJzZrTizjEycRTGxwUo3+LFTKPrrUldB7/LElm+c1CkmvZStZP8DBG/A+VUtUM0hB+Q3dgtPWuCf7HN4lCg9SahLW7sdeJTUWjmnno0IkQChLQB9tUjoe/968d66z/x1iiYsD+i2gKVSG/jrIarwhkVKDHNUgqL0xuPbZQFG7pjwSbbdFBBF65oflP1nHKnIlPbEpgfY1n1YiOWvcH72PBRw4wZflMBRLcQqWZU4z5J/5yHca2/+bDVKwBpimTMJwa3UgLIg+LvCaLMV/PszEXL9duOwflo7iWcGGFItjGrsrwYM/O75r5spW/+CGEAvysz+yjfDmAMdOYbwgdIF+/EFjmNidW+rOa+Yl6f/xOPQ1g X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(39860400002)(396003)(136003)(376002)(230922051799003)(82310400011)(1800799009)(451199024)(64100799003)(186009)(46966006)(36840700001)(40470700004)(1076003)(70586007)(70206006)(6286002)(107886003)(2616005)(26005)(336012)(426003)(478600001)(7696005)(40480700001)(8936002)(55016003)(4326008)(6862004)(8676002)(316002)(37006003)(54906003)(6636002)(47076005)(6666004)(16526019)(5660300002)(36860700001)(40460700003)(41300700001)(86362001)(82740400003)(7636003)(356005)(2906002)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2023 07:33:41.0011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd4ed95f-fe9b-421b-9b1c-08dbe0f6322c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7313 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For the case crypto initialize failed, the allocated crypto dev should be destroyed, otherwise the dev leaked. Current PMD returns directly instead of releasing the dev. This commit fixes the crypto dev leak when initialize failed. Fixes: a27f6a2e1f30 ("crypto/mlx5: split AES-XTS") Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 081e96ad4d..4bac723c8b 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -383,12 +383,14 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev, if (devarg_prms.is_aes_gcm) { ret = mlx5_crypto_gcm_init(priv); if (ret) { + rte_cryptodev_pmd_destroy(priv->crypto_dev); DRV_LOG(ERR, "Failed to init AES-GCM crypto."); return -ENOTSUP; } } else { ret = mlx5_crypto_xts_init(priv); if (ret) { + rte_cryptodev_pmd_destroy(priv->crypto_dev); DRV_LOG(ERR, "Failed to init AES-XTS crypto."); return -ENOTSUP; }