From patchwork Tue Sep 5 16:39:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 131180 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28F8D424F4; Tue, 5 Sep 2023 18:39:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F54C427DB; Tue, 5 Sep 2023 18:39:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A84AB4161A for ; Tue, 5 Sep 2023 18:39:29 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 385DdcLS004704 for ; Tue, 5 Sep 2023 09:39:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=TNRF+AyMhp+C96GHIdnsTHERZ9GRiSmDGoeUWUpb2Jw=; b=AMuub90ahDyc6P7E54nLGfBrudS6s6bmsq+2VtT/DA55fgEpYNBUiq0+Fmc62Hr4tpxG Al+r3wUqiaCiD635FV5mnaheZ7HZJ1K/8pceOF5+0UEevmYQWrxtILezcnpt1RILtgaa njJ7kzIG82YQVDImd3W1dl4xgO4g2J0YKL0GVJciNK/uiucl9qxwBoA0seWfI/yGy/QJ EvZmq/ePzIGh54TJThAZrVTo34nGpvdd/b6j970OSgzoJsSwr5VxNnhl/Q48eL9RbulR ALIK8fagmRmuzhF4uzxVtncFKN7MiUduEn3OjvOyNwrQ4DDFzUo//jRqtqpVoOllDWbz bA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sv4jkajdu-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 05 Sep 2023 09:39:28 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 5 Sep 2023 09:39:13 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 5 Sep 2023 09:39:13 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.164.106]) by maili.marvell.com (Postfix) with ESMTP id B29663F7063; Tue, 5 Sep 2023 09:39:10 -0700 (PDT) From: To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao , Pavan Nikhilesh , Shijith Thotton CC: Subject: [PATCH 1/3] cnxk/event: invalidate GWC on port reset Date: Tue, 5 Sep 2023 22:09:06 +0530 Message-ID: <20230905163908.19946-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-GUID: YusBVT3MA-_In90cZQrWKyXwvzncC_9W X-Proofpoint-ORIG-GUID: YusBVT3MA-_In90cZQrWKyXwvzncC_9W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-05_10,2023-09-05_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Invalidate GWC on event port i.e., HWS reset to prevent invalid response from SSO. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.c | 31 +++++++++++++++++++++++++++++ drivers/common/cnxk/roc_sso.h | 2 ++ drivers/common/cnxk/version.map | 1 + drivers/event/cnxk/cn10k_eventdev.c | 19 +++++++++++++++++- 4 files changed, 52 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c index a5f48d5bbc..1ea0761531 100644 --- a/drivers/common/cnxk/roc_sso.c +++ b/drivers/common/cnxk/roc_sso.c @@ -357,6 +357,37 @@ roc_sso_hws_stats_get(struct roc_sso *roc_sso, uint8_t hws, return rc; } +void +roc_sso_hws_gwc_invalidate(struct roc_sso *roc_sso, uint8_t *hws, + uint8_t nb_hws) +{ + struct sso *sso = roc_sso_to_sso_priv(roc_sso); + struct ssow_lf_inv_req *req; + struct dev *dev = &sso->dev; + struct mbox *mbox; + int i; + + if (!nb_hws) + return; + + mbox = mbox_get(dev->mbox); + req = mbox_alloc_msg_sso_ws_cache_inv(mbox); + if (req == NULL) { + mbox_process(mbox); + req = mbox_alloc_msg_sso_ws_cache_inv(mbox); + if (req == NULL) { + mbox_put(mbox); + return; + } + } + req->hdr.ver = SSOW_INVAL_SELECTIVE_VER; + req->nb_hws = nb_hws; + for (i = 0; i < nb_hws; i++) + req->hws[i] = hws[i]; + mbox_process(mbox); + mbox_put(mbox); +} + int roc_sso_hwgrp_stats_get(struct roc_sso *roc_sso, uint8_t hwgrp, struct roc_sso_hwgrp_stats *stats) diff --git a/drivers/common/cnxk/roc_sso.h b/drivers/common/cnxk/roc_sso.h index a2bb6fcb22..8ee62afb9a 100644 --- a/drivers/common/cnxk/roc_sso.h +++ b/drivers/common/cnxk/roc_sso.h @@ -100,6 +100,8 @@ int __roc_api roc_sso_hwgrp_free_xaq_aura(struct roc_sso *roc_sso, int __roc_api roc_sso_hwgrp_stash_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_stash *stash, uint16_t nb_stash); +void __roc_api roc_sso_hws_gwc_invalidate(struct roc_sso *roc_sso, uint8_t *hws, + uint8_t nb_hws); /* Debug */ void __roc_api roc_sso_dump(struct roc_sso *roc_sso, uint8_t nb_hws, diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map index 8c71497df8..cfb7efbdc7 100644 --- a/drivers/common/cnxk/version.map +++ b/drivers/common/cnxk/version.map @@ -475,6 +475,7 @@ INTERNAL { roc_sso_hws_base_get; roc_sso_hws_link; roc_sso_hws_stats_get; + roc_sso_hws_gwc_invalidate; roc_sso_hws_unlink; roc_sso_ns_to_gw; roc_sso_rsrc_fini; diff --git a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c index 499a3aace7..56482c20a1 100644 --- a/drivers/event/cnxk/cn10k_eventdev.c +++ b/drivers/event/cnxk/cn10k_eventdev.c @@ -118,6 +118,7 @@ static int cn10k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, cnxk_handle_event_t fn, void *arg) { + struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(arg); uint64_t retry = CNXK_SSO_FLUSH_RETRY_MAX; struct cn10k_sso_hws *ws = hws; uint64_t cq_ds_cnt = 1; @@ -128,6 +129,7 @@ cn10k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, plt_write64(0, base + SSO_LF_GGRP_QCTL); + roc_sso_hws_gwc_invalidate(&dev->sso, &ws->hws_id, 1); plt_write64(0, ws->base + SSOW_LF_GWS_OP_GWC_INVAL); req = queue_id; /* GGRP ID */ req |= BIT_ULL(18); /* Grouped */ @@ -162,6 +164,7 @@ cn10k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, return -EAGAIN; plt_write64(0, ws->base + SSOW_LF_GWS_OP_GWC_INVAL); + roc_sso_hws_gwc_invalidate(&dev->sso, &ws->hws_id, 1); rte_mb(); return 0; @@ -181,6 +184,7 @@ cn10k_sso_hws_reset(void *arg, void *hws) uint8_t pend_tt; bool is_pend; + roc_sso_hws_gwc_invalidate(&dev->sso, &ws->hws_id, 1); plt_write64(0, ws->base + SSOW_LF_GWS_OP_GWC_INVAL); /* Wait till getwork/swtp/waitw/desched completes. */ is_pend = false; @@ -237,6 +241,7 @@ cn10k_sso_hws_reset(void *arg, void *hws) } plt_write64(0, base + SSOW_LF_GWS_OP_GWC_INVAL); + roc_sso_hws_gwc_invalidate(&dev->sso, &ws->hws_id, 1); rte_mb(); } @@ -670,7 +675,9 @@ cn10k_sso_configure_queue_stash(struct rte_eventdev *event_dev) static int cn10k_sso_start(struct rte_eventdev *event_dev) { - int rc; + struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev); + uint8_t hws[RTE_EVENT_MAX_PORTS_PER_DEV]; + int rc, i; rc = cn10k_sso_updt_tx_adptr_data(event_dev); if (rc < 0) @@ -682,6 +689,9 @@ cn10k_sso_start(struct rte_eventdev *event_dev) if (rc < 0) return rc; cn10k_sso_fp_fns_set(event_dev); + for (i = 0; i < event_dev->data->nb_ports; i++) + hws[i] = i; + roc_sso_hws_gwc_invalidate(&dev->sso, hws, event_dev->data->nb_ports); return rc; } @@ -689,6 +699,13 @@ cn10k_sso_start(struct rte_eventdev *event_dev) static void cn10k_sso_stop(struct rte_eventdev *event_dev) { + struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev); + uint8_t hws[RTE_EVENT_MAX_PORTS_PER_DEV]; + int i; + + for (i = 0; i < event_dev->data->nb_ports; i++) + hws[i] = i; + roc_sso_hws_gwc_invalidate(&dev->sso, hws, event_dev->data->nb_ports); cnxk_sso_stop(event_dev, cn10k_sso_hws_reset, cn10k_sso_hws_flush_events); } From patchwork Tue Sep 5 16:39:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 131179 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5A22424F4; Tue, 5 Sep 2023 18:39:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A38AF40E78; Tue, 5 Sep 2023 18:39:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 31C3E400D7 for ; Tue, 5 Sep 2023 18:39:18 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 385C6w1p026839 for ; Tue, 5 Sep 2023 09:39:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=tacWIsZdxJk/qZxjYmreA+IhUzHy8CEnzscK8bF0HO8=; b=Q6vHEVZ1qGJEBDLt7UWQvDSPDIxJi59R4NifP6B8K0BmaGDpJgrxAycE3RrGyY1N5oEP GI9fWZW7kwqU95xtB20Z4OjrLUK4loakzfEXNNET9Nd8DNNQU+c/z+W5EFDPX+JO0Ydn e6VdwFBg+dc/ekMQZfBysvwWulc0sQWmoSPxooKkYkAs2aR/b9DmAu3x2cSoUd804UpX qiTWg6dAPX3ClBz3Lw/OJfZtEEL9zxiQ0pZZnZd+vRS+cRERtHug9FNNvUjzYwYzoO3D lVx8iZJlcpKIlakKMxucWSUS/NdjQGcG7T9c8z3zO9HO2vcz4aB9FCCBDIDp6S/k56v/ rA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sv4jkaje0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 05 Sep 2023 09:39:17 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 5 Sep 2023 09:39:15 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 5 Sep 2023 09:39:15 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.164.106]) by maili.marvell.com (Postfix) with ESMTP id D76CF3F7065; Tue, 5 Sep 2023 09:39:13 -0700 (PDT) From: To: , Pavan Nikhilesh , "Shijith Thotton" CC: Subject: [PATCH 2/3] event/cnxk: remove checks from op release Date: Tue, 5 Sep 2023 22:09:07 +0530 Message-ID: <20230905163908.19946-2-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230905163908.19946-1-pbhagavatula@marvell.com> References: <20230905163908.19946-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: K63YARG8ZTyeVM4cD2oouyBYs7H0MUMA X-Proofpoint-ORIG-GUID: K63YARG8ZTyeVM4cD2oouyBYs7H0MUMA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-05_10,2023-09-05_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Remove expensive fastpath checks from op release, remove explicit release in CN9K tx routine. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_worker.h | 17 ----------------- drivers/event/cnxk/cnxk_worker.h | 6 ------ 2 files changed, 23 deletions(-) diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h index 9ddab095ac..ee659e80d6 100644 --- a/drivers/event/cnxk/cn9k_worker.h +++ b/drivers/event/cnxk/cn9k_worker.h @@ -156,15 +156,6 @@ cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base, } } -static __rte_always_inline void -cn9k_sso_tx_tag_flush(uint64_t base) -{ - if (unlikely(CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) == - SSO_TT_EMPTY)) - return; - plt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH); -} - static __rte_always_inline void cn9k_wqe_to_mbuf(uint64_t wqe, const uint64_t mbuf, uint8_t port_id, const uint32_t tag, const uint32_t flags, @@ -727,7 +718,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd, uint64_t *txq_data, const uint32_t flags) { struct rte_mbuf *m = ev->mbuf; - uint16_t ref_cnt = m->refcnt; struct cn9k_eth_txq *txq; /* Perform header writes before barrier for TSO */ @@ -800,13 +790,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd, } done: - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) { - if (ref_cnt > 1) - return 1; - } - - cn9k_sso_tx_tag_flush(base); - return 1; } diff --git a/drivers/event/cnxk/cnxk_worker.h b/drivers/event/cnxk/cnxk_worker.h index 2bd41f8a5e..0e0d728ba4 100644 --- a/drivers/event/cnxk/cnxk_worker.h +++ b/drivers/event/cnxk/cnxk_worker.h @@ -54,12 +54,6 @@ cnxk_sso_hws_swtag_untag(uintptr_t swtag_untag_op) static __rte_always_inline void cnxk_sso_hws_swtag_flush(uint64_t base) { - /* Ensure that there is no previous flush is pending. */ - while (plt_read64(base + SSOW_LF_GWS_PENDSTATE) & BIT_ULL(56)) - ; - if (CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) == - SSO_TT_EMPTY) - return; plt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH); } From patchwork Tue Sep 5 16:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 131181 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C60E5424F4; Tue, 5 Sep 2023 18:39:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AD19427E7; Tue, 5 Sep 2023 18:39:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7A03A4161A for ; Tue, 5 Sep 2023 18:39:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 385DdcLT004704 for ; Tue, 5 Sep 2023 09:39:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=vQ2NoCEd/0yPg4KvitW1d7ibHPkqvZiKOE+7ms/A/XY=; b=kCuOYHPITAPyQe0UpGplaaf9R9TB+zspSjxuwIDMH/Ouki0tQ+NX4mz0JlD+2sU4LGgw WO77mXYzlnhacaiy4Vthk6usKrh9VZFRyr6/epv+ObK2AbGekRwwz5vwtDqO69CPmerp /XRN6LT5JKYEGGJY65h4ToPmhwxhc7JIKDBTe5k5yckr7VU6UXdCvLSbxsXXY6wHKTA7 DShrOQNylxZHb2lwrtP8QMEVdwmsPpRHJQuMCS0pBb0w3tNAJnq4aDLt/dwJRU7Q3UvJ wjleItYGhlpsVjJ9w99sMKHrPG+BvsFSI9tAGdkSzVS6K/XqXwaFUsh9j+kv5/SqLANN 4g== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sv4jkajdu-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 05 Sep 2023 09:39:29 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 5 Sep 2023 09:39:19 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 5 Sep 2023 09:39:19 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.164.106]) by maili.marvell.com (Postfix) with ESMTP id E8FDE3F7081; Tue, 5 Sep 2023 09:39:15 -0700 (PDT) From: To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao CC: , Pavan Nikhilesh Subject: [PATCH 3/3] common/cnxk: use local labels in asm intrinsic Date: Tue, 5 Sep 2023 22:09:08 +0530 Message-ID: <20230905163908.19946-3-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230905163908.19946-1-pbhagavatula@marvell.com> References: <20230905163908.19946-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: c8GTV5a4ZBMmSo56lOEQ4DI1MlZ54nPD X-Proofpoint-ORIG-GUID: c8GTV5a4ZBMmSo56lOEQ4DI1MlZ54nPD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-05_10,2023-09-05_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Using labels in asm generates them as regular function and shades callstack in tools like gdb or perf. Use local label instead for better visibility. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso_dp.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/common/cnxk/roc_sso_dp.h b/drivers/common/cnxk/roc_sso_dp.h index 9d30286d2f..03c5bdf7ee 100644 --- a/drivers/common/cnxk/roc_sso_dp.h +++ b/drivers/common/cnxk/roc_sso_dp.h @@ -13,13 +13,13 @@ roc_sso_hws_head_wait(uintptr_t base) #if defined(__aarch64__) asm volatile(PLT_CPU_FEATURE_PREAMBLE - " ldr %[tag], [%[tag_op]] \n" - " tbnz %[tag], 35, done%= \n" + " ldr %[tag], [%[tag_op]] \n" + " tbnz %[tag], 35, .Ldone%= \n" " sevl \n" - "rty%=: wfe \n" - " ldr %[tag], [%[tag_op]] \n" - " tbz %[tag], 35, rty%= \n" - "done%=: \n" + ".Lrty%=: wfe \n" + " ldr %[tag], [%[tag_op]] \n" + " tbz %[tag], 35, .Lrty%= \n" + ".Ldone%=: \n" : [tag] "=&r"(tag) : [tag_op] "r"(tag_op)); #else