From patchwork Mon Jul 10 21:34:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 129429 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A8AD42DDB; Mon, 10 Jul 2023 23:34:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FDE8410EF; Mon, 10 Jul 2023 23:34:53 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4EBEB40150; Mon, 10 Jul 2023 23:34:52 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1004) id 910FA21C4250; Mon, 10 Jul 2023 14:34:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 910FA21C4250 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com; s=default; t=1689024891; bh=PRfN5slOI39jDKw8JQoa09Q+ibZDgX49MPG6/X2zV5U=; h=From:To:Cc:Subject:Date:From; b=kbfKAxkSaRIE5xizgBmfx+V7BcYgR87DjVDPgKUD4MzDE9jQ+FJoKhH4tHCGrIMPM TMuqXee9m8RRMQ0HJisJjkVf9ZZ+6ltIpjPm5InAp2v1tVQ2DnQY7c4Y0HTWp2h54Z dH3c85wrmPI055GdK+B3m2PjEWvo69QBISYBWTFY= From: longli@linuxonhyperv.com To: Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, Ajay Sharma , Xinhao Kong , Long Li , stable@dpdk.org Subject: [PATCH] net/mana: fix counter overflow for posted WQE Date: Mon, 10 Jul 2023 14:34:41 -0700 Message-Id: <1689024881-18120-1-git-send-email-longli@linuxonhyperv.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Li This counter should set to uint16_t, the same type as pkt_received. Otherwise, it may overflow when pkt_received goes over 256. Thanks Xinhao Kong for debugging. Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") Cc: stable@dpdk.org --- drivers/net/mana/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/rx.c b/drivers/net/mana/rx.c index 1047ac1743..b840e402f9 100644 --- a/drivers/net/mana/rx.c +++ b/drivers/net/mana/rx.c @@ -399,7 +399,7 @@ uint16_t mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) { uint16_t pkt_received = 0; - uint8_t wqe_posted = 0; + uint16_t wqe_posted = 0; struct mana_rxq *rxq = dpdk_rxq; struct mana_priv *priv = rxq->priv; struct rte_mbuf *mbuf;