From patchwork Wed Jun 21 09:41:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhichao Zeng X-Patchwork-Id: 128886 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D55242D12; Wed, 21 Jun 2023 11:35:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDFE44068E; Wed, 21 Jun 2023 11:35:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 071414003C for ; Wed, 21 Jun 2023 11:35:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687340132; x=1718876132; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LHQR+4vvFySjyT48PYC6tobxJi2sG+pvmlJdHYakRm4=; b=GMbZoUYbuE7vVEFqLMBd8ayuWX/yL24m+2ZKiNO1ddcrQhKQlwtuBH5d stxc56JPDgz26qjgSSAVaZbryO1PLUj2U2tOVbN0J4dpNeloJkfDB3GNo rdNSfyvoge0Fi527+hWnMKvzDUvsNX3YLSChhfvecKmLbPd7p7H+tKwLT IHdr8oQNoIxRY4MjojRFM/l6q9LPTjdS65URXSWVtrHbxgyjBIYgpmhu4 soMFp39g802Zbw/l3H7GoeitB+zb8z9UcKK5RWBWwQ3SpU1I5bN8GlSdM yuOOT+0oCEl6ncuNyHa4OucscZgvKXK0hFUf2xx7TahtnB7HpJ0kx/kyU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="362661040" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="362661040" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 02:35:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="714396376" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="714396376" Received: from unknown (HELO zhichao-dpdk..) ([10.239.252.103]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 02:35:09 -0700 From: Zhichao Zeng To: dev@dpdk.org Cc: qi.z.zhang@intel.com, Zhichao Zeng , Qiming Yang , Zhirun Yan Subject: [PATCH] net/ice: revert mark action in switch filter Date: Wed, 21 Jun 2023 17:41:25 +0800 Message-Id: <20230621094125.3071251-1-zhichaox.zeng@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This implementation has some problem, the function did not work properly, and it broke the mark action in FDir filter, so revert this commit. Fixes: e24f43f2c824 ("net/ice: support flow mark action in switch") Signed-off-by: Zhichao Zeng --- drivers/net/ice/ice_switch_filter.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c index 1ff4b1afda..110d8895fe 100644 --- a/drivers/net/ice/ice_switch_filter.c +++ b/drivers/net/ice/ice_switch_filter.c @@ -1715,7 +1715,6 @@ ice_switch_parse_action(struct ice_pf *pf, struct rte_eth_dev_data *dev_data = pf->adapter->pf.dev_data; const struct rte_flow_action_queue *act_q; const struct rte_flow_action_rss *act_qgrop; - const struct rte_flow_action_mark *act_mark; uint16_t base_queue, i; const struct rte_flow_action *action; enum rte_flow_action_type action_type; @@ -1768,13 +1767,6 @@ ice_switch_parse_action(struct ice_pf *pf, ICE_DROP_PACKET; break; - case RTE_FLOW_ACTION_TYPE_MARK: - act_mark = action->conf; - rule_info->sw_act.fltr_act = - ICE_SET_MARK; - rule_info->sw_act.markid = act_mark->id; - break; - case RTE_FLOW_ACTION_TYPE_VOID: break; @@ -1830,7 +1822,6 @@ ice_switch_check_action(const struct rte_flow_action *actions, case RTE_FLOW_ACTION_TYPE_RSS: case RTE_FLOW_ACTION_TYPE_QUEUE: case RTE_FLOW_ACTION_TYPE_DROP: - case RTE_FLOW_ACTION_TYPE_MARK: case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: actions_num++;