From patchwork Wed Jun 14 18:03:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, ZhiminX" X-Patchwork-Id: 128663 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CADD42CB6; Wed, 14 Jun 2023 11:52:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0301540E0F; Wed, 14 Jun 2023 11:52:29 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 358BB40DDB for ; Wed, 14 Jun 2023 11:52:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686736347; x=1718272347; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IsIh2+VB2S5nQ6RQWJ/PH6c5i5RKSsdMc3SqjreqEs4=; b=YOLvgFWFnCl/sdMv4HAB6FeeBnUKtxzOLZTySE+pfBXR0QMKdrcJ6cw/ HVgtw3sgir+02np9BlwphztOnkjwQyYrfPXt6N7Klp/94bxWC3OyfnHB6 zudQka93eMImPxFq2TWua5jccZq4K75gWN4oVDGoz5E7UG9wz6bDXffJd mssmlkjptLONHE7+iFuwM3+YDB3Gic2NVfGMhI/pDwqPUVxxn+VQFsgM4 /grvbE8MCnvQW/2O4HFrWybbyb3OSO8bvRZz+t+gNEWx4Y0EFmc1oFXnN 4ih1ET7g5kmOxTaPe7FrWPE2SAcn9IcIpAG26WprEq78Yy5bBuAQbSNid w==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="422172708" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="422172708" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 02:52:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="662339349" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="662339349" Received: from unknown (HELO localhost.localdomain) ([10.239.252.96]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 02:52:13 -0700 From: Zhimin Huang To: dts@dpdk.org Cc: Zhimin Huang Subject: [dts][PATCH V1] tests/ice_dcf_disable_acl_filter:optimize code for testpmd status flag Date: Wed, 14 Jun 2023 18:03:52 +0000 Message-Id: <20230614180352.1194502-1-zhiminx.huang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org if the case validation failed,the testpmd_status will not be assigned value. Signed-off-by: Zhimin Huang --- tests/TestSuite_ice_dcf_disable_acl_filter.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/TestSuite_ice_dcf_disable_acl_filter.py b/tests/TestSuite_ice_dcf_disable_acl_filter.py index 7e12ad0e..937ba406 100644 --- a/tests/TestSuite_ice_dcf_disable_acl_filter.py +++ b/tests/TestSuite_ice_dcf_disable_acl_filter.py @@ -234,11 +234,11 @@ class TestICEDCFDisableACLFilter(TestCase): # get the average avg_start_up_time_acl_on = sum(start_up_time_acl_on) / repeat_time avg_start_up_time_acl_off = sum(start_up_time_acl_off) / repeat_time + self.testpmd_status = "close" self.verify( avg_start_up_time_acl_on > avg_start_up_time_acl_off, "disable acl to reduce startup time failed!!!", ) - self.testpmd_status = "close" def test_disable_acl(self): """ @@ -267,9 +267,8 @@ class TestICEDCFDisableACLFilter(TestCase): self.logger.warning((RED(e))) self.logger.info((GREEN("case failed: %s" % subcase["name"]))) subcases["result"].append(False) - self.verify(all(subcases["result"]), "test disable acl engine failed.") - self.testpmd_status = "open" + self.verify(all(subcases["result"]), "test disable acl engine failed.") def quit_testpmd(self): """